On Thu, 2006-06-08 at 10:34 +0200, Pavel Machek wrote:
diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
index acde886..1d8b58c 100644
--- a/drivers/usb/host/ohci-pxa27x.c
+++ b/drivers/usb/host/ohci-pxa27x.c
@@ -185,6 +185,13 @@ int usb_hcd_pxa27x_probe (const
Hi,
On Thu, 2006-06-08 at 11:02 +0200, Pavel Machek wrote:
+ if (machine_is_spitz()) {
+ /* Warning, not coming from any official docs. But
+ * spitz is unable to properly power wireless card
+ * claiming 500mA -- usb interface work but wireless
+
Hi!
diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
index acde886..1d8b58c 100644
--- a/drivers/usb/host/ohci-pxa27x.c
+++ b/drivers/usb/host/ohci-pxa27x.c
@@ -185,6 +185,13 @@ int usb_hcd_pxa27x_probe (const struct h
/* Select Power Management Mode */
This limits power budget on spitz to 250mA. I'm not sure if it is the
right value, but it is certainly better than default 500mA, and
prevents nasty failure mode with zd1201.
Signed-off-by: Pavel Machek [EMAIL PROTECTED]
PATCH FOLLOWS
KernelVersion: 2.6.17-rc6-git
diff --git
On Thu, Jun 08, 2006 at 10:22:50AM +0100, Richard Purdie wrote:
Hi,
On Thu, 2006-06-08 at 11:02 +0200, Pavel Machek wrote:
+ if (machine_is_spitz()) {
+ /* Warning, not coming from any official docs. But
+* spitz is unable to properly power
On Thursday 08 June 2006 10:09 am, Russell King wrote:
On Thu, Jun 08, 2006 at 10:22:50AM +0100, Richard Purdie wrote:
Hi,
On Thu, 2006-06-08 at 11:02 +0200, Pavel Machek wrote:
+ if (machine_is_spitz()) {
+ /* Warning, not coming from any official docs. But
On Thu, 2006-06-08 at 11:26 -0700, David Brownell wrote:
On Thu, Jun 08, 2006 at 10:22:50AM +0100, Richard Purdie wrote:
Just because the omap does it that way, doesn't mean it can't be done
better ;-).
Agreed that platform_data is a better approach overall for holding that
power budget.
The PXA platform does have an existing mechanism to pass platform data
(I added it a while back). I've added
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=3547/1
into the patch system replacing Pavel's version.
OK, I see now. Simple enough, better than the original. Go for
On Thu, 2006-06-08 at 13:38 -0700, David Brownell wrote:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=3547/1
OK, I see now. Simple enough, better than the original. Go for it.
There was a PXA issue I was alluding to that's still open, though.
It's the way there's no
On Thursday 08 June 2006 2:22 pm, Richard Purdie wrote:
On Thu, 2006-06-08 at 13:38 -0700, David Brownell wrote:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=3547/1
OK, I see now. Simple enough, better than the original. Go for it.
There was a PXA issue I was
On Thu, 2006-06-08 at 14:40 -0700, David Brownell wrote:
Right. OHCI was just an example though ... there are lots of other
platform drivers for PXA. I'm not sure they all check for platform_data
before succeeding in their probe() methods.
The implementations in mainline generally use all
On Thursday 08 June 2006 2:49 pm, Richard Purdie wrote:
The easiest solution might be to move the ohci device registration into
pxa_set_ohci_info (in pxa27x.c). I gave in and appended a patch (compile
tested only so far).
Looked OK to me.
That's the kind of approach now used
On Thu, 8 Jun 2006, David Brownell wrote:
On Thursday 08 June 2006 2:49 pm, Richard Purdie wrote:
One additional nuance: if
the kernel doesn't have that driver configured, that's another reason not
to bother registering its device.
This is where you start to add ugly ifdefs and
On Thursday 08 June 2006 6:25 pm, Nicolas Pitre wrote:
You are both saying the same thing so far.
Hey, violent agreement is half the fun! :)
But here you argue that platform bus should not work that same way ... it
should register devices that can't be present. If nothing else, that's
On Thu, 8 Jun 2006, David Brownell wrote:
On Thursday 08 June 2006 6:25 pm, Nicolas Pitre wrote:
He replied to your assertion where you said: if the kernel doesn't have
that driver configured, that's another reason not to bother registering
its device to which he disagreed, and I
15 matches
Mail list logo
