Re: [linux-usb-devel] [PATCH] uhci - eliminate td->td_remove_list element

2004-02-26 Thread Alan Stern
On Wed, 25 Feb 2004, Stephen Hemminger wrote: > The idea is good, but something is bad about this. It works for normal i/o > to a USB device, but when I do lsusb, it ends up oops'ing. I think I found the problem. In usb_control_retrigger_status you were freeing a TD without removing it from its

Re: [linux-usb-devel] [PATCH] uhci - eliminate td->td_remove_list element

2004-02-25 Thread Alan Stern
On Wed, 25 Feb 2004, Stephen Hemminger wrote: > The idea is good, but something is bad about this. It works for normal i/o > to a USB device, but when I do lsusb, it ends up oops'ing. > > The earlier splice_init patch seems to be okay though. It looked okay to me too. I'll send it on up. I hav

Re: [linux-usb-devel] [PATCH] uhci - eliminate td->td_remove_list element

2004-02-25 Thread Stephen Hemminger
The idea is good, but something is bad about this. It works for normal i/o to a USB device, but when I do lsusb, it ends up oops'ing. The earlier splice_init patch seems to be okay though. Oops: [#1] SMP DEBUG_PAGEALLOC CPU:0 EIP:0060:[]Not tainted EFLAGS: 00010293 EIP is at uhci

[linux-usb-devel] [PATCH] uhci - eliminate td->td_remove_list element

2004-02-24 Thread Stephen Hemminger
Since a td can beither on the uhci->td_list or uhci->td_remove_list, but not both; it makes sense to use the same list pointers and use the list_move functions, when moving. diff -Nru a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c --- a/drivers/usb/host/uhci-hcd.c Tue Feb 24 09: