Hi,

The loop construct (and following debug message) in the write data function of 
the jumpshot storage driver seems to suggest that it should bail out after 10 
waiting periods if the device's status still doesn't show ready. However it 
looks like someone forgot to increment the variable on each iteration.

Could somebody test this please? I don't own a jumpshot.
(Although unlikely, it may well be that a normal data transfer requires >10 
iterations of that loop, we don't want to bail out too early...)

Signed-off-by: Daniel Drake <[EMAIL PROTECTED]>
--- linux-2.6.9-gentoo-r1/drivers/usb/storage/jumpshot.c.orig	2004-10-30 06:32:40.822324144 +0800
+++ linux-2.6.9-gentoo-r1/drivers/usb/storage/jumpshot.c	2004-10-30 06:33:35.622993176 +0800
@@ -258,6 +258,7 @@
 				// I have not experimented to find the smallest value.
 				//
 				msleep(50); 
+				waitcount++;
 			}
 		} while ((result != USB_STOR_TRANSPORT_GOOD) && (waitcount < 10));
 

Reply via email to