[linux-usb-devel] [PATCH 1/6] USB: remove __usb_port_suspend

2007-05-30 Thread Alan Stern
This patch (as915) combines the public routine usb_port_suspend() and the private routine __usb_port_suspend() into a single function. Propagating the change into the OTG HNP handler requires a slight addition to the OTG whitelist checking code: A device not attached to the OTG port should always

Re: [linux-usb-devel] [PATCH 1/6] USB: remove __usb_port_suspend

2007-05-30 Thread David Brownell
On Wednesday 30 May 2007, Alan Stern wrote: Propagating the change into the OTG HNP handler requires a slight addition to the OTG whitelist checking code: A device not attached to the OTG port should always count as targeted. No, that's not what the OTG spec says. If there's a list of

Re: [linux-usb-devel] [PATCH 1/6] USB: remove __usb_port_suspend

2007-05-30 Thread Alan Stern
On Wed, 30 May 2007, David Brownell wrote: On Wednesday 30 May 2007, Alan Stern wrote: Propagating the change into the OTG HNP handler requires a slight addition to the OTG whitelist checking code: A device not attached to the OTG port should always count as targeted. No, that's not

Re: [linux-usb-devel] [PATCH 1/6] USB: remove __usb_port_suspend

2007-05-30 Thread David Brownell
On Wednesday 30 May 2007, Alan Stern wrote: On Wed, 30 May 2007, David Brownell wrote: On Wednesday 30 May 2007, Alan Stern wrote: Propagating the change into the OTG HNP handler requires a slight addition to the OTG whitelist checking code: A device not attached to the OTG port

Re: [linux-usb-devel] [PATCH 1/6] USB: remove __usb_port_suspend

2007-05-30 Thread Alan Stern
On Wed, 30 May 2007, David Brownell wrote: According to the original code, plugging a non-targeted device into a non-OTG port would cause the host to initiate HNP on the OTG port! At least, that's what it looks like to me. Have I got it wrong? Yeah, I thought I noticed that too. It