Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

2007-06-06 Thread Alan Stern
On Tue, 5 Jun 2007, Marc St-Jean wrote: > @@ -2749,12 +2749,33 @@ static void hub_events(void) > } > > if (portchange & USB_PORT_STAT_C_OVERCURRENT) { > - dev_err (hub_dev, > -

Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

2007-06-05 Thread David Brownell
[ $SUBJECT is getting less accurate... ] There are already big-endian support patches for EHCI in the USB queue. I strongly suspect this patch will clash with those. For example, they obviously don't cope with mixed configuration systems, where an SOC includes big-endian EHCI registers but there

[linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

2007-06-05 Thread Marc St-Jean
[PATCH 11/12] drivers: PMC MSP71xx USB driver Patch to add an USB driver for the PMC-Sierra MSP71xx devices. Patches 1 through 10 were posted to [EMAIL PROTECTED] as well as other sub-system lists/maintainers as appropriate. This patch has some dependencies on the first few patches in the set. If

Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

2007-06-05 Thread David Brownell
> This does far too much to be a single patch. It needs to be broken up. Agreed. 300+ KB is not digestible at all. Most maintainers like to see patches on the order of 10 KB; that much is easy to review. New drivers are rarely that small of course, but that should give you some understanding o

Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

2007-06-05 Thread Alan Stern
On Mon, 4 Jun 2007, Marc St-Jean wrote: > [PATCH 11/12] drivers: PMC MSP71xx USB driver > > Patch to add an USB driver for the PMC-Sierra MSP71xx devices. > > Patches 1 through 10 were posted to [EMAIL PROTECTED] as well > as other sub-system lists/maintainers as appropriate. This patch has > so

Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

2007-06-04 Thread Marc St-Jean
Greg KH wrote: > On Mon, Jun 04, 2007 at 05:23:44PM -0600, Marc St-Jean wrote: > > [PATCH 11/12] drivers: PMC MSP71xx USB driver > > > > Patch to add an USB driver for the PMC-Sierra MSP71xx devices. > > > > Patches 1 through 10 were posted to [EMAIL PROTECTED] as well > > as other sub-system

Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

2007-06-04 Thread Greg KH
On Mon, Jun 04, 2007 at 05:23:44PM -0600, Marc St-Jean wrote: > [PATCH 11/12] drivers: PMC MSP71xx USB driver > > Patch to add an USB driver for the PMC-Sierra MSP71xx devices. > > Patches 1 through 10 were posted to [EMAIL PROTECTED] as well > as other sub-system lists/maintainers as appropriate