On Thu, 17 Aug 2006, Franck Bui-Huu wrote:
> Hi Alan,
> > char *bus_name; /* stable id (PCI slot_name etc) */
> > + u8 uses_dma;/* Does the host controller use DMA? */
>
> Why using 'u8' (which is likely expanded to an int) ? Can we use a bit field
> ins
On Wed, 16 Aug 2006, David Brownell wrote:
> On Wednesday 16 August 2006 1:57 pm, Alan Stern wrote:
> > + hcd->self.uses_dma = (dev->dma_mask &&
> > + dma_supported(dev, *dev->dma_mask));
>
> That does look bizarre, given the variety of often-buggy implementations
> of dma_sup
Hi Alan,
Alan Stern wrote:
> Greg:
>
> Rather than using a home-brewed test (dev->dma_mask != NULL) to
> indicate which host controller devices use DMA, this patch (as770)
> invokes the standard dma_supported() API and caches the result.
>
[snip]
> Index: usb-2.6/include/linux/usb.h
>
On Wednesday 16 August 2006 1:57 pm, Alan Stern wrote:
> + hcd->self.uses_dma = (dev->dma_mask &&
> + dma_supported(dev, *dev->dma_mask));
That does look bizarre, given the variety of often-buggy implementations
of dma_supported() ... the ones looking at dev->dma_mask often
Greg:
Rather than using a home-brewed test (dev->dma_mask != NULL) to
indicate which host controller devices use DMA, this patch (as770)
invokes the standard dma_supported() API and caches the result.
Alan Stern
Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
---
This may be redundant; I don't
