Re: [linux-usb-devel] [PATCH 2/9] usb-skeleton: don't submit URBs after disconnect

2006-06-15 Thread David Brownell
On Wednesday 14 June 2006 11:57 am, Alan Stern wrote: > On Tue, 13 Jun 2006, David Brownell wrote: > > > > > > error: > > > - usb_buffer_free(dev->udev, writesize, buf, urb->transfer_dma); > > > + if (buf) > > > + usb_buffer_free(dev->udev, writesize, buf, urb->transfer_dma); > > > usb

Re: [linux-usb-devel] [PATCH 2/9] usb-skeleton: don't submit URBs after disconnect

2006-06-14 Thread Alan Stern
On Tue, 13 Jun 2006, David Brownell wrote: > > > error: > > - usb_buffer_free(dev->udev, writesize, buf, urb->transfer_dma); > > + if (buf) > > + usb_buffer_free(dev->udev, writesize, buf, urb->transfer_dma); > > usb_free_urb(urb); > > I think that's the wrong policy ... whate

Re: [linux-usb-devel] [PATCH 2/9] usb-skeleton: don't submit URBs after disconnect

2006-06-13 Thread David Brownell
> error: > - usb_buffer_free(dev->udev, writesize, buf, urb->transfer_dma); > + if (buf) > + usb_buffer_free(dev->udev, writesize, buf, urb->transfer_dma); > usb_free_urb(urb); I think that's the wrong policy ... whatever code handles that call should be able to handle

Re: [linux-usb-devel] [PATCH 2/9] usb-skeleton: don't submit URBs after disconnect

2006-06-13 Thread Alan Stern
On Mon, 12 Jun 2006, Greg KH wrote: > On Mon, Jun 12, 2006 at 03:16:31PM -0400, Alan Stern wrote: > > Greg: > > > > This patch (as712) fixes the usb-skeleton example driver so that it won't > > try to submit URBs after skel_disconnect() has returned. This could cause > > errors, if the driver wa

Re: [linux-usb-devel] [PATCH 2/9] usb-skeleton: don't submit URBs after disconnect

2006-06-12 Thread Greg KH
On Mon, Jun 12, 2006 at 03:16:31PM -0400, Alan Stern wrote: > Greg: > > This patch (as712) fixes the usb-skeleton example driver so that it won't > try to submit URBs after skel_disconnect() has returned. This could cause > errors, if the driver was unbound and then a different driver was bound t

[linux-usb-devel] [PATCH 2/9] usb-skeleton: don't submit URBs after disconnect

2006-06-12 Thread Alan Stern
Greg: This patch (as712) fixes the usb-skeleton example driver so that it won't try to submit URBs after skel_disconnect() has returned. This could cause errors, if the driver was unbound and then a different driver was bound to the device. The patch also fixes a couple of small bugs in the skel