Re: [linux-usb-devel] [PATCH 4/9] Make usb_generic a genuine driver

2006-06-17 Thread David Brownell
On Friday 16 June 2006 11:31 pm, Greg KH wrote: > On Tue, Jun 13, 2006 at 10:21:06AM -0400, Alan Stern wrote: > > On Mon, 12 Jun 2006, Greg KH wrote: > > > > In fact, you shouldn't be adding _any_ usb stuff for uevents for usb > > > devices, we only care about interfaces. Why did you change this?

Re: [linux-usb-devel] [PATCH 4/9] Make usb_generic a genuine driver

2006-06-17 Thread Alan Stern
On Fri, 16 Jun 2006, Greg KH wrote: > On Tue, Jun 13, 2006 at 10:21:06AM -0400, Alan Stern wrote: > > On Mon, 12 Jun 2006, Greg KH wrote: > > > One comment thought: > > > > + /* FIXME: What is an appropriate MODALIAS line for a > > > > +* USB device (not interface)? *

Re: [linux-usb-devel] [PATCH 4/9] Make usb_generic a genuine driver

2006-06-16 Thread Greg KH
On Tue, Jun 13, 2006 at 10:21:06AM -0400, Alan Stern wrote: > On Mon, 12 Jun 2006, Greg KH wrote: > > One comment thought: > > > + /* FIXME: What is an appropriate MODALIAS line for a > > > + * USB device (not interface)? */ > > > > There isn't one. > > Clearly it doesn't matter

Re: [linux-usb-devel] [PATCH 4/9] Make usb_generic a genuine driver

2006-06-13 Thread Alan Stern
On Mon, 12 Jun 2006, Greg KH wrote: > One comment thought: > > > @@ -516,14 +756,14 @@ static int usb_uevent(struct device *dev > > /* driver is often null here; dev_dbg() would oops */ > > pr_debug ("usb %s: uevent\n", dev->bus_id); > > > > - /* Must check driver_data here, as on rem

Re: [linux-usb-devel] [PATCH 4/9] Make usb_generic a genuine driver

2006-06-12 Thread Greg KH
On Mon, Jun 12, 2006 at 03:17:35PM -0400, Alan Stern wrote: > Greg: > > This patch (as714) makes the USB device (as opposed to interface) driver > usb_generic be treated just like all other drivers, subject to matching, > probing, and unbinding. For instance, some of the normal boilerplate > stuf

[linux-usb-devel] [PATCH 4/9] Make usb_generic a genuine driver

2006-06-12 Thread Alan Stern
Greg: This patch (as714) makes the USB device (as opposed to interface) driver usb_generic be treated just like all other drivers, subject to matching, probing, and unbinding. For instance, some of the normal boilerplate stuff that goes along with discovery of a new USB device (registration in us