Re: [linux-usb-devel] [PATCH 5/6] USB: make hub driver's release more robust

2007-04-10 Thread David Brownell
On Monday 09 April 2007 7:50 am, Alan Stern wrote: void usb_kick_khubd(struct usb_device *hdev) { + /* FIXME: What if hdev isn't bound to the hub driver? */ We should just disallow that. There's no reason for us to risk the integrity of USB framework by letting any other driver manage

Re: [linux-usb-devel] [PATCH 5/6] USB: make hub driver's release more robust

2007-04-10 Thread Oliver Neukum
Am Dienstag, 10. April 2007 11:05 schrieb David Brownell: On Monday 09 April 2007 7:50 am, Alan Stern wrote: void usb_kick_khubd(struct usb_device *hdev) { + /* FIXME: What if hdev isn't bound to the hub driver? */ We should just disallow that. There's no reason for us to risk

Re: [linux-usb-devel] [PATCH 5/6] USB: make hub driver's release more robust

2007-04-10 Thread Alan Stern
On Tue, 10 Apr 2007, David Brownell wrote: On Monday 09 April 2007 7:50 am, Alan Stern wrote: void usb_kick_khubd(struct usb_device *hdev) { + /* FIXME: What if hdev isn't bound to the hub driver? */ We should just disallow that. There's no reason for us to risk the integrity of

[linux-usb-devel] [PATCH 5/6] USB: make hub driver's release more robust

2007-04-09 Thread Alan Stern
This patch (as893) improves the method used by the hub driver to release its private data structure. The current code is non-robust, relying on a memory region not getting reused by another driver after it has been freed. Signed-off-by: Alan Stern [EMAIL PROTECTED] --- Index: