Fingering BIOS/SMM code as the guilty party should
speed up fixes or workarounds.

- Dave
This changes the OHCI "USB HC TakeOver failed" message to be a bit
more informative, by fingering the root cause:  a BIOS/SMM bug.

That way they're more likely to either bug the board vendor, or find
workarounds (like tweaking the BIOS setup, or the ohci_hcd no_handshake
parameter) before giving up or (wrongly) reporting a Linux bug.

Signed-off-by: David Brownell <[EMAIL PROTECTED]>

--- a/drivers/usb/host/ohci-hcd.c	2005-01-05 12:21:53 -08:00
+++ b/drivers/usb/host/ohci-hcd.c	2005-01-05 12:21:53 -08:00
@@ -445,7 +445,8 @@
 		while (ohci_readl (ohci, &ohci->regs->control) & OHCI_CTRL_IR) {
 			msleep (10);
 			if (--temp == 0) {
-				ohci_err (ohci, "USB HC TakeOver failed!\n");
+				ohci_err (ohci, "USB HC takeover failed!"
+					"  (BIOS/SMM bug)\n");
 				return -EBUSY;
 			}
 		}

Reply via email to