Re: [linux-usb-devel] [rfc]autosuspend in hid

2006-10-14 Thread Oliver Neukum
Am Donnerstag, 12. Oktober 2006 23:17 schrieb Alan Stern: > > OK, of course. Please disregard my last remark. > > In fact the usb_autpm_{get|put}_interface API is a little clumsy.  It > works okay if you do nothing but suspend on close and resume on open.  But > for anything more substantial it

Re: [linux-usb-devel] [rfc]autosuspend in hid

2006-10-13 Thread Oliver Neukum
Am Freitag, 13. Oktober 2006 16:12 schrieb Alan Stern: > Then set it in the open routine and clear it in the close routine (before > calling usb_autopm_put_interface).  You should understand that this flag > doesn't indicate whether the driver _wants_ remote wakeup -- it indicates > that the driv

Re: [linux-usb-devel] [rfc]autosuspend in hid

2006-10-13 Thread Alan Stern
On Fri, 13 Oct 2006, Oliver Neukum wrote: > > Oh yes, there's one detail I forgot to mention before. You need to set > > the supports_autosuspend flag in the usb_driver structure (can be done > > OK. > > > statically) and the needs_remote_wakeup flag in the usb_interface > > structure (must be

Re: [linux-usb-devel] [rfc]autosuspend in hid

2006-10-13 Thread Oliver Neukum
Am Donnerstag, 12. Oktober 2006 23:17 schrieben Sie: > On Thu, 12 Oct 2006, Oliver Neukum wrote: > > > Am Donnerstag, 12. Oktober 2006 19:10 schrieb Alan Stern: > > > >  void hid_close(struct hid_device *hid) > > > >  { > > > > - if (!--hid->open) > > > > + if (!--hid->open) { > > > >

Re: [linux-usb-devel] [rfc]autosuspend in hid

2006-10-12 Thread Alan Stern
On Thu, 12 Oct 2006, Oliver Neukum wrote: > Am Donnerstag, 12. Oktober 2006 19:10 schrieb Alan Stern: > > >  void hid_close(struct hid_device *hid) > > >  { > > > - if (!--hid->open) > > > + if (!--hid->open) { > > >   usb_kill_urb(hid->urbin); > > > + set_bit(HID_I

Re: [linux-usb-devel] [rfc]autosuspend in hid

2006-10-12 Thread Oliver Neukum
Am Donnerstag, 12. Oktober 2006 19:10 schrieb Alan Stern: > >  void hid_close(struct hid_device *hid) > >  { > > - if (!--hid->open) > > + if (!--hid->open) { > >   usb_kill_urb(hid->urbin); > > + set_bit(HID_IN_IDLE, &hid->iofl); > > + } > >  } > > There needs

Re: [linux-usb-devel] [rfc]autosuspend in hid

2006-10-12 Thread Oliver Neukum
Am Donnerstag, 12. Oktober 2006 19:10 schrieb Alan Stern: > On Thu, 12 Oct 2006, Oliver Neukum wrote: > > > Hi, > > > > I can't boot 2.6.19-rc1, so here's an incomplete version of autosuspend > > for hid to invite comments on the basic approach. > > > > Regards > > Oliver > > >

Re: [linux-usb-devel] [rfc]autosuspend in hid

2006-10-12 Thread Alan Stern
On Thu, 12 Oct 2006, Oliver Neukum wrote: > Hi, > > I can't boot 2.6.19-rc1, so here's an incomplete version of autosuspend > for hid to invite comments on the basic approach. > > Regards > Oliver > > --- linux-2.6.19-rc1/drivers/usb/input/hid.h 2006-10-05 04:57:05.

[linux-usb-devel] [rfc]autosuspend in hid

2006-10-11 Thread Oliver Neukum
Hi, I can't boot 2.6.19-rc1, so here's an incomplete version of autosuspend for hid to invite comments on the basic approach. Regards Oliver --- linux-2.6.19-rc1/drivers/usb/input/hid.h2006-10-05 04:57:05.0 +0200 +++ gregtree/drivers/usb/input/hid.h2006-1