Re: [linux-usb-devel] 16 bit IDs for usbserial

2004-04-16 Thread Greg KH
On Thu, Apr 15, 2004 at 09:44:46PM +0200, Robert Schwebel wrote: > On Thu, Apr 15, 2004 at 02:51:18PM -0400, Alan Stern wrote: > > For Linux 2.6 you could use module_param instead of MODULE_PARM. That > > will allow you to specify the type as ushort. > > Ah, ok. Hmm, strange - I tried this but,

Re: [linux-usb-devel] 16 bit IDs for usbserial

2004-04-15 Thread Robert Schwebel
On Thu, Apr 15, 2004 at 10:24:05PM +0200, Wolfgang Mües wrote: > 0x12345 is outside of the unsigned 16 bit range. It can't work... Ok - must have been a late night brain segfault ;) But it happens identically when you use values larger than 0x7FFF. Robert -- Dipl.-Ing. Robert Schwebel | http:

Re: [linux-usb-devel] 16 bit IDs for usbserial

2004-04-15 Thread Alan Stern
On Thu, 15 Apr 2004, Robert Schwebel wrote: > On Thu, Apr 15, 2004 at 02:51:18PM -0400, Alan Stern wrote: > > For Linux 2.6 you could use module_param instead of MODULE_PARM. That > > will allow you to specify the type as ushort. > > Ah, ok. Hmm, strange - I tried this but, although modinfo say

Re: [linux-usb-devel] 16 bit IDs for usbserial

2004-04-15 Thread Wolfgang Mües
Hello Robert, On Thursday 15 April 2004 21:09, Robert Schwebel wrote: > On Thu, Apr 15, 2004 at 11:48:14AM -0700, Pete Zaitcev wrote: > > What is the symptom of "do not work"? > > The driver returns -1 and does not load. You can try by calling it > with for example vendor=0x1234 product=0x12345.

Re: [linux-usb-devel] 16 bit IDs for usbserial

2004-04-15 Thread Robert Schwebel
On Thu, Apr 15, 2004 at 02:51:18PM -0400, Alan Stern wrote: > For Linux 2.6 you could use module_param instead of MODULE_PARM. That > will allow you to specify the type as ushort. Ah, ok. Hmm, strange - I tried this but, although modinfo says that there is a vendor and product parameter, I get t

Re: [linux-usb-devel] 16 bit IDs for usbserial

2004-04-15 Thread Robert Schwebel
On Thu, Apr 15, 2004 at 11:48:14AM -0700, Pete Zaitcev wrote: > What is the symptom of "do not work"? The driver returns -1 and does not load. You can try by calling it with for example vendor=0x1234 product=0x12345. Robert -- Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de Pengutronix

Re: [linux-usb-devel] 16 bit IDs for usbserial

2004-04-15 Thread Alan Stern
On Thu, 15 Apr 2004, Robert Schwebel wrote: > Hi, > > the usbserial driver can have two parameters, vendor=0x and > product=0x. Currently they are defined as 'h' which is 16 bit > (correct), but _signed_. This means that IDs larger than 0x7FFF do not > work right now. > > The fix below

Re: [linux-usb-devel] 16 bit IDs for usbserial

2004-04-15 Thread Pete Zaitcev
On Thu, 15 Apr 2004 20:18:31 +0200 Robert Schwebel <[EMAIL PROTECTED]> wrote: > the usbserial driver can have two parameters, vendor=0x and > product=0x. Currently they are defined as 'h' which is 16 bit > (correct), but _signed_. This means that IDs larger than 0x7FFF do not > work right

[linux-usb-devel] 16 bit IDs for usbserial

2004-04-15 Thread Robert Schwebel
Hi, the usbserial driver can have two parameters, vendor=0x and product=0x. Currently they are defined as 'h' which is 16 bit (correct), but _signed_. This means that IDs larger than 0x7FFF do not work right now. The fix below is my quickhack - maybe somebody has a better idea. Robert