Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-11 Thread Willy Tarreau
On Fri, Aug 11, 2006 at 09:14:57PM -0300, Marcelo Tosatti wrote: > > The reason for so much delay was a serious accident which resulted in 2 > weeks of hospitalization with no Internet connnectivity (and no mental > state for work). > > Sorry about that. Hey Marcelo, you don't have to apologize

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-11 Thread Marcelo Tosatti
On Wed, Aug 09, 2006 at 07:02:01PM +0200, Willy Tarreau wrote: > Hi Benjamin, > > On Wed, Aug 09, 2006 at 10:01:41AM -0700, Benjamin Cherian wrote: > > Willy, > > Sorry I didn't notice your email till now. > > no problem. > > > On Friday 04 August 2006 09:55, Willy Tarreau wrote: > > > The probl

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-09 Thread Willy Tarreau
Hi Benjamin, On Wed, Aug 09, 2006 at 10:01:41AM -0700, Benjamin Cherian wrote: > Willy, > Sorry I didn't notice your email till now. no problem. > On Friday 04 August 2006 09:55, Willy Tarreau wrote: > > The problem is that Marcelo is very very busy those days (as you might have > > noticed from

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-09 Thread Benjamin Cherian
Willy, Sorry I didn't notice your email till now. On Friday 04 August 2006 09:55, Willy Tarreau wrote: > The problem is that Marcelo is very very busy those days (as you might have > noticed from the delay between each release), and there are a good bunch of > security fixes in -rc3 which should w

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-04 Thread Willy Tarreau
On Fri, Aug 04, 2006 at 09:57:04AM -0700, Benjamin Cherian wrote: > Willy, > > On Wednesday 02 August 2006 23:29, Willy Tarreau wrote: > > Perfect. Patch queued, thanks Pete. > > Do you know if it would be possible for this to get into 2.4.33? I know its > already at rc3, but it would be nice if

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-04 Thread Benjamin Cherian
Willy, On Wednesday 02 August 2006 23:29, Willy Tarreau wrote: > Perfect. Patch queued, thanks Pete. Do you know if it would be possible for this to get into 2.4.33? I know its already at rc3, but it would be nice if this patch could be pushed out sooner since 2.4.34 will probably not be out fo

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-02 Thread Willy Tarreau
On Wed, Aug 02, 2006 at 11:00:58PM -0700, Pete Zaitcev wrote: > Replace the semaphore exclusive_access with an open-coded lock for > the special use. The lock can be taken for: read, write, and both. > This way, two bulk URBs can be submitted simultaneously with ioctl > USBDEVFS_BULK: one read and

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-02 Thread Pete Zaitcev
Replace the semaphore exclusive_access with an open-coded lock for the special use. The lock can be taken for: read, write, and both. This way, two bulk URBs can be submitted simultaneously with ioctl USBDEVFS_BULK: one read and one write. Such access was possible before 2.4.28. Signed-off-By: Pet

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-02 Thread Willy Tarreau
On Wed, Aug 02, 2006 at 06:02:16PM -0700, Pete Zaitcev wrote: > On Wed, 2 Aug 2006 21:51:00 +0200, Willy Tarreau <[EMAIL PROTECTED]> wrote: > > > Pete, do you consider your work as appropriate for mainline ? In this > > case, I can queue it for 2.4.34. > > Yes, please use the attached patch. The

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-02 Thread Pete Zaitcev
On Wed, 2 Aug 2006 21:51:00 +0200, Willy Tarreau <[EMAIL PROTECTED]> wrote: > Pete, do you consider your work as appropriate for mainline ? In this > case, I can queue it for 2.4.34. Yes, please use the attached patch. The one I sent for testing missed necessary exports. This is also tested with

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-08-02 Thread Willy Tarreau
Hi Benjamin, Hi Pete, On Mon, Jul 31, 2006 at 11:41:28AM -0700, Benjamin Cherian wrote: > Hi Pete, > > >How about now? > > Much better! For me, everything seems to be working. No segfaults, and > everything seems to work. That's very good news. Pete, do you consider your work as appropriate f

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-31 Thread Benjamin Cherian
Hi Pete, >How about now? Much better! For me, everything seems to be working. No segfaults, and everything seems to work. Thanks, Ben - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay pa

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-30 Thread Pete Zaitcev
On Thu, 27 Jul 2006 15:21:37 -0700, Benjamin Cherian <[EMAIL PROTECTED]> wrote: > On Monday 24 July 2006 23:07, Pete Zaitcev wrote: > > Anyway, please test the attached patch. Does it do what you want? > > Sorry to say that it doesnt. When calling usb_get_string_simple in libusb, > the program se

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-29 Thread Benjamin Cherian
On Monday 24 July 2006 23:07, Pete Zaitcev wrote: > Anyway, please test the attached patch. Does it do what you want? Sorry to say that it doesnt. When calling usb_get_string_simple in libusb, the program segfaults with the patched kernel. I believe that usb_get_string_simple eventually calls us

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-28 Thread Benjamin Cherian
Hi Pete, Thanks for the reply. > By the way, you didn't tell me if you tried to use alarm(2) across > submitted URBs. This is the technique ADSL modem drivers use. They > also have to have input and output streams running simultaneously. I'm making a library to operate my device, and I don't want

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-28 Thread Willy Tarreau
Hi Pete, On Mon, Jul 24, 2006 at 11:07:32PM -0700, Pete Zaitcev wrote: > On Thu, 20 Jul 2006 10:43:59 -0700, Benjamin Cherian <[EMAIL PROTECTED]> > wrote: > > > > Although I am starting to think about creating a custom locking > > > scheme in devio.c after all. It seems like less work. > > > Wh

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-28 Thread Pete Zaitcev
On Thu, 27 Jul 2006 15:21:37 -0700, Benjamin Cherian <[EMAIL PROTECTED]> wrote: > On Monday 24 July 2006 23:07, Pete Zaitcev wrote: > > Anyway, please test the attached patch. Does it do what you want? > > Sorry to say that it doesnt. When calling usb_get_string_simple in libusb, > the program se

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-24 Thread Pete Zaitcev
On Thu, 20 Jul 2006 10:43:59 -0700, Benjamin Cherian <[EMAIL PROTECTED]> wrote: > > Although I am starting to think about creating a custom locking > > scheme in devio.c after all. It seems like less work. > What's your timeframe for this? Good luck with it. OK, now I hate my life, I hate you, I

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-20 Thread Benjamin Cherian
Pete, Thanks for the reply. > > All right then. I'll send you a patch that backports the string caching > > mechanism from 2.6 in a few days. Would you be able to test it with the > > 210PU? > > Yes, that would be fine. We should get back to you in a couple weeks with this. > Although I am start

Re: [linux-usb-devel] Bug with USB proc_bulk in 2.4 kernel

2006-07-17 Thread Pete Zaitcev
On Mon, 17 Jul 2006 14:35:21 -0700, Benjamin Cherian <[EMAIL PROTECTED]> wrote: I'm skipping the discussion of the spec, but going further, here's what we have: > It is really looking like you are backing me into a corner to make the change > myself. However, before doing so I'd like to say tha