Re: [linux-usb-devel] IO Region allocation in 2.6 (philips isp1160 PCI evaluation board - HCD)

2004-07-08 Thread David Brownell
Dimitris Lampridis wrote: On Thu, 2004-07-08 at 18:32, David Brownell wrote: Now, you may not be in a position to make sure your driver works without the PLX and related glue ... but you're certainly in a position to make sure PCI-isms are limited in scope. I agree 100%, but I don't understand how

Re: [linux-usb-devel] IO Region allocation in 2.6 (philips isp1160 PCI evaluation board - HCD)

2004-07-08 Thread Dimitris Lampridis
On Thu, 2004-07-08 at 18:32, David Brownell wrote: > Hi, > > >>>pdev = to_pci_dev(hcd->self.controller); > >>> > >>>if (pci_request_region (pdev, 2, (char *) hcd_name)) > >>>return -ENOMEM; > >> > >>... and "}" plus probably "else { ... }". That "else" > >>branch should probably use pla

Re: [linux-usb-devel] IO Region allocation in 2.6

2004-07-08 Thread David Brownell
Hi, struct isp1160_hcd *isp1160 = hcd_to_isp1160 (hcd); struct pci_dev *pdev = NULL; if(hcd->self.controller &&(hcd->self.controller->bus == &pci_bus_type)) Needs "{" ... and probably a comment about the eval board used with this non-pci driver. "non-pci"??? This IS a pci board. What makes you thin

Re: [linux-usb-devel] IO Region allocation in 2.6

2004-07-08 Thread Dimitris Lampridis
On Mon, 2004-07-05 at 21:57, David Brownell wrote: > Dimitris Lampridis wrote: > > > struct isp1160_hcd *isp1160 = hcd_to_isp1160 (hcd); > > struct pci_dev *pdev = NULL; > > > > if(hcd->self.controller &&(hcd->self.controller->bus == &pci_bus_type)) > > Needs "{" ... and probably a comment about

Re: [linux-usb-devel] IO Region allocation in 2.6

2004-07-06 Thread David Brownell
Dimitris Lampridis wrote: struct isp1160_hcd *isp1160 = hcd_to_isp1160 (hcd); struct pci_dev *pdev = NULL; if(hcd->self.controller &&(hcd->self.controller->bus == &pci_bus_type)) Needs "{" ... and probably a comment about the eval board used with this non-pci driver. pdev = to_pci_dev(hcd->sel

[linux-usb-devel] IO Region allocation in 2.6

2004-07-05 Thread Dimitris Lampridis
The following question is about an HCD: Why is it that when I try to allocate an IO region (io port) during the reset function it fails (pretty ugly), while it succeeds when I do exactly the same thing at the start function? I've looked at usb_hcd_pci_probe() and the allocation of the first region