Re: [linux-usb-devel] PATCH: audio driver cancellation

2002-02-28 Thread David Brownell
> > How about verifying that this problem is still present in the most > > recent kernel versions, and then sending a patch against those versions? > > Sure. I verified by eye that the problem still existed (by checking > that in usb-ohci.c, in dl_del_urb, there's a code path that doesn't > call

Re: [linux-usb-devel] PATCH: audio driver cancellation

2002-02-27 Thread Geoff Keating
> Date: Tue, 26 Feb 2002 22:38:57 -0800 > From: Greg KH <[EMAIL PROTECTED]> > On Tue, Feb 26, 2002 at 10:38:56AM -0800, Geoff Keating wrote: > > > > Starting a command-line mp3 player on a system with USB speakers, > > and then trying to stop it with control-C, didn't work; at best it > > didn't

Re: [linux-usb-devel] PATCH: audio driver cancellation

2002-02-26 Thread Greg KH
On Tue, Feb 26, 2002 at 10:38:56AM -0800, Geoff Keating wrote: > > Starting a command-line mp3 player on a system with USB speakers, > and then trying to stop it with control-C, didn't work; at best it > didn't stop right away, at worst kernel panics. > > It turned out that if a request is stopp

[linux-usb-devel] PATCH: audio driver cancellation

2002-02-26 Thread Geoff Keating
Starting a command-line mp3 player on a system with USB speakers, and then trying to stop it with control-C, didn't work; at best it didn't stop right away, at worst kernel panics. It turned out that if a request is stopped half-way using usb_unlink_urb, the completion routine never gets run, an