Greg KH wrote:
You need to allocate that buf structure (yeah, all 2 bytes of it) from a
call to kmalloc. Hm, I thought the documentation stated this. David,
did this change recently?
No recent changes. Documentation/usb/dma.txt points to DMA-mapping.txt
which is explicit about not allocating DMA
On Fri, Jan 23, 2004 at 01:19:17AM +0100, Marius Vollmer wrote:
>
> However, the interface of tsc10_control _is_ a bit whacky: badness
> results when passing in a retlen > 2. I have put in an assertion.
As you are the only caller of this function, why have that assertion in
there at all? A simp
On Fri, Jan 23, 2004 at 01:19:17AM +0100, Marius Vollmer wrote:
> Greg KH <[EMAIL PROTECTED]> writes:
>
> > It looks like you are sending data out the bus from the stack in the
> > tsc10_control() function. Care to fix that up?
>
> Hmm, are you referring to the 'buf' variable? That is used for
Greg KH <[EMAIL PROTECTED]> writes:
> It looks like you are sending data out the bus from the stack in the
> tsc10_control() function. Care to fix that up?
Hmm, are you referring to the 'buf' variable? That is used for
storing the response and is not sent out to the bus, as far as I
understand.
On Wed, Jan 21, 2004 at 09:50:58PM +0100, Marius Vollmer wrote:
>
> Anyway, here is tsc10.c reformatted ala Linux:
Also, you need to submit this as a patch, as per
Documentation/SubmittingDrivers that can be applied, if you wish to have
this added to the kernel tree.
thanks,
greg k-h
On Wed, Jan 21, 2004 at 09:50:58PM +0100, Marius Vollmer wrote:
> Greg KH <[EMAIL PROTECTED]> writes:
>
> > Does the driver work for you?
>
> Yes, I'm using it together with a slightly hacked kdrive X server on a
> EarthLCD TC-10 panel computer.
>
> > Looks like your email client ate all of the
Greg KH <[EMAIL PROTECTED]> writes:
> Does the driver work for you?
Yes, I'm using it together with a slightly hacked kdrive X server on a
EarthLCD TC-10 panel computer.
> Looks like your email client ate all of the tabs in your patch :(
Hehe, no, there aren't any. It's my way of indenting cod
On Wed, Jan 21, 2004 at 12:22:42AM +0100, Marius Vollmer wrote:
> Hi,
>
> please find attached a patch that adds support for the DMC TSC-10 USB
> touchscreen controller to linux-2.6.1. I hope you can use it.
>
> This driver is based on the wacom.c driver, and I don't really know
> enough about U
Hi,
please find attached a patch that adds support for the DMC TSC-10 USB
touchscreen controller to linux-2.6.1. I hope you can use it.
This driver is based on the wacom.c driver, and I don't really know
enough about USB or the input event stuff to be sure that I got it
right. If you spot any p
