> -Original Message-
> From: Patrick Mansfield [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, November 08, 2005 4:33 PM
> To: James Bottomley
> Cc: goggin, edward; 'Rolf Eike Beer'; 'Andrew Morton';
> Masanari Iida; linux-kernel@vger.kernel.org;
> linux-usb-devel@lists.sourceforge.net; linux
On Tue, 2005-11-08 at 13:33 -0800, Patrick Mansfield wrote:
> I mean we get a ref to the sdev in the upper level driver opens, scan, and
> sd flush. So where are we not getting a ref?
>
> Shouldn't the get be done at a higher level?
Actually, no, because of the way we run the queues for the next
On Tue, Nov 08, 2005 at 04:08:43PM -0500, James Bottomley wrote:
> On Tue, 2005-11-08 at 15:02 -0500, goggin, edward wrote:
> > Thanks! Here's a better one.
>
> It's line wrapped, but I fixed that up.
What code path triggered this?
I mean we get a ref to the sdev in the upper level driver opens
On Tue, 2005-11-08 at 15:02 -0500, goggin, edward wrote:
> Thanks! Here's a better one.
It's line wrapped, but I fixed that up.
James
---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Down
Thanks! Here's a better one.
--- ../base/linux-2.6.14-rc4/drivers/scsi/scsi_lib.c2005-10-10
20:19:19.0 -0500
+++ drivers/scsi/scsi_lib.c 2005-11-07 04:46:23.0 -0600
@@ -592,10 +592,17 @@ static void scsi_requeue_command(struct
void scsi_next_command(struct scsi_cmnd *c
Good point.
I tested your suggested patch fix and it works well in my test use case.
BTW, I've got test code in my just tested version of your patch to read the
kref of the sdev_gendev between the calls to scsi_run_queue and
put_device to increase the likelihood that the use case has actually
bee
On Tue, 2005-11-08 at 11:24 -0500, goggin, edward wrote:
> ! struct scsi_device *sdev = cmd->device;
> ! struct request_queue *q = sdev->request_queue;
> !
> ! // need to hold a reference on the device before we let go of the
> cmd
> ! if (scsi_device_get(sdev)) {
> ! s
Am Dienstag, 8. November 2005 17:24 schrieb goggin, edward:
>I've run into a bug like this several times using 2.6.14-rc4 while
>testing dm-multipath's reaction to uevents generated by forcing
>fiber channel transport failures -- which leads to the scsi device
>being detached and the queuedata poin
I've run into a bug like this several times using 2.6.14-rc4 while
testing dm-multipath's reaction to uevents generated by forcing
fiber channel transport failures -- which leads to the scsi device
being detached and the queuedata pointer in the device's queue being
reset in scsi_device_dev_releas
On 11/8/05, Andrew Morton <[EMAIL PROTECTED]> wrote:
> Masanari Iida <[EMAIL PROTECTED]> wrote:
> >
> > Hello,
> > I updated my system's kernel from 2.6.13.2 to 2.6.14,
> > then it oops when I connect my Digital Camera via USB connection
> > as USB storage device.
> > I went back to 2.6.14-rc1, sti
Masanari Iida <[EMAIL PROTECTED]> wrote:
>
> Hello,
> I updated my system's kernel from 2.6.13.2 to 2.6.14,
> then it oops when I connect my Digital Camera via USB connection
> as USB storage device.
> I went back to 2.6.14-rc1, still the same panic happen.
> 2.6.13.2 and before, the kernel has bee
Masanari Iida <[EMAIL PROTECTED]> wrote:
>
> On 11/1/05, Alan Stern <[EMAIL PROTECTED]> wrote:
> > On Sun, 30 Oct 2005, Andrew Morton wrote:
> >
> > > Masanari Iida <[EMAIL PROTECTED]> wrote:
> >
> > > > Hello Andrew,
> > > >
> > > > I did disabled CONFIG_DEBUG_PAGEALLOC and re-tested on 2.6.14-rc1
On 11/1/05, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Sun, 30 Oct 2005, Andrew Morton wrote:
>
> > Masanari Iida <[EMAIL PROTECTED]> wrote:
>
> > > Hello Andrew,
> > >
> > > I did disabled CONFIG_DEBUG_PAGEALLOC and re-tested on 2.6.14-rc1.
> > > Now the oops didn't happen when I connect digital c
On Sun, 30 Oct 2005, Andrew Morton wrote:
> Masanari Iida <[EMAIL PROTECTED]> wrote:
> > Hello Andrew,
> >
> > I did disabled CONFIG_DEBUG_PAGEALLOC and re-tested on 2.6.14-rc1.
> > Now the oops didn't happen when I connect digital camera to the USB.
>
> So the first oops was probably use-after
Masanari Iida <[EMAIL PROTECTED]> wrote:
>
You removed linux-scis and linux-usb from cc. Please retain them.
> >
> > Could you please try disabling CONFIG_DEBUG_PAGEALLOC and retest? If that
> > works OK, it's probably a use-after-free.
> >
> Hello Andrew,
>
> I did disabled CONFIG_DEBUG_PAGEA
Masanari Iida <[EMAIL PROTECTED]> wrote:
>
> Hello,
> I updated my system's kernel from 2.6.13.2 to 2.6.14,
> then it oops when I connect my Digital Camera via USB connection
> as USB storage device.
> I went back to 2.6.14-rc1, still the same panic happen.
> 2.6.13.2 and before, the kernel has bee
16 matches
Mail list logo
