Re: [linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume

2006-01-18 Thread Greg KH
On Wed, Jan 18, 2006 at 04:34:08PM +0100, Oliver Neukum wrote: > Am Mittwoch, 18. Januar 2006 15:13 schrieb Johannes Berg: > > On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote: > > > > > This patch is wrong. usb_kill_urb() will sleep. You must not use it under > > > a spinlock. > > > > Whoo

[linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume

2006-01-18 Thread Oliver Neukum
Am Mittwoch, 18. Januar 2006 15:13 schrieb Johannes Berg: > On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote: > > > This patch is wrong. usb_kill_urb() will sleep. You must not use it under > > a spinlock. > > Whoops. Good catch. I'll have to analyse the logic with the lists being > used he

[linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume

2006-01-18 Thread Johannes Berg
On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote: > This patch is wrong. usb_kill_urb() will sleep. You must not use it under > a spinlock. Whoops. Good catch. I'll have to analyse the logic with the lists being used here (and probably add a temporary list). Will try to get a new patch unti

[linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume

2006-01-18 Thread Oliver Neukum
Am Mittwoch, 18. Januar 2006 00:21 schrieb Johannes Berg: > The attached patch implements suspend/resume for the hci_usb bluetooth > driver by simply killing all outstanding urbs on suspend, and re-issuing > them on resume. > > This allows me to actually use the internal bluetooth "dongle" in my >