[linux-usb-devel] Re: [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module

2006-02-27 Thread Arjan van de Ven
On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote: > + struct semaphore sem; /* locks this structure: > + * connected is not changed, > + * hardware_up is not changed, > +

[linux-usb-devel] Re: [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module

2006-02-27 Thread Arjan van de Ven
On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote: > +#define IFNULL(a) \ > + if (unlikely(!(a))) please please get rid of this! first of all, gcc ALREADY treats null pointer checks as unlikely, second of all this makes code entirely unreadable, so please just use "if (!a)" where you