Re: [linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-04 Thread Frank Loeffler
Hi, Andrew Morton wrote: IOW: what does this (wordwrapped!) patch do? It changes the keycode the kernel is sending for three keys. For normal keyboards there is usually no argument to which keycode to send. An 'a' would send the keycoe for an 'a'. This however is a remote control. The keys

[linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-04 Thread Andrew Morton
Ryan Brown <[EMAIL PROTECTED]> wrote: > > Sorry Andrew, but the diff was incorrectly made, the updated patch, > reverts the changes too TV, DVD and OK Button, from 2.6.12-rc1. hm, this was about 20 patches and 300 emails ago and I've forgotten what we're discussing. For poor old scatterbrains it

[linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-04 Thread Ryan Brown
Sorry Andrew, but the diff was incorrectly made, the updated patch, reverts the changes too TV, DVD and OK Button, from 2.6.12-rc1. diff -ruN linux-2.6.12/drivers/usb/input/ati_remote.c linux-2.6.12-modified/drivers/usb/input/ati_remote.c --- linux-2.6.12/drivers/usb/input/ati_remote.c 2005-06-18

Re: [linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-04 Thread Pavel Machek
Hi! > - You might want to differentiate between this key and the ENTER key > of your keyboard, at least I do. If the kernel is sending the same > code for both keys, this is not possible in userspace. No, I think that you can still diferentiate between them ... they come from different keyboa

[linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-04 Thread Andrew Morton
mdew <[EMAIL PROTECTED]> wrote: > > I discovered a minor change in 2.6.10-mm1, changing this value back > corrects the "ok" button issue. > > > diff -urN linux/drivers/usb/input/ati_remote.c > linux-2.6.11/drivers/usb/input/ati_remote.c > --- linux/drivers/usb/input/ati_remote.c2005-0

Re: [linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-03 Thread Ryan Brown
> mdew wrote: > > mapped to "p". I found the TV Button, The DVD Button, the CH-/+ and > > the OK Button all non-working, every other button produced the "p". > > Could you please try 'showkey -s' from a console on all of those keys? Without my patch, nothing shows up when pressing OK, TV and DVD,

Re: [linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-03 Thread Frank Loeffler
Hi 'mdew' (you do have a name, do you?), mdew wrote: mapped to "p". I found the TV Button, The DVD Button, the CH-/+ and the OK Button all non-working, every other button produced the "p". Could you please try 'showkey -s' from a console on all of those keys? Pavel: I would think that 'more u

[linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-03 Thread mdew
Hi Pavel, Further testing, I initated xmodmap -e "keycode $X = p" (where X was 10->255), so theoritcally, all the buttons on the ati-remote should be mapped to "p". I found the TV Button, The DVD Button, the CH-/+ and the OK Button all non-working, every other button produced the "p". xbindkeys -m

[linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-02 Thread Pavel Machek
Hi! > I discovered a minor change in 2.6.10-mm1, changing this value back > corrects the "ok" button issue. > > > diff -urN linux/drivers/usb/input/ati_remote.c > linux-2.6.11/drivers/usb/input/ati_remote.c > --- linux/drivers/usb/input/ati_remote.c2005-08-02 > 17:56:26.0 +1200 >

Re: [linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-02 Thread Frank Loeffler
Hi 'mdew', mdew wrote: > I discovered a minor change in 2.6.10-mm1, changing this value back > corrects the "ok" button issue. This change seems to have been made on purpose[1] and it also seems correct to me. This is an 'ok' button and not an 'enter' button. If you want it to act like an ente

[linux-usb-devel] Re: Fw: ati-remote strangeness from 2.6.12 onwards

2005-08-01 Thread mdew
I discovered a minor change in 2.6.10-mm1, changing this value back corrects the "ok" button issue. diff -urN linux/drivers/usb/input/ati_remote.c linux-2.6.11/drivers/usb/input/ati_remote.c --- linux/drivers/usb/input/ati_remote.c2005-08-02 17:56:26.0 +1200 +++ linux-2.6.11/drive