Re: [linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-09-18 Thread Greg KH
On Thu, Sep 18, 2003 at 07:35:30PM +0900, Shin-ichiro KAWASAKI wrote: > > Greg KH wrote: > > >On Fri, Sep 12, 2003 at 01:31:28PM +0900, Shin-ichiro KAWASAKI wrote: > > > >>I wish pl2303.c would accept write request while the device is busy. > > > > > >Patches are always welcome :) > > I tried to

Re: [linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-09-18 Thread Shin-ichiro KAWASAKI
Greg KH wrote: On Fri, Sep 12, 2003 at 01:31:28PM +0900, Shin-ichiro KAWASAKI wrote: I wish pl2303.c would accept write request while the device is busy. Patches are always welcome :) I tried to make my wish come true on 2.4. Here's the patch. Five functions including pl2303_write() and pl2303

Re: [linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-09-12 Thread Greg KH
On Fri, Sep 12, 2003 at 01:31:28PM +0900, Shin-ichiro KAWASAKI wrote: > I wish pl2303.c would accept write request while the device is busy. Patches are always welcome :) To do this on 2.6 would be quite easy, 2.4 will be a bit tougher. thanks, greg k-h ---

[linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-09-12 Thread Shin-ichiro KAWASAKI
Hi, this is Shin-ichiro KAWASAKI My usb-to-serial converter (pl2303) shows similar problem as dave found. When I put a string with command 'echo hello > /dev/ttyUSB0', string 'hello' is sent correctly, but the echo command stop working and do not return to command prompt. I found that 'echo -n he

[linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-08-30 Thread Al Borchers
Greg KH wrote: > But I don't think the log shows this happening, right? Right--I do not understand what is happening in the logs. I am interested in investigating more. I was trying to clarify what was happening with opost processing and why the write has to succeed. > Actually, if write() does

Re: [linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-08-27 Thread David Anders
Borchers, Al (C)(STP) wrote: The digi_acceleport driver does something like this--you can look at that. thanks, i had just started looking at the digi driver this morning and was wondering if that could be implemented on other adapters. i'll post as soon as i have something testable. thanks d

[linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-08-27 Thread Borchers, Al (C)(STP)
Dave Anders wrote: > exactly, i just finished tracing this problem down and started looking > at what i could do to make this work properly. i've already begun > experimenting with different solutions for this, however nothing solid yet. There are lots of ways to fix this, here is one way... Ad

Re: [linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-08-27 Thread David Anders
Al Borchers wrote: > Forgot to explain that opost calls write_room to see > if there is room to write two characters when it > wants to write "\r\n". pl2303 says sure, there is > room. opost then writes '\r' and '\n' in two > separate writes, expecting that there is room for > both, but the seco

[linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-08-27 Thread Al Borchers
Forgot to explain that opost calls write_room to see if there is room to write two characters when it wants to write "\r\n". pl2303 says sure, there is room. opost then writes '\r' and '\n' in two separate writes, expecting that there is room for both, but the second write fails. pl2303 and simi

[linux-usb-devel] Re: ONLCR broken on pl2303 and mct_u232

2003-08-27 Thread Al Borchers
Dave, Greg -- I think this is one problem with OPOST ONLCR and the pl2303 usb usb driver (and other usb serial drivers)-- Look at the write_chan in n_tty.c. It calls opost_block() to write a block of characters up to the first '\n', then opost() to write the '\r' and '\n', using two calls to the