Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-25 Thread Greg KH
On Wed, Aug 25, 2004 at 10:44:47AM -0400, Alan Stern wrote: > The real question is: Is there sufficient demand for these timers outside > of usb_control/bulk_msg() to make it worth the effort of supporting them? I don't think so. But then again, I've never had to write a driver that needs this

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-25 Thread Alan Stern
On Wed, 25 Aug 2004, Oliver Neukum wrote: > Am Dienstag, 24. August 2004 23:18 schrieb Alan Stern: > > On Tue, 24 Aug 2004, Oliver Neukum wrote: > > > > > Where would you put the struct timer? Into the URB? > > > > No, it would have to go in a separately allocated block. The problem, of > > cou

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Jean Tourrilhes
On Tue, Aug 24, 2004 at 05:34:21PM -0400, Alan Stern wrote: > Jean: > > You might want to review some of the message in this thread on > linux-usb-devel. I personally never had hope of impacting the USB API one way or another. I'm just glad that I managed to get ZERO_PACKET support in it.

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Jean Tourrilhes
On Tue, Aug 24, 2004 at 02:56:56PM -0700, Greg KH wrote: > > Heh, thanks, but no, it doesn't change my mind :) > > Jean got the irda-usb driver working just fine on OHCI controllers, so > that proves that it doesn't need the timeout value. There was a time where usb-ohci did implement th

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Oliver Neukum
Am Dienstag, 24. August 2004 23:18 schrieb Alan Stern: > On Tue, 24 Aug 2004, Oliver Neukum wrote: > > > Where would you put the struct timer? Into the URB? > > No, it would have to go in a separately allocated block. The problem, of > course, is that the URB will often complete and be reused be

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Greg KH
On Tue, Aug 24, 2004 at 05:34:21PM -0400, Alan Stern wrote: > Jean: > > You might want to review some of the message in this thread on > linux-usb-devel. > > > Greg: > > You might want to read this thread (although I don't expect it to change > your mind): > > http://marc.theaimsgroup.com/?l=

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Alan Stern
Jean: You might want to review some of the message in this thread on linux-usb-devel. Greg: You might want to read this thread (although I don't expect it to change your mind): http://marc.theaimsgroup.com/?l=linux-usb-devel&m=108476210111359&w=2 Alan Stern On Tue, 24 Aug 2004, Greg KH wro

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Alan Stern
On Tue, 24 Aug 2004, Oliver Neukum wrote: > Where would you put the struct timer? Into the URB? No, it would have to go in a separately allocated block. The problem, of course, is that the URB will often complete and be reused before the timer expires or can be cancelled. The block will have to

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Greg KH
On Tue, Aug 24, 2004 at 03:58:56PM -0400, Alan Stern wrote: > On Tue, 24 Aug 2004, Greg KH wrote: > > > Ok, anyone mind if I just rip that field out of the urb structure so no > > one tries to rely on it anymore? > > Please don't. It's actually used in one or two drivers. Obviously those > dri

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Oliver Neukum
> Also, there is a proposal that's been lying around for a while to move the > timeout functionality out of usb_control/bulk_msg() and into the core. > Once that's done the timeout field will be perfectly functional, for all > HCDs. I'd do it myself if I had the time available. Where would y

[linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Greg KH
On Tue, Aug 24, 2004 at 11:33:23AM -0700, Pete Zaitcev wrote: > It just occured to me that urb->timeout is not functional. Applied, thanks. greg k-h --- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4

Re: [linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Alan Stern
On Tue, 24 Aug 2004, Greg KH wrote: > Ok, anyone mind if I just rip that field out of the urb structure so no > one tries to rely on it anymore? Please don't. It's actually used in one or two drivers. Obviously those drivers will only work properly with UHCI controllers, but the authors will

[linux-usb-devel] Re: ub patch to use add_timer

2004-08-24 Thread Greg KH
On Tue, Aug 24, 2004 at 11:33:23AM -0700, Pete Zaitcev wrote: > It just occured to me that urb->timeout is not functional. Crap. Ok, anyone mind if I just rip that field out of the urb structure so no one tries to rely on it anymore? thanks, greg k-h --