Re: [linux-usb-devel] request for test with your quirky drive enclosure

2007-01-31 Thread Oliver Neukum
Am Mittwoch, 31. Januar 2007 20:35 schrieb Alan Stern: > On Wed, 31 Jan 2007, Oliver Neukum wrote: > > > > > + if (sdkp->capacity % 63 || sdkp->capacity % 255) > > > > + --sdkp->capacity; > > > > > > This is a strange computation. You avoid decrementing the ca

Re: [linux-usb-devel] request for test with your quirky drive enclosure

2007-01-31 Thread Alan Stern
On Wed, 31 Jan 2007, Oliver Neukum wrote: > > > + if (sdkp->capacity % 63 || sdkp->capacity % 255) > > > + --sdkp->capacity; > > > > This is a strange computation. You avoid decrementing the capacity iff it > > is already divisible both by 63 and by 255. Maybe you really

Re: [linux-usb-devel] request for test with your quirky drive enclosure

2007-01-31 Thread Oliver Neukum
Am Mittwoch, 31. Januar 2007 17:22 schrieb Alan Stern: > On Wed, 31 Jan 2007, Oliver Neukum wrote: > If some other device ends up needing this in the future, what makes you > think the heuristic you have chosen will be appropriate? I've checked my disks and asked for counterexamples. If you have

Re: [linux-usb-devel] request for test with your quirky drive enclosure

2007-01-31 Thread Alan Stern
On Wed, 31 Jan 2007, Oliver Neukum wrote: > Hi, > > could you please test this with your storage device. It tries to implement > a heuristics which will work with both versions of the firmware. > > Regards > Oliver If some other device ends up needing this in the future, wha

[linux-usb-devel] request for test with your quirky drive enclosure

2007-01-31 Thread Oliver Neukum
Hi, could you please test this with your storage device. It tries to implement a heuristics which will work with both versions of the firmware. Regards Oliver --- a/drivers/usb/storage/unusual_devs.h2007-01-31 14:48:08.0 +0100 +++ b/drivers/usb/stora