[linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-27 Thread David Zeuthen
(please keep me Cc'ed, I'm not subscribed to linux-usb-devel) Hi, it seems that recent kernels (I'm using the Fedora 2.6.11-1.1268_FC4 kernel which I believe is based off 2.6.12-rc3 and AFAIK it doesn't have any invasive patches in that area) has changed behavior wrt hotplug event ordering. In [

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-27 Thread Alan Stern
On Wed, 27 Apr 2005, David Zeuthen wrote: > Hi, > > it seems that recent kernels (I'm using the Fedora 2.6.11-1.1268_FC4 > kernel which I believe is based off 2.6.12-rc3 and AFAIK it doesn't have > any invasive patches in that area) has changed behavior wrt hotplug > event ordering. In [1], I've

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-27 Thread Patrick Mansfield
On Wed, Apr 27, 2005 at 05:21:10PM -0400, Alan Stern wrote: > David's right. Why did kobject_hotplug() move out of kobject_add() and > into its callers sometime after 2.6.11? In particular the invocation in > device_add() is in the wrong place; it needs to come before > bus_add_device() starts

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-27 Thread Kay Sievers
On Wed, Apr 27, 2005 at 04:14:08PM -0700, Patrick Mansfield wrote: > On Wed, Apr 27, 2005 at 05:21:10PM -0400, Alan Stern wrote: > > > David's right. Why did kobject_hotplug() move out of kobject_add() and > > into its callers sometime after 2.6.11? In particular the invocation in > > device_ad

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-27 Thread Greg KH
On Thu, Apr 28, 2005 at 02:47:23AM +0200, Kay Sievers wrote: > On Wed, Apr 27, 2005 at 04:14:08PM -0700, Patrick Mansfield wrote: > > On Wed, Apr 27, 2005 at 05:21:10PM -0400, Alan Stern wrote: > > > > > David's right. Why did kobject_hotplug() move out of kobject_add() and > > > into its callers

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-29 Thread Roman Kagan
On Wed, Apr 27, 2005 at 04:14:08PM -0700, Patrick Mansfield wrote: > On Wed, Apr 27, 2005 at 05:21:10PM -0400, Alan Stern wrote: > > > David's right. Why did kobject_hotplug() move out of kobject_add() and > > into its callers sometime after 2.6.11? In particular the invocation in > > device_ad

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-29 Thread David Brownell
On Friday 29 April 2005 11:23 am, Roman Kagan wrote: > > ... instead of trying to make sure the attributes are available via > sysfs at hotplug time, we can use another means to pass them to hotplug: > we can add a routine, which, when called from the .hotplug function > and given pointers to stru

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-29 Thread Oliver Neukum
Am Freitag, 29. April 2005 21:28 schrieb David Brownell: > On Friday 29 April 2005 11:23 am, Roman Kagan wrote: > > > > ... instead of trying to make sure the attributes are available via > > sysfs at hotplug time, we can use another means to pass them to hotplug: > > we can add a routine, which,

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-29 Thread Greg KH
On Fri, Apr 29, 2005 at 09:35:52PM +0200, Oliver Neukum wrote: > Am Freitag, 29. April 2005 21:28 schrieb David Brownell: > > On Friday 29 April 2005 11:23 am, Roman Kagan wrote: > > > > > > ... instead of trying to make sure the attributes are available via > > > sysfs at hotplug time, we can use

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-29 Thread Greg KH
On Fri, Apr 29, 2005 at 10:23:36PM +0400, Roman Kagan wrote: > On Wed, Apr 27, 2005 at 04:14:08PM -0700, Patrick Mansfield wrote: > > On Wed, Apr 27, 2005 at 05:21:10PM -0400, Alan Stern wrote: > > > > > David's right. Why did kobject_hotplug() move out of kobject_add() and > > > into its callers

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-29 Thread Oliver Neukum
Am Freitag, 29. April 2005 22:01 schrieb Greg KH: > > > I'd rather just guarantee that the sysfs device were fully > > > constructed (attributes and all) before the driver binding and > > > hotplug stages of enumeration started.  That's been a problem > > > all along, and that's what those recent c

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-29 Thread David Brownell
On Friday 29 April 2005 12:35 pm, Oliver Neukum wrote: > Am Freitag, 29. April 2005 21:28 schrieb David Brownell: > > On Friday 29 April 2005 11:23 am, Roman Kagan wrote: > > > > > > ... add environment variable ... > > > > Color me amused. That was the original way to pass information > > to ho

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-04-29 Thread David Zeuthen
On Fri, 2005-04-29 at 22:16 +0200, Oliver Neukum wrote: > Am Freitag, 29. April 2005 22:01 schrieb Greg KH: > > > > I'd rather just guarantee that the sysfs device were fully > > > > constructed (attributes and all) before the driver binding and > > > > hotplug stages of enumeration started. That'

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-05-04 Thread Roman Kagan
On Fri, Apr 29, 2005 at 12:28:30PM -0700, David Brownell wrote: > On Friday 29 April 2005 11:23 am, Roman Kagan wrote: > > > > ... instead of trying to make sure the attributes are available via > > sysfs at hotplug time, we can use another means to pass them to hotplug: > > we can add a routine,

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-05-18 Thread David Zeuthen
Hey, On Wed, 2005-04-27 at 21:34 -0700, Greg KH wrote: > > Greg, ok if I prepare a patch to look at or don't you like the split? > > Let's see what the patch looks like :) > Did anything happen on this issue? Is there a patch yet? :-) Thanks, Dave -

Re: [linux-usb-devel] usb-storage bug in 2.6.12-rc3

2005-05-18 Thread Greg KH
On Wed, May 18, 2005 at 10:19:41AM -0400, David Zeuthen wrote: > > Hey, > > On Wed, 2005-04-27 at 21:34 -0700, Greg KH wrote: > > > Greg, ok if I prepare a patch to look at or don't you like the split? > > > > Let's see what the patch looks like :) > > Did anything happen on this issue? Is ther