Re: [linux-usb-devel] usblp_write error handling is broken

2007-05-09 Thread Pete Zaitcev
On Thu, 10 May 2007 01:24:17 +0200, Jochen Karrer <[EMAIL PROTECTED]> wrote: I agree that the code is clearly broken. There's lot more wrong going on in there, like the confusion over what 'err' is. > How is the intended error behaviour ? Should usblp_write simply retry > forever or should the sy

[linux-usb-devel] usblp_write error handling is broken

2007-05-09 Thread Jochen Karrer
Hi, The error handling in usblp_write in linux-2.6.18.1 is broken. I suspect its also broken in 2.6.21 because the code of usblp_write didn't change since 2.6.18. If I use blocking IO and any error happens which makes writeurb_status nonzero the usblp driver will end up in an endless loop sending