Re: [linux-usb-devel] [PATCH] USB Scanner devfs support

2001-06-07 Thread Karl Heinz Kremer
On Thu, Jun 07, 2001 at 04:46:11PM -0700, Greg KH wrote: > On Thu, Jun 07, 2001 at 04:42:45PM -0700, Tom Rini wrote: > > > > I changed that in the version I use but forgot to do that here as well, > > sorry. Want me to re-sent w/o this or can you just edit it out? It would > > be nice if this m

Re: [linux-usb-devel] [PATCH] USB Scanner devfs support

2001-06-07 Thread Tom Rini
On Thu, Jun 07, 2001 at 11:21:11AM -0400, Pavel Roskin wrote: > I've made a patch for devfs support in USB scanners (against 2.4.5-ac9). > It can be found here: > > http://www.red-bean.com/~proski/linux/scanner-devfs.diff It looks almost like the one I sent a few weeks ago. :) Hopefully this o

Re: [linux-usb-devel] [PATCH] USB Scanner devfs support

2001-06-07 Thread Greg KH
On Thu, Jun 07, 2001 at 03:39:11PM -0700, Tom Rini wrote: > + if (scn->devfs == NULL) > + err("scanner%d: device node registration failed", scn_minor); Make this a "dbg" call, not "err". See all of the people wondering why their printer is giving out kernel error messages when th

Re: [linux-usb-devel] [PATCH] USB Scanner devfs support

2001-06-07 Thread Tom Rini
On Thu, Jun 07, 2001 at 04:25:11PM -0700, Greg KH wrote: > On Thu, Jun 07, 2001 at 03:39:11PM -0700, Tom Rini wrote: > > + if (scn->devfs == NULL) > > + err("scanner%d: device node registration failed", scn_minor); > > Make this a "dbg" call, not "err". See all of the people wonderin

Re: [linux-usb-devel] [PATCH] USB Scanner devfs support

2001-06-07 Thread Tom Rini
On Thu, Jun 07, 2001 at 04:46:11PM -0700, Greg KH wrote: > On Thu, Jun 07, 2001 at 04:42:45PM -0700, Tom Rini wrote: > > > > I changed that in the version I use but forgot to do that here as well, > > sorry. Want me to re-sent w/o this or can you just edit it out? It would > > be nice if this m

Re: [linux-usb-devel] [PATCH] USB Scanner devfs support

2001-06-07 Thread Greg KH
On Thu, Jun 07, 2001 at 04:42:45PM -0700, Tom Rini wrote: > > I changed that in the version I use but forgot to do that here as well, > sorry. Want me to re-sent w/o this or can you just edit it out? It would > be nice if this made it upstream :) That's up to the current maintainer of the USB

Re: [linux-usb-devel] [PATCH] USB Scanner & Devfs support

2001-05-15 Thread Tom Rini
On Mon, May 14, 2001 at 09:01:17PM -0700, Mark McClelland wrote: > Tom Rini wrote: > > > Hello. The attached patch makes the 'normal' USB scanner register w/ devfs. > > Comments/questions/et al? Thanks.. > > IIRC, people who had devfs disabled were complaining about getting a similar > error m

Re: [linux-usb-devel] [PATCH] USB Scanner & Devfs support

2001-05-15 Thread Tom Rini
On Tue, May 15, 2001 at 02:40:08PM +0200, Oliver Neukum wrote: > On Monday, 14. May 2001 23:31, Tom Rini wrote: > > Hello. The attached patch makes the 'normal' USB scanner register w/ > > devfs. Comments/questions/et al? Thanks.. > > You may pass a null pointer to devfs_unregister is registeri

Re: [linux-usb-devel] [PATCH] USB Scanner & Devfs support

2001-05-15 Thread Oliver Neukum
On Monday, 14. May 2001 23:31, Tom Rini wrote: > Hello. The attached patch makes the 'normal' USB scanner register w/ > devfs. Comments/questions/et al? Thanks.. You may pass a null pointer to devfs_unregister is registering has failed, eg due to low memory. I don't know whether this is a bug,

Re: [linux-usb-devel] [PATCH] USB Scanner & Devfs support

2001-05-14 Thread Mark McClelland
Tom Rini wrote: > Hello. The attached patch makes the 'normal' USB scanner register w/ devfs. > Comments/questions/et al? Thanks.. IIRC, people who had devfs disabled were complaining about getting a similar error message from printer.c, after devfs support was added to it: + if(!scn->d