Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration()can change configs

2003-06-06 Thread Oliver Neukum
> Sorry, I misspoke in my original message. I didn't mean > usb_reset_config(); I was thinking about drivers that want to change to a > different configuration during their probe(). How do you plan to > accomodate that? Let the perverts use a workqueue. Regards Oliver

Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration()can change configs

2003-06-06 Thread David Brownell
Alan Stern wrote: Sorry, I misspoke in my original message. I didn't mean usb_reset_config(); I was thinking about drivers that want to change to a different configuration during their probe(). How do you plan to accomodate that? As I said earlier on a different thread: by adding a new "stru

Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration()can change configs

2003-06-06 Thread David Brownell
Alan Stern wrote: On Thu, 5 Jun 2003, David Brownell wrote: Yes, something like usb_reset_config(dev) call is needed. As well as converting code to use it, instead of the current calls to usb_set_configuration() in drivers. I want to echo Oliver's sentiment; this is a great patch. Needed a few o

Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration()can change configs

2003-06-06 Thread Alan Stern
On Fri, 6 Jun 2003, David Brownell wrote: > The way I see it, usb_reset_config(dev) should actually be > easy ... but it'll necessarily have significant restrictions > when used on devices with multiple interfaces. Basically, > don't use it unless you're the only driver bound (or being > bound) t

Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration()can change configs

2003-06-06 Thread David Brownell
Alan Stern wrote: On Thu, 5 Jun 2003, David Brownell wrote: Yes, something like usb_reset_config(dev) call is needed. As well as converting code to use it, instead of the current calls to usb_set_configuration() in drivers. I want to echo Oliver's sentiment; this is a great patch. Needed a few o

Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration()can change configs

2003-06-06 Thread Alan Stern
On Thu, 5 Jun 2003, David Brownell wrote: > Oliver Neukum wrote: > > Am Donnerstag, 5. Juni 2003 22:16 schrieb David Brownell: > >>In short, usb_set_configuration() now does what > >>it's supposed to do: it changes the device config, > >>and all usbcore state depending on it. > > > > > > Way co

Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration() can change configs

2003-06-06 Thread Oliver Neukum
Am Donnerstag, 5. Juni 2003 22:16 schrieb David Brownell: > This patch: > > - moves the config-specific sysfs updates out of > usb_new_device() into usb_set_configuration(), > where it belongs. > > - makes usb_set_configuration() get rid of sysfs > state for the previous configurati

Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration()can change configs

2003-06-06 Thread Oliver Neukum
> > 2. You can set hubs to config 0. What will that do? > > You can set anything to config 0 -- perfectly reasonable. > I take it you're suggesting that hubs are special enough > that allowing that to happen would be a Bad Thing? > Makes sense to me. Suggestion? I take that back. Your implementa

Re: [linux-usb-devel] [patch/rft 2.5.70] usb_set_configuration()can change configs

2003-06-05 Thread David Brownell
Oliver Neukum wrote: Am Donnerstag, 5. Juni 2003 22:16 schrieb David Brownell: In short, usb_set_configuration() now does what it's supposed to do: it changes the device config, and all usbcore state depending on it. Way cool. A few points. 1. We need a special function for devices that just re