Re: [linux-usb-devel] cdc-ether.c still wrong

2003-03-25 Thread Benjamin Herrenschmidt
> Yes, although I sent a patch (that I'd been trying to get people to provide > test feedback on for months - I never saw the problem occur on my test setup) > to the l-u-devel mailing list that corrects this (a few days ago). > > Are you actually seeing problems? Can you test the patches? I'v

Re: [linux-usb-devel] cdc-ether.c still wrong

2003-03-25 Thread Brad Hards
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 26 Mar 2003 01:41, Benjamin Herrenschmidt wrote: > This code in cdc-ether.c, CDCEther_start_xmit() > 2.5.x current but 2.4 seem wrong too: > > // If we are told to transmit an ethernet frame that fits EXACTLY > // into an integer number of USB

Re: [linux-usb-devel] cdc-ether.c still wrong

2003-03-25 Thread David Brownell
Alan Stern wrote: The byte in question should be set to 0 before it is transmitted. Second, if this is a matter of sending a runt USB packet, why not make it a 0-length packet instead of a 1-byte packet? Set to zero or any other constant value, yes. Not a very high bandwidth cove

Re: [linux-usb-devel] cdc-ether.c still wrong

2003-03-25 Thread Alan Stern
On 25 Mar 2003, Benjamin Herrenschmidt wrote: > This code in cdc-ether.c, CDCEther_start_xmit() > 2.5.x current but 2.4 seem wrong too: > > // If we are told to transmit an ethernet frame that fits EXACTLY > // into an integer number of USB packets, we force it to send one > // more byte so the