Re: [Linux-uvc-devel] Patch: Read support - Update

2007-09-11 Thread Brandon Philips
On 16:15 Sat 21 Jul 2007, Christopher HORLER wrote: I tried to take into account everyones comments, but it's possible I've missed things - hopefully it's better than the first attempt. What is the status of this patch? On Thursday 19 July 2007 19:30, Laurent Pinchart wrote: Hi Chris,

Re: [Linux-uvc-devel] Patch: Read support

2007-07-22 Thread Christopher HORLER
Hi Laurent, I've made adjustments, but I still think there maybe some problems. 1. I included the G_STD ioctl (but I've #if 0 it out - I was testing against an application that uses it, feel free to remove it). 2. Detecting if the stream is on - not sure I'm doing this right (see the read

Re: [Linux-uvc-devel] Patch: Read support - Update

2007-07-22 Thread Christopher HORLER
Hi Laurent, I realised I left in the TIMEOUT change as well - so I removed that and G_STD (see previous email) I've made adjustments, but I still think there maybe some problems. 1. Detecting if the stream is on - not sure I'm doing this right (see the read function). 2. I've several static

Re: [Linux-uvc-devel] Patch: Read support

2007-07-19 Thread Laurent Pinchart
Hi Chris, please keep the list CC'ed. On Wednesday 18 July 2007, Christopher HORLER wrote: Hi Laurent, I've cut a lot of it out because I only had three things to say, as I mostly agree. I was learning as a did it... and it was a first attempt, so I actually expected quite a few issues.

Re: [Linux-uvc-devel] Patch: Read support

2007-07-18 Thread Laurent Pinchart
Hi Chris, On Friday 13 July 2007, Christopher HORLER wrote: Hi, Here's a first attempt at supporting read - I'm sure there's bits to iron out, but it works for me. I already applied whitespace cleanup and other cosmetic changes. I'll comment on the rest. Index: uvc_queue.c

Re: [Linux-uvc-devel] Patch: Read support

2007-07-16 Thread Laurent Pinchart
Hi Chris, On Friday 13 July 2007, Christopher HORLER wrote: Hi, Here's a first attempt at supporting read - I'm sure there's bits to iron out, but it works for me. Thanks a lot for the patch. I haven't had time to look at it yet, but I'll try to review it before the end of the week.

[Linux-uvc-devel] Patch: Read support

2007-07-13 Thread Christopher HORLER
Hi, Here's a first attempt at supporting read - I'm sure there's bits to iron out, but it works for me. Chris Index: uvc_queue.c === --- uvc_queue.c (revision 111) +++ uvc_queue.c (working copy) @@ -63,6 +63,8 @@ *At that