Re: [Linux-uvc-devel] Possible bug in while enumerating private controls

2008-01-10 Thread Laurent Pinchart
Hi Antoine, On Thursday 03 January 2008, Antoine Cellerier wrote: Hello, I've stumbled upon a problem when hacking the VLC v4l2 driver: I want to enumerate all the private controls to make them available in the interface. The code used to enumerate the controls uses the same logic as

Re: [Linux-uvc-devel] Possible bug in while enumerating private controls

2008-01-10 Thread Antoine Cellerier
On Thu, Jan 10, 2008, Laurent Pinchart wrote: The UVC driver is different. The UVC spec allows devices to define new controls. The total number of controls could be huge, so using V4L2_CTRL_FLAG_DISABLED is not practical. For this reason, you should use the enumeration method described in

[Linux-uvc-devel] Possible bug in while enumerating private controls

2008-01-03 Thread Antoine Cellerier
Hello, I've stumbled upon a problem when hacking the VLC v4l2 driver: I want to enumerate all the private controls to make them available in the interface. The code used to enumerate the controls uses the same logic as Example 1-8 in the spec:

Re: [Linux-uvc-devel] Possible bug in while enumerating private controls

2008-01-03 Thread Antoine Cellerier
On Thu, Jan 03, 2008, Antoine Cellerier wrote: Since I don't know the uvcvideo control code really well I haven't started patching it yet and would like a confirmation from the gurus that I'm reading the spec correctly. Ok, so here is a patch that fixes the problem as far as i can tell. It