Re: [PATCH] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()

2014-09-10 Thread Johannes Berg
On Thu, 2014-09-11 at 04:02 +, Sharma, Sanjeev wrote: > -Original Message- > From: Johannes Berg [mailto:johan...@sipsolutions.net] > Sent: Friday, August 22, 2014 5:01 PM > To: Sharma, Sanjeev > Cc: d...@gentoo.org; k...@deine-taler.de; linvi...@tuxdriver.com; > linux-wireless@vger.k

CSA broken with !use_chanctx drivers?

2014-09-10 Thread Luca Coelho
Hi Michal, Johannes and I were checking the channel switch code (namely to see if implementing the drv_channel_switch op was fine in our case) and we saw that CSA with non-chanctx drivers seems to be broken. In commit 4c3ebc56 (mac80211: use chanctx reservation for STA CSA) we lost this piece of

Re: [PATCH v3] ath10k: fix debugfs_create_dir() checking

2014-09-10 Thread Michal Kazior
On 10 September 2014 18:14, Kalle Valo wrote: > Michal Kazior writes: [...] >> Since mine is just an extra precaution feel free >> to drop all but the first paragraph of my commit >> message if you want to. > > Thanks, I just left the first paragraph like you recommended. Also I had > a conflict

RE: [PATCH] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()

2014-09-10 Thread Sharma, Sanjeev
-Original Message- From: Johannes Berg [mailto:johan...@sipsolutions.net] Sent: Friday, August 22, 2014 5:01 PM To: Sharma, Sanjeev Cc: d...@gentoo.org; k...@deine-taler.de; linvi...@tuxdriver.com; linux-wireless@vger.kernel.org; net...@vger.kernel.org; linux-ker...@vger.kernel.org Subje

[PATCH net-next 2/2] mac80211: Resolve sk_refcnt/sk_wmem_alloc issue in wifi ack path

2014-09-10 Thread Alexander Duyck
There is a possible issue with the use, or lack thereof of sk_refcnt and sk_wmem_alloc in the wifi ack status functionality. Specifically if a socket were to request acknowledgements, and the socket were to have sk_refcnt drop to 0 resulting in it waiting on sk_wmem_alloc to reach 0 it would be po

[PATCH net-next 0/2] Address reference counting issues with sock_queue_err_skb

2014-09-10 Thread Alexander Duyck
After looking over the code for skb_clone_sk after some comments made by Eric Dumazet I have come to the conclusion that skb_clone_sk is taking the correct approach in how to handle the sk_refcnt when creating a buffer that is eventually meant to be returned to the socket via the sock_queue_err_skb

[PATCH net-next v2 1/2] skb: Add documentation for skb_clone_sk

2014-09-10 Thread Alexander Duyck
This change adds some documentation to the call skb_clone_sk. This is meant to help clarify the purpose of the function for other developers. Signed-off-by: Alexander Duyck --- v2: Updated comments to specifically call out need for sock_hold/sock_put net/core/skbuff.c | 13 + 1

Re: [PATCH net-next] mac80211: Check correct skb for shared states before freeing original

2014-09-10 Thread Alexander Duyck
On 09/10/2014 01:33 PM, Johannes Berg wrote: > On Wed, 2014-09-10 at 16:06 -0400, Alexander Duyck wrote: >> The code for cloning the skb for an acknowledgement was checking to see if >> the cloned skb was shared and if it was it was then freeing the original >> skb. Since a clone should never real

Re: [PATCH net-next] mac80211: Check correct skb for shared states before freeing original

2014-09-10 Thread Johannes Berg
On Wed, 2014-09-10 at 16:06 -0400, Alexander Duyck wrote: > The code for cloning the skb for an acknowledgement was checking to see if > the cloned skb was shared and if it was it was then freeing the original > skb. Since a clone should never really be shared I suspect that the > intention was to

[PATCH net-next] mac80211: Check correct skb for shared states before freeing original

2014-09-10 Thread Alexander Duyck
The code for cloning the skb for an acknowledgement was checking to see if the cloned skb was shared and if it was it was then freeing the original skb. Since a clone should never really be shared I suspect that the intention was to avoid freeing the clone if the original was shared. As such I am

[PATCH] cfg80211: don't put kek/kck/replay counter on the stack

2014-09-10 Thread Emmanuel Grumbach
From: Johannes Berg There's no need to put the values on the stack, just pass a pointer to the data in the nl80211 message. This reduces stack usage and avoids potential issues with putting sensitive data on the stack. Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach --- include/

[PATCH] cfg80211/mac80211: add wmm info to assoc event

2014-09-10 Thread Emmanuel Grumbach
From: Eliad Peller Userspace might need to know what queues are configured for uapsd (e.g. for setting proper default values in tspecs). Add this bitmap to the association event (inside wmm nested attribute) Add additional parameter to cfg80211_rx_assoc_resp, and update its callers. Signed-off

Re: [PATCH v2] ath10k: support firmware crash-by-assert

2014-09-10 Thread Ben Greear
On 09/10/2014 08:59 AM, Kalle Valo wrote: From: Ben Greear 10.1 firmware does not have an official way to cause assert on purpose, but it can be done with carefully crafted WMI command. This is a different kind of crash from the 'hard' crash, which is a bad memory dereference. Different crash

Re: iwlwifi no authentication with AP - Re: pull request: wireless-next 2014-09-08

2014-09-10 Thread Oliver Hartkopp
On 10.09.2014 11:23, Oliver Hartkopp wrote: > Hi all, > > yes for me too. > > Although I only could test it here with my mobile hotspot which only supports > WEP ... but before that hotspot was not working too. > > I'll check with my WPA2 setup again when I'm back home (if it's still needed). >

Re: [PATCH v3] ath10k: fix debugfs_create_dir() checking

2014-09-10 Thread Kalle Valo
Michal Kazior writes: > The function may return an -ENODEV if debugfs is > disabled in kernel. This should originally be > guarded by ath10k's Kconfig but it still makes > sense to check for the non-NULL errno return > value. > [...] > Reported-by: Matteo Croce > Signed-off-by: Michal Kazior

[PATCH v2] ath10k: support firmware crash-by-assert

2014-09-10 Thread Kalle Valo
From: Ben Greear 10.1 firmware does not have an official way to cause assert on purpose, but it can be done with carefully crafted WMI command. This is a different kind of crash from the 'hard' crash, which is a bad memory dereference. Different crashes decode in different manners, so this will

Re: [PATCH] ath10k: Support firmware crash-by-assert.

2014-09-10 Thread Kalle Valo
gree...@candelatech.com writes: > From: Ben Greear > > 10.1 firmware does not have an official way to > cause assert on purpose, but it can be done with > carefully crafted WMI command. This is a different > kind of crash from the 'hard' crash, which is > a bad memory dereference. > > Different

[PATCH v4 2/2] ath10k: add testmode

2014-09-10 Thread Kalle Valo
Add testmode interface for starting and using UTF firmware which is used to run factory tests. This is implemented by adding new state ATH10K_STATE_UTF and user space can enable this state with ATH10K_TM_CMD_UTF_START command. To go back to normal mode user space can send ATH10K_TM_CMD_UTF_STOP. S

[PATCH v4 0/2] ath10k: testmode support

2014-09-10 Thread Kalle Valo
Hi, latest version of my testmode patches. Getting closer, more or less cosmetic changes this time :) v4: * fix comment style (Michal) * add extra checks for at->testmode.utf (Michal) * add __ath10k_tm_cmd_utf_stop() and call it from ath10k_testmode_destroy() (Michal) v3: * remove false "f

[PATCH v4 1/2] ath10k: make ath10k_wmi_cmd_send() public

2014-09-10 Thread Kalle Valo
We need this function to send wmi packets from testmode.c. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/wmi.c |5 ++--- drivers/net/wireless/ath/ath10k/wmi.h |4 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/

Re: Not reaching optimum speeds with IEEE 802.11n

2014-09-10 Thread Andreas Hartmann
Hello Helmut! Helmut Schaa wrote: > On Wed, Sep 10, 2014 at 10:42 AM, Arend van Spriel wrote: >> On 09/10/14 03:26, Sourav wrote: >>> We are using Ralink chip Rt3072L (using rt2800usb drivers rt2800usb.c), > > The Ralink USB hardware is quite bad in reporting TX status and as > such minstrel_ht

Re: Not reaching optimum speeds with IEEE 802.11n

2014-09-10 Thread Andreas Hartmann
Sourav wrote: > Hi All, > We are using Ralink chip Rt3072L (using rt2800usb drivers rt2800usb.c), > mac80211, and hostapd in our routers. > root:~# lsmod > Module Size Used byTainted: P > rt2800usb 15371 0 > rt2800lib 74214 1 rt2800usb > rt2x00usb

Re: Realtek GPIO chipset, for Baytrail?

2014-09-10 Thread Marcel Holtmann
Hi Bastien, >>> What specific Baytrail tablet do you have? >> >> The Onda v975w. It came with Windows 8.1 32-bit. >> >> I guess that the device is probably a PCI one, but the enumeration is >> done through ACPI instead of "normal" PCI. > > In > http://www.on

Re: [PATCH v3 2/2] ath10k: add testmode

2014-09-10 Thread Kalle Valo
Michal Kazior writes: > (On 4 September 2014 15:56, Kalle Valo wrote: >> Add testmode interface for starting and using UTF firmware which is used to >> run >> factory tests. This is implemented by adding new state ATH10K_STATE_UTF and >> user >> space can enable this state with ATH10K_TM_CMD_U

Re: P2P_DEVICE support in Android KitKat

2014-09-10 Thread Arend van Spriel
On 09/10/14 16:00, Peer, Ilan wrote: Hi Arend, We've encountered this issue in the past, and resolved it by passing the wpa_supplicant a P2P specific configuration file using the -m option. Try using -m but do not populate it with any network blocks that are not P2P groups. Hope this helps,

Re: P2P_DEVICE support in Android KitKat

2014-09-10 Thread Arend van Spriel
On 09/10/14 13:10, Jouni Malinen wrote: On Wed, Sep 10, 2014 at 09:30:05AM +0200, Arend van Spriel wrote: I am running some tests on a haswell target with Android KitKat (3.10.20 kernel). In this configuration our brcmfmac driver is used with driver param 'p2p_device=1'. So we end up with wlan0

Re: Not reaching optimum speeds with IEEE 802.11n

2014-09-10 Thread Helmut Schaa
On Wed, Sep 10, 2014 at 10:42 AM, Arend van Spriel wrote: > On 09/10/14 03:26, Sourav wrote: >> We are using Ralink chip Rt3072L (using rt2800usb drivers rt2800usb.c), The Ralink USB hardware is quite bad in reporting TX status and as such minstrel_ht cannot do proper rate selection. If you watch

RE: P2P_DEVICE support in Android KitKat

2014-09-10 Thread Peer, Ilan
Hi Arend, We've encountered this issue in the past, and resolved it by passing the wpa_supplicant a P2P specific configuration file using the -m option. Try using -m but do not populate it with any network blocks that are not P2P groups. Hope this helps, Ilan. > -Original Message- > F

[PATCH 1/5] ath9k: Assign offchannel duration properly

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan In multi-channel mode, an offchannel request will be deferred if both contexts are active. The duration of the offchannel operation is calculated but is not stored in the scheduler state. Fix this. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/channe

[PATCH 4/5] ath9k: Fix channel switch time duration

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan Since the NoA duration is the maximum time the GO interface can be offline, it needs to include the time take to switch channels in the HW. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 5/5] ath9k: Fix beacon miss handling

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan The NoA duration for a GO is half the beacon interval and a concurrent context like a STA can be active only for that duration, before switching back to the GO's operating channel. Currently, when multiple beacons are missed, the dwell time for the STA context is extended

Re: Realtek GPIO chipset, for Baytrail?

2014-09-10 Thread Larry Finger
On 09/10/2014 05:21 AM, Arend van Spriel wrote: On 09/10/14 11:50, Bastien Nocera wrote: Indeed. That did the trick. mmc0:0001 is the builtin storage, mmc1:0001:1 however is an unbound device with vendor 0x024c and device 0xb723 (modalias: sdio:c07v024CdB723). More interestingly class is 0x07,

[PATCH 0/5] ath9k patches

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan MCC fixes for 3.18. Sujith Manoharan (5): ath9k: Assign offchannel duration properly ath9k: Fix Notice of Absence issues ath9k: Clear offchannel duration properly ath9k: Fix channel switch time duration ath9k: Fix beacon miss handling drivers/net/wireless/ath/a

[PATCH 3/5] ath9k: Clear offchannel duration properly

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan Clearing the offchannel duration value in the scheduler unconditionally breaks NoA when multiple contexts are active and an offchannel request is deferred, for example, in a scan run. Fix this by clearing the duration only if there is no pending offchannel request. Signed

[PATCH 2/5] ath9k: Fix Notice of Absence issues

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan * The index has to incremented only when advertising a new NoA schedule. * Switch to non-periodic NoA when starting a scan operation and multiple channel contexts are active. * Make sure that periodic NoA is advertised again when scan ends. Since the offchannel time

[PATCH 05/22] wil6210: coding style fixes

2014-09-10 Thread Vladimir Kondratiev
- parentheses, indentation, typos - seq_puts() instead of seq_printf() with single argument - sizeof(var) vs. sizeof(type) Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/cfg80211.c | 4 +- drivers/net/wireless/ath/wil6210/debugfs.c| 53 +--

[PATCH 09/22] wil6210: fix for memory corruption upon rmmod

2014-09-10 Thread Vladimir Kondratiev
From: Dedy Lansky Driver disabled PCI master before making sure HW is idle. This caused memory corruption in case HW access system memory after PCI master got disabled. The fix is to change uninit sequence. Make sure FW/HW is idle before disabling PCI Signed-off-by: Dedy Lansky Signed-off-by: V

[PATCH 17/22] wil6210: introduce separate completion for WMI

2014-09-10 Thread Vladimir Kondratiev
From: Dedy Lansky re-use of wmi_ready for both FW ready event and for wmi_call was causing false "FW not ready" indication in case wmi_call() was invoked while reset took place. add wmi_call completion variable instead of re-using wmi_ready. Signed-off-by: Dedy Lansky Signed-off-by: Vladimir Ko

[PATCH 18/22] wil6210: specify max. IE length

2014-09-10 Thread Vladimir Kondratiev
Expose firmware limit for the max_scan_ie_len; also do actually set IE's for the probe request max_scan_ie_len used to be 0, this blocks scan requests with non-zero IE's Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/cfg80211.c | 15 +++ 1 file changed, 15 i

[PATCH 12/22] wil6210: modify confusing printout

2014-09-10 Thread Vladimir Kondratiev
From: Dedy Lansky When WMI event received when driver not ready to accept it, the printed error message is misleading and hints that HW is stuck. Modify the error message to make it clearer Signed-off-by: Dedy Lansky Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/wmi.

[PATCH 02/22] wil6210: debug prints for vring de-allocation

2014-09-10 Thread Vladimir Kondratiev
Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/txrx.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c index 9bd920d..2cc3569 100644 --- a/drivers/net/wireless/ath/wil6210/

[PATCH 03/22] wil6210: print more information when connecting

2014-09-10 Thread Vladimir Kondratiev
when connecting, print some info about BSS Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/cfg80211.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/wireless/ath/wil6210/cfg80211.c b/drivers/net/wireless/ath/wil6210/cfg80211.c index a

[PATCH 07/22] wil6210: add more debug printouts

2014-09-10 Thread Vladimir Kondratiev
added misc printouts in some init/uninit functions for better traceability Signed-off-by: Dedy Lansky Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/cfg80211.c | 8 ++-- drivers/net/wireless/ath/wil6210/interrupt.c | 5 + drivers/net/wireless/ath/wil6210/main

[PATCH 14/22] wil6210: send connect request IEs to FW also for non-secure connection

2014-09-10 Thread Vladimir Kondratiev
Driver is sending connect request IEs to FW only for secure connection and ignores them for non-secure connection. This is fixed by always sending the IEs to FW upon connect request Signed-off-by: Dedy Lansky Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/cfg80211.c | 2

[PATCH 08/22] wil6210: fix for memory corruption while insmod

2014-09-10 Thread Vladimir Kondratiev
From: Dedy Lansky After setting interrupt handler, driver enabled interrupts. This caused stale (old) HW interrupts to fire before driver is fully initialized. The fix is to enable interrupts only when driver is fully initialized and after FW/HW reset (to prevent any stale interrupts) Signed-off

[PATCH 15/22] wil6210: add change_beacon() driver callback

2014-09-10 Thread Vladimir Kondratiev
This allows updating IEs (e.g. from hostapd) when AP is already started Signed-off-by: Dedy Lansky Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/cfg80211.c | 40 + 1 file changed, 40 insertions(+) diff --git a/drivers/net/wireless/ath/wil62

[PATCH 20/22] wil6210: rename [en|dis]able irq to [un]mask

2014-09-10 Thread Vladimir Kondratiev
To better reflect real action performed, rename: s/wil6210_disable_irq/wil_mask_irq/ s/wil6210_enable_irq/wil_unmask_irq/ Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/interrupt.c | 6 +++--- drivers/net/wireless/ath/wil6210/main.c | 4 ++-- drivers/net/wireless/at

[PATCH 01/22] wil6210: firmware download

2014-09-10 Thread Vladimir Kondratiev
Firmware download implemented but is still experimental feature; flag controlling it added, no_fw_load. It is true by default, use no_fw_load=N to activate feature. Reset flows also got some adjustment for the fw download to work Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/w

[PATCH 13/22] wil6210: fix race condition between BACK event and Rx data

2014-09-10 Thread Vladimir Kondratiev
From: Dedy Lansky While handling Rx packet, BACK event arrives and frees tid_ampdu_rx array. This causes kernel panic while accessing already freed spinlock The fix is to remove tid_ampdu_rx[]'s spinlock and instead use single sta's spinlock to guard the whole tid_ampdu_rx array. Signed-off-by:

[PATCH 19/22] wil6210: fix typo in comment

2014-09-10 Thread Vladimir Kondratiev
Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/interrupt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6210/interrupt.c b/drivers/net/wireless/ath/wil6210/interrupt.c index 58ddcc9..7d319d9 100644 --- a/drivers/net/wi

[PATCH 22/22] wil6210: fix PTR_ERR() usage after initialization to constant

2014-09-10 Thread Vladimir Kondratiev
Reported by coccinelle: tree: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master head: 6a5d088a923854569e20eac4f3f569926d5911ec commit: b7cde47009640b88cb3629ee7078a43bc2642459 [18/80] wil6210: convert debugfs to the table mode coccinelle warnings: (new ones pre

[PATCH 11/22] wil6210: fix race condition of disconnect while BACK event

2014-09-10 Thread Vladimir Kondratiev
From: Dedy Lansky This race condition was causing double free of tid_ampdu_rx structures Signed-off-by: Dedy Lansky Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/wmi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/a

[PATCH 21/22] wil6210: fix for oops while stopping interface

2014-09-10 Thread Vladimir Kondratiev
When interface stopped while running intensive Rx traffic, the following oops observed: [89846.734683] Call trace: [89846.737117] [] dev_gro_receive+0xac/0x358 [89846.742674] [] napi_gro_receive+0x24/0xa4 [89846.748251] [] $x+0xec/0x1f8 [wil6210] wil_netif_rx_any [89846.753547] [] $x+0x34

[PATCH 06/22] wil6210: platform specific module

2014-09-10 Thread Vladimir Kondratiev
New module (wil_platform) for handling platform specific tasks Signed-off-by: Dedy Lansky Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/Kconfig | 9 + drivers/net/wireless/ath/wil6210/Makefile | 2 + drivers/net/wireless/ath/wil6210/main.c

[PATCH 04/22] wil6210: some more debug for the WMI mechanism

2014-09-10 Thread Vladimir Kondratiev
Log worker thread start/stop; as well as every handler invocation Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/wmi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c index b1aaaee.

[PATCH 16/22] wil6210: enlarge TX/RX buffer length

2014-09-10 Thread Vladimir Kondratiev
HW supports upto 2304 packet size on the air. HW is responsible for adding (Tx) or removing (Rx) the following headers: 802.11 hdr: 26B SNAP: 8B CRC: 4B Security (optional): 24B HW adds max 62B to the payload passed from driver. It means driver can use max packet size of 2304-62 = 2242B Signed-off

[PATCH 10/22] wil6210: fix usage of print_hex_dump_debug

2014-09-10 Thread Vladimir Kondratiev
When CONFIG_DYNAMIC_DEBUG is not defined, print_hex_dump_debug is mapped directly to print_hex_dump which might cause printout to exist all the time Signed-off-by: Vladimir Kondratiev --- drivers/net/wireless/ath/wil6210/wil6210.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/driver

[PATCH 00/22] wil6210 patches

2014-09-10 Thread Vladimir Kondratiev
Really big item is firmware download. It is still experimental, and there is no firmware ready for public release yet; but we are getting close. Another item worth mentioning is provisioning for platform specific code. The rest is bug fixes and small improvements Dedy Lansky (6): wil6210: fix

Re: [PATCH 09/28] Remove ATHEROS_AR231X

2014-09-10 Thread Sergey Ryazanov
2014-09-10 15:36 GMT+04:00, Jiri Slaby : > On 09/10/2014, 12:33 PM, Sergey Ryazanov wrote: >> 2014-09-09 22:27 GMT+04:00, John W. Linville : >>> On Fri, Sep 05, 2014 at 04:02:10PM +0400, Sergey Ryazanov wrote: 2014-09-05 15:33 GMT+04:00 Paul Bolle : > Hi Sergey, > > On Fri, 2014-09

[PATCH] cfg80211: clear nl80211 messages carrying keys after processing

2014-09-10 Thread Emmanuel Grumbach
From: Johannes Berg Clear any nl80211 messages that might contain keys after processing them to avoid leaving their data in memory "forever" after they've been freed. Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach --- net/wireless/nl80211.c | 25 + 1 fil

Re: [PATCH 09/28] Remove ATHEROS_AR231X

2014-09-10 Thread Jiri Slaby
On 09/10/2014, 12:33 PM, Sergey Ryazanov wrote: > 2014-09-09 22:27 GMT+04:00, John W. Linville : >> On Fri, Sep 05, 2014 at 04:02:10PM +0400, Sergey Ryazanov wrote: >>> 2014-09-05 15:33 GMT+04:00 Paul Bolle : Hi Sergey, On Fri, 2014-09-05 at 15:12 +0400, Sergey Ryazanov wrote: >

Re: Realtek GPIO chipset, for Baytrail?

2014-09-10 Thread Bastien Nocera
On Wed, 2014-09-10 at 12:21 +0200, Arend van Spriel wrote: > On 09/10/14 11:50, Bastien Nocera wrote: > > On Wed, 2014-09-10 at 10:46 +0200, Arend van Spriel wrote: > >> On 09/10/14 01:10, Marcel Holtmann wrote: > >>> Hi Bastien, > >>> > >>> What specific Baytrail tablet do you have? > >> >

Re: [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS

2014-09-10 Thread Kalle Valo
Matteo Croce writes: > ATH10K_DEBUGFS must depend on DEBUG_FS, otherwise > ath10k will generate an invalid pointer on module load > > Signed-off-by: Matteo Croce Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a messag

Re: [PATCH] ath10k: use proper service bitmap size

2014-09-10 Thread Kalle Valo
Michal Kazior writes: > On 32bit systems the bitmap was too small and it > was overwritten partially by the stat completion > structure. This was visible with 10.2 firmware > only due to it using a few of the last service > ids. > > Signed-off-by: Michal Kazior Thanks, applied. -- Kalle Valo

Re: [PATCH] ath10k: move fw_crash_dump allocation

2014-09-10 Thread Kalle Valo
Michal Kazior writes: > The fw_crash_data was allocated too late. Upon > early firmware crash, before registering to > mac80211, it was possible to crash the whole > system: > > ath10k_pci :00:05.0: device has crashed during init > BUG: unable to handle kernel NULL pointer dereference at

[PATCH 1/3] cfg80211: allow requesting SMPS mode on ap start

2014-09-10 Thread Emmanuel Grumbach
From: Eliad Peller Add feature bits to indicate device support for static-smps and dynamic-smps modes. Add a new NL80211_ATTR_SMPS_MODE attribue to allow configuring the smps mode to be used by the ap (e.g. configuring to ap to dynamic smps mode will reduce power consumption while having minor e

[PATCH 3/3] mac80211: replace SMPS hw flags with wiphy feature bits

2014-09-10 Thread Emmanuel Grumbach
From: Eliad Peller Use the new static_smps / dynamic_smps feature bits instead of mac80211-internal hw flags. Signed-off-by: Eliad Peller Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/ath/ath10k/mac.c | 5 +++-- drivers/net/wireless/iwlegacy/4965-mac.c| 5 ++--- driver

[PATCH 2/3] mac80211: set smps_mode according to ap params

2014-09-10 Thread Emmanuel Grumbach
From: Eliad Peller Take the requested smps mode from the ap params (instead of always starting with SMPS_OFF) Signed-off-by: Eliad Peller Signed-off-by: Emmanuel Grumbach --- net/mac80211/cfg.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/net/mac80211/c

Re: P2P_DEVICE support in Android KitKat

2014-09-10 Thread Jouni Malinen
On Wed, Sep 10, 2014 at 09:30:05AM +0200, Arend van Spriel wrote: > I am running some tests on a haswell target with Android KitKat > (3.10.20 kernel). In this configuration our brcmfmac driver is used > with driver param 'p2p_device=1'. So we end up with wlan0 and > p2p-dev-wlan0 interfaces (can b

[PATCH 1/4] cfg80211: clear connect keys when freeing them

2014-09-10 Thread Emmanuel Grumbach
From: Johannes Berg When freeing the connect keys, clear the memory to avoid having the key material stick around in memory "forever". Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach --- net/wireless/ibss.c | 4 ++-- net/wireless/nl80211.c | 8 net/wireless/sme.c

[PATCH 3/4] cfg80211: clear wext keys when freeing and removing them

2014-09-10 Thread Emmanuel Grumbach
From: Johannes Berg When freeing the keys stored for wireless extensions, clear the memory to avoid having the key material stick around in memory "forever". Similarly, when userspace overwrites a key, actually clear it instead of just setting the key length to zero. Signed-off-by: Johannes Berg

[PATCH 4/4] cfg80211: clear rekey data on stack

2014-09-10 Thread Emmanuel Grumbach
From: Johannes Berg Clear the rekey data on the stack to avoid leaving it there in case another place might leak some stack bytes. Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach --- net/wireless/nl80211.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wireless/nl80211.

[PATCH 2/4] mac80211: clear key material when freeing keys

2014-09-10 Thread Emmanuel Grumbach
From: Johannes Berg When freeing the key, clear the memory to avoid having the key material stick around in memory "forever". Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach --- net/mac80211/key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/k

Re: [PATCH 09/28] Remove ATHEROS_AR231X

2014-09-10 Thread Sergey Ryazanov
2014-09-09 22:27 GMT+04:00, John W. Linville : > On Fri, Sep 05, 2014 at 04:02:10PM +0400, Sergey Ryazanov wrote: >> 2014-09-05 15:33 GMT+04:00 Paul Bolle : >> > Hi Sergey, >> > >> > On Fri, 2014-09-05 at 15:12 +0400, Sergey Ryazanov wrote: >> >> 2014-09-05 14:10 GMT+04:00, Paul Bolle : >> >> > On

Re: Realtek GPIO chipset, for Baytrail?

2014-09-10 Thread Arend van Spriel
On 09/10/14 11:50, Bastien Nocera wrote: On Wed, 2014-09-10 at 10:46 +0200, Arend van Spriel wrote: On 09/10/14 01:10, Marcel Holtmann wrote: Hi Bastien, What specific Baytrail tablet do you have? The Onda v975w. It came with Windows 8.1 32-bit. I guess that the device is probably a PCI on

Re: Realtek GPIO chipset, for Baytrail?

2014-09-10 Thread Bastien Nocera
On Wed, 2014-09-10 at 10:46 +0200, Arend van Spriel wrote: > On 09/10/14 01:10, Marcel Holtmann wrote: > > Hi Bastien, > > > > What specific Baytrail tablet do you have? > > The Onda v975w. It came with Windows 8.1 32-bit. > > I guess that the device is probably a PCI one, b

Re: Realtek GPIO chipset, for Baytrail?

2014-09-10 Thread Bastien Nocera
On Tue, 2014-09-09 at 16:10 -0700, Marcel Holtmann wrote: > Hi Bastien, > > What specific Baytrail tablet do you have? > >>> > >>> The Onda v975w. It came with Windows 8.1 32-bit. > >>> > >>> I guess that the device is probably a PCI one, but the enumeration is > >>> done through ACPI inste

Re: 802.11p rate control

2014-09-10 Thread Emmanuel Thierry
Le 10 sept. 2014 à 10:50, Johannes Berg a écrit : > On Mon, 2014-09-08 at 18:30 +0200, Rostislav Lisovy wrote: > >> If I am not mistaken, it is not possible to live without an in-kernel >> rate_control algorithm? >> One interesting idea I got from one colleague is to implement the >> algorithm l

Re: iwlwifi no authentication with AP - Re: pull request: wireless-next 2014-09-08

2014-09-10 Thread Oliver Hartkopp
Hi all, yes for me too. Although I only could test it here with my mobile hotspot which only supports WEP ... but before that hotspot was not working too. I'll check with my WPA2 setup again when I'm back home (if it's still needed). So far feel free to add my Reported-by: Oliver Hartkopp Tes

Re: iwlwifi no authentication with AP - Re: pull request: wireless-next 2014-09-08

2014-09-10 Thread Vadim Kochan
Hi, Your patch works for me. On Wed, Sep 10, 2014 at 11:24 AM, Emmanuel Grumbach wrote: > On Wed, Sep 10, 2014 at 8:01 AM, Oliver Hartkopp > wrote: >> On 10.09.2014 00:07, Vadim Kochan wrote: >>> I have the same issue with iwlwifi. >> >> I tried an old zd1211 wireless USB stick to check if thi

[PATCH] [RESEND] ath5k: Remove AHB bus support

2014-09-10 Thread Paul Bolle
AHB bus support was added in v2.6.38, through commit a0b907ee2a71 ("ath5k: Add AHB bus support."). That code can only be build if the Kconfig symbol ATHEROS_AR231X is set. But that symbol has never been added to the tree. So AHB bus support has always been dead code. Let's remove all code that dep

Re: 802.11p rate control

2014-09-10 Thread Johannes Berg
On Mon, 2014-09-08 at 18:30 +0200, Rostislav Lisovy wrote: > The possible (first implementation) solution might be either to > implement some "dummy" rate control algorithm that will set a fixed > datarate only once (during "ocb join" command) or to use the Minstrel > while limiting the allowed da

Re: Realtek GPIO chipset, for Baytrail?

2014-09-10 Thread Arend van Spriel
On 09/10/14 01:10, Marcel Holtmann wrote: Hi Bastien, What specific Baytrail tablet do you have? The Onda v975w. It came with Windows 8.1 32-bit. I guess that the device is probably a PCI one, but the enumeration is done through ACPI instead of "normal" PCI. In http://www.onda-tablet.com/

Re: Not reaching optimum speeds with IEEE 802.11n

2014-09-10 Thread Arend van Spriel
On 09/10/14 03:26, Sourav wrote: Hi All, We are using Ralink chip Rt3072L (using rt2800usb drivers rt2800usb.c), mac80211, and hostapd in our routers. root:~# lsmod Module Size Used by Tainted: P rt2800usb 15371 0 rt2800lib 74214 1 rt2800usb rt2x00usb 9718 1 rt2800usb rt2x00lib 39328 3 rt2800usb,

Re: iwlwifi no authentication with AP - Re: pull request: wireless-next 2014-09-08

2014-09-10 Thread Emmanuel Grumbach
On Wed, Sep 10, 2014 at 8:01 AM, Oliver Hartkopp wrote: > On 10.09.2014 00:07, Vadim Kochan wrote: >> I have the same issue with iwlwifi. > > I tried an old zd1211 wireless USB stick to check if this problem is 80211 > related. But the USB stick works fine (I'm using it right now). > So its defini

P2P_DEVICE support in Android KitKat

2014-09-10 Thread Arend van Spriel
Hi Jouni, I am running some tests on a haswell target with Android KitKat (3.10.20 kernel). In this configuration our brcmfmac driver is used with driver param 'p2p_device=1'. So we end up with wlan0 and p2p-dev-wlan0 interfaces (can blame myself for that). The configuration has a network con

[RFC 3/5] ath9k: Clear offchannel duration properly

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan Clearing the offchannel duration value in the scheduler unconditionally breaks NoA when multiple contexts are active and an offchannel request is deferred, for example, in a scan run. Fix this by clearing the duration only if there is no pending offchannel request. Signed

[RFC 2/5] ath9k: Fix Notice of Absence issues

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan * The index has to incremented only when advertising a new NoA schedule. * Switch to non-periodic NoA when starting a scan operation and multiple channel contexts are active. * Make sure that periodic NoA is advertised again when scan ends. Since the offchannel time

[RFC 5/5] ath9k: Fix beacon miss handling

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan The NoA duration for a GO is half the beacon interval and a concurrent context like a STA can be active only for that duration, before switching back to the GO's operating channel. Currently, when multiple beacons are missed, the dwell time for the STA context is extended

[RFC 0/5] ath9k patches

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan MCC fixes. Please review. Sujith Manoharan (5): ath9k: Assign offchannel duration properly ath9k: Fix Notice of Absence issues ath9k: Clear offchannel duration properly ath9k: Fix channel switch time duration ath9k: Fix beacon miss handling drivers/net/wireless

[RFC 1/5] ath9k: Assign offchannel duration properly

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan In multi-channel mode, an offchannel request will be deferred if both contexts are active. The duration of the offchannel operation is calculated but is not stored in the scheduler state. Fix this. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/channe

[RFC 4/5] ath9k: Fix channel switch time duration

2014-09-10 Thread Sujith Manoharan
From: Sujith Manoharan Since the NoA duration is the maximum time the GO interface can be offline, it needs to include the time take to switch channels in the HW. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] b43: HT-PHY: Set MAC frequency to correct values

2014-09-10 Thread Rafał Miłecki
I misunderstood original Broadcom comment and used wrong values. Signed-off-by: Rafał Miłecki --- Comment in original brcm80211 patch was like this: + * HTPHY Formula is 2^26/freq(MHz) e.g. + * For spuron2 - 126MHz -> 2^26/126 = 532610.0 + * - 532610 = 0x82082 => tsf_clk_frac_h = 0x8, tsf_clk_fr