On 8 October 2014 16:50, Sujith Manoharan wrote:
> Michal Kazior wrote:
>> I think you've just found an ath10k bug.
>>
>> I've been running through Rx code lately. I was looking at
>> htt_rx_mpdu_status and noticed it was a bit greedy. I then recalled
>> someone was complaining about RTS reception
On Wed, Oct 8, 2014 at 3:52 PM, Mark Asselstine wrote:
> On Wed, Oct 8, 2014 at 9:00 AM, Stanislaw Gruszka wrote:
>>
>> On Wed, Oct 08, 2014 at 07:46:33AM -0400, Mark Asselstine wrote:
>> > > If rt2x00 does not remove the alignment from the frame before giving it
>> > > back
>> > > to mac80211 a
On Tuesday 30 September 2014 12:06:10 Arend van Spriel wrote:
> On 09/29/14 21:40, Maximilian Engelhardt wrote:
> > On Monday 29 September 2014 15:44:03 Arend van Spriel wrote:
> >> On 09/26/14 17:20, Michael Tokarev wrote:
> >>> I can send it your way, -- guess it will be quite a bit costly,
> >>>
On Wed, Oct 8, 2014 at 9:00 AM, Stanislaw Gruszka wrote:
>
> On Wed, Oct 08, 2014 at 07:46:33AM -0400, Mark Asselstine wrote:
> > > If rt2x00 does not remove the alignment from the frame before giving it
> > > back
> > > to mac80211 and the same frame comes into rt2x00 again it should be
> > > c
From: Larry Finger
Date: Wed, 8 Oct 2014 12:44:55 -0500
> Two macros used to copy BSSID information use ether_addr_copy(), thus
> the arrays must be 2-byte aligned. In one case, the array could become
> unaligned if the struct containing it were changed. Use the __unaligned(2)
> attribute to ret
On Wed, 2014-10-08 at 12:52 -0500, Dan Williams wrote:
> On Wed, 2014-10-08 at 15:37 +0200, CHAUMETTE Hubert wrote:
> > Hi all,
> >
> > I need to activate the wl12xx driver (from drivers/net/wireless/ti/) on a
> > (Android) Linux 3.10.31 kernel on an i.MX6Q SabreSD board. The wl1271 is to
> > co
On Wed, 2014-10-08 at 15:37 +0200, CHAUMETTE Hubert wrote:
> Hi all,
>
> I need to activate the wl12xx driver (from drivers/net/wireless/ti/) on a
> (Android) Linux 3.10.31 kernel on an i.MX6Q SabreSD board. The wl1271 is to
> communicate with the board through an SDIO interface (SD2 on the boar
Two macros used to copy BSSID information use ether_addr_copy(), thus
the arrays must be 2-byte aligned. In one case, the array could become
unaligned if the struct containing it were changed. Use the __unaligned(2)
attribute to retain the necessary alignment. In addition, the magic number
used to
Joe Perches writes:
> On Wed, 2014-10-08 at 16:33 +0200, Jes Sorensen wrote:
>> Joe Perches writes:
>> > On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
>> >> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
>> >> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
>> >>
On Wed, 2014-10-08 at 16:33 +0200, Jes Sorensen wrote:
> Joe Perches writes:
> > On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
> >> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> >> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> >> > > The return from myid()
Michal Kazior wrote:
> I think you've just found an ath10k bug.
>
> I've been running through Rx code lately. I was looking at
> htt_rx_mpdu_status and noticed it was a bit greedy. I then recalled
> someone was complaining about RTS reception.
Maybe the RX filter to receive control frames is not
Joe Perches writes:
> On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
>> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
>> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
>> > > The return from myid() isn't aligned correctly for ether_addr_copy().
>> >
>> > Hey Dan
Dan Carpenter writes:
> On Wed, Oct 08, 2014 at 03:59:33PM +0200, Jes Sorensen wrote:
>> Dan Carpenter writes:
>> > The return from myid() isn't aligned correctly for ether_addr_copy().
>> >
>> > Signed-off-by: Dan Carpenter
>>
>> Sorry, this makes no sense, just fix it properly!
>>
>> drivers
On Wed, Oct 08, 2014 at 03:59:33PM +0200, Jes Sorensen wrote:
> Dan Carpenter writes:
> > The return from myid() isn't aligned correctly for ether_addr_copy().
> >
> > Signed-off-by: Dan Carpenter
>
> Sorry, this makes no sense, just fix it properly!
>
> drivers/staging/rtl8723au/include/rtw_ee
On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> > > The return from myid() isn't aligned correctly for ether_addr_copy().
> >
> > Hey Dan.
> >
> > Actual evidence s
Dan Carpenter writes:
> The return from myid() isn't aligned correctly for ether_addr_copy().
>
> Signed-off-by: Dan Carpenter
Sorry, this makes no sense, just fix it properly!
drivers/staging/rtl8723au/include/rtw_eeprom.h:
struct eeprom_priv {
u8 bautoload_fail_flag;
+ath...@lists.infradead.org
On 7 October 2014 13:30, Okhwan Lee wrote:
> Hi,
>
> We are trying to develop an algorithm by using the information of RTS
> reception at the receiver side. (actually, we need the preceding frame of
> A-MPDU).
> As far as we know, RTS/CTS exchange is done by firmware
Thanks, it sounds good to use a label instead of index.
However:
- DSD is only compatible with BIOS ACPI 5.1
- gpiod_get_index does not take care of con_id (label) parameter in case
of ACPI (acpi_find_gpio).
- gpiod_get calls gpiod_get_index with index 0.
Any patch ongoing to support con_id par
Hi all,
I need to activate the wl12xx driver (from drivers/net/wireless/ti/) on a
(Android) Linux 3.10.31 kernel on an i.MX6Q SabreSD board. The wl1271 is to
communicate with the board through an SDIO interface (SD2 on the board).
I have built the driver modules (cfg80211 and mac80211; wlcore,
On Wed, Oct 08, 2014 at 02:50:50PM +0200, Julia Lawall wrote:
> Couldn't you just use your favorite matching tool, collect the file names,
> compile them, run pahole, and process the output in some way? It doesn't
> give a complete analysis (you don't find all problems), but if you find a
> proble
On Wed, Oct 08, 2014 at 07:46:33AM -0400, Mark Asselstine wrote:
> > If rt2x00 does not remove the alignment from the frame before giving it back
> > to mac80211 and the same frame comes into rt2x00 again it should be
> > correctly
> > aligned and no additional header space is required. So this sh
On Wed, 8 Oct 2014, Dan Carpenter wrote:
> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> > > The return from myid() isn't aligned correctly for ether_addr_copy().
> >
> > Hey Dan.
> >
> > Actual evidence showing ether_a
On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> > The return from myid() isn't aligned correctly for ether_addr_copy().
>
> Hey Dan.
>
> Actual evidence showing ether_addr_copy conversions
> may not always be wise.
>
> How
Michal Kazior writes:
>>> Until now we have protected arvif->beacon_buf with data_lock. How do we
>>> know that this is safe to do without taking data_lock?
>>>
>> As said, spin_lock can not be used for dma_free_coherent.
>> arvif->beacon_buf is already protected by conf_mutex. At this state
>> i
On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> The return from myid() isn't aligned correctly for ether_addr_copy().
Hey Dan.
Actual evidence showing ether_addr_copy conversions
may not always be wise.
How did you find them?
Is there a new alignment capability in smatch?
--
To unsu
On 8 October 2014 12:48, Rajkumar Manoharan wrote:
> On Wed, Oct 08, 2014 at 12:52:04PM +0300, Kalle Valo wrote:
>> Rajkumar Manoharan writes:
>>
>> > The commit "ath10k: workaround fw beaconing bug" is freeing
>> > DMA-coherent memory in irq context which is hitting BUG ON
>> > in ARM platforms.
We provide timeout value to rt2x00usb_vendor_request_buff() based on
number of registers to process. That value is passed down to
rt2x00usb_vendor_req_buff_lock() and ends in usb_control_msg(). But we
do not read/write all registers in rt2x00usb_vendor_req_buff_lock() at
once. We read/write them in
On 8 October 2014 13:13, Rajkumar Manoharan wrote:
> On Wed, Oct 08, 2014 at 04:38:44PM +0530, Rajkumar Manoharan wrote:
>> On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote:
>> > If anything the offender should be dma_unmap_single() but the thing is
>> > beacon_buf is always allocated
On 8 October 2014 13:08, Rajkumar Manoharan wrote:
> On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote:
>> On 8 October 2014 12:33, Rajkumar Manoharan
>> wrote:
>> > On Wed, Oct 08, 2014 at 11:45:38AM +0200, Michal Kazior wrote:
>> >> On 8 October 2014 11:16, Rajkumar Manoharan
>>
On Wed, Oct 08, 2014 at 10:34:38AM +0200, Loic Poulain wrote:
> Some GPIO based rfkill devices can wake their host up from suspend by
> toggling an input (from the host perspective) GPIO.
> This patch adds a generic support for that feature by registering a
> threaded interrupt routine and thus set
On Sun, Oct 5, 2014 at 4:39 AM, Helmut Schaa
wrote:
>
>
>
>
> Mark Asselstine schrieb:
>>On Wed, Oct 1, 2014 at 9:42 PM, Mark Asselstine
>>wrote:
>>>
>>> Damn, you are right. I thought I had it licked.
>>>
>>> Unfortunately with the overloaded variable name it was easy to get
>>turned
>>> around
On Wed, Oct 08, 2014 at 04:38:44PM +0530, Rajkumar Manoharan wrote:
> On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote:
> > On 8 October 2014 12:33, Rajkumar Manoharan
> > wrote:
> > > On Wed, Oct 08, 2014 at 11:45:38AM +0200, Michal Kazior wrote:
> > >> On 8 October 2014 11:16, Rajk
On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote:
> On 8 October 2014 12:33, Rajkumar Manoharan wrote:
> > On Wed, Oct 08, 2014 at 11:45:38AM +0200, Michal Kazior wrote:
> >> On 8 October 2014 11:16, Rajkumar Manoharan
> >> wrote:
> >> > The commit "ath10k: workaround fw beaconing b
On 8 October 2014 12:33, Rajkumar Manoharan wrote:
> On Wed, Oct 08, 2014 at 11:45:38AM +0200, Michal Kazior wrote:
>> On 8 October 2014 11:16, Rajkumar Manoharan
>> wrote:
>> > The commit "ath10k: workaround fw beaconing bug" is freeing
>> > DMA-coherent memory in irq context which is hitting B
On Wed, Oct 08, 2014 at 12:52:04PM +0300, Kalle Valo wrote:
> Rajkumar Manoharan writes:
>
> > The commit "ath10k: workaround fw beaconing bug" is freeing
> > DMA-coherent memory in irq context which is hitting BUG ON
> > in ARM platforms. Fix this by moving dma_free out of spin
> > lock.
> [..
The return from myid() isn't aligned correctly for ether_addr_copy().
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index 3eb77de..c8f7890 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/d
On Wed, Oct 08, 2014 at 11:45:38AM +0200, Michal Kazior wrote:
> On 8 October 2014 11:16, Rajkumar Manoharan wrote:
> > The commit "ath10k: workaround fw beaconing bug" is freeing
> > DMA-coherent memory in irq context which is hitting BUG ON
> > in ARM platforms. Fix this by moving dma_free out o
Rajkumar Manoharan writes:
> Add tracing support to forward management and data frames to
> user space for packet inspection.
>
> Signed-off-by: Rajkumar Manoharan
Thanks, applied.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a mess
On Wed, Oct 08, 2014 at 10:34:36AM +0200, Loic Poulain wrote:
> Some devices don't match the current static gpio mapping:
> -BCM4752 (GPS) uses gpio res 0 as host wake irq.
> -OBDA8723 (Bluetooth) uses gpio res 0 as controller wake gpio
> and res 2 as host wake irq.
>
> To allow more flexibility,
Janusz Dziedzic writes:
> Fix WMI scan command length we setup when scan request.
>
> This fix issue with 636 firmware when scan always failed
> with message:
>
> ath10k_pci :02:00.0: wmi start scan
> ath10k_pci :02:00.0: wmi stop scan reqid 1 req_type 0 vdev/scan_id 0
> ath10k_pci :0
Bartosz Markowski writes:
> This is required if we take into account possibility to load the driver
> from initrd (RAM disk), so in other words: very early in the boot process,
> before the file system is visible.
>
> In such case we need to have the firmware files accessible from ram disk too,
>
Janusz Dziedzic writes:
> It's not really necessary to create bssid peer for
> bssid. Self-address peer is sufficient.
>
> This prevents some firmware revisions from crashing.
>
> Signed-off-by: Janusz Dziedzic
Thanks, applied.
--
Kalle Valo
--
To unsubscribe from this list: send the line "un
Michal Kazior writes:
> It makes a lot more sense to print these kinds of
> problems as a warning instead of a debug.
>
> Signed-off-by: Michal Kazior
Thanks, applied.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord
Rajkumar Manoharan writes:
>> > + trace_ath10k_htt_rx_pop_msdu(ar, msdu->data, msdu->len +
>> > + skb_tailroom(msdu));
>>
>> Why add skb_tailroom() to the length? I think that deserves a comment.
>
> It is used for rx crypto length. skb_tailroom is used in most of
On Tue, Oct 07, 2014 at 05:12:47PM +0200, poma wrote:
> BTW, pán Gruszka, when will these devices be supported as a part of the
> upstream Linux kernel?
I'm not an oracle :-)
Larry declared to work on some mt76xx chip support, I'm cc him.
I can also work on new chips for rt2x00, but wanted to f
Rajkumar Manoharan writes:
> The commit "ath10k: workaround fw beaconing bug" is freeing
> DMA-coherent memory in irq context which is hitting BUG ON
> in ARM platforms. Fix this by moving dma_free out of spin
> lock.
>
> kernel BUG at mm/vmalloc.c:1512!
> Internal error: Oops - BUG: 0 [#1] PREEM
On 8 October 2014 11:16, Rajkumar Manoharan wrote:
> The commit "ath10k: workaround fw beaconing bug" is freeing
> DMA-coherent memory in irq context which is hitting BUG ON
> in ARM platforms. Fix this by moving dma_free out of spin
> lock.
I hardly see how moving the freeing outside the spinloc
Hi Johannes,
acpi_device_id driver_data field is defined as a kernel_ulong_t in
mod_devicetable.h.
Regards,
Loic
On 08/10/2014 10:53, Johannes Berg wrote:
On Wed, 2014-10-08 at 10:34 +0200, Loic Poulain wrote:
+ { "BCM2E1A", (kernel_ulong_t)&acpi_default_bluetooth },
Shouldn't that
The commit "ath10k: workaround fw beaconing bug" is freeing
DMA-coherent memory in irq context which is hitting BUG ON
in ARM platforms. Fix this by moving dma_free out of spin
lock.
kernel BUG at mm/vmalloc.c:1512!
Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
CPU: 0 PID: 722 Comm: hostapd N
On Wed, 2014-10-08 at 10:34 +0200, Loic Poulain wrote:
> + { "BCM2E1A", (kernel_ulong_t)&acpi_default_bluetooth },
Shouldn't that be uintptr_t?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More ma
Add BCM47521 (GPS) to the ACPI table.
BCM47521 supports host wake.
HOST <---UART---> CONTROLLER
HOST <-- WAKE CONTROLLER (gpio res 0)
HOST ---ENABLE--> CONTROLLER (gpio res 1)
Signed-off-by: Loic Poulain
---
net/rfkill/rfkill-gpio.c | 9 +
1 file changed, 9 insertions(+)
diff --git
Add OBDA8723 (rtl8723) ACPI id.
rtl8723 bluetooth chip has the following interface:
HOST <---UART---> CONTROLLER
HOST --- WAKE---> CONTROLLER (gpio res 0)
HOST ---ENABLE--> CONTROLLER (gpio res 1)
HOST <---WAKE CONTROLLER (gpio res 2)
Signed-off-by: Loic Poulain
---
net/rfkill/rfkill-gpio.c
Some GPIO based rfkill devices can wake their host up from suspend by
toggling an input (from the host perspective) GPIO.
This patch adds a generic support for that feature by registering a
threaded interrupt routine and thus setting the corresponding GPIO as a
wake up source.
Signed-off-by: Loic
GPIO based rfkill devices should also be put to sleep mode when the
system enters suspend. This patch introduces a wake gpio.
Signed-off-by: Loic Poulain
---
net/rfkill/rfkill-gpio.c | 48
1 file changed, 48 insertions(+)
diff --git a/net/rfkill/
Some devices don't match the current static gpio mapping:
-BCM4752 (GPS) uses gpio res 0 as host wake irq.
-OBDA8723 (Bluetooth) uses gpio res 0 as controller wake gpio
and res 2 as host wake irq.
To allow more flexibility, this patch introduces an index
map description.
By default, legacy config
Mark Asselstine schrieb:
>On Wed, Oct 1, 2014 at 9:42 PM, Mark Asselstine
>wrote:
>>
>> Damn, you are right. I thought I had it licked.
>>
>> Unfortunately with the overloaded variable name it was easy to get
>turned
>> around. The comments in the code didn't prevent me knotting myself up
>>
56 matches
Mail list logo
