Re: [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-13 Thread Marcel Holtmann
Hi Dan, > With the alias cfg80211 module is loaded on systems without the wireless > hardware when user-space use nl80211 to discover if there are wireless > devices, what is considered as resources wastage. On systems with > wireless hardware cfg80211 module will be loaded anyway.

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-13 Thread Marcel Holtmann
Hi Dan, I've updated wireless code on RHEL and get complain that now cfg80211 and rfkill modules are loaded on machines that do not have wireless hardware. Modules are auto-loaded because NetworkManager send nl80211 messages to check if there are wireless devices in the system.

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-13 Thread Marcel Holtmann
Hi Luca, > I've updated wireless code on RHEL and get complain that now > cfg80211 and rfkill modules are loaded on machines that do not have > wireless hardware. Modules are auto-loaded because NetworkManager send > nl80211 messages to check if there are wireless devices in the sy

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-13 Thread Luca Coelho
On Thu, 2014-11-13 at 20:55 -0600, Dan Williams wrote: > On Thu, 2014-11-13 at 22:41 +0900, Marcel Holtmann wrote: > > Hi Johannes, > > > > >> I've updated wireless code on RHEL and get complain that now > > >> cfg80211 and rfkill modules are loaded on machines that do not have > > >> wireless har

Re: [PATCH 1/6] ath9k: disable overriding AR9340 SLP32 registers

2014-11-13 Thread Sujith Manoharan
Sujith Manoharan wrote: > Well, the code is redundant and I don't see the point in > doing the writes when we don't have to ? We could maybe > restructure it a bit... So I managed to track down the reason for this override. This is a specific hack for an Apple product that is based on Wasp in whi

RE: [PATCH] carl9170: Convert byte_rev_table uses to bitrev8

2014-11-13 Thread Wang, Yalin
> From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, November 14, 2014 1:33 PM > To: Wang, Yalin > Cc: 'chunk...@googlemail.com'; 'linvi...@tuxdriver.com'; 'linux- > wirel...@vger.kernel.org'; 'net...@vger.kernel.org'; 'linux- > ker...@vger.kernel.org' > Subject: Re: [PATCH] carl9170: Conv

[PATCH] carl9170: Convert byte_rev_table uses to bitrev8

2014-11-13 Thread Wang, Yalin
Use the inline function instead of directly indexing the array. This allows some architectures with hardware instructions for bit reversals to eliminate the array. Signed-off-by: Joe Perches Signed-off-by: Yalin Wang --- drivers/net/wireless/ath/carl9170/phy.c | 4 ++-- 1 file changed, 2 inser

Re: [PATCH] carl9170: Convert byte_rev_table uses to bitrev8

2014-11-13 Thread Joe Perches
On Fri, 2014-11-14 at 13:16 +0800, Wang, Yalin wrote: > Use the inline function instead of directly indexing the array. > > This allows some architectures with hardware instructions for bit > reversals to eliminate the array. This one is already in -next commit 7a1283d8f5298437a454ec477384dcd9f9

[PATCH] ath9k_htc: turn on software mgmt crypto for secured mesh

2014-11-13 Thread Chun-Yeow Yeoh
Secured mesh encrypts the unicast mgmt frame using the same key that used for encrypting the unicast data frame. The patch "ath9k_htc_firmware: fix the offset of CCMP header for mesh data frame" applied to open-ath9k-htc-firmware allows the ath9k_htc to be loaded without "nohwcrypt=1". Unfortunatel

[PATCH] ath10k: fix mismatched wmi api call

2014-11-13 Thread Peter Oh
Fix to use v10.2 wmi call for firmware v10.2. It turned out that peer association function was using v10.1 wmi call for v10.2 firmware during code review. Signed-off-by: Peter Oh --- drivers/net/wireless/ath/ath10k/wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

Re: [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-13 Thread Dan Williams
On Thu, 2014-11-13 at 22:48 +0900, Marcel Holtmann wrote: > Hi Stanislaw, > > >>> With the alias cfg80211 module is loaded on systems without the wireless > >>> hardware when user-space use nl80211 to discover if there are wireless > >>> devices, what is considered as resources wastage. On systems

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-13 Thread Dan Williams
On Thu, 2014-11-13 at 22:41 +0900, Marcel Holtmann wrote: > Hi Johannes, > > >> I've updated wireless code on RHEL and get complain that now > >> cfg80211 and rfkill modules are loaded on machines that do not have > >> wireless hardware. Modules are auto-loaded because NetworkManager send > >> nl8

Re: [PATCH v4 0/2] ath10k: testmode support

2014-11-13 Thread Pushpal Sidhu
On Thu, Sep 11, 2014 at 1:43 PM, Kalle Valo wrote: > Kalle Valo writes: > >> latest version of my testmode patches. Getting closer, more or less cosmetic >> changes this time :) While looking through this patchset (sorry it took two months), I have to wonder: what's this utf.bin blob? It seems i

linux-next: ath9k: build failure, ath_cmn_process_fft() redefinition

2014-11-13 Thread Jeremiah Mahler
In version 20141113 of the linux-next kernel, if it is compiled with CONFIG_ATH9K_DEBUGFS unset, an error about ath_cmn_process_fft() being redefined will be produced. make ... LD [M] drivers/net/wireless/ath/ath9k/ath9k_hw.o CC [M] drivers/net/wireless/ath/ath9k/common-spectral.o

Re: [PATCH v2 4/4] cfg80211: Allow usermode to query wiphy specific regd info

2014-11-13 Thread Luis R. Rodriguez
On Thu, Nov 13, 2014 at 06:13:39PM +0200, Arik Nemtsov wrote: > From: Jonathan Doron > > Allow usermode to query wiphy-specific regd info, for drivers that use > wiphy-specific regulatory management. > > Use the existing API for sending regdomain info to usermode, but return > the wiphy-specific

Re: [PATCH v2 3/4] cfg80211: allow wiphy specific regdomain management

2014-11-13 Thread Luis R. Rodriguez
On Thu, Nov 13, 2014 at 06:13:38PM +0200, Arik Nemtsov wrote: > From: Jonathan Doron > > Add a new regulatory flag that allows a driver to manage regdomain > changes/updates for its own wiphy. > In this case the regdomain is local to the driver, and it does not use > the shared cfg80211 regdomain

Re: [PATCH v2 2/4] cfg80211: update missing fields in custom regulatory path

2014-11-13 Thread Luis R. Rodriguez
On Thu, Nov 13, 2014 at 06:13:37PM +0200, Arik Nemtsov wrote: > From: Jonathan Doron > > Some channels fields were not being updated in the custom regulatory > path. Update them according to the code in handle_channel(). > > Signed-off-by: Jonathan Doron > Signed-off-by: Arik Nemtsov > --- >

Re: [PATCH v2 1/4] cfg80211: leave invalid channels on regdomain change

2014-11-13 Thread Luis R. Rodriguez
Johannes, Jouni, please review the comment about WLAN_REASON_DEAUTH_LEAVING below. On Thu, Nov 13, 2014 at 06:13:36PM +0200, Arik Nemtsov wrote: > When the regulatory settings change, some channels might become invalid. > Disconnect interfaces acting on these channels, after giving userspace > cod

pull request: wireless 2014-11-13

2014-11-13 Thread John W. Linville
Dave, Please pull this set of a few more wireless fixes intended for the 3.18 stream... For the mac80211 bits, Johannes says: "This has just one fix, for an issue with the CCMP decryption that can cause a kernel crash. I'm not sure it's remotely exploitable, but it's an important fix nonetheless

Qualcomm Atheros AR93xx reset behavior

2014-11-13 Thread Alex Williamson
Hi, This is a question not about the wireless properties of the Atheros AR93xx, but about the PCIe bus reset behavior. We have a user reporting errors with a TP-LINK TL-WDN4800 and I've acquired the same card and have been able to reproduce the error on two systems. The problem is that if we att

Re: [PATCH 5/5] cfg80211: Allow usermode to query wiphy specific regd info

2014-11-13 Thread Luis R. Rodriguez
On Thu, Nov 13, 2014 at 05:55:13PM +0200, Arik Nemtsov wrote: > > > >> 2. And then if userspace sends a wiphy idx to the NL80211_CMD_GET_REG, > >> we'll return wiphy->regd for that case as well? > > > > That's right, for now we'd be able to send the regd when either > > NL80211_ATTR_WIPHY_SELF_MANA

Re: [PATCH] mac80211: Send peering open frame again if beacon from listen state peer is received

2014-11-13 Thread Thomas Pedersen
Hi Kenzoh, Looks like your email is part HTML. Please submit using git-send-email. Your patch looks ok, just a small comment below. On 11/12/2014 08:27 PM, Nishikawa, Kenzoh via Devel wrote: > net/mac80211/mesh_plink.c |6 ++ > 1 file changed, 6 insertions(+) > diff --git a/net/mac80211/m

[PATCH 3.18 3/3] ath9k: do not access hardware on IRQs during reset

2014-11-13 Thread Felix Fietkau
Instead of killing interrupts during reset when the first one happens, kill them before issuing the reset. This fixes an easy to reproduce crash with multiple cards sharing the same IRQ. Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath9k/main.c | 11 +-

[PATCH 3.18 2/3] ath9k: set ATH_OP_INVALID before disabling hardware

2014-11-13 Thread Felix Fietkau
Closes another small IRQ handler race Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath9k/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 644552c..ee67956 100644 --- a/d

[PATCH 3.18 1/3] ath9k: prevent early IRQs from accessing hardware

2014-11-13 Thread Felix Fietkau
IRQs are suppressed if ah == NULL and ATH_OP_INVALID being set in common->op_flags. Close a short time window between those two. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath9k/init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireles

Re: mmotm 2014-11-12-16-34 uploaded (net/wireless/ath9k)

2014-11-13 Thread Randy Dunlap
On 11/12/14 16:36, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2014-11-12-16-34 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > on x86_64: (from linux-next.p

[PATCH v2 3/4] cfg80211: allow wiphy specific regdomain management

2014-11-13 Thread Arik Nemtsov
From: Jonathan Doron Add a new regulatory flag that allows a driver to manage regdomain changes/updates for its own wiphy. In this case the regdomain is local to the driver, and it does not use the shared cfg80211 regdomain. It also implies that the driver does not wish to get regulatory updates

[PATCH v2 4/4] cfg80211: Allow usermode to query wiphy specific regd info

2014-11-13 Thread Arik Nemtsov
From: Jonathan Doron Allow usermode to query wiphy-specific regd info, for drivers that use wiphy-specific regulatory management. Use the existing API for sending regdomain info to usermode, but return the wiphy-specific regd in case wiphy index is provided and the driver employs wiphy-specific

[PATCH v2 1/4] cfg80211: leave invalid channels on regdomain change

2014-11-13 Thread Arik Nemtsov
When the regulatory settings change, some channels might become invalid. Disconnect interfaces acting on these channels, after giving userspace code a grace period to leave them. Signed-off-by: Arik Nemtsov Reviewed-by: Johannes Berg --- include/net/regulatory.h | 6 +++ net/wireless/reg.c

[PATCH v2 2/4] cfg80211: update missing fields in custom regulatory path

2014-11-13 Thread Arik Nemtsov
From: Jonathan Doron Some channels fields were not being updated in the custom regulatory path. Update them according to the code in handle_channel(). Signed-off-by: Jonathan Doron Signed-off-by: Arik Nemtsov --- net/wireless/reg.c | 13 + 1 file changed, 13 insertions(+) diff --

Re: [PATCH 0/5] wiphy-specific regulatory management

2014-11-13 Thread Arik Nemtsov
On Thu, Nov 13, 2014 at 1:07 AM, Luis R. Rodriguez wrote: > On Wed, Nov 5, 2014 at 12:41 AM, Arik Nemtsov wrote: >> On Wed, Nov 5, 2014 at 5:21 AM, Luis R. Rodriguez >> wrote: >>> On Wed, Oct 22, 2014 at 11:37 PM, Arik Nemtsov wrote: cfg80211: allow wiphy specific regdomain management >>

Re: [PATCH 5/5] cfg80211: Allow usermode to query wiphy specific regd info

2014-11-13 Thread Arik Nemtsov
> >> 2. And then if userspace sends a wiphy idx to the NL80211_CMD_GET_REG, >> we'll return wiphy->regd for that case as well? > > That's right, for now we'd be able to send the regd when either > NL80211_ATTR_WIPHY_SELF_MANAGED_REG is set or when > NL80211_ATTR_WIPHY_SELF_MANAGED_REG is not set bu

Re: [PATCH 2/5] cfg80211: leave invalid channels on regdomain change

2014-11-13 Thread Arik Nemtsov
On Thu, Nov 13, 2014 at 12:53 AM, Luis R. Rodriguez wrote: > On Wed, Nov 5, 2014 at 1:18 AM, Arik Nemtsov wrote: >> On Wed, Nov 5, 2014 at 5:16 AM, Luis R. Rodriguez >> wrote: >>> On Wed, Oct 22, 2014 at 11:37 PM, Arik Nemtsov wrote: +static bool reg_wdev_chan_valid(struct wiphy *wiphy, st

[PATCH v5 2/2] nl80211: Stop scheduled scan if netlink client disappears

2014-11-13 Thread Jukka Rissanen
An attribute NL80211_ATTR_SOCKET_OWNER can be set by the scan initiator. If present, the attribute will cause the scan to be stopped if the client dies. Signed-off-by: Jukka Rissanen --- include/net/cfg80211.h | 1 + include/uapi/linux/nl80211.h | 3 +++ net/wireless/core.c | 17

[PATCH v5 1/2] nl80211: Replace interface socket owner attribute with more generic one

2014-11-13 Thread Jukka Rissanen
Replace NL80211_ATTR_IFACE_SOCKET_OWNER attribute with more generic NL80211_ATTR_SOCKET_OWNER that can be used with other commands that interface creation. Signed-off-by: Jukka Rissanen --- include/uapi/linux/nl80211.h | 7 --- net/wireless/nl80211.c | 4 ++-- 2 files changed, 6 insert

[PATCH v5 0/2] Stop scheduled scan if netlink client disappears

2014-11-13 Thread Jukka Rissanen
Hi, v5: - discarded the locking changes in v4 - instead of trying to schedule sched_scan_stop worker from struct cfg80211_sched_scan_request, move the worker to wiphy as that makes it easier to manage the sched_scan_stop worker. There are also one scheduled scan / wiphy so it is also logical

Re: [PATCH v4 2/2] nl80211: Stop scheduled scan if netlink client disappears

2014-11-13 Thread Johannes Berg
On Thu, 2014-11-13 at 15:49 +0200, Jukka Rissanen wrote: > An attribute NL80211_ATTR_SOCKET_OWNER can be set by the scan initiator. > If present, the attribute will cause the scan to be stopped if the client > dies. > + if (rtnl_trylock()) { > + __cfg80211_stop_sched_scan(rdev, fal

[PATCH v4 0/2] Stop scheduled scan if netlink client disappears

2014-11-13 Thread Jukka Rissanen
Hi, v4: - rtnl locking issues fixed in patch 2 v3: - backward compatibility define tweaked in patch 1 - added missing signed-off-by: v2: - split the patch - In patch 1, use a generic NL80211_ATTR_SOCKET_OWNER attribute and convert the old code that uses NL80211_ATTR_IFACE_SOCKET_OWNER to use

[PATCH v4 2/2] nl80211: Stop scheduled scan if netlink client disappears

2014-11-13 Thread Jukka Rissanen
An attribute NL80211_ATTR_SOCKET_OWNER can be set by the scan initiator. If present, the attribute will cause the scan to be stopped if the client dies. Signed-off-by: Jukka Rissanen --- include/net/cfg80211.h | 2 ++ include/uapi/linux/nl80211.h | 3 +++ net/wireless/core.c |

[PATCH v4 1/2] nl80211: Replace interface socket owner attribute with more generic one

2014-11-13 Thread Jukka Rissanen
Replace NL80211_ATTR_IFACE_SOCKET_OWNER attribute with more generic NL80211_ATTR_SOCKET_OWNER that can be used with other commands that interface creation. Signed-off-by: Jukka Rissanen --- include/uapi/linux/nl80211.h | 7 --- net/wireless/nl80211.c | 4 ++-- 2 files changed, 6 insert

Re: [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-13 Thread Marcel Holtmann
Hi Stanislaw, >>> With the alias cfg80211 module is loaded on systems without the wireless >>> hardware when user-space use nl80211 to discover if there are wireless >>> devices, what is considered as resources wastage. On systems with >>> wireless hardware cfg80211 module will be loaded anyway. >

Re: [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-13 Thread Stanislaw Gruszka
Hi On Thu, Nov 13, 2014 at 10:36:17PM +0900, Marcel Holtmann wrote: > > With the alias cfg80211 module is loaded on systems without the wireless > > hardware when user-space use nl80211 to discover if there are wireless > > devices, what is considered as resources wastage. On systems with > > wire

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-13 Thread Marcel Holtmann
Hi Johannes, >> I've updated wireless code on RHEL and get complain that now >> cfg80211 and rfkill modules are loaded on machines that do not have >> wireless hardware. Modules are auto-loaded because NetworkManager send >> nl80211 messages to check if there are wireless devices in the system. >>

Re: [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-13 Thread Marcel Holtmann
Hi Stanislaw, > With the alias cfg80211 module is loaded on systems without the wireless > hardware when user-space use nl80211 to discover if there are wireless > devices, what is considered as resources wastage. On systems with > wireless hardware cfg80211 module will be loaded anyway. > > Cc:

[PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-13 Thread Stanislaw Gruszka
With the alias cfg80211 module is loaded on systems without the wireless hardware when user-space use nl80211 to discover if there are wireless devices, what is considered as resources wastage. On systems with wireless hardware cfg80211 module will be loaded anyway. Cc: Marcel Holtmann Signed-off

Re: [PATCH v2 06/10] ath10k: use configured nss instead of max nss.

2014-11-13 Thread Kalle Valo
Ben Greear writes: > On 09/23/2014 02:17 PM, gree...@candelatech.com wrote: >> From: Ben Greear >> >> When re-associating a station, the nss was set back to >> maximum value even if user had configured small number >> of tx chains. So, pay attention to user's config in >> this case as well. >

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-13 Thread Johannes Berg
On Thu, 2014-11-13 at 13:33 +0100, Stanislaw Gruszka wrote: > I've updated wireless code on RHEL and get complain that now > cfg80211 and rfkill modules are loaded on machines that do not have > wireless hardware. Modules are auto-loaded because NetworkManager send > nl80211 messages to check if th

Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-13 Thread Stanislaw Gruszka
I've updated wireless code on RHEL and get complain that now cfg80211 and rfkill modules are loaded on machines that do not have wireless hardware. Modules are auto-loaded because NetworkManager send nl80211 messages to check if there are wireless devices in the system. Hence my question, can we r

[PATCH 5/6] mwifiex: support for parsing TDLS discovery frames

2014-11-13 Thread Avinash Patil
This patch adds support for parsing TDLS discovery frames. After parsing, we update peer RSSI information. Signed-off-by: Avinash Patil Signed-off-by: Cathy Luo --- drivers/net/wireless/mwifiex/util.c | 38 + 1 file changed, 38 insertions(+) diff --git a/dri

[PATCH 6/6] mwifiex: enable auto TDLS support for SD8887

2014-11-13 Thread Avinash Patil
Auto TDLS support is enabled per device. As of now add this feature only for SD8887. Signed-off-by: Avinash Patil Signed-off-by: Cathy Luo --- drivers/net/wireless/mwifiex/init.c | 1 - drivers/net/wireless/mwifiex/sdio.c | 2 ++ drivers/net/wireless/mwifiex/sdio.h | 7 +++ 3 files changed,

[PATCH 2/6] mwifiex: do not explicitly disable TDLS link during teardown

2014-11-13 Thread Avinash Patil
When Teardown event from FW is indicated to userspace, userspace would trigger tdls_oper handler to disable TDLS link. We need not do this explicitly here. Signed-off-by: Avinash Patil Signed-off-by: Cathy Luo --- drivers/net/wireless/mwifiex/sta_event.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH 4/6] mwifiex: add auto TDLS support

2014-11-13 Thread Avinash Patil
This patch adds auto TDLS support to mwifiex. Auto TDLS functionality works as follows: 1. Whenever userspace application has triggered TDLS connection with any peer, driver would store this peer mac address details in its database. 2. After this driver whenever driver receives packet on direct li

[PATCH 1/6] mwifiex: update rx packet descriptor structure to match FW

2014-11-13 Thread Avinash Patil
RX packet descriptor structure has recently changed in FW. This patch updates rxpd accordingly. Signed-off-by: Avinash Patil Signed-off-by: Cathy Luo --- drivers/net/wireless/mwifiex/fw.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mwifiex/fw.h b/drivers/net/wirele

[PATCH 0/6] mwifiex: auto TDLS support for mwifiex

2014-11-13 Thread Avinash Patil
This patch series adds auto TDLS support for mwifiex. Avinash Patil (6): mwifiex: update rx packet descriptor structure to match FW mwifiex: do not explicitly disable TDLS link during teardown mwifiex: wmm support for TDLS link mwifiex: add auto TDLS support mwifiex: support for parsing

[PATCH 3/6] mwifiex: wmm support for TDLS link

2014-11-13 Thread Avinash Patil
This patch adds WMM support for TDLS link. Patch add WMM info IE for TDLS setup request/response frames while WMM parameter for TDLS confirm frame. Signed-off-by: Avinash Patil Signed-off-by: Cathy Luo --- drivers/net/wireless/mwifiex/tdls.c | 55 + 1 file ch

Re: brcmfmac not working on ECS LIVA

2014-11-13 Thread Arend van Spriel
On 12-11-14 16:23, Felipe Contreras wrote: > On Wed, Nov 12, 2014 at 4:40 AM, Arend van Spriel wrote: >> On 11-11-14 23:32, Felipe Contreras wrote: >>> On Sun, Nov 9, 2014 at 4:46 AM, Arend van Spriel wrote: >>> Could you share the nvram obtained from EFI? Also please create a kernel l

[PATCH] wireless-regdb: Reorder country codes to be in alphabetical order

2014-11-13 Thread Jouni Malinen
This makes it easier to write (semi-)automated synchronization and validation scripts against external databases. I'd assume this order was already supposed to be used, but couple of the countries have been placed in incorrect locations in the file over the years. Signed-off-by: Jouni Malinen ---