Re: [PATCH v2] mac80211: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-07 Thread Johannes Berg
On Sun, 2014-12-07 at 12:20 +0200, Vadim Kochan wrote: > +++ b/net/mac80211/iface.c > @@ -1624,6 +1625,10 @@ static void ieee80211_assign_perm_addr(struct > ieee80211_local *local, > mutex_unlock(&local->iflist_mtx); > } > > +static struct rtnl_link_ops wireless_link_ops __read_mostly =

Re: [PATCH v4 6/8] ath10k: introduce wmi ops

2014-12-07 Thread Kalle Valo
Michal Kazior writes: > On 3 December 2014 at 09:10, Kalle Valo wrote: > [...] >> int ath10k_wmi_attach(struct ath10k *ar) >> { >> - if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) { >> - if (test_bit(ATH10K_FW_FEATURE_WMI_10_2, ar->fw_features)) >> -

Re: [PATCH v4 6/8] ath10k: introduce wmi ops

2014-12-07 Thread Kalle Valo
Michal Kazior writes: > On 3 December 2014 at 09:10, Kalle Valo wrote: > >> --- a/drivers/net/wireless/ath/ath10k/testmode.c >> +++ b/drivers/net/wireless/ath/ath10k/testmode.c >> @@ -187,13 +187,14 @@ static int ath10k_tm_cmd_utf_start(struct ath10k *ar, >> struct nlattr *tb[]) >> >> m

Re: [PATCH v4 8/8] ath10k: implement wmi-tlv backend

2014-12-07 Thread Kalle Valo
Michal Kazior writes: > On 3 December 2014 at 09:11, Kalle Valo wrote: > [...] >> diff --git a/drivers/net/wireless/ath/ath10k/core.c >> b/drivers/net/wireless/ath/ath10k/core.c >> index 0f4369e4f358..815d6e27aa53 100644 >> --- a/drivers/net/wireless/ath/ath10k/core.c >> +++ b/drivers/net/wirel

Re: [PATCH v4 6/8] ath10k: introduce wmi ops

2014-12-07 Thread Michal Kazior
On 3 December 2014 at 09:10, Kalle Valo wrote: [...] > int ath10k_wmi_attach(struct ath10k *ar) > { > - if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) { > - if (test_bit(ATH10K_FW_FEATURE_WMI_10_2, ar->fw_features)) > - ar->wmi.cmd = &wmi_10_2

Re: [PATCH 0/20] fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
On Mon, 8 Dec 2014, Julian Calaby wrote: > Hi Julia, > > On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote: > > These patches replace what appears to be a reference to the name of the > > current function but is misspelled in some way by either the name of the > > function itself, or by %s and

Re: [PATCH 0/20] fix misspelling of current function in string

2014-12-07 Thread Joe Perches
On Sun, 2014-12-07 at 20:20 +0100, Julia Lawall wrote: > These patches replace what appears to be a reference to the name of the > current function but is misspelled in some way by either the name of the > function itself, or by %s and then __func__ in an argument list. At least a few of these see

Re: [PATCH 0/20] fix misspelling of current function in string

2014-12-07 Thread Julian Calaby
Hi Julia, On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote: > These patches replace what appears to be a reference to the name of the > current function but is misspelled in some way by either the name of the > function itself, or by %s and then __func__ in an argument list. Would there be any

[PATCH] net: wireless: rtlwifi: rtl8192de: fw.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function rtl92d_set_fw_pwrmode_cmd() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/rtlwifi/rtl8192de/fw.c | 17 - drivers/net/wireless/rtlwifi

[PATCH 0/20] fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
These patches replace what appears to be a reference to the name of the current function but is misspelled in some way by either the name of the function itself, or by %s and then __func__ in an argument list. // // sudo apt-get install python-pip // sudo pip install python-Levenshtein // spatch

[PATCH 13/20] zd1211rw: fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
Replace a misspelled function name by %s and then __func__. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall --- The semantic patch is difficult to summarize, but is available in the cover letter of this patc

[PATCH 15/20] hostap_cs: fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
Replace a misspelled function name by %s and then __func__. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall --- The semantic patch is difficult to summarize, but is available in the cover letter of this patc

[PATCH 16/20] rtlwifi: rtl8821ae: fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
Replace a misspelled function name by %s and then __func__. 8821 was written as 8812. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall --- The semantic patch is difficult to summarize, but is available in th

[PATCH] cfg80211: avoid intersection when applying custom reg

2014-12-07 Thread Arik Nemtsov
The custom-reg handling function can currently only add flags to a given channel. This results in stale flags being left applied. In some cases a channel was disabled and even the orig_flags were changed to reflect this. Previously the API was designed for a single invocation before wiphy registra

[PATCH] drivers: staging: rtl8723au: get rid of unneeded memset/memcpy

2014-12-07 Thread Emil Renner Berthing
This also fixes a sparse warning. Signed-off-by: Emil Renner Berthing --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c in

[PATCH v2] mac80211: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-07 Thread Vadim Kochan
It allows to identify the wlan kind of device for the user application, e.g.: # ip -d link 1: lo: mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 promiscuity 0 2: enp0s25: mtu 1500 qdisc pfifo_fast stat

Re: [PATCH] mac80211: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-07 Thread vadim4j
On Sun, Dec 07, 2014 at 10:06:52AM +0100, Marcel Holtmann wrote: > Hi Vadim, > > > It allows to identify the wireless kind of device for > > the user application, e.g.: > > > ># ip -d link > > > >1: lo: mtu 65536 qdisc noqueue state UNKNOWN mode > > DEFAULT group default > >lin

Re: [PATCH] mac80211: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-07 Thread Marcel Holtmann
Hi Vadim, > It allows to identify the wireless kind of device for > the user application, e.g.: > ># ip -d link > >1: lo: mtu 65536 qdisc noqueue state UNKNOWN mode > DEFAULT group default >link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 promiscuity 0 >2: enp0s25: mt