Re: [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK

2015-01-12 Thread Vadim Kochan
On Mon, Jan 5, 2015 at 11:22 AM, Johannes Berg wrote: > On Wed, 2014-12-24 at 11:48 +0200, Vadim Kochan wrote: > >> 1) Set NETIF_F_NETNS_LOCAL for phy wireless device only if there >> is at least one virtual interface which was created on it > > You mean at least two? I'd think the behaviour b

Re: [PATCH 0/8] wcn36xx locking and a-mpdu fixes

2015-01-12 Thread Eugene Krasnikov
Looks good to me! 2015-01-09 19:15 GMT+00:00 Bob Copeland : > Hello, > > These patches have been merged into the wcn36xx github tree but have > been collecting dust for some time. I pinged Eugene (CCed) who said I > could just go ahead and send them upstream. Rebased and re-tested on > an Androi

Re: [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK

2015-01-12 Thread Johannes Berg
On Mon, 2015-01-12 at 11:07 +0200, Vadim Kochan wrote: > Would you please explain why wireless devs related to the same phy > can't live in separated network namespaces ? Well, they interact very deeply, for example the # of virtual interfaces is often severely limited, and they often have to be

Re: [PATCH v2] ath9k_htc: Add a module parameter to disable blink

2015-01-12 Thread Arend van Spriel
On 01/11/15 20:45, Hong Xu wrote: Add an option "blink" to enable or disable the LED blink. The default value is set to 1 so that existing users would not experience any unexpected changes. Signed-off-by: Hong Xu --- drivers/net/wireless/ath/ath9k/htc.h | 3 +++ drivers/net/wireless/

Re: [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK

2015-01-12 Thread Vadim Kochan
Thank you! Seems reasonably for me. The question is not related to the thread: May be this is not very good idea to copy behavior from other tools but what do you think about add the same ability to use named network namespaces as it is done in iproute2 - from /var/run/netns ? Thanks,

Re: [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK

2015-01-12 Thread Johannes Berg
On Mon, 2015-01-12 at 11:57 +0200, Vadim Kochan wrote: > Thank you! Seems reasonably for me. > > The question is not related to the thread: > May be this is not very good idea to copy behavior from other > tools but what do you think about > add the same ability to use named network name

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-12 Thread Arend van Spriel
On 01/12/15 07:41, Fu, Zhonghui wrote: From 8685c3c2746b4275fc808d9db23c364b2f54b52a Mon Sep 17 00:00:00 2001 From: Zhonghui Fu Date: Mon, 12 Jan 2015 14:25:46 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation WiFi chip has 2 SDIO functions, and PM core will trigger twi

Re: [PATCH v2] ath9k_htc: Add a module parameter to disable blink

2015-01-12 Thread Oleksij Rempel
Am 12.01.2015 um 10:48 schrieb Arend van Spriel: > On 01/11/15 20:45, Hong Xu wrote: >> Add an option "blink" to enable or disable the LED blink. The default >> value is set to 1 so that existing users would not experience any >> unexpected changes. >> >> Signed-off-by: Hong Xu >> --- >> drivers/

(re)licensing the wireless wiki

2015-01-12 Thread Johannes Berg
Hi, I've been working on moving the wireless wiki over to kernel.org infrastructure (https://wireless.wiki.kernel.org/), and we're going to need to tag the content with an explicit license there. As the previous wiki didn't have an explicit license, we can't do so easily. For the new license we'v

Re: [PATCH v2 5/8] ath10k: Implement sta_add_debugfs

2015-01-12 Thread Kalle Valo
Rajkumar Manoharan writes: > Add per station debugfs files when a station is added to mac80211's > station list. This helps to group peer specific debugfs entries > altogether. Right now this callback adds support to test aggregation > procedures (addba/addba_resp/delba) manually. > > To enable a

Re: [PATCH v2 6/8] ath10k: add support to send addba request

2015-01-12 Thread Kalle Valo
Rajkumar Manoharan writes: > This per-station debugfs entry helps to send addba request in manual > mode. Need to pass two configuration parameters (tid, buffer size) > as input. > > To send addba, > > echo 1 32 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ > stations/XX:XX:XX:XX:XX:XX

Re: [PATCH v2 7/8] ath10k: add support to send addba response

2015-01-12 Thread Kalle Valo
Rajkumar Manoharan writes: > This per-station debugfs entry helps to send addba response in > manual mode for debugging purpose. It accepts tid and status code > as input arguments. > > To send addba response, > > echo 0 25 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ > stations/XX:XX

Re: [PATCH v2 8/8] ath10k: add support to send delba

2015-01-12 Thread Kalle Valo
Rajkumar Manoharan writes: > This per-station debugfs entry helps to send delba in manual mode > for debugging purpose. It accepts tid, initiator and reason code > as inputs. > > To send delba, > > echo 0 1 37 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ >stations/XX:XX:XX:XX:XX:XX

Re: IWLWIFI - 3.18-stable

2015-01-12 Thread Chris Clayton
Thanks Emmanuel. On 01/12/15 06:03, Emmanuel Grumbach wrote: > On Sun, Jan 11, 2015 at 10:23 PM, Chris Clayton > wrote: [snip] >>> >>> The first one (c93edc639392df733c7d72db4376a9add775d18a) is tagged for >>> stable. >> >> Ah, sorry I missed that. >> >>> Are you using bluetooth? >> >> Yes, I

Re: [PATCH] ath10k: Fix DMA burst size

2015-01-12 Thread Kalle Valo
Sujith Manoharan writes: > Michal Kazior wrote: >> Since it's for cards/chips why do you enable it for 10.2 only? There's >> 10.1, main and tlv as well which could possibly benefit from this. > > I've not tested it with any of the FW versions other than 10.2 and > am not sure if older FW support

Re: [PATCH] ath10k: Fix DMA burst size

2015-01-12 Thread Kalle Valo
Sujith Manoharan writes: > From: Sujith Manoharan > > A value of zero indicates that 128B is the maximum > DMA request size for read/writes. But PCI cards based > on AR9880 can support 256B, so enable this for > the 10.2 firmware. > > Signed-off-by: Sujith Manoharan Thanks, applied. -- Kalle

Re: [PATCH] ath10k: Enable RX batching

2015-01-12 Thread Kalle Valo
Sujith Manoharan writes: > From: Sujith Manoharan > > This feature allows the FW to batch RX indications, > reducing the rate of host interrupt generation, which > in turn reduces CPU load. Currently, this is enabled > only for the 10.2 firmware. > > Signed-off-by: Sujith Manoharan Thanks, app

Re: ath10k: fw_stats not reporting peer_stats with 10.2

2015-01-12 Thread Michal Kazior
On 18 December 2014 at 14:00, Antonio Quartulli wrote: > Hello, Hi, Sorry for the late reply. > (line grabbed from dmesg at boot time) > > On my device I have configured 2 AP vifs and for each of them I would > like to read the last TX rate of the associated stations. > > As I've read on wirel

Re: IWLWIFI - 3.18-stable

2015-01-12 Thread Emmanuel Grumbach
> [snip] > The first one (c93edc639392df733c7d72db4376a9add775d18a) is tagged for stable. >>> >>> Ah, sorry I missed that. >>> Are you using bluetooth? >>> >>> Yes, I have a bluetooth mouse and use bluetooth for audio from time to time. >>> Are you able to tell me which of

Re: [PATCH v2 0/5] ath10k: implement beacon offload

2015-01-12 Thread Kalle Valo
Michal Kazior writes: > Hi, > > New wmi-tlv firmware will support beacon/presp > offloading. This patchset adds appropriate > support. > > These patches of mine were originally posted by > Bartosz before christmas after I went on my > holidays. > > v2: > * add a comment in patch 5 > > > Michal K

Re: [PATCH v3] ath10k: fixup wait_for_completion_timeout return handling

2015-01-12 Thread Kalle Valo
Nicholas Mc Guire writes: > wait_for_completion_timeout does not return negative values so the tests > for <= 0 are not needed and the case differentiation in the error handling > path unnecessary. > > v2: all wait_for_completion_timeout changes in a single patch > v3: patch formatting cleanups -

[PATCH] iw: Add OCB mode handling

2015-01-12 Thread Rostislav Lisovy
Since the commit 6e0bd6c35b021dc73a81ebd1ef79761233c48b50 ("cfg80211: 802.11p OCB mode handling") and 239281f803e2efdb77d906ef296086b6917e5d71 ("mac80211: 802.11p OCB mode support") does the Linux kernel support OCB mode. This commit adds proper OCB mode handling. Modify the command for device typ

Re: [PATCH] ath10k: add additional fw build version to info print

2015-01-12 Thread Kalle Valo
Michal Kazior writes: > The wmi-tlv firmware contains additional > versioning info. It may help reporting/debugging. > > Signed-off-by: Michal Kazior [...] > void ath10k_print_driver_info(struct ath10k *ar) > { > - ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d cal >

Re: [PATCH] ath10k: add additional fw build version to info print

2015-01-12 Thread Michal Kazior
On 12 January 2015 at 13:56, Kalle Valo wrote: >> Signed-off-by: Michal Kazior [...] >> void ath10k_print_driver_info(struct ath10k *ar) >> { >> - ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d cal >> %s max_sta %d\n", >> + ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s

Re: [PATCH] ath10k: add additional fw build version to info print

2015-01-12 Thread Kalle Valo
Michal Kazior writes: > On 12 January 2015 at 13:56, Kalle Valo wrote: >>> Signed-off-by: Michal Kazior > [...] >>> void ath10k_print_driver_info(struct ath10k *ar) >>> { >>> - ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d >>> cal %s max_sta %d\n", >>> + ath10k_i

Re: [PATCH v2 0/5] ath10k: implement beacon offload

2015-01-12 Thread Michal Kazior
On 12 January 2015 at 13:31, Kalle Valo wrote: > Michal Kazior writes: [...] >> Michal Kazior (5): >> ath10k: implement new beacon tx status event >> ath10k: implement beacon template command >> ath10k: implement prb tmpl wmi command >> ath10k: implement p2p bcn ie command >> ath10k: im

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-12 Thread Sergei Shtylyov
Hello. On 1/12/2015 9:41 AM, Fu, Zhonghui wrote: From 8685c3c2746b4275fc808d9db23c364b2f54b52a Mon Sep 17 00:00:00 2001 From: Zhonghui Fu Date: Mon, 12 Jan 2015 14:25:46 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation The lines above are not needed. WiFi chip

[PATCH] ath10k: prevent fw reg dump spam

2015-01-12 Thread Michal Kazior
Originally the explicit fw register dump was added to wait_for_target_init because interrupts are masked early during power_up. Due to some changes in power_up/reset sequences sometimes when fw crashed ath10k would print the dump more than once via hif_stop -> warm_reset -> wait_for_target_init, p

[PATCH mac80211-next] nl80211: Allow set network namespace by fd

2015-01-12 Thread Vadim Kochan
From: Vadim Kochan Added new NL80211_ATTR_NETNS_FD which allows to set namespace via nl80211 by fd. Signed-off-by: Vadim Kochan --- include/uapi/linux/nl80211.h | 2 ++ net/core/net_namespace.c | 1 + net/wireless/nl80211.c | 16 +++- 3 files changed, 14 insertions(+),

Re: (re)licensing the wireless wiki

2015-01-12 Thread Johannes Berg
On Mon, 2015-01-12 at 12:16 +0100, Johannes Berg wrote: > I've emailed every contributor who I could find an email address for, > but some (~40) don't have an email address and I already have a bunch of > bounces (~50). Additionally, gmail has apparently decided that I was spamming -- so you may

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-12 Thread Arend van Spriel
On 01/12/15 15:06, Sergei Shtylyov wrote: Hello. On 1/12/2015 9:41 AM, Fu, Zhonghui wrote: From 8685c3c2746b4275fc808d9db23c364b2f54b52a Mon Sep 17 00:00:00 2001 From: Zhonghui Fu Date: Mon, 12 Jan 2015 14:25:46 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation The

Re: (re)licensing the wireless wiki

2015-01-12 Thread Pat Erley
On 01/12/2015 09:26 AM, Johannes Berg wrote: On Mon, 2015-01-12 at 12:16 +0100, Johannes Berg wrote: I've emailed every contributor who I could find an email address for, but some (~40) don't have an email address and I already have a bunch of bounces (~50). Additionally, gmail has apparently

[PATCH 1/8] ath10k: scan should handle scan-start-failed event properly.

2015-01-12 Thread greearb
From: Ben Greear In case firmware fails to start the scan, then complete the start condition and clean up so that driver does not block on timeout. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 11 +++ drivers/net/wireless/ath/ath10k/wmi.c | 20 +

[PATCH 6/8] ath10k: fix spelling in htt code comment.

2015-01-12 Thread greearb
From: Ben Greear Fix spelling error. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index fdd665c..a3ca25c 100644 ---

[RFC 5/8] ath10k: add firmware wmi keep-alive message.

2015-01-12 Thread greearb
From: Ben Greear Only useful for CT firmware. This sends a wmi message to the firmware every 2 seconds or so. Once CT firmware receives one of these messages, it will assert if it does not receive more within a 10 second window. This helps debug and work-around wmi transport hangs. Signed-off-

[PATCH 8/8] ath10k: fix CE_DESC_FLAGS_META_DATA_LSB definition.

2015-01-12 Thread greearb
From: Ben Greear The value was off by one. The error probably has no negative affect on any upstream firmware, but should be fixed anyway in case it comes into use in the future. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/ce.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 3/8] ath10k: fix spelling mistakes and add details to mac logging.

2015-01-12 Thread greearb
From: Ben Greear A bit of general cleanup to make debug messages more useful. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath

[PATCH 2/8] ath10k: add wmi-id to htc credits debugging.

2015-01-12 Thread greearb
From: Ben Greear This helps when trying to figure out exactly which commands are consuming credits when trying to debug wmi credit hangs. --- drivers/net/wireless/ath/ath10k/htc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k

[PATCH 4/8] ath10k: make dbglog debug messages be 'warn' level.

2015-01-12 Thread greearb
From: Ben Greear This only happens on firmware crash, and it appears this logic is not always perfect, so make sure the information is printed to logs at higher level. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/pci.c | 14 ++ 1 file changed, 6 insertions(+), 8 de

[PATCH 7/8] ath10k: start using htt/pci/ce transfer_id properly.

2015-01-12 Thread greearb
From: Ben Greear Upstream firmware may ingore, but someone hacking on firmware can use this (and similar instrumentation on the firmware side) to help determine what is happening when there are communication issues between firmware and host. Signed-off-by: Ben Greear --- drivers/net/wireless/a

mwl8k txpower help? NEWBIE

2015-01-12 Thread Larry Harmon
This is my first post, so be gentle... I am trying to learn how to control the tx power of my access point. After my system is up and running I attempt to lower the txpower using "iwconfig wlp1s0 txpower 15" The system accepts the command without complaint and a subsequent iwconfig wlp1s0 comm

[PATCH 7/8] ath10k: start using htt/pci/ce transfer_id properly.

2015-01-12 Thread greearb
From: Ben Greear Upstream firmware may ingore, but someone hacking on firmware can use this (and similar instrumentation on the firmware side) to help determine what is happening when there are communication issues between firmware and host. Signed-off-by: Ben Greear --- drivers/net/wireless/a

[PATCH 8/8] ath10k: fix CE_DESC_FLAGS_META_DATA_LSB definition.

2015-01-12 Thread greearb
From: Ben Greear The value was off by one. The error probably has no negative affect on any upstream firmware, but should be fixed anyway in case it comes into use in the future. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/ce.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 1/8] ath10k: scan should handle scan-start-failed event properly.

2015-01-12 Thread greearb
From: Ben Greear In case firmware fails to start the scan, then complete the start condition and clean up so that driver does not block on timeout. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 11 +++ drivers/net/wireless/ath/ath10k/wmi.c | 20 +

[PATCH 2/8] ath10k: add wmi-id to htc credits debugging.

2015-01-12 Thread greearb
From: Ben Greear This helps when trying to figure out exactly which commands are consuming credits when trying to debug wmi credit hangs. --- drivers/net/wireless/ath/ath10k/htc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k

[PATCH 3/8] ath10k: fix spelling mistakes and add details to mac logging.

2015-01-12 Thread greearb
From: Ben Greear A bit of general cleanup to make debug messages more useful. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath

[PATCH 6/8] ath10k: fix spelling in htt code comment.

2015-01-12 Thread greearb
From: Ben Greear Fix spelling error. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index fdd665c..a3ca25c 100644 ---

[RFC 5/8] ath10k: add firmware wmi keep-alive message.

2015-01-12 Thread greearb
From: Ben Greear Only useful for CT firmware. This sends a wmi message to the firmware every 2 seconds or so. Once CT firmware receives one of these messages, it will assert if it does not receive more within a 10 second window. This helps debug and work-around wmi transport hangs. Signed-off-

[PATCH 1/8] ath10k: scan should handle scan-start-failed event properly.

2015-01-12 Thread greearb
From: Ben Greear In case firmware fails to start the scan, then complete the start condition and clean up so that driver does not block on timeout. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 11 +++ drivers/net/wireless/ath/ath10k/wmi.c | 20 +

[PATCH 4/8] ath10k: make dbglog debug messages be 'warn' level.

2015-01-12 Thread greearb
From: Ben Greear This only happens on firmware crash, and it appears this logic is not always perfect, so make sure the information is printed to logs at higher level. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/pci.c | 14 ++ 1 file changed, 6 insertions(+), 8 de

Re: [PATCH 1/8] ath10k: scan should handle scan-start-failed event properly.

2015-01-12 Thread Ben Greear
Sorry about the resends...had mail-server issue, should be resolved now. Thanks, Ben On 01/12/2015 11:29 AM, gree...@candelatech.com wrote: > From: Ben Greear > > In case firmware fails to start the scan, then complete > the start condition and clean up so that driver does not > block on timeou

[PATCH] ath10k: document switch case fall-through in __ath10k_scan_finish

2015-01-12 Thread John W. Linville
Add a comment for indicating that the ATH10K_SCAN_RUNNING case falls through to the ATH10K_SCAN_ABORTING case in __ath10k_scan_finish. This will document that the lack of a break is intentional. Coverity: CID 1260017 Signed-off-by: John W. Linville --- drivers/net/wireless/ath/ath10k/mac.c | 1

[PATCH] iwlwifi: document switch case fall-through in iwl_mvm_send_sta_key

2015-01-12 Thread John W. Linville
Add a comment indicating that the WLAN_CIPHER_SUITE_WEP104 case falls through to the WLAN_CIPHER_SUITE_WEP40 case in iwl_mvm_send_sta_key. This will document that the lack of a break is intentional. Coverity: CID 1260023 Signed-off-by: John W. Linville --- This seems to work, so I'm guessing tha

Re: [PATCH] iwlwifi: document switch case fall-through in iwl_mvm_send_sta_key

2015-01-12 Thread Johannes Berg
On Mon, 2015-01-12 at 16:18 -0500, John W. Linville wrote: > Add a comment indicating that the WLAN_CIPHER_SUITE_WEP104 case falls > through to the WLAN_CIPHER_SUITE_WEP40 case in iwl_mvm_send_sta_key. > This will document that the lack of a break is intentional. > > Coverity: CID 1260023 > > Sig

NetDev 0.1 new proposals accepted update

2015-01-12 Thread Richard Guy Briggs
Fellow netheads: Here is an update on new proposals accepted this past week for NetDev 0.1 that you may have missed if you aren't following the RSS feed or twitter: Accepted talks: (All listed: https://www.netdev01.org/sessions ) === Offloading to yet another software switch Michio H

Re: [PATCH] ath9k_htc: Add a module parameter to disable blink

2015-01-12 Thread Julian Calaby
Hi Hong, On Mon, Jan 12, 2015 at 6:09 PM, Hong Xu wrote: > > Bob Copeland writes: > >> On Sun, Jan 11, 2015 at 01:20:29AM -0800, Hong Xu wrote: >>> Add an option "blink" to enable or disable the LED blink. The default >>> value is set to 1 so that existing users would not experience any >>> unex

Re: [PATCH v2 2/2] cfg80211: avoid reg-hints in self-managed only systems

2015-01-12 Thread Julian Calaby
Hi Arik, On Thu, Jan 8, 2015 at 1:47 AM, Arik Nemtsov wrote: > When a system contains only self-managed regulatory devices all hints > from the regulatory core are ignored. Stop hint processing early in this > case. These systems usually don't have CRDA deployed, which results in > endless (irrel

[PATCH] ath10k: fix hwmon temperature input units

2015-01-12 Thread Rajkumar Manoharan
To be compliant with the hwmon interface the unit needs to be millidegree Celsius. Fix that. Reported-by: Matthias Kaehlcke Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/thermal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/

Re: [PATCH 1/6] staging: vt6655: set_channel replace parameter with ieee80211_channel

2015-01-12 Thread Greg KH
On Wed, Dec 17, 2014 at 11:16:44PM +, Malcolm Priestley wrote: > > > On 04/12/14 22:12, Malcolm Priestley wrote: > >replacing uConnectionChannel for hw_value as set in vnt_init_bands. > > > >This allows other signaling of ieee80211_channel to move deeper into > >driver. > > > >Signed-off-by:

Re: [PATCH] iwlwifi: document switch case fall-through in iwl_mvm_send_sta_key

2015-01-12 Thread Grumbach, Emmanuel
On Mon, 2015-01-12 at 16:18 -0500, John W. Linville wrote: > Add a comment indicating that the WLAN_CIPHER_SUITE_WEP104 case falls > through to the WLAN_CIPHER_SUITE_WEP40 case in iwl_mvm_send_sta_key. > This will document that the lack of a break is intentional. > > Coverity: CID 1260023 > > Sig

Re: [PATCH] ath9k_htc: Add a module parameter to disable blink

2015-01-12 Thread Hong Xu
Julian Calaby writes: > Hi Hong, > > On Mon, Jan 12, 2015 at 6:09 PM, Hong Xu wrote: >> >> Bob Copeland writes: >> >>> On Sun, Jan 11, 2015 at 01:20:29AM -0800, Hong Xu wrote: Add an option "blink" to enable or disable the LED blink. The default value is set to 1 so that existing use

[PATCH 0/8] mwifiex change virtual interface enhancements

2015-01-12 Thread Avinash Patil
This patch series is enhancement for change virtual interface handling in mwifiex. With this series in, now we remove coupling between netdev and FW supported interface combination. Now conversion from any type of supported interface types to any other type is possible. Avinash Patil (8): mwifie

[PATCH 6/8] mwifiex: manage virtual interface limits efficiently

2015-01-12 Thread Avinash Patil
Currently interface limits are checked by seeing if bss_mode for particular priv is set. If bss_mode is not set, interface creation is allowed. This patch adds framework to initializes maximum virtual interfaces supported during load time and check current number of interfaces created agains allowe

[PATCH 8/8] mwifiex: support conversion to any virtual interface type

2015-01-12 Thread Avinash Patil
Currently, we support virtual interface type change from station<=>adhoc or station <=> p2p client/GO. This patch adds support to change virtual interface type to any of the type advertised in interface combinations. Signed-off-by: Avinash Patil Signed-off-by: Amitkumar Karwar Signed-off-by: Cat

[PATCH 2/8] mwifiex: set wiphy params only once

2015-01-12 Thread Avinash Patil
RTS threshold, fragmentation threshold are per device properties. Setting them on any interface would be reflected for all other interfaces as well. This patch removes unnesessary command download per interface. Signed-off-by: Avinash Patil Signed-off-by: Amitkumar Karwar Signed-off-by: Cathy Lu

[PATCH 1/8] mwifiex: remove redundant nick_name variable

2015-01-12 Thread Avinash Patil
This is not used anywhere execpt initialization. Signed-off-by: Avinash Patil Signed-off-by: Amitkumar Karwar Signed-off-by: Cathy Luo --- drivers/net/wireless/mwifiex/main.c | 1 - drivers/net/wireless/mwifiex/main.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/wireless/mw

[PATCH 7/8] mwifiex: handle PS events on AP interface as well

2015-01-12 Thread Avinash Patil
This patch adds support to handle PS events on AP interface as well. Signed-off-by: Avinash Patil Signed-off-by: Amitkumar Karwar Signed-off-by: Cathy Luo --- drivers/net/wireless/mwifiex/cmdevt.c| 36 - drivers/net/wireless/mwifiex/uap_event.c | 39

[PATCH 4/8] mwifiex: store permanant mac address in adapter structure

2015-01-12 Thread Avinash Patil
This would be used to set mac address while changing virtual interface to different types. Signed-off-by: Avinash Patil Signed-off-by: Amitkumar Karwar Signed-off-by: Cathy Luo --- drivers/net/wireless/mwifiex/cfg80211.c | 2 +- drivers/net/wireless/mwifiex/cmdevt.c | 4 +--- drivers/net/wir

[PATCH 3/8] mwifiex: do not declare wdev as pointer

2015-01-12 Thread Avinash Patil
wdev is used even after del_virtual_interface handler in cfg80211 in nl80211_post_doit. Since we have freed wdev in handling of del_virtual_intf, this can result into crash while deleting interface. Avoid this be not declaring wdev which part of mwifiex_private structure but struct wireless_dev typ

[PATCH 5/8] mwifiex: add init parameter to init command routine

2015-01-12 Thread Avinash Patil
FW initialization routine can also be called while changing virtual interface types. This patch adds bool parameter "init" to init command routine so as to differentiate between initialization during driver load and change virtual interface handler. Signed-off-by: Avinash Patil Signed-off-by: Ami

Re: ath10k: fw_stats not reporting peer_stats with 10.2

2015-01-12 Thread Antonio Quartulli
On 12/01/15 12:54, Michal Kazior wrote: > On 18 December 2014 at 14:00, Antonio Quartulli wrote: >> I tried printing some debug messages here and there and the only useful >> information I got is that in "ath10k_wmi_10x_pull_fw_stats()" the value >> of "ev->num_peer_stats" is always 0. >> >> Is th

[PATCH v2] ath10k: fix hwmon temperature input units

2015-01-12 Thread Rajkumar Manoharan
To be compliant with the hwmon interface the unit needs to be millidegree Celsius. Fix that. Reported-by: Matthias Kaehlcke Signed-off-by: Rajkumar Manoharan --- v2: added new line for better readability. drivers/net/wireless/ath/ath10k/thermal.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele