Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Sudip Mukherjee
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote: > On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote: > > On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote: > > > On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: > > > > On Mon, May 25, 2015 at 10:37:28AM -0700,

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Joe Perches
On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote: > On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote: > > On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: > > > On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote: > > > > It'd be better if the approved patches fr

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Sudip Mukherjee
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote: > On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: > > On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote: > > > It'd be better if the approved patches from the intern list > > > (no idea what that is) were sent to lkml/

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Joe Perches
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: > On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote: > > It'd be better if the approved patches from the intern list > > (no idea what that is) were sent to lkml/devel@driverdev lists > > for review before actually being applied. >

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Sudip Mukherjee
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote: > It'd be better if the approved patches from the intern list > (no idea what that is) were sent to lkml/devel@driverdev lists > for review before actually being applied. Its the outreachy program. And http://kernelnewbies.org/OutreachyAp

Re: [PATCH v3] brcmfmac: prohibit ACPI power management for brcmfmac driver

2015-05-25 Thread Fu, Zhonghui
On 2015/5/20 17:02, Arend van Spriel wrote: > On 05/18/15 08:26, Fu, Zhonghui wrote: >> >> Hi guys, >> >> Any comments about this patch? > > My acked is already there. I have not been able to test it, but I assume you > did. Yes, I have verified this patch on ASUS T100TA. Thanks, Zhonghui > >

Re: iwlwifi: Queue 16 stuck for 10000 ms - Microcode SW error detected.

2015-05-25 Thread Dominik Brodowski
On Mon, May 25, 2015 at 09:27:39PM +0300, Emmanuel Grumbach wrote: > On Mon, May 25, 2015 at 9:10 PM, Dominik Brodowski > wrote: > > Hey, > > > > on my pretty new iwlwifi device 8086:08b1 (7260), the following error just > > appeared twice in dmesg on 4.1.0-rc4+ (Linus' tree as of Saturday/Sunday

Re: iwlwifi: Queue 16 stuck for 10000 ms - Microcode SW error detected.

2015-05-25 Thread Emmanuel Grumbach
On Mon, May 25, 2015 at 9:10 PM, Dominik Brodowski wrote: > Hey, > > on my pretty new iwlwifi device 8086:08b1 (7260), the following error just > appeared twice in dmesg on 4.1.0-rc4+ (Linus' tree as of Saturday/Sunday > morning): Firmware problem. Please try to update your -13.ucode from the git

iwlwifi: Queue 16 stuck for 10000 ms - Microcode SW error detected.

2015-05-25 Thread Dominik Brodowski
Hey, on my pretty new iwlwifi device 8086:08b1 (7260), the following error just appeared twice in dmesg on 4.1.0-rc4+ (Linus' tree as of Saturday/Sunday morning): iwlwifi :02:00.0: Queue 16 stuck for 1 ms. iwlwifi :02:00.0: Current SW read_ptr 109 write_ptr 243 iwl data: : 00

Re: [PATCH] net:wireless - Change 1 to true for bool type variable.

2015-05-25 Thread Joe Perches
On Mon, 2015-05-25 at 23:25 +0530, Shailendra Verma wrote: > The variable translate is bool type.So assigning true instead of 1. There are a lot these in the kernel. $ git grep -P "^[ \t]*(?:static[ \t]+)?(?:const\s+)?bool\s+\w+\s*=\s*[01]\s*;" * | wc -l 161 Are you going to submit patches for

[PATCH] net:wireless:rndis_wlan - Use bool function return value

2015-05-25 Thread Shailendra Verma
The function rndis_bss_info_update() has bool return type. So use bool value flase instead of NULL to return. Signed-off-by: Shailendra Verma --- drivers/net/wireless/rndis_wlan.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/rndis_wlan.c b/dr

Re: [PATCH] net:wireless - Change 1 to true for bool type variable.

2015-05-25 Thread Larry Finger
On 05/25/2015 12:55 PM, Shailendra Verma wrote: The variable translate is bool type.So assigning true instead of 1. Signed-off-by: Shailendra Verma When you submit a patch for a particular driver in the drivers/net/wireless/ tree, it is preferred that the subject start with the driver name,

[PATCH] net:wireless - Change 1 to true for bool type variable.

2015-05-25 Thread Shailendra Verma
The variable translate is bool type.So assigning true instead of 1. Signed-off-by: Shailendra Verma --- drivers/net/wireless/ray_cs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c index 477f863..0881ba8 100644

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Joe Perches
On Mon, 2015-05-25 at 12:17 +0300, Dan Carpenter wrote: > These are special intern patches that > dont' go through the normal review process. The intern process is over > this year. The lack of normal review introduced a number of bugs this > year. I always complain to Greg about it and he says

Re: pull-request: wireless-drivers 2015-05-25

2015-05-25 Thread David Miller
From: Kalle Valo Date: Mon, 25 May 2015 15:01:19 +0300 > here's hopefully the last wireless-drivers pull request for 4.1. Mostly > iwlwifi fixes this time. Please let me know if there are any problems. Pulled into 'net', thanks Kalle. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] mac80211: fix a NULL dereference in ath9k (and likely other drivers) when fixed mesh paths are used

2015-05-25 Thread Bob Copeland
On Thu, May 21, 2015 at 06:05:13PM -0700, Alexis Green wrote: > This patch fixes a NULL dereference in ath9k (and likely other drivers) when > fixed mesh paths are used. The problem is that when a station comes up > sta_info_alloc allocates ath_node implicitly via hw->sta_data_size. When it > does

Re: [PATCH] rtlwifi: Fix EFUSE_ANA8M map value

2015-05-25 Thread Larry Finger
On 05/23/2015 01:01 PM, Michael Büsch wrote: On Sat, 23 May 2015 12:40:38 +0200 Michael Büsch wrote: I will also try your driver from your github repo soon and see if that makes it work. Oh well. To put it mildly, this driver is awful. It compiles with frightening array overrun warnings in

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Larry Finger
On 05/23/2015 04:16 PM, Larry Finger wrote: The driver is reporting a warning at kernel/time/timer.c:1096 due to calling del_timer_sync() while in interrupt mode. Such warnings are fixed by calling del_timer() instead. Signed-off-by: Larry Finger Cc: Stable Cc: Haggi Eran --- Greg, Please

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Larry Finger
On 05/24/2015 11:42 PM, Sudip Mukherjee wrote: I haven't been using kernel v4.1 so I haven't seen this warning, but looking at the code it seems to originate from the two recent patches to remove _cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1] that changes del_tim

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Larry Finger
On 05/25/2015 04:37 AM, Vaishali Thakkar wrote: On 25 May 2015 14:49, "Dan Carpenter" mailto:dan.carpen...@oracle.com>> wrote: > > On Sun, May 24, 2015 at 07:11:40PM -0500, Larry Finger wrote: > > On 05/24/2015 02:03 PM, Haggai Eran wrote: > > >On 24 May 2015 at 00:16, Larry Finger mailto:la

Re: [PATCH] amth10k: fix promisc handling

2015-05-25 Thread Kalle Valo
Kalle Valo writes: > Adding John as this involved wireless-testing > > Michal Kazior writes: > >> On 12 May 2015 at 14:45, Michal Kazior wrote: >>> Patch df1404650ccb ("mac80211: remove support for >>> IFF_PROMISC") removed promiscuous flag propagation >>> to drivers. >>> >>> However the patch

[PATCH v4 3/3] ath10k: fix inconsistent survey reports

2015-05-25 Thread Michal Kazior
In some cases some channel survey data was reported incorrect. Channel info events were expected to come in pairs without and with COMPLETE flag set respectively for each channel visit during scan. The known deviation from this is rule for last scan chan info and first (next) scan chan info both

[PATCH v4 2/3] ath10k: handle cycle counter wraparound

2015-05-25 Thread Michal Kazior
When QCA988X cycle counter HW register wraps around it resets to 0x7fff instead of 0. All other cycle counter related registers are divided by 2 so they never wraparound themselves. QCA61X4 has a uniform CC and it wraparounds in a regular fashion though. Worst case wraparound time is approx 24

[PATCH v4 1/3] ath10k: move cycle_count macro

2015-05-25 Thread Michal Kazior
The macro isn't WMI specific. Instead it is related to hardware chip so move the macro accordingly. While at it document the magic value. Signed-off-by: Michal Kazior --- Notes: I've had to move more survey logic in "ath10k: handle cycle counter wraparound" into hw.c hence this patch

pull-request: wireless-drivers 2015-05-25

2015-05-25 Thread Kalle Valo
Hi Dave, here's hopefully the last wireless-drivers pull request for 4.1. Mostly iwlwifi fixes this time. Please let me know if there are any problems. Kalle The following changes since commit f673821864899153142365aca888435815ac93f0: ath9k: fix per-packet tx power configuration (2015-05-03 2

Re: packet loss, disconnects and possible bug in iwlwifi

2015-05-25 Thread Emmanuel Grumbach
On Sat, May 23, 2015 at 1:28 PM, Nick Dimov wrote: > Hello, > I recently bought the Intel 7260 AC wifi card (below is the PCI info) > and the card works perfectly in windows with the latest intel driver but > in linux I get deauthenticating and disconnects (reason -3) every minute > or so. When th

[PATCH] mac80211: docs: fix cannot parse enum error

2015-05-25 Thread Stanislaw Gruszka
Patch fixes documentation generation error: Error(./include/net/mac80211.h:331): Cannot parse enum! Error(./include/net/mac80211.h:369): Cannot parse enum! Signed-off-by: Stanislaw Gruszka --- include/net/mac80211.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/inc

Re: pull-request: wireless-drivers-next 2015-05-21

2015-05-25 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Thu, 21 May 2015 16:39:04 +0300 > >> here's a wireless-drivers pull request for 4.2. This time please pay >> extra attention to this pull as there are two problems: >> >> First of all as you can see the diffstat from git-pull-request in the >> end

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Dan Carpenter
On Mon, May 25, 2015 at 03:07:08PM +0530, Vaishali Thakkar wrote: > I am sorry for those patches. It was me who introduced those bugs. Yes, it > was sent during Outreachy process. But it was my mistake as a newbie. May > be I should have taken care of interrupt mode thing. > > I would like to fix

Re: [PATCHv2 0/2] add mt7601u driver

2015-05-25 Thread Jakub Kiciński
On Mon, 25 May 2015 11:13:32 +0300, Kalle Valo wrote: > Jakub Kicinski writes: > > > From: Jakub Kicinski > > > >> This miniseries adds support for the simplest of MediaTek Wi-Fi > >> devices. MT7601U is a single stream bgn chip with no bells or whistles. > >> My driver is partially based on Fe

[PATCHv3 2/2] add mt7601u kbuild and others

2015-05-25 Thread Jakub Kicinski
From: Jakub Kicinski Signed-off-by: Jakub Kicinski --- MAINTAINERS| 6 ++ drivers/net/wireless/Kconfig | 1 + drivers/net/wireless/Makefile | 2 ++ drivers/net/wireless/mediatek/Kconfig | 10 ++ drive

[PATCHv3 0/2] add mt7601u driver

2015-05-25 Thread Jakub Kicinski
From: Jakub Kicinski > This miniseries adds support for the simplest of MediaTek Wi-Fi > devices. MT7601U is a single stream bgn chip with no bells or whistles. > My driver is partially based on Felix's mt76 but IMHO it doesn't > make sense to merge the two right now because MT7601U is a design

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-25 Thread Dan Carpenter
On Sun, May 24, 2015 at 07:11:40PM -0500, Larry Finger wrote: > On 05/24/2015 02:03 PM, Haggai Eran wrote: > >On 24 May 2015 at 00:16, Larry Finger wrote: > >>The driver is reporting a warning at kernel/time/timer.c:1096 due to calling > >>del_timer_sync() while in interrupt mode. Such warnings ar

PATCH] cfg80211: moving up BAND_2GHZ above BAND_5GHZ regulatory class [EDT]

2015-05-25 Thread Rahul Jain
EP-FEDC771DF4FF48A9829CB85254E29FD3 hello Joe, Rafel, Wireless Community, I have incorporated your review comments. Please find updated patch. From 30f4fb72bcb10f9f6589ea22e26e37631f07f8fe Mon Sep 17 00:00:00 2001 From: Rahul Jain Date: Mon, 25 May 2015 14:15:36 +0530 Subject: [PATCH] cfg80211:

Re: [PATCH v3 1/2] ath10k: handle cycle counter wraparound

2015-05-25 Thread Michal Kazior
On 22 May 2015 at 19:11, Srinivasa Duvvuri wrote: > Michal, >Sorry I was out sick last few days. Thanks for splitting and creating 2 > patches. >The math for total cycle counts makes sense but the math to handle the > rx_clear_count >does not seem right to me. For the total cycle count

Re: [PATCH] Reordering for better readability and consistency [EDT]

2015-05-25 Thread Joe Perches
On Mon, 2015-05-25 at 07:37 +, Rahul Jain wrote: > diff --git a/net/wireless/util.c b/net/wireless/util.c [] > @@ -1340,10 +1340,7 @@ bool ieee80211_operating_class_to_band(u8 > operating_class, > case 128 ... 130: > *band = IEEE80211_BAND_5GHZ; > return true;

Re: [PATCHv2 0/2] add mt7601u driver

2015-05-25 Thread Kalle Valo
Jakub Kicinski writes: > From: Jakub Kicinski > >> This miniseries adds support for the simplest of MediaTek Wi-Fi >> devices. MT7601U is a single stream bgn chip with no bells or whistles. >> My driver is partially based on Felix's mt76 but IMHO it doesn't >> make sense to merge the two right

Re: [PATCH] Reordering for better readability and consistency [EDT]

2015-05-25 Thread Rafał Miłecki
On 25 May 2015 at 09:37, Rahul Jain wrote: > hello Wireless Community, Hi :) > Please find patch for review. > > From 328fb9d1b772788fc51e7f9bb21e57a1d91b0188 Mon Sep 17 00:00:00 2001 > From: Rahul Jain > Date: Mon, 25 May 2015 12:02:12 +0530 > Subject: [PATCH] Reordering for better readabilit

[PATCH] Reordering for better readability and consistency [EDT]

2015-05-25 Thread Rahul Jain
EP-FEDC771DF4FF48A9829CB85254E29FD3 hello Wireless Community, Please find patch for review. From 328fb9d1b772788fc51e7f9bb21e57a1d91b0188 Mon Sep 17 00:00:00 2001 From: Rahul Jain Date: Mon, 25 May 2015 12:02:12 +0530 Subject: [PATCH] Reordering for better readability and consistency Signed-o