Re: [PATCH] brcmfmac: use direct data pointer in NVRAM parser struct

2015-05-29 Thread Arend van Spriel
On 05/29/15 07:20, Rafał Miłecki wrote: On 28 May 2015 at 23:24, Arend van Sprielar...@broadcom.com wrote: On 05/28/15 14:34, Rafał Miłecki wrote: On 28 May 2015 at 13:54, Arend van Sprielar...@broadcom.com wrote: On 05/28/15 13:37, Rafał Miłecki wrote: As we plan to add support for

[PATCHv3 01/16] mwifiex: verbose logging for association failure messages

2015-05-29 Thread Avinash Patil
This patch adds more detailed information about association failures - reason and states. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/fw.h | 15 +-- drivers/net/wireless/mwifiex/join.c | 30

[PATCHv3 03/16] mwifiex: support AP reset after bss_stop

2015-05-29 Thread Avinash Patil
This would enable clearing of FW bss data structures when AP operations are stopped. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/cfg80211.c| 7 +++ drivers/net/wireless/mwifiex/cmdevt.c | 1 +

[PATCHv3 00/17] mwifiex patches

2015-05-29 Thread Avinash Patil
This patch series mainly adds enhancements for mwifiex AP. With this series, we support verbose information in station dump command also information about AP link. Another important enhancement is related to parsing IEs from Tail of beacon_data. Few issues seen during DFS testing are also fixed

[PATCHv3 02/16] mwifiex: correct bss_type assignment

2015-05-29 Thread Avinash Patil
Correct bss_type assignment in add_virtual_interface. This would ensure correct operation in multiple station scenarios. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/cfg80211.c | 6 +++--- 1 file changed, 3

[PATCHv3 04/16] mwifiex: enable 11d after bss reset

2015-05-29 Thread Avinash Patil
BSS reset would reset all state information in FW. Issue 11d config command after reset to enabled 11d in FW. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/uap_cmd.c | 12 1 file changed, 12 insertions(+)

pull-request: mac80211-next 2015-05-29

2015-05-29 Thread Johannes Berg
Hi Dave, It's been a while since I sent anything for -next, but with the merge window getting closer I wanted to send a few more things, mostly fixes. Of course I expect that tomorrow somebody will send an important fix, but hey :-) johannes The following changes since commit

[PATCHv3 14/16] mwifiex: advertise PS ON by default support to cfg80211

2015-05-29 Thread Avinash Patil
This would enable driver to enter powersave as soon as connected. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCHv3 15/16] mwifiex: update AP WMM settings from BSS_START event

2015-05-29 Thread Avinash Patil
This was missing and would cause issue in WMM handling. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/uap_event.c | 63 1 file changed, 63 insertions(+) diff --git

[PATCHv3 16/16] mwifiex: using right tid for addressing ra_list

2015-05-29 Thread Avinash Patil
From: Xinming Hu h...@marvell.com This patch fixes issue with the accessing correct ra_list by downgrading corresponding tid number. Alternatively, ra lists are created in mwifiex_wmm_add_buf_txqueue using downgraded tid number. Signed-off-by: Xinming Hu h...@marvell.com Signed-off-by: Cathy

[PATCHv3 17/17] mwifiex: do not decrease tx_pending for AMSDU packet once more

2015-05-29 Thread Avinash Patil
From: Xinming Hu h...@marvell.com Negative adapter-tx_pending is observed while running data traffic, because tx_pending is decreased once more for AMSDU packet. since tx_pending have been decreased for all the source MSDU packets, we don't need to update once more for AMSDU packet.

[PATCHv3 13/16] mwifiex: drop block-ack action frames

2015-05-29 Thread Avinash Patil
We often see ADDBA request packets coming to driver because driver has registered for action frame subtype. We dont process BA action frames in host. Drop such frames. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Xinmin Hu h...@marvell.com Signed-off-by: Cathy Luo

[PATCHv3 12/16] mwifiex: support downloading IEs from tail

2015-05-29 Thread Avinash Patil
Earlier only RSN, WPA and channel switch IEs from tail buffer would be downloaded to FW. This patch adds support for downloading more IEs from tail buffer. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/ie.c | 102

Re: [PATCH v2 2/2] mac80211: guard against invalid ptr deref

2015-05-29 Thread Michal Kazior
On 29 May 2015 at 13:10, Johannes Berg johan...@sipsolutions.net wrote: On Fri, 2015-05-22 at 10:57 +0200, Michal Kazior wrote: It was possible for mac80211 to be coerced into an unexpected flow causing sdata union to become corrupted. Station pointer was put into sdata-u.vlan.sta memory

[PATCHv3 08/16] mwifiex: maintain station statistic in uap mode

2015-05-29 Thread Avinash Patil
From: Xinming Hu h...@marvell.com This patch maintain statistic information for the stations associated to the mwifiex micro AP, include tx/rx bytes/packets, signal strength, tx bitrate. Signed-off-by: Xinming Hu h...@marvell.com Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by:

[PATCHv3 11/16] mwifiex: parse power constraint IE from Tail

2015-05-29 Thread Avinash Patil
This patch adds support to parse power constraint IEs from Tail buffer. This power constraint is then set to FW during bss_config download. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/cfg80211.c | 3 +++

[PATCHv3 05/16] mwifiex: reset 11h active flag when chandef does not require dfs

2015-05-29 Thread Avinash Patil
This patch fixes an issue where we were still setting 11h_active flag to true for channel defs where DFS is not required. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/cfg80211.c | 2 +- 1 file changed, 1 insertion(+),

[PATCHv3 07/16] mwifiex: add cfg80211 get_channel handler

2015-05-29 Thread Avinash Patil
From: Xinming Hu h...@marvell.com This patch add cfg80211 get_channel handler for mwifiex. The handler will be used to report current channel to upper layer utility. Signed-off-by: Xinming Hu h...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com Signed-off-by: Avinash Patil

[PATCHv3 06/16] mwifiex: disable CAC upon radar detection event

2015-05-29 Thread Avinash Patil
This patch adds support to disable ongoing CAC in FW upon detecting radar during CAC period. Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/11h.c | 30 ++ drivers/net/wireless/mwifiex/main.h

[PATCHv3 10/16] mwifiex: dump station support in uap mode

2015-05-29 Thread Avinash Patil
From: Xinming Hu h...@marvell.com This patch extend cfg80211 dump_station handler, support for dump stations associated to mwifiex micro AP. Signed-off-by: Xinming Hu h...@marvell.com Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com ---

[PATCHv3 09/16] mwifiex: add sta_list firmware command

2015-05-29 Thread Avinash Patil
From: Xinming Hu h...@marvell.com This patch add sta_list firmware command, which can be used to get power status and rssi for the stations associated to mwifiex micro AP. Signed-off-by: Xinming Hu h...@marvell.com Signed-off-by: Avinash Patil pat...@marvell.com Signed-off-by: Cathy Luo

Re: [PATCH v2 2/2] mac80211: guard against invalid ptr deref

2015-05-29 Thread Johannes Berg
On Fri, 2015-05-29 at 13:34 +0200, Michal Kazior wrote: I'm a bit undecided about this. Is this really the only place that assumes use_4addr implies that it's a VLAN, in a context like this? Hmm.. I guess TDLS could also have use_4addr and still be a IFTYPE_STATION, right? No, TDLS can

Re: [PATCH v2 2/2] mac80211: guard against invalid ptr deref

2015-05-29 Thread Michal Kazior
On 29 May 2015 at 13:39, Johannes Berg johan...@sipsolutions.net wrote: On Fri, 2015-05-29 at 13:34 +0200, Michal Kazior wrote: I'm a bit undecided about this. Is this really the only place that assumes use_4addr implies that it's a VLAN, in a context like this? Hmm.. I guess TDLS could

Re: [PATCHv3 09/16] mwifiex: add sta_list firmware command

2015-05-29 Thread Bjørn Mork
Avinash Patil pat...@marvell.com writes: case HostCmd_CMD_UAP_BSS_STOP: case HostCmd_CMD_UAP_STA_DEAUTH: case HOST_CMD_APCMD_SYS_RESET: + case HOSTCMD_CMD_UAP_STA_LIST: Just wondering, not really objecting But wouldn't it be nice

Re: [PATCH next 1/2] net: rfkill: gpio: make better use of gpiod API

2015-05-29 Thread Johannes Berg
On Thu, 2015-05-28 at 11:46 +0200, Uwe Kleine-König wrote: Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) which appeared in v3.17-rc1, the gpiod_get* functions take an additional parameter that allows to specify direction and initial value for output. Furthermore

Re: [PATCH v2 1/2] cfg80211: ignore netif running state when changing iftype

2015-05-29 Thread Johannes Berg
On Fri, 2015-05-22 at 10:57 +0200, Michal Kazior wrote: It was possible for mac80211 to be coerced into an unexpected flow causing sdata union to become corrupted. Station pointer was put into sdata-u.vlan.sta memory location while it was really master AP's sdata-u.ap.next_beacon. This led

Re: [PATCH v3] mac80211: prevent possible crypto tx tailroom corruption

2015-05-29 Thread Johannes Berg
On Fri, 2015-05-22 at 10:22 +0200, Michal Kazior wrote: There was a possible race between ieee80211_reconfig() and ieee80211_delayed_tailroom_dec(). This could result in inability to transmit data if driver crashed during roaming or rekeying and subsequent skbs with insufficient tailroom

Re: [PATCH v2 2/2] mac80211: guard against invalid ptr deref

2015-05-29 Thread Johannes Berg
On Fri, 2015-05-22 at 10:57 +0200, Michal Kazior wrote: It was possible for mac80211 to be coerced into an unexpected flow causing sdata union to become corrupted. Station pointer was put into sdata-u.vlan.sta memory location while it was really master AP's sdata-u.ap.next_beacon. This led

Re: [PATCH RFC next 2/2] net: rfkill: gpio: simplify code flow

2015-05-29 Thread Johannes Berg
On Thu, 2015-05-28 at 11:46 +0200, Uwe Kleine-König wrote: When assigning directly to the pointer contained in the driver data the local variable can be dropped together with the extra assignment to it. I'm not really sure I see the big benefit of this? It doesn't really seem to make the code

Re: [PATCH 01/17] mwifiex: verbose logging for association failure messages

2015-05-29 Thread Avinash Patil
On Thu, 2015-05-28 at 11:27 -0700, Joe Perches wrote: On Thu, 2015-05-28 at 18:27 +0530, Avinash Patil wrote: This patch adds more logging support for association failure - reason and states. [] diff --git a/drivers/net/wireless/mwifiex/fw.h b/drivers/net/wireless/mwifiex/fw.h [] @@

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-29 Thread David Howells
Andy Lutomirski l...@kernel.org wrote: This is insecure because PKCS#7 authenticated attributes are broken (see RFC2315 section 9.4 note 4). You need to either require that everything have authenticated attributes or require that nothing have authenticated attributes. Maybe this insecurity

Re: [PATCH RFC next 2/2] net: rfkill: gpio: simplify code flow

2015-05-29 Thread Uwe Kleine-König
Hello, On Fri, May 29, 2015 at 02:45:10PM +0200, Johannes Berg wrote: On Fri, 2015-05-29 at 14:42 +0200, Uwe Kleine-König wrote: On Fri, May 29, 2015 at 01:17:04PM +0200, Johannes Berg wrote: On Thu, 2015-05-28 at 11:46 +0200, Uwe Kleine-König wrote: When assigning directly to the

debian: crda package depends on iw?

2015-05-29 Thread Luca Coelho
Hi Ben, I just noticed that the crda package depends on the iw package in Debian (I'm using jessie): luca@weizen:~$ apt-cache show crda Package: crda Version: 3.13-1 Installed-Size: 293 Maintainer: Ben Hutchings b...@decadent.org.uk Architecture: amd64 Depends: libc6 (= 2.7), libnl-3-200 (=

Re: [PATCH RFC next 2/2] net: rfkill: gpio: simplify code flow

2015-05-29 Thread Johannes Berg
On Fri, 2015-05-29 at 14:42 +0200, Uwe Kleine-König wrote: On Fri, May 29, 2015 at 01:17:04PM +0200, Johannes Berg wrote: On Thu, 2015-05-28 at 11:46 +0200, Uwe Kleine-König wrote: When assigning directly to the pointer contained in the driver data the local variable can be dropped

Re: [PATCH RFC next 2/2] net: rfkill: gpio: simplify code flow

2015-05-29 Thread Uwe Kleine-König
Hello again, On Fri, May 29, 2015 at 02:46:37PM +0200, Uwe Kleine-König wrote: On Fri, May 29, 2015 at 02:45:10PM +0200, Johannes Berg wrote: On Fri, 2015-05-29 at 14:42 +0200, Uwe Kleine-König wrote: On Fri, May 29, 2015 at 01:17:04PM +0200, Johannes Berg wrote: On Thu, 2015-05-28 at

Re: [PATCH RFC next 2/2] net: rfkill: gpio: simplify code flow

2015-05-29 Thread Uwe Kleine-König
On Fri, May 29, 2015 at 01:17:04PM +0200, Johannes Berg wrote: On Thu, 2015-05-28 at 11:46 +0200, Uwe Kleine-König wrote: When assigning directly to the pointer contained in the driver data the local variable can be dropped together with the extra assignment to it. I'm not really sure I

Re: debian: crda package depends on iw?

2015-05-29 Thread Ben Hutchings
On Fri, 2015-05-29 at 16:24 +0300, Luca Coelho wrote: Hi Ben, I just noticed that the crda package depends on the iw package in Debian (I'm using jessie): luca@weizen:~$ apt-cache show crda Package: crda Version: 3.13-1 Installed-Size: 293 Maintainer: Ben Hutchings b...@decadent.org.uk

RE: [PATCHv3 09/16] mwifiex: add sta_list firmware command

2015-05-29 Thread Avinash Patil
-Original Message- From: Bjørn Mork [mailto:bj...@mork.no] Sent: Friday, May 29, 2015 5:36 PM To: Avinash Patil Cc: linux-wireless@vger.kernel.org; Amitkumar Karwar; Cathy Luo; Xinming Hu Subject: Re: [PATCHv3 09/16] mwifiex: add sta_list firmware command Avinash Patil

re: mwifiex: add dump data debug support

2015-05-29 Thread Dan Carpenter
Hello Zhaoyang Liu, This is a semi-automatic email about new static checker warnings. The patch 868093a9df75: mwifiex: add dump data debug support from May 12, 2015, leads to the following Smatch complaint: drivers/net/wireless/mwifiex/cmdevt.c:475 mwifiex_process_event() error: we

Re: [PATCH] ath10k: Add debugfs support to configure beacon tx mode

2015-05-29 Thread Kalle Valo
Rajkumar Manoharan rmano...@qti.qualcomm.com writes: Introduce debugfs entry to select beacon tx mode to staggered or bursted mode. In staggered mode, software beacon alert will be evenly distributed for each beaconing interfaces by (beacon intval / number of vif). In bursted mode, batch of

Re: [PATCH v4 1/3] ath10k: move cycle_count macro

2015-05-29 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: The macro isn't WMI specific. Instead it is related to hardware chip so move the macro accordingly. While at it document the magic value. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, all three applied. -- Kalle Valo -- To

Re: [PATCH] ath10k: add missing firmware declarations

2015-05-29 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: This could lead userspace initram images getting built without necessary firmware files included leading to probing failures of ath10k on boot with QCA61X4. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo

Re: [PATCH] brcmfmac: use direct data pointer in NVRAM parser struct

2015-05-29 Thread Rafał Miłecki
On 29 May 2015 at 10:03, Arend van Spriel ar...@broadcom.com wrote: On 05/29/15 07:20, Rafał Miłecki wrote: On 28 May 2015 at 23:24, Arend van Sprielar...@broadcom.com wrote: On 05/28/15 14:34, Rafał Miłecki wrote: On 28 May 2015 at 13:54, Arend van Sprielar...@broadcom.com wrote: On

[PATCH] mac80211: Always check rates and capabilities in mesh mode

2015-05-29 Thread Alexis Green
In mesh mode there is a race between establishing links and processing rates and capabilities in beacons. This is very noticeable with slow beacons (e.g. beacon intervals of 1s) and manifested for us as stations using minstrel when minstrel_ht should be used. Fixed by changing mesh_sta_info_init

Re: iwlwifi: Queue 16 stuck for 10000 ms - Microcode SW error detected.

2015-05-29 Thread Dominik Brodowski
On Mon, May 25, 2015 at 08:40:47PM +0200, Dominik Brodowski wrote: On Mon, May 25, 2015 at 09:27:39PM +0300, Emmanuel Grumbach wrote: On Mon, May 25, 2015 at 9:10 PM, Dominik Brodowski li...@dominikbrodowski.net wrote: Hey, on my pretty new iwlwifi device 8086:08b1 (7260), the