RE: [PATCH v4] Add new mac80211 driver mwlwifi.

2015-06-29 Thread David Lin
> Joe Perches wrote: > > On Tue, 2015-06-30 at 01:49 +, David Lin wrote: > > The Linux driver for WRT1900AC. The work was initially developed as > > part of openwrt effort and maintained on https://github.com/kaloz/mwlwifi. > > trivia: > > Please add terminating newlines to logging messages.

Re: [PATCH v4] Add new mac80211 driver mwlwifi.

2015-06-29 Thread Joe Perches
On Tue, 2015-06-30 at 01:49 +, David Lin wrote: > The Linux driver for WRT1900AC. The work was initially developed as part of > openwrt effort and maintained on https://github.com/kaloz/mwlwifi. trivia: Please add terminating newlines to logging messages. This prevents interleaving output fro

Re: [PATCH] rtlwifi: Trivial: fix typo in comments

2015-06-29 Thread Larry Finger
On 06/29/2015 07:17 PM, Nik Nyby wrote: This fixes a typo in two comments: "paht" -> "path". Signed-off-by: Nik Nyby --- drivers/net/wireless/rtlwifi/rtl8192de/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Larry Finger Larry diff --git a/drivers/net/wireles

Re: [PATCH] b43: Fix typo in function name

2015-06-29 Thread Larry Finger
On 06/29/2015 07:45 PM, Nik Nyby wrote: This fixes a typo in the "b43_lo_g_maintenance_work" function name. Signed-off-by: Nik Nyby --- drivers/net/wireless/b43/lo.c| 4 ++-- drivers/net/wireless/b43/lo.h| 2 +- drivers/net/wireless/b43/phy_g.c | 2 +- 3 files changed, 4 insertions

[PATCH] b43: Fix typo in function name

2015-06-29 Thread Nik Nyby
This fixes a typo in the "b43_lo_g_maintenance_work" function name. Signed-off-by: Nik Nyby --- drivers/net/wireless/b43/lo.c| 4 ++-- drivers/net/wireless/b43/lo.h| 2 +- drivers/net/wireless/b43/phy_g.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/

[PATCH] rtlwifi: Trivial: fix typo in comments

2015-06-29 Thread Nik Nyby
This fixes a typo in two comments: "paht" -> "path". Signed-off-by: Nik Nyby --- drivers/net/wireless/rtlwifi/rtl8192de/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c index

[PATCH] Clear subdir_stations when stations directory is removed (was Re: Null pointer dereference when station associates [introduced by 4.0.5?])

2015-06-29 Thread Tom Hughes
On 29/06/15 11:28, Tom Hughes wrote: > On 29/06/15 11:24, Tom Hughes wrote: > >> So I think this happens when hostapd switches the interface >> to AP mode, which causes the netdev to be torn down and then >> recreated, and the debugfs directory along with it. >> >> Except that if the netlink messa

[PATCH v2] ath6kl: Trivial: spell "distribution" correctly in a comment.

2015-06-29 Thread Nik Nyby
This fixes two misspellings of "distribution" in a comment. Signed-off-by: Nik Nyby --- drivers/net/wireless/ath/ath6kl/htc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/htc.h b/drivers/net/wireless/ath/ath6kl/htc.h index 14cab14..112d8a9

Re: iw and non-ASCII SSIDs

2015-06-29 Thread Paul Stewart
On Mon, Jun 29, 2015 at 1:23 AM, Johannes Berg wrote: > > [please don't use HTML] > > On Mon, 2015-06-29 at 08:17 +, Joerg Pommnitz wrote: > > We don't have to break compatibility. The commandline syntax of iw is > > iw [options] command > > My suggestion would be a new option "--binary-ssid"

Re: [PATCH V2 09/10] ath10k: Add support for code swap

2015-06-29 Thread Vasanthakumar Thiagarajan
On Monday 29 June 2015 04:51 PM, Kalle Valo wrote: Vasanthakumar Thiagarajan writes: Code swap is a mechanism to use host memory to store some fw binary code segment. Ath10k host driver allocates and loads the code swap binary into the host memory and configures the target with the host alloca

[PATCH] staging:wilc1000: code cleanup Fix reported by coccinelle

2015-06-29 Thread Mutharaju, Prasanna (P.)
From: Prasanna Karthik Removed {} for single statement if block Signed-off-by: Prasanna Karthik --- drivers/staging/wilc1000/fifo_buffer.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/fifo_buffer.c b/drivers/staging/wilc1000/fifo_

Re: [PATCH V2 09/10] ath10k: Add support for code swap

2015-06-29 Thread Kalle Valo
Vasanthakumar Thiagarajan writes: > Code swap is a mechanism to use host memory to store > some fw binary code segment. Ath10k host driver allocates > and loads the code swap binary into the host memory and > configures the target with the host allocated memory > information at the address taken

Re: Null pointer dereference when station associates [introduced by 4.0.5?]

2015-06-29 Thread Tom Hughes
On 29/06/15 11:24, Tom Hughes wrote: So I think this happens when hostapd switches the interface to AP mode, which causes the netdev to be torn down and then recreated, and the debugfs directory along with it. Except that if the netlink message to change the mode was sent from a daemon whose se

Re: Null pointer dereference when station associates [introduced by 4.0.5?]

2015-06-29 Thread Tom Hughes
On 29/06/15 10:44, Tom Hughes wrote: On 29/06/15 10:20, Tom Hughes wrote: On 29/06/15 09:30, Tom Hughes wrote: On 29/06/15 09:14, Johannes Berg wrote: On Sat, 2015-06-27 at 16:34 +0100, Tom Hughes wrote: Interestingly from what I can see this is trying to create a file for the station at a p

[PATCH] NFC: st21nfca,st-nci: fix use of uninitialized variables in error path

2015-06-29 Thread Nicolas Iooss
st21nfca_hci_load_session() calls kfree_skb() on unitialized variables skb_pipe_info and skb_pipe_list if the call to nfc_hci_connect_gate() failed. Reword the error path to not use these variables when they are not initialized. While at it, there seemed to be a memory leak because skb_pipe_info

Re: Null pointer dereference when station associates [introduced by 4.0.5?]

2015-06-29 Thread Tom Hughes
On 29/06/15 10:20, Tom Hughes wrote: > On 29/06/15 09:30, Tom Hughes wrote: >> On 29/06/15 09:14, Johannes Berg wrote: >>> On Sat, 2015-06-27 at 16:34 +0100, Tom Hughes wrote: Interestingly from what I can see this is trying to create a file for the station at a path something like:

Re: [PATCH] Trivial: spell "distribution" correctly in a comment.

2015-06-29 Thread Kalle Valo
Nik Nyby writes: > Signed-off-by: Nik Nyby Please use prefix "ath6kl: " for ath6kl patches. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Null pointer dereference when station associates [introduced by 4.0.5?]

2015-06-29 Thread Tom Hughes
On 29/06/15 09:30, Tom Hughes wrote: > On 29/06/15 09:14, Johannes Berg wrote: >> On Sat, 2015-06-27 at 16:34 +0100, Tom Hughes wrote: >>> >>> Interestingly from what I can see this is trying to create a file >>> for the station at a path something like: >>> >>> ieee80211/phy0/netdev:/stations/

Re: Null pointer dereference when station associates [introduced by 4.0.5?]

2015-06-29 Thread Tom Hughes
On 29/06/15 09:14, Johannes Berg wrote: > On Sat, 2015-06-27 at 16:34 +0100, Tom Hughes wrote: >> >> Interestingly from what I can see this is trying to create a file >> for the station at a path something like: >> >> ieee80211/phy0/netdev:/stations/XX > > indeed. > >> but in my (currentl

Re: iw and non-ASCII SSIDs

2015-06-29 Thread Johannes Berg
[please don't use HTML] On Mon, 2015-06-29 at 08:17 +, Joerg Pommnitz wrote: > We don't have to break compatibility. The commandline syntax of iw is > iw [options] command > My suggestion would be a new option "--binary-ssid" that sets a flag > and causes all SSID to be treated as a hex encod

Re: Null pointer dereference when station associates [introduced by 4.0.5?]

2015-06-29 Thread Johannes Berg
On Sat, 2015-06-27 at 16:34 +0100, Tom Hughes wrote: > > Interestingly from what I can see this is trying to create a file > for the station at a path something like: > > ieee80211/phy0/netdev:/stations/XX indeed. > but in my (currently working) boot under 4.0.4 there is no netdev > dir

Re: [PATCH] mac80211: remove compilation warning on mesh

2015-06-29 Thread Johannes Berg
On Mon, 2015-06-29 at 15:41 +0800, Yeoh Chun-Yeow wrote: > On Mon, Jun 29, 2015 at 3:27 PM, Johannes Berg > wrote: > > On Mon, 2015-06-29 at 11:50 +0800, Chun-Yeow Yeoh wrote: > > > Remove the warning on the following: > > > mesh_hwmp.c: warning: ‘target_metric’ may be used > > > uninitialized in

Re: [PATCH] mac80211: remove compilation warning on mesh

2015-06-29 Thread Yeoh Chun-Yeow
On Mon, Jun 29, 2015 at 3:27 PM, Johannes Berg wrote: > On Mon, 2015-06-29 at 11:50 +0800, Chun-Yeow Yeoh wrote: >> Remove the warning on the following: >> mesh_hwmp.c: warning: ‘target_metric’ may be used >> uninitialized in this function [-Wmaybe-uninitialized] >> > I don't see any such warning,

Re: [PATCH] mac80211: remove compilation warning on mesh

2015-06-29 Thread Johannes Berg
On Mon, 2015-06-29 at 11:50 +0800, Chun-Yeow Yeoh wrote: > Remove the warning on the following: > mesh_hwmp.c: warning: ‘target_metric’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > I don't see any such warning, and would prefer not to have a blanket initialization that mi