Re: [PATCH] ath10k: Improve performance by reducing tx_lock contention.

2015-07-21 Thread Kalle Valo
Avery Pennarun writes: > On Wed, Jul 22, 2015 at 2:16 AM, Kalle Valo wrote: >> Marty Faltesek writes: >>> From: Qi Zhou >>> >>> During tx completion, tx_lock is held for longer than required, preventing >>> efficient refill of htt->pending_tx. Refactor the code so that only MSDU >>> related op

Re: [PATCH] ath10k: Improve performance by reducing tx_lock contention.

2015-07-21 Thread Avery Pennarun
On Wed, Jul 22, 2015 at 2:16 AM, Kalle Valo wrote: > Marty Faltesek writes: >> From: Qi Zhou >> >> During tx completion, tx_lock is held for longer than required, preventing >> efficient refill of htt->pending_tx. Refactor the code so that only MSDU >> related operations are protected by the loc

Re: [PATCH] ath10k: Improve performance by reducing tx_lock contention.

2015-07-21 Thread Kalle Valo
Marty Faltesek writes: > From: Qi Zhou > > During tx completion, tx_lock is held for longer than required, preventing > efficient refill of htt->pending_tx. Refactor the code so that only MSDU > related operations are protected by the lock. > > Improves downstream performance on a 3x3 client fro

Re: linux-next: build failure after merge of the wireless-drivers-next tree

2015-07-21 Thread Kalle Valo
cae761b5a6bd ("bcma: populate bus DT subnodes as platform_device-s") > > I have used the wireless-drivers-next tree from next-20150721 for today. Sorry about that. Rafal, can you please send a patch to fix this? I'll apply it ASAP. -- Kalle Valo -- To unsubscribe from this lis

[PATCH 2/2] Small build system improvements.

2015-07-21 Thread ahmed . taahir
From: Taahir Ahmed Phony targets are properly declared. User's CFLAGS are not clobbered with '-O2 -g' unless the user has set no cflags. --- Makefile | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 4ce900c..b5aa8e3 100644 --- a/Makefile +

Support Python 3 in the crda build system (Take 2)

2015-07-21 Thread ahmed . taahir
Updated Intro: This patchset takes into account helpful comments by Stefan. The user can now set the make variable BUILD_PYTHON to select which interpreter runs key2pub.py. key2pub.py is further simplified as well. Original Intro: crda's build system is one of the last packages with a hard dep

[PATCH 1/2] Support python 3 in utils/key2pub.py.

2015-07-21 Thread ahmed . taahir
From: Taahir Ahmed utils/key2pub.py can now be run under either python 2.7 or python 3.x. This required some minor syntactical changes as well as switching from M2Crypto to pycrypto, since M2Crypto doesn't support python 3.x. The generate source files have been renamed to keys-*.h, to prevent a

Re: [PATCH 1/2] Support python 3 in utils/key2pub.py.

2015-07-21 Thread Stefan Lippers-Hollmann
Hi On 2015-07-21, Taahir Ahmed wrote: > On Wednesday 22 July 2015 04:50:45 Stefan Lippers-Hollmann wrote: > > You omit $(pwd) from ./utils/key2pub.py, while /utils/key2pub.py > > won't exist. > > Wow, that's a really bad mistake on my part. It should indeed probably > be './utils/key2pub.py'. I

[PATCH] mac80211_hwsim: unregister genetlink family properly

2015-07-21 Thread Su Kang Yin
During hwsim_init_netlink(), we should call genl_unregister_family() if failed on netlink_register_notifier() since the genetlink is already registered. Signed-off-by: Su Kang Yin --- drivers/net/wireless/mac80211_hwsim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dri

Re: [PATCH 1/2] Support python 3 in utils/key2pub.py.

2015-07-21 Thread Taahir Ahmed
On Wednesday 22 July 2015 04:50:45 Stefan Lippers-Hollmann wrote: > You omit $(pwd) from ./utils/key2pub.py, while /utils/key2pub.py > won't exist. Wow, that's a really bad mistake on my part. It should indeed probably be './utils/key2pub.py'. I made this change after my general testing, simply

Re: [PATCH 1/2] Support python 3 in utils/key2pub.py.

2015-07-21 Thread Stefan Lippers-Hollmann
Hi On 2015-07-21, ahmed.taa...@gmail.com wrote: > From: Taahir Ahmed > > utils/key2pub.py can now be run under either python 2.7 or python 3.x. > This required some minor syntactical changes as well as switching from > M2Crypto to pycrypto, since M2Crypto doesn't support python 3.x. [...] > diff

[PATCH] ath10k: Improve performance by reducing tx_lock contention.

2015-07-21 Thread Marty Faltesek
From: Qi Zhou During tx completion, tx_lock is held for longer than required, preventing efficient refill of htt->pending_tx. Refactor the code so that only MSDU related operations are protected by the lock. Improves downstream performance on a 3x3 client from 495 to 580 Mbps. Signed-off-by: De

Support Python3 in the crda buildsystem.

2015-07-21 Thread ahmed . taahir
crda's build system is one of the last packages with a hard dep on python-2.7 on my Gentoo system. This patchset adapts the utility script 'key2pub.py' so that it will run under either Python 2.7 or Python 3.x. The main change is a switch from using M2Crypto to PyCrypto, specifically for Python 3

[PATCH 2/2] Small build system improvements.

2015-07-21 Thread ahmed . taahir
From: Taahir Ahmed Phony targets are properly declared. User's CFLAGS are not clobbered with '-O2 -g' unless the user has set no cflags. Rename the generated file 'keys-*.c' to 'keys-*.h', so the general object compilation pattern rule doesn't try to build it. --- Makefile | 16 ++-

[PATCH 1/2] Support python 3 in utils/key2pub.py.

2015-07-21 Thread ahmed . taahir
From: Taahir Ahmed utils/key2pub.py can now be run under either python 2.7 or python 3.x. This required some minor syntactical changes as well as switching from M2Crypto to pycrypto, since M2Crypto doesn't support python 3.x. In addition, some errors in the generated source file keys-ssl.h are f

Re: [RFC v3 2/2] firmware: add firmware signature checking support

2015-07-21 Thread Luis R. Rodriguez
On Tue, Jul 14, 2015 at 12:20 PM, Luis R. Rodriguez wrote: >> > + strcpy(signed_name, buf->fw_id); >> > + strncat(signed_name, sign_ext, strlen(sign_ext)); >> >> fw_id is potentially unbounded, so using strncat hear poses an >> overflow risk. Maybe better to use strlcpy? >> > > Thanks

Re: pull-request: wireless-drivers 2015-07-20

2015-07-21 Thread David Miller
From: Kalle Valo Date: Mon, 20 Jul 2015 18:36:30 +0300 > here are few fixes for 4.2, should not have anything out of ordinary. > Please let me know if there are any issues. Pulled, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to ma

[PATCH] bcma: switch GPIO portions to use GPIOLIB_IRQCHIP

2015-07-21 Thread Linus Walleij
This switches the BCMA GPIO driver to use GPIOLIB_IRQCHIP to handle its interrupts instead of rolling its own copy of the irqdomain handling etc. Signed-off-by: Linus Walleij --- Hi BCMA people, if we can figure this out it would be great if you can test this and merge it through whatever GIT tr

Re: [PATCH] staging: rtl8723au: fix incorrect type in assignment warning

2015-07-21 Thread Jes Sorensen
Steve Pennington writes: > Repaced call to htons with call to cpu_to_be16s to fix the > following sparse warning: > drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in > assignment (different base types) > drivers/staging/rtl8723au/core/rtw_recv.c:1557:21:expected un

[PATCH] staging: rtl8723au: fix incorrect type in assignment warning

2015-07-21 Thread Steve Pennington
Repaced call to htons with call to cpu_to_be16s to fix the following sparse warning: drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/core/rtw_recv.c:1557:21:expected unsigned short [unsigned] [assigned]

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-21 Thread Kalle Valo
Maninder Singh writes: >>> chandef is initialized with NULL and on the very next line, >>> we are using it to get channel, which is not correct. >>> >>> channel should be initialized after obtaining chandef. >>> >>> Signed-off-by: Maninder Singh > >>How did you find this bug? > > Static anlysis

Re: [v2,1/3] mwifiex: add bss mode TLV to extended scan command

2015-07-21 Thread Kalle Valo
> From: Aniket Nagarnaik > > We are setting BSS mode as ANY so that firmware will provide > all types of scan entries. > > Signed-off-by: Aniket Nagarnaik > Signed-off-by: Amitkumar Karwar Thanks, 3 patches applied to wireless-drivers-next.git: 40d7412b56f0 mwifiex: add bss mode TLV to exte

Re: [2/2] iwlegacy: convert hex_dump_to_buffer() to %*ph

2015-07-21 Thread Kalle Valo
> There is no need to use hex_dump_to_buffer() in the cases like this: > > hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /* len > <= 16 */ > sprintf("%s\n", outbuf); > > since it maybe easily converted to simple: > > sprintf("%*ph\n", len, buf); > > Note: i

Re: wlcore: add antenna diversity reading

2015-07-21 Thread Kalle Valo
> update the rssi reading on rx_status > to read both RSSI level (7 bits) and > antenna diversity (msb) > > Signed-off-by: Guy Mishol Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message t

Re: [PATCH] wl18xx: add dynamic fw traces

2015-07-21 Thread Kalle Valo
Guy Mishol writes: > add option to dynamically configure the fw > which debug traces to open > > Signed-off-by: Guy Mishol Failed to apply, please rebase: Applying: wl18xx: add dynamic fw traces fatal: sha1 information is lacking or useless (drivers/net/wireless/ti/wl18xx/acx.c). Repository la

[PATCH] ath10k: suppress 'failed to process fft' warning messages.

2015-07-21 Thread Kevin Darbyshire-Bryant
When using DFS channels on Ath10k, kernel log has repeated warning message 'failed to process fft: -22' typically under medium/heavy traffic. This patch switches the warnings to driver debug (WMI events) mode only thus reducing log file noise. DFS and spectral scan share underlying HW mechanisms

Re: [1/2] ath9k: Fix register definitions for QCA956x

2015-07-21 Thread Kalle Valo
> From: Miaoqing Pan > > Signed-off-by: Miaoqing Pan Thanks, 2 patches applied to wireless-drivers-next.git: fa5b8c8a5ae4 ath9k: Fix register definitions for QCA956x 6301566e0b2d ath9k: export HW random number generator Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe

Re: brcmfmac: set wiphy's addresses to provide valid MACs

2015-07-21 Thread Kalle Valo
> Broadcom's firmware requires every BSS to use MAC address with unique > last few bits. The amount of bits may depend on a particular firmware, > it was verified to be 2 for BCM43602 one. > If this condition won't be fulfilled firmware will reject such MAC: > brcmfmac: _brcmf_set_mac_address: Set

Re: ath9k: fix moredata flag endianness in cabq tx

2015-07-21 Thread Kalle Valo
> While compiling ath9k with some extra flags I've > found that: > > ath9k/xmit.c +2473 ## 16: warning: restricted __le16 degrades to integer > ath9k/xmit.c +2474 ## 36: warning: invalid assignment: &= > ath9k/xmit.c +2474 ## 36:left side has type restricted __le16 > ath9k/xmit.c +2474 ##

Re: [v2] brcmsmac: Use kstrdup to simplify code

2015-07-21 Thread Kalle Valo
> Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve > readability. > > Signed-off-by: Christophe JAILLET > Acked-by: Arend van Spriel Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in th

Re: rtlwifi: rtl8821ae: Fix an expression that is always false

2015-07-21 Thread Kalle Valo
> In routine _rtl8821ae_set_media_status(), an incorrect mask results in a test > for AP status to always be false. Similar bugs were fixed in rtl8192cu and > rtl8192de, but this instance was missed at that time. > > Reported-by: David Binderman > Signed-off-by: Larry Finger > Cc: Stable [3.18

Re: [PATCH 1/2] ath9k: Fix register definitions for QCA956x

2015-07-21 Thread Kalle Valo
writes: > From: Miaoqing Pan > > Signed-off-by: Miaoqing Pan No need to change anything for this patch, but I want to warn that in the future I will automatically start rejecting patches with empty commit logs. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 11/13] wil6210: TSO implementation

2015-07-21 Thread Kalle Valo
Vladimir Kondratiev writes: > On Wednesday, July 08, 2015 10:06:37 PM Emmanuel Grumbach wrote: >> So your device is able to replicate and update the IP / TCP header? >> I don't really follow what your device is able to do. >> You seem to be cutting the frags so that their length sums up to mss. >

Re: [PATCH] bcma: populate bus DT subnodes as platform_device-s

2015-07-21 Thread Kalle Valo
Rafał Miłecki writes: > Our bus should allow defining children nodes as we may want to specify > devices attached to the bus. This is required e.g. to specify NAND or > ChipCommon cores and use bus's address and IRQ mappings. > > Signed-off-by: Rafał Miłecki Thanks, manually applied to wireless

Re: mwifiex: fix for p2p broken link

2015-07-21 Thread Kalle Valo
> From: Aniket Nagarnaik > > This patch fixes following issues in p2p code paths. > > 1) bss role, bss type and connection type was not set correctly > for p2p GO and p2p client at couple of places. > 2) Driver appends a proprietary header to management frames > which will be parsed by our firm

Re: wlcore: sdio: return correct error code

2015-07-21 Thread Kalle Valo
> When wlcore_probe_of failed, return the correct error code instead of ENOMEM > > Signed-off-by: Raphaël Poggi Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kern

Re: ath9k: make DMA stop related messages debug-only

2015-07-21 Thread Kalle Valo
> A long time ago, ath9k had issues during reset where the DMA engine > would stay active and could potentially corrupt memory. > To debug those issues, the driver would print warnings whenever they > occur. > > Nowadays, these issues are gone and the primary cause of these messages > is if the M

Re: rtlwifi: fix typo in comments

2015-07-21 Thread Kalle Valo
> This fixes a typo in two comments: "paht" -> "path". > > Signed-off-by: Nik Nyby > Acked-by: Larry Finger Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.o

Re: b43: Fix typo in function name

2015-07-21 Thread Kalle Valo
> This fixes a typo in the "b43_lo_g_maintenance_work" function > name. > > Signed-off-by: Nik Nyby > Acked-by: Larry Finger > Acked-by: Michael Buesch Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the

Re: mwifiex: usb: Fix double add error when submitting rx urb

2015-07-21 Thread Kalle Valo
> There is an error that can occur where the driver adds the same URB to USB > submission list twice. > This happens since mwifiex_usb_submit_rem_rx can submit packets at same time > as an rx urb complete callback. > This causes list corruption and is fixed by not setting the skb to NULL when >

Re: mwifiex: fix leak of gen_ie storage on exit from mwifiex_del_mgmt_ies

2015-07-21 Thread Kalle Valo
> Storage pointed to by gen_ie is allocated with kmalloc, but was > never freed. > > Coverity CID #1271251 > > Signed-off-by: John W. Linville > Acked-by: Amitkumar Karwar Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe li

Re: MAINTAINERS: update for mwifiex driver maintainers

2015-07-21 Thread Kalle Valo
> Amit & Nishant would be taking care of maintaining mwifiex driver here > onwards on account of organizational changes. > > Signed-off-by: Avinash Patil > Signed-off-by: Amitkumar Karwar > Signed-off-by: Nishant Sarmukadam > Signed-off-by: Cathy Luo > Signed-off-by: Frank Huang Thanks, app

Re: mwifiex: do not short circuit exit from mwifiex_set_mgmt_ies

2015-07-21 Thread Kalle Valo
> Without this change, the code simply exits after calling > mwifiex_uap_set_head_tail_ies, leving the call to > mwifiex_set_mgmt_beacon_data_ies as dead code. > > Coverity CID #1271292 > > Signed-off-by: John W. Linville > Acked-by: Amitkumar Karwar Thanks, applied to wireless-drivers-next.g

Re: [01/17] mwifiex: add tx data pause support

2015-07-21 Thread Kalle Valo
> This patch adds support to enable TX data pause feature for mwifiex. > Whenever FW TX buffers reach threshold, FW would send TX pause event > to driver. Driver in turn would block data traffic to that particular > receiver address. > > Signed-off-by: Avinash Patil > Signed-off-by: Xinming Hu

Re: mwifiex: avoid freeing improper pointer inmwifiex_set_wowlan_mef_entry

2015-07-21 Thread Kalle Valo
> mwifiex_set_wowlan_mef_entry attempts to free a passed-in pointer in > case of an error. The only caller (mwifiex_set_mef_filter) passes that > pointer as an offset into allocated memory, so any attempt to free that > will not be the actual allocated pointer. > > Address this by changing mwifi

Re: [5/6] wireless: cw1200: Remove redundant spi driver bus initialization

2015-07-21 Thread Kalle Valo
> In ancient times it was necessary to manually initialize the bus > field of an spi_driver to spi_bus_type. These days this is done in > spi_register_driver(), so we can drop the manual assignment. > > Signed-off-by: Antonio Borneo > To: Solomon Peachy > To: Kalle Valo > To: linux-wireless@vg

Re: rtlwifi: rtl8192cu: Remove rtl8723 code

2015-07-21 Thread Kalle Valo
> In the rtlwifi/rtl8192cu, rtl8723 code is dead code. > So I remove it. > > Signed-off-by: Taehee Yoo > Acked-by: Larry Finger Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to maj

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-21 Thread Maninder Singh
>> chandef is initialized with NULL and on the very next line, >> we are using it to get channel, which is not correct. >> >> channel should be initialized after obtaining chandef. >> >> Signed-off-by: Maninder Singh >How did you find this bug? Static anlysis reports this bug like coverity or an

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-21 Thread Kalle Valo
Maninder Singh writes: > chandef is initialized with NULL and on the very next line, > we are using it to get channel, which is not correct. > > channel should be initialized after obtaining chandef. > > Signed-off-by: Maninder Singh How did you find this bug? -- Kalle Valo -- To unsubscribe

[PATCH] ath10k: Add QCA99X0 to supported device list

2015-07-21 Thread Vasanthakumar Thiagarajan
Add vendor/device id of QCA99X0 V2.0 to pci id table and QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for QCA99X0 to get detected by the driver. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drive

FW: Multiple Vifs in Managed Mode

2015-07-21 Thread Doru
Hello, Johannes What I try to do is perfectly described in this picture: https://drive.google.com/file/d/0B5SBH08PU_ChSVVQdEhQQ29neG8/view? usp=sharing It’s worth mentioning that I need to do this on an Android phone. The problem is that the only resources for finding a solution seems to be thi

[PATCH v3 3/4] ath9k: setup rxfilter for all chanctx

2015-07-21 Thread Janusz Dziedzic
While mac80211 setup this per HW, set same rxfilter configuration for all chanctx. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath

[PATCH v3 1/4] ath9k: advertise p2p dev support when chanctx

2015-07-21 Thread Janusz Dziedzic
Advertise p2p device support when ath9k loaded with use_chanctx=1. This will fix problem, when first interface is an AP and next we would like to run p2p_find. Before p2p find (scan phase) failed with EOPNOTSUPP. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/init.c | 7 +

[PATCH v3 2/4] ath9k: handle RoC cancel correctly

2015-07-21 Thread Janusz Dziedzic
In case we will get ROC cancel from mac80211 we should not call ieee80211_remain_on_channel_expired(). In other case I hit such warning on MIPS and p2p negotiation failed (tested with use_chanctx=1). ath: phy0: Starting RoC period ath: phy0: Channel definition created: 2412 MHz ath: phy0: Assigne

[PATCH v3 4/4] ath9k: setup rxfilter when offchannel

2015-07-21 Thread Janusz Dziedzic
Setup rxfiler correctly for offchannel ctx. This fix problem we didn't configure rxfilter, next didn't receive probe requests and next failed p2p_find. This was seen when ath9k loaded with use_chanctx=1 Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/main.c | 3 +++ 1 file cha

Re: pull-request: mac80211 2015-07-17

2015-07-21 Thread David Miller
From: Johannes Berg Date: Fri, 17 Jul 2015 15:31:34 +0200 > We've accumulated some wireless fixes, please pull. Arik's fix is a bit > bigger than I might like, but it fixes a real locking issue and we > didn't really see a good way to make a smaller version. > > Let me know if there's any proble