Re: [PATCH] ath10k: Add QCA99X0 to supported device list

2015-07-30 Thread Kalle Valo
Vasanthakumar Thiagarajan vthia...@qti.qualcomm.com writes: Add vendor/device id of QCA99X0 V2.0 to pci id table and QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for QCA99X0 to get detected by the driver. Signed-off-by: Vasanthakumar Thiagarajan vthia...@qti.qualcomm.com Thanks,

Re: [PATCH V2 3/5] staging: wilc1000: remove warnings on missing blank line

2015-07-30 Thread Sudip Mukherjee
On Thu, Jul 30, 2015 at 06:10:12PM +0900, Tony Cho wrote: This patch removes the warnings reported by checkpatch.pl on missing a blank line after declarations. Signed-off-by: Tony Cho tony@atmel.com --- V2: This patch doesn't have a difference with the first one. However, it's resent

[PATCH] mac80211: make local-tx_headroom a multiple of 4

2015-07-30 Thread Felix Fietkau
This ensures that mac80211 generated management frames and beacons are aligned before being passed to the driver Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac80211/main.c b/net/mac80211/main.c index

Re: [PATCH] nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip

2015-07-30 Thread Robert Baldyga
On 07/30/2015 12:22 PM, Paul Bolle wrote: On wo, 2015-07-29 at 14:15 +0200, Robert Baldyga wrote: --- /dev/null +++ b/drivers/nfc/s3fwrn5/Kconfig @@ -0,0 +1,22 @@ +config NFC_S3FWRN5 +tristate Samsung S3FWRN5 NFC driver +depends on NFC_NCI +default n +---help--- +

Re: [PATCH] ath10k: initialize msdu ext. descriptor before use

2015-07-30 Thread Kalle Valo
Peter Oh p...@qca.qualcomm.com writes: Initial QCA99X0 support has a known issue with TCP Tx throughput. All other path such as UDP Tx/Rx and TCP Rx meet their expectation ( 900Mbps), but TCP Tx marked as low as 5Mbps when single pair is used on iperf. The root cause is turned out because

[RESEND V2 3/3] staging: wilc1000: coreconfigurator.c: fix kmalloc error check

2015-07-30 Thread Chaehyun Lim
Return -ENOMEM if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c

[RESEND V2 2/3] staging: wilc1000: coreconfigurator.c: add kmalloc error check

2015-07-30 Thread Chaehyun Lim
Add error check if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/wilc1000/coreconfigurator.c

[RESEND V2 0/3] cover letter of wilc1000 patches

2015-07-30 Thread Chaehyun Lim
Hi, Greg I'm sorry that I did not say whether GFP_ATOMIC should be used or not. This is my review on it. If it's not correct, please give me any comment or direction. First patch has 4 sites of kmalloc change in coreconfigurator.c First one, it is used for gps8ConfigPacket at

[RESEND V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC

2015-07-30 Thread Chaehyun Lim
Use kmalloc and kmalloc_array instead of WILC_MALLOC. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Sudip Mukherjee
On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions of functions or expressions becausue doing so

Re: [PATCH 1/2] ath10k: Fix memory alloc failure in qca99x0 during wmi svc rdy event

2015-07-30 Thread Kalle Valo
Raja Mani rm...@qti.qualcomm.com writes: Host memory required for firmware is allocated while handling wmi service ready event. Right now, wmi service ready is handled in tasklet context and it calls dma_alloc_coherent() with atomic flag (GFP_ATOMIC) to allocate memory in host needed for

Re: [RESEND V2 0/3] cover letter of wilc1000 patches

2015-07-30 Thread Chaehyun Lim
I'm sorry that I have mistake the number of kmalloc changes. The total change is 6, not 4. On Thu, Jul 30, 2015 at 8:41 PM, Chaehyun Lim chaehyun@gmail.com wrote: Hi, Greg I'm sorry that I did not say whether GFP_ATOMIC should be used or not. This is my review on it. If it's not correct,

Re: [RESEND V2 0/3] cover letter of wilc1000 patches

2015-07-30 Thread Dan Carpenter
On Thu, Jul 30, 2015 at 09:03:48PM +0900, Chaehyun Lim wrote: On Thu, Jul 30, 2015 at 8:41 PM, Chaehyun Lim chaehyun@gmail.com wrote: First patch has 4 sites of kmalloc change in coreconfigurator.c First one, it is used for gps8ConfigPacket at CoreconfiguratorInit and

[PATCH v2] nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip

2015-07-30 Thread Robert Baldyga
Add driver for Samsung S3FWRN5 NFC controller. S3FWRN5 is using NCI protocol and I2C communication interface. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- Changelog: v2: - Adressed comments from Paul Bolle v1: http://www.spinics.net/lists/kernel/msg2044290.html

[PATCH 2/2] iw: remove android-nl.c with unneeded workaround

2015-07-30 Thread Filipe Brandenburger
The workaround might have been necessary in the past, however now it produces the following error: .../libnl.a(attr.o): multiple definition of 'nla_put_flag' .../android-nl.o: previous definition here collect2: error: ld returned 1 exit status TEST=Built AOSP tree with this patchset,

[PATCH 1/2] iw: fix references to libnl in Android.mk

2015-07-30 Thread Filipe Brandenburger
The latest AOSP refers to that library as libnl and not libnl_2. TEST=Built AOSP tree with this patchset, tested the generated iw binary. Signed-off-by: Filipe Brandenburger filbran...@google.com --- Android.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Android.mk

[PATCH 1/4] wlcore/wl18xx : add time sync event handling

2015-07-30 Thread Yaniv Machani
Added support for a new time sync event the event data contains the WiLink TSF value. To trigger the event, a HW modification is required, so as a supporting firmware binary. Signed-off-by: Yaniv Machani yani...@ti.com --- drivers/net/wireless/ti/wl18xx/event.c | 13 +

[PATCH 0/2] iw: fixes to Android.mk to include iw in AOSP builds

2015-07-30 Thread Filipe Brandenburger
Hi, I'm working on including iw on Android AOSP eng builds and it turns out we need some fixes to Android.mk to make it build on a current AOSP tree. We already have an Android git repo set up with the iw tree: https://android.googlesource.com/platform/external/iw.git The two patches in this

Re: [PATCH 1/2] iw: fix references to libnl in Android.mk

2015-07-30 Thread enh
On Thu, Jul 30, 2015 at 2:35 PM, Filipe Brandenburger filbran...@google.com wrote: The latest AOSP refers to that library as libnl and not libnl_2. TEST=Built AOSP tree with this patchset, tested the generated iw binary. Signed-off-by: Filipe Brandenburger filbran...@google.com ---

[PATCH 4/4] wlcore: add p2p device support

2015-07-30 Thread Yaniv Machani
From: Eliad Peller el...@wizery.com When starting a p2p mgmt interface, enable its device role. This allows us to keep the sta role disabled and scan on the dev role. In general, p2p management interfaces cannot send vif-specific commands to FW, as the vif role id is invalid. Only off-channel

[PATCH 3/4] wlcore: add generic_cfg_feature command definitions

2015-07-30 Thread Yaniv Machani
From: Eliad Peller el...@wizery.com Add definitions and function prototypes for generic_cfg command. Signed-off-by: Eliad Peller el...@wizery.com --- drivers/net/wireless/ti/wlcore/cmd.c | 30 ++ drivers/net/wireless/ti/wlcore/cmd.h | 15 +++ 2 files

[PATCH 2/4] wl18xx: use long intervals in sched scan

2015-07-30 Thread Yaniv Machani
From: Eliad Peller el...@wizery.com Add support for long intervals on sched scan. If configured, the original request interval will be used num_short_interval times, and then the long interval will be used. While on it, fix the scan command field names to reflect the expected value is in ms

[PATCH 1/2] ARM: dts: am335x-evm: add wilink8 wlan support

2015-07-30 Thread Yaniv Machani
From: Eliad Peller el...@wizery.com * enable mmc3 used for wlan * configure the gpios used for wlan * add fixed voltage regulator used for wlan power control Signed-off-by: Eliad Peller el...@wizery.com Signed-off-by: Yaniv Machani yani...@ti.com --- arch/arm/boot/dts/am335x-evm.dts |

[PATCH 2/2] ARM: dts: am335x-evm: add wilink8 bluetooth support

2015-07-30 Thread Yaniv Machani
From: Eliad Peller el...@wizery.com uart1 is used for shared transport (used for multiplexing bluetooth and nfc data). add the needed muxes and definitions. Signed-off-by: Eliad Peller el...@wizery.com Signed-off-by: Eyal Reizer ey...@ti.com --- arch/arm/boot/dts/am335x-evm.dts | 29

[PATCH v2 1/2] iw: fix references to libnl in Android.mk

2015-07-30 Thread Filipe Brandenburger
The latest AOSP refers to that library as libnl and not libnl_2. TEST=Built AOSP tree with this patchset, tested the generated iw binary. Signed-off-by: Filipe Brandenburger filbran...@google.com --- v2: Removed now redundant LOCAL_C_INCLUDES as suggested by Elliott. Retested to confirm it

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Greg KH
On Fri, Jul 31, 2015 at 12:27:04PM +0900, tony.cho wrote: On 2015년 07월 30일 20:56, Sudip Mukherjee wrote: On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling

[PATCH 3/3] iwlwifi: pcie: fix stuck queue detection for sleeping clients

2015-07-30 Thread Emmanuel Grumbach
The stuck queue detection mechanism allows to detect queues that are stuck. For sleeping clients, a queue may rightfully be stuck: if a poor client implementation stays asleep for more than 10s, then we don't want to trigger recovery flows because of that client. In order to cope with this, I

[PATCH 2/3] iwlwifi: mvm: Fix regular scan priority

2015-07-30 Thread Emmanuel Grumbach
From: Avraham Stern avraham.st...@intel.com The code checks the total number of iterations to differentiate between regular scan and scheduled scan. However, regular scan has a total of one iteration, not zero. As a result, regular scan will have lower priority than it should have, and in case

[PATCH 1/3] iwlwifi: pcie: fix prepare card flow

2015-07-30 Thread Emmanuel Grumbach
When the card is not owned by the PCIe bus, we need to acquire ownership first. This flow is implemented in iwl_pcie_prepare_card_hw. Because of a hardware bug, we need to disable link power management before we can request ownership otherwise the other user of the device won't get notified that

Re: [PATCH 0/5] 2nd patch for illegal coding style

2015-07-30 Thread Greg KH
On Thu, Jul 30, 2015 at 06:10:09PM +0900, Tony Cho wrote: This patch V2 includes only patches rejected. The rejected patch for the following, #ifdef conditionals cover entire functions, introduced new error on required space before the open parenthesis '('. This is my mistake while rewriting

Re: [PATCH] Staging:wilc1000 :Remove braces for single statement blocks

2015-07-30 Thread Vaishali Thakkar
On 31 Jul 2015 10:49, Shraddha Barke shraddha.6...@gmail.com wrote: This patch fixes the following checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks There should be one line space between your commit log and Signed-off-by line. Signed-off-by: Shraddha

[PATCH] Staging : wilc1000 :Remove typedef from struct

2015-07-30 Thread Shraddha Barke
This patch fixes the following checkpatch.pl warning: WARNING: do not add new typedefs Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] Staging:wilc1000 :Remove typedef from struct

2015-07-30 Thread Shraddha Barke
This patch fixes the following checkpatch.pl warning: WARNING: do not add new typedefs Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] Staging : wilc1000 :Remove typedef from struct

2015-07-30 Thread Joe Perches
On Fri, 2015-07-31 at 11:02 +0530, Shraddha Barke wrote: This patch fixes the following checkpatch.pl warning: WARNING: do not add new typedefs Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] Staging:wilc1000 :Remove braces for single statement blocks

2015-07-30 Thread Shraddha Barke
This patch fixes the following checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH] Staging: wilc1000 :Insert blank line after declaration

2015-07-30 Thread Shraddha Barke
This patch fixes the following checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] b43: fix extpa_gain check for 2GHz

2015-07-30 Thread Rafał Miłecki
On 30 July 2015 at 07:40, Kalle Valo kv...@codeaurora.org wrote: Hauke Mehrtens ha...@hauke-m.de writes: On the 2GHz and and on the 5GHZ band only the extpa_gain setting from the 5GHz band was checked. this patch makes it check the property from the correct band. Signed-off-by: Hauke

Re: [PATCH] b43: fix extpa_gain check for 2GHz

2015-07-30 Thread Hauke Mehrtens
On 07/30/2015 08:54 AM, Rafał Miłecki wrote: On 30 July 2015 at 07:40, Kalle Valo kv...@codeaurora.org wrote: Hauke Mehrtens ha...@hauke-m.de writes: On the 2GHz and and on the 5GHZ band only the extpa_gain setting from the 5GHz band was checked. this patch makes it check the property from

[no subject]

2015-07-30 Thread Grumbach, Emmanuel
ds dsa -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

pull request: iwlwifi 2015-07-30

2015-07-30 Thread Grumbach, Emmanuel
Hi Kalle, Here is another pull request for 4.2. Three small fixes this time. Let me know if you have any issues. Note that my availability will be limited next week, and the week after I'll be completely offline. Thanks! The following changes since commit

[PATCH v3 04/19] wil6210: use vs. for global include

2015-07-30 Thread Vladimir Kondratiev
linux/device.h should be included using , not since it is not local include Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/wil_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 01/19] wil6210: support boot loader struct v0 v1

2015-07-30 Thread Vladimir Kondratiev
There are 2 versions of boot loader struct: v0 and v1. In the v1, boot loader build version added; as well as RF status. Support both versions. Boot loader structure v1 has RF status; ignore RF error if firmware not going to be loaded; driver can still be used to interact with the HW

[PATCH v3 00/19] wil6210 patches

2015-07-30 Thread Vladimir Kondratiev
Several new features introduced: - TSO improves throughput on Tx side on systems with weak CPU - ACS chooses best channel automatically when starting AP - support for the new boot loader Bug fixes: - wait for del_station to complete - hold wil-mutex while managing vrings The rest are small fixes

[PATCH v3 02/19] wil6210: count drops in Rx block ack reorder

2015-07-30 Thread Vladimir Kondratiev
When performing Rx reordering, count skb's dropped per reorder buffer; and print dropped packets count on the stations debugfs entry Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/debugfs.c| 2 +-

[PATCH v3 10/19] wil6210: treat unhandled event as warning instead of error

2015-07-30 Thread Vladimir Kondratiev
From: Dedy Lansky qca_dlan...@qca.qualcomm.com FW is allowed to generate WMI events that are not handled by this driver. Treat such case as warning instead of error. Signed-off-by: Dedy Lansky qca_dlan...@qca.qualcomm.com Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com ---

[PATCH v3 16/19] wil6210: allow to handle Rx on 2 cores

2015-07-30 Thread Vladimir Kondratiev
From: Vladimir Shulman qca_shulm...@qca.qualcomm.com Allow network stack part of Rx processing to run on separate core, relaxing CPU utilization on the core used for Rx NAPI. If RXHASH feature is enabled, the driver sets rxhash of each skb to 1 to enable RPS. The core for processing the rx skb

[PATCH v3 17/19] wil6210: system power management

2015-07-30 Thread Vladimir Kondratiev
Support for the system suspend/resume. In preparation for the run-time PM, implementation made run-time PM friendly: common for system and run-time PM code factored out as generic functions, albeit is_runtime parameter value is always false currently. For debug purposes, PM debug category

[PATCH v3 15/19] wil6210: use inline functions for register access

2015-07-30 Thread Vladimir Kondratiev
Replace macros like R, W, S, C, defined multiple times, with inline functions wil_[rwsc]. Use readl and writel instead of ioread32 and iowrite32 since it is granted that memory transactions are used, not port ones like IN/OUT Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com ---

[PATCH v3 19/19] wil6210: support future boot loaders

2015-07-30 Thread Vladimir Kondratiev
Boot loader versions as backward compatible, starting from v1 Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/main.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git

[PATCH v3 06/19] wil6210: use wil_fw_error_recovery()

2015-07-30 Thread Vladimir Kondratiev
Use function wil_fw_error_recovery() instead of inline equivalent code Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/main.c

[PATCH v3 08/19] wil6210: TSO implementation

2015-07-30 Thread Vladimir Kondratiev
Driver report supported TSO (v4 v6) and IP checksum offload in addition to previously supported features. In data path skbs are checked for non-zero gso_size, and when detected sent to additional function for processing TSO SKBs. Since HW does not fully support TSO, additional effort is required

[PATCH v3 13/19] wil6210: detailed statistics for Rx reorder drop

2015-07-30 Thread Vladimir Kondratiev
Rx drops may be for 2 reasons: frame is old, or it is duplicate. On the debugfs stations entry, provide counters per reorder buffer for total frames processed, drops for these 2 reasons. Also add debug print for dropped frames. Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com ---

[PATCH v3 03/19] wil6210: print ulong fields in hex format in the debugfs

2015-07-30 Thread Vladimir Kondratiev
In the debugfs, there is ulong attribute printing. It is used for bitmap printing, and more appropriate format would be hexadecimal, not decimal. Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/debugfs.c | 2 +- 1 file changed, 1

[PATCH v3 11/19] wil6210: sort IEs handling

2015-07-30 Thread Vladimir Kondratiev
sort overall IE's handling prepare code (disabled for now) to add IEs for the beacon Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/cfg80211.c | 78 +++-- 1 file changed, 29 insertions(+), 49 deletions(-) diff --git

[PATCH v3 18/19] wil6210: report boot loader error

2015-07-30 Thread Vladimir Kondratiev
Boot loader reports error starting from the struct v2. Print error info before reset (power up state) in debug mode, and print same info as error if target reset timed out. Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/boot_loader.h | 5

[PATCH v3 12/19] wil6210: unify wmi_set_ie() error handling

2015-07-30 Thread Vladimir Kondratiev
When printing error message, provide string describing IE kind. Derive it from IE type This allows removing of error messages printing in callers Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/cfg80211.c | 29 -

[PATCH v3 05/19] wil6210: wait for del_station to complete

2015-07-30 Thread Vladimir Kondratiev
Multiple del_station requests may be sent to the driver by the supplicant when turning down AP. This may overflow mailbox between the FW and ucode Wait till disconnect of one STA completed before sending next command. Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com ---

[PATCH v3 07/19] wil6210: skip HW version check for chip debugging

2015-07-30 Thread Vladimir Kondratiev
When loading with debug_fw flag, do not bail out on unknown chipId Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/main.c

[PATCH v3 14/19] wil6210: remove 3-MSI support

2015-07-30 Thread Vladimir Kondratiev
In the recent kernel versions, multiple MSI is not well supported. In particular, it is not supported on x86 and ARM architectures. Also, internal interrupt handling logic is simpler and more effective when using single interrupt. Remove support for 3 MSI, convert module parameter use_msi from

[PATCH v3 09/19] wil6210: improve mgmt frame handling

2015-07-30 Thread Vladimir Kondratiev
Check event length; hex dump both Rx and Tx frames Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com --- drivers/net/wireless/ath/wil6210/wmi.c | 54 +++--- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip

2015-07-30 Thread Paul Bolle
On wo, 2015-07-29 at 14:15 +0200, Robert Baldyga wrote: --- /dev/null +++ b/drivers/nfc/s3fwrn5/Kconfig @@ -0,0 +1,22 @@ +config NFC_S3FWRN5 + tristate Samsung S3FWRN5 NFC driver + depends on NFC_NCI + default n + ---help--- + Core driver for Samsung S3FWRN5 NFC

[PATCH 0/5] 2nd patch for illegal coding style

2015-07-30 Thread Tony Cho
This patch V2 includes only patches rejected. The rejected patch for the following, #ifdef conditionals cover entire functions, introduced new error on required space before the open parenthesis '('. This is my mistake while rewriting codes. The original 13th patch didn't include new fix

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Johnny Kim
Your patch has wrong sentence. Please remove --- ASCHI Loot at below line. On 2015년 07월 30일 18:10, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than

[PATCH V2 5/5] staging: wilc1000: remove unused functions

2015-07-30 Thread Tony Cho
This patch removes the dead functions which are not used anymore. - sdio_check_bs - sdio_xfer_cnt Signed-off-by: Tony Cho tony@atmel.com --- V2: This patch doesn't have any difference with the first patch becasue this patch just removes unnecessary functions. However, it is

[PATCH V2 3/5] staging: wilc1000: remove warnings on missing blank line

2015-07-30 Thread Tony Cho
This patch removes the warnings reported by checkpatch.pl on missing a blank line after declarations. Signed-off-by: Tony Cho tony@atmel.com --- V2: This patch doesn't have a difference with the first one. However, it's resent becasue not accepted with the 9th patch. ---

[PATCH V2 4/5] staging: wilc1000: remove errors on required space

2015-07-30 Thread Tony Cho
This patch removes the errors reported by checkpatch.pl, which is the space required before the open parenthesis '('. Signed-off-by: Tony Cho tony@atmel.com --- V2: This patch is not different with the first one. This patch includes warnings on no space required before the open parenthesis in

[PATCH V2 2/5] staging: wilc1000: remove unnecessary blank lines

2015-07-30 Thread Tony Cho
This patch removes the following warnings reported by checkpatch.pl. - Blank lines aren't necessary after an open brace '{' - Blank lines aren't necessary before a close brace '}' Signed-off-by: Tony Cho tony@atmel.com --- V2: This patch doesn't have a difference with the first one but resent

[PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Tony Cho
This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions of functions or expressions becausue doing so makes code harder to read. Signed-off-by: Tony Cho