I'm running kernel 4.2.0-rc3 with the following patches to the mwifiex
driver, thanks to your advice.
> Do you have following USB chipset specific fixes included?
> http://www.spinics.net/lists/linux-wireless/msg129129.html
> http://www.spinics.net/lists/netdev/msg334367.html
I've recently notic
If firmware did not have any feature flags set the
var would be left with values found on the stack
(i.e. garbage) yielding print string like this:
(...) features \xffa6m:^R\xfffbԂ\xffc4^E
Fixes: b27bc5a40f91 ("ath10k: dump fw features during probing")
Signed-off-by: Michal Kazior
From: "Luis R. Rodriguez"
The firmware API has evolved over the years slowly, as it
grows we extend it by adding new routines or at times we extend
existing routines with more or less arguments. This doesn't scale
well, when new arguments are added to existing routines it means
we need to travers
On Tuesday 04 Aug 2015 à 18:11:29 (+), Chor Teck Law wrote:
Hi Chor,
> mwl8k was a driver for chips few generations older sponsored by
> Marvell. We did leverage part of driver framework that is still
> applicable. However, for the current development, the firmware API
> specs, chip capabili
On Tuesday 04 Aug 2015 à 20:02:23 (+0300), Kalle Valo wrote:
> I haven't looked at the driver myself yet. Do you have any estimates how
> much duplication there is?
ok the thing is I happen to know a bit about the chipset internals and
so it's easy for me to know that having a common driver is d
From: Johannes Berg
There's no need to forward RX MPDUs to notification wait tests, nor
do we need to check them for firmware dump triggers, nor could they
be asynchronous. It's thus more efficient to handle them separately,
before going into the regular RX handlers.
Signed-off-by: Johannes Berg
From: Johannes Berg
With the previous patch series, no opmode continues using the
command or handler_status (i.e. the return value from the RX)
so it can be removed now.
Signed-off-by: Johannes Berg
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/dvm/agn.h | 5 ++---
The new locking in PCIe transport requires to start_hw
before start_fw. This uncovered a bug in dvm which failed
to do so.
Fix that.
Reviewed-by: Johannes Berg
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/dvm/mac80211.c | 12
1 file changed, 12 insertions(+)
d
From: Eliad Peller
This reverts commit 088070a2f6575402d3dd82e1c5a4a8e1941805f6.
When working in d0i3_on_idle mode, we explicitly go out
of d0i3 on resume (so other potential commands could
be sent).
However, D0I3_DEFER_WAKEUP is currently cleared on
resume complete (which happens only later on
From: Johannes Berg
Existing UMAC commands already use the long header, but are sent
with group 0 and the long header inserted manually. Move them to
the group 1 to take advantage of the header building in the low-
level transport.
Existing firmware ignores the group_id field (it's reserved) and
From: Eliad Peller
Some CSR registers have to be configured also
in case of suspend/resume with unified image
(which doesn't includes reconfiguration flow).
Reuse the existing d3_suspend/d3_resume trans ops,
while making sure some configurations are a bit
different, according to the wowlan type.
From: Johannes Berg
Move the TX PN assignment (for CCMP only) to the driver. This prepares
the driver for future DSO (driver segmentation offload) where it will
split an SKB into multiple MPDUs by itself.
For TDLS, split out the CCMP TX command handling so that it won't get
a PN assigned, the fi
From: Haim Dreyfuss
During NIC initialization shared HW is reset and this disables the
scheduler. Some HW platforms do not activate the scheduler after it.
Consequently all HCMD sent by the driver stay at the queues which cause
to queue stuck.
Set the scheduler to work on auto active mode so it w
In a few places, we were disabling interrupts but didn't
make sure that the interrupt handler has finished running.
Add calls to synchronize_irq() to ensure we finish handling
the interrupts before we free resources or other things that
could lead to a crash if the interrupt were to be handled
late
From: Ilan Peer
Since the time-event is sent with the immediate flag set, there is
no need to sample the device time.
Signed-off-by: Ilan Peer
Reviewed-by: Johannes Berg
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/time-event.c | 3 +--
1 file changed, 1 insertion(+)
From: Johannes Berg
The current key offset assignment algorithm always uses the lowest
unused key offset, which will potentially lead to issues when the
firmware will change to take the key material for TX from the key
table rather than from the TX command.
In order to avoid those issues (and av
From: Avraham Stern
Add support for extended firmware event header that contains
a group id as well as the command id.
Signed-off-by: Avraham Stern
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/ops.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --
From: Ilan Peer
In iwl_mvm_tx_skb_non_sta(), in case of managed interface,
use the AP station for multicast frames instead of the auxiliary
station as otherwise the frames can be sent to an absent P2P GO as
the FW does not block transmissions for the auxiliary station
since it is not associated w
From: Eliad Peller
Allow the transport layer to return an error upon suspend.
Signed-off-by: Eliad Peller
Reviewed-by: Luciano Coelho
Reviewed-by: Johannes Berg
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/iwl-trans.h | 10 ++
drivers/net/wireless/iwlwifi/mvm/d3
From: Johannes Berg
The 'flags' field really has been reserved in the firmware API for a
very long time, probably since 4965. As a consequence, the field is
always 0 and checking for a IWL_CMD_FAILED_MSK flag makes no sense.
Rename the field to 'reserved', get rid of IWL_CMD_FAILED_MSK and
all t
From: David Spinadel
Remove outdated and unused definitions
Signed-off-by: David Spinadel
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/fw-api-scan.h | 129 -
1 file changed, 129 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/fw-api
From: Nicholas Krause
This makes various functions in the file rs.c void due to these
functions never returning a error code to signal to their callers
if and how they have failed to complete their intended work.
Signed-off-by: Nicholas Krause
Signed-off-by: Emmanuel Grumbach
---
drivers/net/
From: Sara Sharon
Add support for extended command id in notification system.
Extended command id header contains group id in addition to command id.
Signed-off-by: Sara Sharon
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/dvm/mac80211.c | 2 +-
drivers/net/wireless/iwlw
From: Johannes Berg
This makes the logging a little less useful, but as they're mostly
synchronous commands it won't matter much. It gets rid of the
dependency on the input command, which this is the only user of.
Signed-off-by: Johannes Berg
Signed-off-by: Emmanuel Grumbach
---
drivers/net/w
From: Sara Sharon
Add support for extended command id in triggers handling.
Extended command id header contains group id in addition to command id.
Signed-off-by: Sara Sharon
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/ops.c | 7 ---
1 file changed, 4 insertions(
From: Eliad Peller
Since the CSR_DRAM_INIT_TBL_WRITE_POINTER bit wasn't set
on ict reset, in some flows (like disable ict followed by
immediate reset ict) the driver and hardware went out
of sync (the driver cleared the ict_index, while the hw
kept it intact).
Fix it by setting the flag when res
From: Avri Altman
Signed-off-by: Avri Altman
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/mvm.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/mvm.h
b/drivers/net/wireless/iwlwifi/mvm/mvm.h
index d78af9f..767880b
From: Gregory Greenman
CQM overwrites a few thresholds in the bf command. On the other hand,
when entering D0i3 the thresholds are set to higher values on purpose,
so ignore CQM in this case.
Signed-off-by: Gregory Greenman
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm
From: Johannes Berg
This driver currently has some very confusing ADD_STA response handling
that runs asynchronously in the background for all of the commands, but
is only really necessary for synchronous ones (the really asynchronous
ones can only be done for already existing stations), and for
From: Sara Sharon
All the supported firmwares support this API.
This includes removing dwell per band, as band is no longer a factor
in calculating the dwell. Only basic dwell is used and FW will calculate
the actual dwell time.
Signed-off-by: Sara Sharon
Signed-off-by: Emmanuel Grumbach
---
From: Gregory Greenman
The slow filtering threshold should be higher in D0i3 case.
Signed-off-by: Gregory Greenman
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/fw-api-power.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlw
When the firmware crashes, we can't expect the Tx queues to
progress. Cancel their timer.
Reviewed-by: Johannes Berg
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/pcie/rx.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/iwlwifi/pcie/rx.c
b/driv
From: Haim Dreyfuss
The firmware debug infrastructure allows the user to
provide a firmware that will toggle a few registers to
configure the debugging capabilities.
On certain devices, certain operations are forbidden.
Executing a forbidden operation will cause the hardware to
die in a way that
From: Johannes Berg
In the mvm driver, neither the old command nor the return value
are used, so remove them.
Signed-off-by: Johannes Berg
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/coex.c| 44 +-
drivers/net/wireless/iwlwifi/mvm/coex_legacy.c | 31
From: Aviya Erenfeld
As the firmware is slowly running out of command IDs and grouping of
commands is desirable anyway, the firmware is extending the command
header from 4 bytes to 8 bytes to introduce a group (in place of the
former flags field, since that's always 0 on commands and thus can
be
In iwlmvm firmwares, the Byte count written in the scheduler
byte count table is in DWORDs and not in bytes.
We should check that this value fits in the 12 bits and
the value can be either in bits of in DWORD or bytes
depending on the firmware. Check the value after the
translation to DWORDs is don
This allows to ensure that we don't have races between them.
A user reported that stop_device was called twice upon
rfkill interrupt after suspend. When the interrupts are
enabled, and right after when we directly check the rfkill
state.
Reviewed-by: Johannes Berg
Signed-off-by: Emmanuel Grumbach
From: Avri Altman
TCP software implementation on the host requires extensive computing
power. Offloading even some of the TCP/IP stack to the NIC might save
a significant overhead. In order to enable this feature on our hw,
we need to configure it first. Once done, we mark this capability,
to be
From: Sara Sharon
This firmware is not supported anymore - stop loading this firmware.
Remove code handling older versions.
Signed-off-by: Sara Sharon
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/iwl-7000.c | 2 +-
drivers/net/wireless/iwlwifi/iwl-8000.c | 2 +-
drivers/n
From: Gregory Greenman
ToF is a time based method for measurement of the WiFi device
location within a WiFi environment. The driver functionality provided
by this patch is the interface for communication with FW and receiving
location related updates from the FW. The interface provided by this
pa
From: Johannes Berg
After the previous patches, the command that's passed in nor the
return value are used any more, so can be removed.
While at it, make some functions static.
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/dvm/agn.h | 14 ++---
drivers/net/wireless/iwlwi
From: Eyal Shapira
In scenarios where we haven't converged yet to a specific modulation
and rate it could be better to report to userspace the last tx rate
based on the STA capabilities and RSSI. This is important as sometimes
userspace displays the last tx rate as the link speed.
This avoids bei
Hi Kalle,
It comes late, but this is the first pull request for 4.3.
I have quite a bit for the next one that will come after this one.
Please pull - thanks!
emmanuel
The following changes since commit e0456717e483bb8a9431b80a5bdc99a928b9b003:
Merge git://git.kernel.org/pub/scm/linux/kernel/
The Linux kernel coding style guidelines suggest not using typedefs for
structure and enum types. This patch gets rid of the typedefs for
Ack_session_info_t.
The following Coccinelle semantic patch detects the cases for struct type:
@tn@
identifier i;
type td;
@@
-typedef
struct i { ... }
-td
On Tue, Aug 4, 2015 at 5:30 AM, Amitkumar Karwar wrote:
> From: chunfan chen
>
> We will check if any hidden SSID found in passive scan channels
> and do specific SSID active scan for those channels.
>
> Signed-off-by: chunfan chen
> Signed-off-by: Amitkumar Karwar
> ---
> v2: Corrected hidden
Hi Kalle,
> -Original Message-
> From: Kalle Valo [mailto:kv...@codeaurora.org]
> Sent: Tuesday, August 04, 2015 10:02 AM
>
> Maxime Bizon writes:
>
> > On Fri, 2015-07-03 at 06:10 +, David Lin wrote:
> >
> > Hello,
> >
> >> The Linux driver for WRT1900AC. The work was initially dev
Maxime Bizon writes:
> On Fri, 2015-07-03 at 06:10 +, David Lin wrote:
>
> Hello,
>
>> The Linux driver for WRT1900AC. The work was initially developed as
>> part of openwrt effort and maintained on
>> https://github.com/kaloz/mwlwifi.
>
> I see *massive* code duplication with the mwl8k drive
Hi Dave,
here are few small fixes I would like to get to 4.2. Please let me know
if there are any problems.
Kalle
The following changes since commit df2cd4586f177acf9493dee079fc7d18268c5f54:
Merge tag 'iwlwifi-for-kalle-2015-06-12' of
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/i
On Tue, Aug 04, 2015 at 09:31:58AM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 4, 2015 at 2:34 AM, Seth Forshee
> wrote:
> > On Thu, Jul 23, 2015 at 11:32:59AM +0800, Chen-Yu Tsai wrote:
> >> The FCC increased the maximum conducted transmission power for the
> >> U-NII-1 (5150 ~ 5250 MHz) band to 30
On Tue, Aug 04, 2015 at 09:55:06AM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 4, 2015 at 9:26 AM, Chen-Yu Tsai wrote:
> > On Tue, Aug 4, 2015 at 2:27 AM, Seth Forshee
> > wrote:
> >> On Thu, Jul 23, 2015 at 11:32:56AM +0800, Chen-Yu Tsai wrote:
> >>> Taiwan's Ministry of Transportation and Communi
From: Zhaoyang Liu
This patch adds support for 8997 chipset to mwifiex
with SDIO/PCIe/USB interface.
The corresponding firmware image files are located in:
"mrvl/sd8997_uapsta.bin"
"mrvl/pcie8997_uapsta.bin"
"mrvl/usb8997_uapsta.bin"
Signed-off-by: Zhaoyang Liu
Signed-off-by: Cathy Luo
Signed
From: Zhaoyang Liu
This patch adds firmware dump feature for SD8997 chipset.
The difference here is only one memory type is needed
to save all firmware information. Device dump information
will be uploaded to usersapace file.
Signed-off-by: Zhaoyang Liu
Signed-off-by: Cathy Luo
Signed-off-by:
From: chunfan chen
We will check if any hidden SSID found in passive scan channels
and do specific SSID active scan for those channels.
Signed-off-by: chunfan chen
Signed-off-by: Amitkumar Karwar
---
v2: Corrected hidden SSID detection logic as per Paul Stewart's comment.
---
drivers/net/wire
On Tue, Aug 4, 2015 at 2:48 PM, Emmanuel Grumbach wrote:
> On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko
> wrote:
>> On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote:
>>> There is no need to use hex_dump_to_buffer() in the cases like this:
>>>
>>> hexdump_to_buffer(buf, len, 16, 1
On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko
wrote:
> On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote:
>> There is no need to use hex_dump_to_buffer() in the cases like this:
>>
>> hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); > /*
>> len <= 16
>> */
>> s
On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote:
> There is no need to use hex_dump_to_buffer() in the cases like this:
>
> hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); > /*
> len <= 16
> */
> sprintf("%s\n", outbuf);
>
> since it maybe easily converted t
Ting-Chih Hsiao writes:
> remove spaces at the start of a line
> align enum variable with other parameters
>
> Signed-off-by: Ting-Chih Hsiao
Acked-by: Jes Sorensen
> ---
> drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --g
The current code returns success if kmalloc fails.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/wireless/mwifiex/usb.c
b/drivers/net/wireless/mwifiex/usb.c
index fbad99c..f866d5d 100644
--- a/drivers/net/wireless/mwifiex/usb.c
+++ b/drivers/net/wireless/mwifiex/usb.c
@@ -870,8 +870,10
58 matches
Mail list logo
