On Sun, Aug 16, 2015 at 01:30:12AM -0400, Raphaël Beamonte wrote:
#define MALLOC_WILC_BUFFER(name, size) \
- exported_ ## name = kmalloc(size, GFP_KERNEL);\
- if (!exported_ ## name) { \
- printk(fail to alloc: %s memory\n, exported_ ## name); \
-
Vasanthakumar Thiagarajan vthia...@qti.qualcomm.com writes:
There are three WMI_CHAN_INFO events reported per channel
in QCA99X0 firmware. First one is a notification at the begining
of the channel dwell time with cmd_flag as CHAN_INFO_START(cmd_flag = 0),
second one is a notification at the
Michal Kazior michal.kaz...@tieto.com writes:
Once HTT Tx queue got full offchannel queue was
stopped and never woken up again. This broke, e.g.
P2P. This could be reproduced after running a lot
of traffic enough to saturate 100% of the driver
Tx queue and then trying to send offchannel
Hi,
On Friday 10 April 2015 16:32:29 Ben Greear wrote:
First, thanks to everyone that helped me with questions,
QCA/Tieto's upstream patches, etc.
This needs more testing, but it appears to at least mostly work.
I am using this 4.0 related kernel. I think only the last 3 patches
are
Vasanthakumar Thiagarajan vthia...@qti.qualcomm.com writes:
WMI 10.4 uses the same command interface as QCA988X for addba/delba
debug wmi commands. Fill wmi_10_4_ops table with the functions used
for QCA988X for these commands.
With this change, the following debugfs entries can be used to
2015-08-17 5:08 GMT-04:00 Dan Carpenter dan.carpen...@oracle.com:
Pull it in one indent level... But actually this macro has a return in
the middle of it, so it just introduces bugs all over the place like
eating cookies in bed. We should just delete it instead.
You're right!
I'll clean
Raja Mani rm...@qti.qualcomm.com writes:
Existing phyerr event handlers directly uses phyerr header format
(ie, struct wmi_phyerr and struct wmi_phyerr_event) in the code
exactly on how firmware packs it. This is the problem in 10.4 fw
specific phyerr event handling where it uses different
On 17 August 2015 at 10:01, Arend van Spriel ar...@broadcom.com wrote:
On 08/16/2015 05:10 PM, Rafał Miłecki wrote:
On 16 August 2015 at 08:55, Arend van Spriel ar...@broadcom.com wrote:
This series comprises of following changes:
- support NVRAM loading for bcm47xx platform.
- revise
WILC_ErrNo is replaced by s32, then WILC_ErrNo typedef is removed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_errorsupport.h | 2 --
drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++--
drivers/staging/wilc1000/wilc_msgqueue.h | 8
This patch uses -EINVAL for invalid argument checking instead of using
WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The macros inside wilc_osconfig.h are not referenced anywhere,
so just delete it.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_osconfig.h | 9 -
drivers/staging/wilc1000/wilc_oswrapper.h | 1 -
2 files changed, 10 deletions(-)
delete mode 100644
The macros in wilc_log.h are not referenced anywhere, so just delete it.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_log.h | 47 ---
drivers/staging/wilc1000/wilc_oswrapper.h | 2 --
2 files changed, 49 deletions(-)
rtl92c_set_xxx_filter is same routine with rtl92cu_set_hw_reg.
so i remove those functions that are rtl92c_set_xxx_filter.
(rtl92c_get_xxx_filter is also same reason.)
also i add code updating struct rtl_mac member variable in the
rtl92cu_set_hw_reg.
after that, no more _update_mac_setting
Hi,
The first 3 patches of the following 5 are aimed to simplify the
wilc_exported_buf.c macros as well as correct a potential memory
leak from the use of the MALLOC_WILC_BUFFER one.
The next 2 patches are correcting two kind of checkpatch warning
reports in different files of the wilc1000
On Mon, Aug 17, 2015 at 12:08:36PM -0400, Raphaël Beamonte wrote:
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8 +++
drivers/staging/wilc1000/linux_wlan_common.h |
On Mon, Aug 17, 2015 at 01:59:44PM -0400, Raphaël Beamonte wrote:
2015-08-17 13:47 GMT-04:00 Dan Carpenter dan.carpen...@oracle.com:
- printk([Sendconfigpkt]Get Timed out\n);
+ pr_debug([Sendconfigpkt]Get Timed out\n);
Possibly
2015-08-17 13:47 GMT-04:00 Dan Carpenter dan.carpen...@oracle.com:
- printk([Sendconfigpkt]Get Timed out\n);
+ pr_debug([Sendconfigpkt]Get Timed out\n);
Possibly pr_err()?
Yep. My mistake. I'll do the same for Set Timed Out also!
-
On 08/17/2015 06:11 AM, Sven Eckelmann wrote:
Hi,
On Friday 10 April 2015 16:32:29 Ben Greear wrote:
First, thanks to everyone that helped me with questions,
QCA/Tieto's upstream patches, etc.
This needs more testing, but it appears to at least mostly work.
I am using this 4.0 related
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/host_interface.c| 4
drivers/staging/wilc1000/linux_wlan.c| 1 -
drivers/staging/wilc1000/wilc_exported_buf.c | 2 --
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
On Mon, 2015-08-17 at 09:48 +0800, Fu, Zhonghui wrote:
The suspend/resume timing of wiphy device and related devices will be
ensured by their parent/child relationship. So, enabling wiphy device
to suspend/resume asynchronously does not change any dependency. It
can only take advantage
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h | 28 ++--
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/host_interface.c| 4
drivers/staging/wilc1000/linux_wlan.c| 1 -
drivers/staging/wilc1000/wilc_exported_buf.c | 4 +---
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
On Mon, Aug 17, 2015 at 10:44:28PM +0900, Chaehyun Lim wrote:
The macros in wilc_log.h are not referenced anywhere, so just delete it.
Oops, I just did this same thing before I saw your email, sorry about
that.
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-wireless
On Mon, Aug 17, 2015 at 10:44:31PM +0900, Chaehyun Lim wrote:
This patch uses -EINVAL for invalid argument checking instead of using
WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1
On Mon, Aug 17, 2015 at 03:28:29PM -0400, Raphaël Beamonte wrote:
It was just a wrapper around kfree(), so call that instead.
Someone else already did this, sorry.
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
It was just a wrapper around kfree(), so call that instead.
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
Hi,
Following comments from Dan Carpenter, please find the following
revised patches.
Raphaël
Raphaël Beamonte (5):
staging: wilc1000: remove void function return statements that are not
useful
staging: wilc1000: use pr_* instead of printk
staging: wilc1000: remove
On 08/17/2015 09:28 PM, Raphaël Beamonte wrote:
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
Probable MACRO_WILC_BUFFER should be MALLOC_WILC_BUFFER here.
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations.
On Mon, Aug 17, 2015 at 03:28:27PM -0400, Raphaël Beamonte wrote:
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h |
From: Johannes Berg johan...@sipsolutions.net
Date: Fri, 14 Aug 2015 17:54:36 +0200
And, in addition to the fix before, I have a -next pull request. It's
actually quite big since I hadn't wanted to send one just before my
vacation.
Let me know if there are any issues.
Pulled, thanks
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/wilc_exported_buf.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git
+ Rafael
On 08/17/2015 09:29 AM, Johannes Berg wrote:
On Mon, 2015-08-17 at 09:48 +0800, Fu, Zhonghui wrote:
The suspend/resume timing of wiphy device and related devices will be
ensured by their parent/child relationship. So, enabling wiphy device
to suspend/resume asynchronously does not
35 matches
Mail list logo
