[PATCH 12/18] staging: wilc1000: remove useless comment

This patch removes useless comment that is containing "Bug" Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 14 -- drivers/staging/wilc1000/linux_mon.c | 2 -- drivers/staging/wilc1000/linux_wlan.c

[PATCH 04/18] staging: wilc1000: remove blank line after an open brace '{'

This patch removes blank line after an open brace '{' found by checkpatch.pl. CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 03/18] staging: wilc1000: fix NULL comparison style

This patch fixes NULL comparison style found by checkpatch.pl. CHECK: Comparison to NULL could be written "!net" CHECK: Comparison to NULL could be written "!net->ieee80211_ptr" CHECK: Comparison to NULL could be written "!net->ieee80211_ptr->wiphy" Signed-off-by: Chaehyun Lim

[PATCH 02/18] staging: wilc1000: rename WILC_WFI_WiphyRegister

This patch replaces WILC_WFI_WiphyRegister with wilc_create_wiphy to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--

[PATCH 06/18] staging: wilc1000: replace PRINT_D with netdev_info

This patch replaces PRINT_D with netdev_info in wilc_free_wiphy function. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 18/18] staging: wilc1000: rename WILC_WFI_InitHostInt

This patch replaces WILC_WFI_InitHostInt with wilc_init_host_int to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-

[PATCH 16/18] staging: wilc1000: replace s32 with int

This patch changes date type of s32Error as int. The return type of WILC_WFI_InitHostInt and WILC_WFI_DeInitHostInt is int so that data type of this variable is changed by int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1

[PATCH 13/18] staging: wilc1000: wilc_msgqueue.c: replace s32RetStatus with result

This patch replaces s32RetStatus with result to avoid CamelCase in wilc_msgqueue.c Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH 05/18] staging: wilc1000: remove blank line before a close brace '{'

This patch removes blank line before a close brace '{' found by checkpatch.pl CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 07/18] staging: wilc1000: replaces PRINT_D with netdev_err

This patch replaces PRINT_D with netdev_err which is used at error checking. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 17/18] staging: wilc1000: rename WILC_WFI_DeInitHostInt

This patch replaces WILC_WFI_DeInitHostInt with wilc_deinit_host_int to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-

[PATCH 14/18] staging: wilc1000: remove useless #if 1

This patch removes #if 1, which is encapsulated some codes. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 drivers/staging/wilc1000/wilc_wlan.c | 2 -- drivers/staging/wilc1000/wilc_wlan_cfg.c | 2 -- 3

[PATCH 11/18] staging: wilc1000: rename WILC_WFI_set_cqm_rssi_config

This patch replaces WILC_WFI_set_cqm_rssi_config with set_cqm_rssi_config to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 01/18] staging: wilc1000: rename WILC_WFI_WiphyFree

This patch replaces WILC_WFI_WiphyFree with wilc_free_wiphy to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-

[PATCH 2/2] staging: wilc1000: rename SendConfigPkt

This patch replaces SendConfigPkt with send_config_pkt to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 4 +- drivers/staging/wilc1000/coreconfigurator.h | 4 +- drivers/staging/wilc1000/host_interface.c | 102

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

On Mon, Sep 21, 2015 at 9:40 AM, Julian Calaby wrote: > Hi Chaehyun, > > > On Mon, Sep 21, 2015 at 10:25 AM, Chaehyun Lim wrote: >> Most of functions use s32Error variable to check error and return its value. >> This patch replaces s32Error with

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

On Mon, Sep 21, 2015 at 9:52 AM, Chaehyun Lim wrote: > On Mon, Sep 21, 2015 at 9:40 AM, Julian Calaby > wrote: >> Hi Chaehyun, >> >> >> On Mon, Sep 21, 2015 at 10:25 AM, Chaehyun Lim >> wrote: >>> Most of functions use

[PATCH 1/2] staging: wilc1000: replace s32Error with result

Most of functions use s32Error variable to check error and return its value. This patch replaces s32Error with result to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 40 +- drivers/staging/wilc1000/host_interface.c

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

Hi Chaehyun, On Mon, Sep 21, 2015 at 10:25 AM, Chaehyun Lim wrote: > Most of functions use s32Error variable to check error and return its value. > This patch replaces s32Error with result to avoid CamelCase. > > Signed-off-by: Chaehyun Lim > ---

Re: [PATCH v2 1/4] staging: wilc1000: fix null check routine

On 2015년 09월 19일 11:50, Greg KH wrote: On Thu, Sep 17, 2015 at 07:02:17PM +0900, Tony Cho wrote: From: Leo Kim This patch removes the potential faults which may happen when unexpectedly getting access to invalid pointer. The pointer of pstrWFIDrv is unlikely to be

[PATCH v2 15/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetBeacon

This patch removes typedef from the struct tstrHostIFSetBeacon and renames it to set_beacon in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 8 insertions(+), 7

[PATCH v2 19/34] staging: wilc1000: remove typedef from the struct tstrHostIfPowerMgmtParam

This patch removes typedef from the struct tstrHostIfPowerMgmtParam and renames it to power_mgmt_param in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH v2 18/34] staging: wilc1000: remove typedef from the struct tstrTimerCb

This patch removes typedef from the tstrTimerCb and renames it to timer_cb in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 30/34] staging: wilc1000: remove typedef from the struct tstrHostIfRegisterFrame

This patch removes typedef from the struct tstrHostIfRegisterFrame and renames it to reg_frame in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 7

[PATCH v2 27/34] staging: wilc1000: remove typedef from the struct tstrHostIfBASessionInfo

This patch removes typedef from the struct tstrHostIfBASessionInfo and renames it to ba_session_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 17 ++---

[PATCH v2 32/34] staging: wilc1000: remove unnecessary global variable

The global variable msgQ_created is removed because it is not necessary. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH v2 31/34] staging: wilc1000: remove typedef from the struct tstrHostIFDelAllSta

This patch removes typedef from the struct tstrHostIFDelAllSta and renames it to del_all_sta in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH v2 23/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetMulti

This patch removes typedef from the struct tstrHostIFSetMulti and renames it to set_multicast in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 17 + 1 file changed, 9 insertions(+), 8

[PATCH v2 24/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetOperationMode

This patch removes typedef from the struct tstrHostIfSetOperationMode and renames it to op_mode in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 4 ++--

[PATCH v2 26/34] staging: wilc1000: remove typedef from the struct tstrHostIfGetMacAddress

This patch removes typedef from the struct tstrHostIfGetMacAddress and renames it get_mac_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 4 ++--

[PATCH v2 29/34] staging: wilc1000: remove typedef from the struct tstrHostIfRemainOnChan

This patch removes typedef from the struct tstrHostIfRemainOnChan and renames it to remain_ch in order to comply with the Linux coding style Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 +--- drivers/staging/wilc1000/host_interface.h | 6

[PATCH v2 25/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetMacAddress

This patch removes typedef from the struct tstrHostIfSetMacAddress and renames it set_mac_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 4 ++--

Re: [PATCH 10/18] staging: wilc1000: rename WILC_WFI_set_power_mgmt

On Sun, Sep 20, 2015 at 03:51:17PM +0900, Chaehyun Lim wrote: > This patch replaces WILC_WFI_set_power_mgmt with set_power_mgmt to avoid > CamelCase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 > 1 file changed,

Re: [PATCH 07/18] staging: wilc1000: replaces PRINT_D with netdev_err

On Sun, Sep 20, 2015 at 03:51:14PM +0900, Chaehyun Lim wrote: > This patch replaces PRINT_D with netdev_err which is used at error > checking. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- > 1 file changed, 3

Re: [PATCH 06/18] staging: wilc1000: replace PRINT_D with netdev_info

On Sun, Sep 20, 2015 at 03:51:13PM +0900, Chaehyun Lim wrote: > This patch replaces PRINT_D with netdev_info in wilc_free_wiphy function. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- > 1 file changed, 2

Re: Ath10K issue

I think anything from https://github.com/kvalo/ath10k-firmware/tree/master/10.2.4/untested should support mgmt-over-htt. Michał On 10 September 2015 at 19:37, Ben Greear wrote: > You probably need a firmware with mgt over htt. CT firmware has this, but > you have to

Re: [PATCH 03/34] staging: wilc1000: rename strHostIFmsg

On 2015년 09월 19일 12:00, Greg KH wrote: On Fri, Sep 18, 2015 at 06:11:05PM +0900, Tony Cho wrote: This patch changes the name, strHostIFmsg simply to msg because the camelcase notation is not recommended in Linux. Signed-off-by: Tony Cho Because of the other patches I

[PATCH v2 34/34] staging: wilc1000: delete unnecessary comments and dead code

The comments in union message_body are not essential and cross 80 ending line, so they are deleted and also a dead code commented out in the union is deleted. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 27 +-- 1 file

[PATCH v2 33/34] staging: wilc1000: remove u32Intialized which is unnecessary

This patch removes the global variable, u32Intialized which is not necessary from the host_interface.c file. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 15 deletions(-) diff --git

[PATCH v2 03/34] staging: wilc1000: rename strHostIFmsg

This patch changes the name, strHostIFmsg simply to msg because the camelcase notation is not recommended in Linux. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 794 +++--- 1 file changed, 397 insertions(+), 397 deletions(-)

[PATCH v2 01/34] staging: wilc1000: rename tstrHostIFmsg

This patch changes the name, tstrHostIFmsg to host_if_msg not to use camelcase notation in the Linux. Signed-off-by: Tony Cho Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/host_interface.c | 294 +++--- 1

[PATCH v2 00/34] resending v2 for the patches of removing typedef

This is the version 2 for the series of the patch that mostly removes the typedef from the structures and renames its names to comply with the Linux coding style. The version 2 is rebased again onto the staging-testing branch to synchronize with the mainstream. Tony Cho (34):

[PATCH v2 02/34] staging: wilc1000: remove typedef from the struct

The Linux kernel coding style does not recommend to use typedef for the structure. This patch removes typedef from the host_if_msg structure. Signed-off-by: Tony Cho Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/host_interface.c

[PATCH v2 10/34] staging: wilc1000: remove typedef from the struct tstrRcvdGnrlAsyncInfo

This patch removes typedef from the struct tstrRcvdGnrlAsyncInfo and renames it to rcvd_async_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH v2 14/34] staging: wilc1000: remove typedef from the struct tstrHostIFGetChan

This patch removes typedef from the struct tstrHostIFGetChan and renames it to get_channel in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v2 11/34] staging: wilc1000: remove typedef from the struct tstrHostIFkeyAttr

This patch removes typedef from the struct tstrHostIFkeyAttr and renames it to key_attr in oder to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

[PATCH v2 12/34] staging: wilc1000: remove typedef from the struct tstrHostIFCfgParamAttr

This patch removes typedef from the struct tstrHostIFCfgParamAttr and renames it to cfg_param_attr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH v2 06/34] staging: wilc1000: rename uniHostIFmsgBody

This patch changes the camelcase notation, uniHostIFmsgBody which is a member variable of structure host_if_msg to body in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 296 +++---

[PATCH v2 04/34] staging: wilc1000: rename u16MsgId

This patch changes the name, u16MsgId simply to id to avoid the camelcase notation. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 102 +++--- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git

[PATCH v2 21/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetIPAddr

This patch removes typedef from the struct tstrHostIFSetIPAddr and renames it to set_ip_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

[PATCH v2 16/34] staging: wilc1000: remove typedef from the struct tstrHostIFDelBeacon

This patch removes typedef from the struct tstrHostIFDelBeacon and renames it to del_beacon in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH v2 17/34] staging: wilc1000: remove typedef from the struct tstrWILC_AddStaParam

This patch removes typedef from the struct tstrWILC_AddStaParam and renames it to add_sta_param in oder to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 37 +--

[PATCH v2 22/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetDrvHandler

This patch removes typedef from the struct tstrHostIfSetDrvHandler and renames it to drv_handler in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 7 --- drivers/staging/wilc1000/host_interface.h | 4

[PATCH v2 08/34] staging: wilc1000: remove typedef from the struct tstrHostIFconnectAttr

This patch removes typedef from the struct tstrHostIFconnectAttr and renames it to connect_attr to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

[PATCH v2 07/34] staging: wilc1000: remove typedef from the struct tstrHostIFscanAttr

This patch removes typedef from the structure tstrHostIFscanAttr and changes the camelcase name, tstrHostIFscanAttr to scan_attr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file

[PATCH v2 09/34] staging: wilc1000: remove typedef from the struct tstrRcvdNetworkInfo

This patch removes typedef from the struct tstrRcvdNetworkInfo and renames it to rcvd_net_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 7 --- drivers/staging/wilc1000/host_interface.h | 6

[PATCH v2 05/34] staging: wilc1000 remove typedef from the union

This patch gets rid of typedef from the union and renames tuniHostIFmsgBody with simply message_body because the Linux coding style does not recommend camelcase notation and typedef for structure, enmu and also union. Signed-off-by: Tony Cho ---

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: > This patch removes function declaration of WILC_WFI_frame_register in > linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file. > > The compilation warning occurs because it is assigned to incorrect > pointer type of second

Re: [PATCH v2 02/34] staging: wilc1000: remove typedef from the struct

On Mon, Sep 21, 2015 at 12:16:31PM +0900, Tony Cho wrote: > The Linux kernel coding style does not recommend to use typedef for the > structure. This patch removes typedef from the host_if_msg structure. > > Signed-off-by: Tony Cho > Signed-off-by: Greg Kroah-Hartman

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On 2015년 09월 21일 11:01, Greg KH wrote: On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: This patch removes function declaration of WILC_WFI_frame_register in linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file. The compilation warning occurs because it is assigned

Re: [PATCH v2 01/34] staging: wilc1000: rename tstrHostIFmsg

On Mon, Sep 21, 2015 at 12:16:30PM +0900, Tony Cho wrote: > This patch changes the name, tstrHostIFmsg to host_if_msg not to use > camelcase notation in the Linux. > > Signed-off-by: Tony Cho > Signed-off-by: Greg Kroah-Hartman Is this already in