Re: [PATCH v2] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-09-22 Thread Fu, Zhonghui
Hi johannes, Could you please tell me which kernel version will merge this patch? Thanks, Zhonghui On 2015/9/22 22:05, Johannes Berg wrote: > On Sat, 2015-09-19 at 10:40 +0800, Fu, Zhonghui wrote: >> Now, PM core supports asynchronous suspend/resume mode for devices >> during system suspend/

Re: [PATCH 20/38] net: brcm80211: fix range check

2015-09-22 Thread David Miller
From: Andrzej Hajda Date: Mon, 21 Sep 2015 15:33:52 +0200 > Unsigned minus constant is still unsigned so checking its sign makes no > sense. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.

Re: [PATCH 21/38] mwifiex: fix comparison expression

2015-09-22 Thread David Miller
From: Andrzej Hajda Date: Mon, 21 Sep 2015 15:33:53 +0200 > To avoid underflows signed variables should be used in expression. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gman

Re: [PATCH 22/38] orinoco: fix checking for default value

2015-09-22 Thread David Miller
From: Andrzej Hajda Date: Mon, 21 Sep 2015 15:33:54 +0200 > Thresholds uses -1 to indicate that default value should be used. > Since thresholds are unsigned sign checking makes no sense. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_t

Re: [PATCH 23/38] rndis_wlan: fix checking for default value

2015-09-22 Thread David Miller
From: Andrzej Hajda Date: Mon, 21 Sep 2015 15:33:55 +0200 > Thresholds uses -1 to indicate that default value should be used. > Since thresholds are unsigned sign checking makes no sense. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_t

Re: [PATCH] staging: rtl8723au: Mark type casts to __le32 as intentional

2015-09-22 Thread Larry Finger
On 09/22/2015 02:24 AM, Lars Svensson wrote: Fixing Sparse warnings about intentional type casts in rtw_security.c as below. CHECK drivers/staging/rtl8723au/core/rtw_security.c drivers/staging/rtl8723au/core/rtw_security.c:248:22: \ warning: cast to restricted __le32 drivers/staging/rtl8723

ANN: wireless workshop at netdev 1.1 in Seville / February 10th

2015-09-22 Thread Johannes Berg
Hi all, As we did last year, we're planning to hold a wireless workshop for wireless (mostly 802.11) related topics at the netdev conference. This workshop will be at netdev 1.1, which takes places in Seville, Spain, February 10-12. The workshop will be held on the first day of the conference, i.

Re: [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160

2015-09-22 Thread Johannes Berg
> > Should I change something? No, I already created a different patch to make it simply use the 7260 number instead of the 3165 one. I also made one, in fact, to get rid of the 3165 since that has the same values anyway. > iwl3165 uses iwl3160 firmware, but support for that was added in rev >

Re: [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160

2015-09-22 Thread Hauke Mehrtens
On 09/22/2015 10:46 AM, Johannes Berg wrote: > On Tue, 2015-09-22 at 10:44 +0200, Johannes Berg wrote: >> On Sat, 2015-09-19 at 12:39 +0200, Hauke Mehrtens wrote: >>> modinfo iwlwifi showed the following required firmware: >>> firmware: iwlwifi-3160-IWL3160_UCODE_API_OK.ucode >> >> This is obviousl

[PATCH] staging: wicl1000: remove duplicated operand in OR operation

2015-09-22 Thread Javier Martinez Canillas
The IEEE80211_STYPE_PROBE_REQ flag appears twice in the expression and coccicheck complains with: wilc_wfi_cfgoperations.h:80:3-38: duplicated argument to & or | Signed-off-by: Javier Martinez Canillas --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 1 - 1 file changed, 1 deletion(-)

[PATCH] ath9k_htc: use ether_addr_copy() instead of memcpy()

2015-09-22 Thread Oleksij Rempel
Signed-off-by: Oleksij Rempel --- drivers/net/wireless/ath/ath9k/htc_drv_init.c | 2 +- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 24 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wirel

Re: [PATCH v2] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-09-22 Thread Johannes Berg
On Sat, 2015-09-19 at 10:40 +0800, Fu, Zhonghui wrote: > Now, PM core supports asynchronous suspend/resume mode for devices > during system suspend/resume, and the power state transition of one > device may be completed in separate kernel thread. PM core ensures > all power state transition timing

[PATCH] staging: rtl8723au: Mark type casts to __le32 as intentional

2015-09-22 Thread Lars Svensson
Fixing Sparse warnings about intentional type casts in rtw_security.c as below. CHECK drivers/staging/rtl8723au/core/rtw_security.c drivers/staging/rtl8723au/core/rtw_security.c:248:22: \ warning: cast to restricted __le32 drivers/staging/rtl8723au/core/rtw_security.c:249:24: \ warning: cast t

[PATCH 1/9] staging: wilc1000: remove CoreConfiguratorDeInit

2015-09-22 Thread Chaehyun Lim
This patch removes CoreConfiguratorDeInit function, which is not doing anything else except printing a PRINT_D message and returning a s32Error. It is also removed the codes that is calling this function. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 20 --

[PATCH 3/9] staging: wilc1000: replace kmalloc with kzalloc

2015-09-22 Thread Chaehyun Lim
This patch replaces kmalloc with kzalloc because it is initialized by 0 immediately after allcating memory. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigu

[PATCH 9/9] staging: wilc1000: parse_network_info: remove s32Error

2015-09-22 Thread Chaehyun Lim
s32Error is defined, but not used anywhere in this function. Then just delete it and return 0 at the end of this function. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/co

[PATCH 6/9] staging: wilc1000: remove useless comment

2015-09-22 Thread Chaehyun Lim
This patch removes useless comment in coreconfigurator.c Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 38 - drivers/staging/wilc1000/coreconfigurator.h | 29 ++ 2 files changed, 8 insertions(+), 59 deletions(-) dif

[PATCH 4/9] staging: wilc1000: replace kmalloc/memcpy with kmemdup

2015-09-22 Thread Chaehyun Lim
This patch replaces kmalloc followed by memset and memcpy with kmemdup. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc

[PATCH 8/9] staging: wilc1000: rename ParseNetworkInfo

2015-09-22 Thread Chaehyun Lim
This patch replaces ParseNetworkInfo with parse_network_info to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 2 +- 3 files changed, 3 insertio

[PATCH 5/9] staging: wilc1000: replace kmalloc_array/memset with kcalloc

2015-09-22 Thread Chaehyun Lim
This patch replaces kmalloc_array followed by memset with kcalloc. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/corecon

[PATCH 2/9] staging: wilc1000: rename SendConfigPkt

2015-09-22 Thread Chaehyun Lim
This patch replaces SendConfigPkt with send_config_pkt to aovid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 4 +- drivers/staging/wilc1000/coreconfigurator.h | 4 +- drivers/staging/wilc1000/host_interface.c | 204 ++-- 3

[PATCH 7/9] staging: wilc1000: remove extern declaration

2015-09-22 Thread Chaehyun Lim
This patch removes extern declaration of *gpstrWlanOps in coreconfigurator.c file. It is defined extern declaration in wilc_wlan_if.h file and then is included in coreconfigurator.c file. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000

[PATCH v2] staging: wicl1000: fix dereference after free in wilc_wlan_cleanup()

2015-09-22 Thread Javier Martinez Canillas
The wilc_wlan_cleanup() function iterates over the list of transmission buffers freeing all of them and then iterates over the receive buffers list to free all of them as well. But on the receive loop a pointer to struct txq_entry_t is dereferenced instead of the pointer to a struct rxq_entry_t. T

Re: [PATCH 0/6] mac80211: Deinline large functions in driver-ops.h

2015-09-22 Thread Johannes Berg
On Tue, 2015-09-22 at 15:28 +0200, Johannes Berg wrote: > On Fri, 2015-09-18 at 15:19 +0200, Denys Vlasenko wrote: > > After measuring size of inlines, these functions were found to be > > largest. > > These patches reduce code size by about 21 kbytes. > > > > Only patches 1, 2 and 5 applied to

Re: [PATCH 0/6] mac80211: Deinline large functions in driver-ops.h

2015-09-22 Thread Johannes Berg
On Fri, 2015-09-18 at 15:19 +0200, Denys Vlasenko wrote: > After measuring size of inlines, these functions were found to be > largest. > These patches reduce code size by about 21 kbytes. > Only patches 1, 2 and 5 applied to mac80211-next. johannes -- To unsubscribe from this list: send the li

Re: [PATCH] mac80211: reset CQM history upon reconfiguration

2015-09-22 Thread Johannes Berg
On Mon, 2015-09-21 at 15:47 +0300, Luca Coelho wrote: > From: Sara Sharon > > Current behavior of notifying CQM events is inconsistent. > Upon first configuration there is a cqm event of channel status > according to threshold configured, regardless of signal stability. > When there is reconfigur

Re: [PATCH] staging: wicl1000: fix dereference after free in wilc_wlan_cleanup()

2015-09-22 Thread Javier Martinez Canillas
Hello Sudip, Thanks a lot for your feedback. On 09/22/2015 02:16 PM, Sudip Mukherjee wrote: > On Tue, Sep 22, 2015 at 12:24:50PM +0200, Javier Martinez Canillas wrote: >> The wilc_wlan_cleanup() function iterates over the list of transmission >> buffers freeing all of them and then iterates over

Re: [PATCH] staging: wicl1000: fix dereference after free in wilc_wlan_cleanup()

2015-09-22 Thread Sudip Mukherjee
On Tue, Sep 22, 2015 at 12:24:50PM +0200, Javier Martinez Canillas wrote: > The wilc_wlan_cleanup() function iterates over the list of transmission > buffers freeing all of them and then iterates over the receive buffers > list to free all of them as well. > > But on the receive loop a pointer to

RE: [patch v2] mwifiex: fix mwifiex_rdeeprom_read()

2015-09-22 Thread Amitkumar Karwar
Hi Dan, > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, September 21, 2015 9:50 PM > To: Amitkumar Karwar > Cc: Nishant Sarmukadam; Kalle Valo; linux-wireless@vger.kernel.org; > kernel-janit...@vger.kernel.org > Subject: [patch v2] mwifiex: fix mwifiex_rdeeprom_read() > >

RE: [PATCH 21/38] mwifiex: fix comparison expression

2015-09-22 Thread Amitkumar Karwar
Hi Andrzej, > From: Andrzej Hajda [mailto:a.ha...@samsung.com] > Sent: Monday, September 21, 2015 7:04 PM > To: linux-ker...@vger.kernel.org > Cc: Andrzej Hajda; Bartlomiej Zolnierkiewicz; Marek Szyprowski; > Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; linux- > wirel...@vger.kernel.org; net.

[PATCH] staging: wicl1000: fix dereference after free in wilc_wlan_cleanup()

2015-09-22 Thread Javier Martinez Canillas
The wilc_wlan_cleanup() function iterates over the list of transmission buffers freeing all of them and then iterates over the receive buffers list to free all of them as well. But on the receive loop a pointer to struct txq_entry_t is dereferenced instead of the pointer to a struct rxq_entry_t. T

Re: [PATCH 00/38] Fixes related to incorrect usage of unsigned types

2015-09-22 Thread Jacek Anaszewski
On 09/22/2015 11:13 AM, Andrzej Hajda wrote: On 09/21/2015 03:42 PM, David Howells wrote: Andrzej Hajda wrote: Semantic patch finds comparisons of types: unsigned < 0 unsigned >= 0 The former is always false, the latter is always true. Such comparisons are useless, so theoretically

[PATCH V2 08/16] staging: wilc1000: remove CoreConfiguratorInit

2015-09-22 Thread Chaehyun Lim
This patch removes CoreConfiguratorInit function, which is not doing anything else except printing a PRINT_D message and returing a s32Error. It is also removed the code that is calling this function. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing and remove declaration of func

[PATCH V2 07/16] staging: wilc1000: make add_virtual_intf static

2015-09-22 Thread Chaehyun Lim
This patch makes add_virtual_intf static. This function is used only at wilc_wfi_cfgoperation.c file. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH V2 14/16] staging: wilc1000: host_int_init: replace s32Error with result

2015-09-22 Thread Chaehyun Lim
This patch replaces s32Error with result in host_int_init function to avoid camelcase. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/host_interface.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH V2 13/16] staging: wilc1000: host_int_init: remove commented code

2015-09-22 Thread Chaehyun Lim
This patch removes commented code in host_int_init function. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_

[PATCH V2 15/16] staging: wilc1000: host_int_init: remove blank line before a close brace.

2015-09-22 Thread Chaehyun Lim
This patch removes blank line before a close brace. CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc100

[PATCH V2 10/16] staging: wilc1000: host_int_init: replace kmalloc with kzalloc

2015-09-22 Thread Chaehyun Lim
This patch replaces kmalloc with kzalloc in host_int_init. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagi

[PATCH V2 16/16] staging: wilc1000: host_int_init: remove unnecessary parentheses

2015-09-22 Thread Chaehyun Lim
This patch removes unnecessary parentheses found by checkpatch.pl Unnecessary parentheses around pstrWFIDrv->hSemTestKeyBlock Unnecessary parentheses around pstrWFIDrv->hSemTestDisconnectBlock Unnecessary parentheses around pstrWFIDrv->hSemGetRSSI Unnecessary parentheses around pstrWFIDrv->hSemGet

[PATCH V2 12/16] staging: wilc1000: host_int_init: remove multiple blank lines

2015-09-22 Thread Chaehyun Lim
This patch removes multiple blank lines in host_int_init function. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/

[PATCH V2 11/16] staging: wilc1000: host_int_init: fix kzalloc error check

2015-09-22 Thread Chaehyun Lim
This patch fixes error check when kzalloc is failed. NULL comparison style is changed to use ! operator and PRINT_ER is also removed. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(

[PATCH V2 09/16] staging: wilc1000: host_int_init: remove meaningless comment

2015-09-22 Thread Chaehyun Lim
This patch removes meaningless comment in host_int_init function. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wil

[PATCH V2 01/16] staging: wilc1000: rename WILC_WFI_set_power_mgmt

2015-09-22 Thread Chaehyun Lim
This patch replaces WILC_WFI_set_power_mgmt with set_power_mgmt. then makes set_power_mgmt static. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH V2 03/16] staging: wilc1000: rename WILC_WFI_set_cqm_rssi_config

2015-09-22 Thread Chaehyun Lim
This patch replaces WILC_WFI_set_cqm_rssi_config with set_cqm_rssi_config to avoid CamelCase. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/s

[PATCH V2 02/16] staging: wilc1000: remove useless comment

2015-09-22 Thread Chaehyun Lim
This patch removes useless comment. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/d

[PATCH V2 05/16] staging: wilc1000: make mgmt_tx_cancel_wait static

2015-09-22 Thread Chaehyun Lim
This patch makes mgmt_tx_cancel_wait static. This function is used only at wilc_wfi_cfgoperation.c file. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

[PATCH V2 06/16] staging: wilc1000: make mgmt_tx static

2015-09-22 Thread Chaehyun Lim
This patch makes mgmt_tx static. This function is used only at wilc_wfi_cfgoperation.c file. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/st

[PATCH V2 04/16] staging: wilc1000: make del_virtual_intf static

2015-09-22 Thread Chaehyun Lim
This patch makes del_virtual_intf static. This function is used only at wilc_wfi_cfgoperation.c file. Signed-off-by: Chaehyun Lim --- v2: rebase latest staging-testing drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

Re: [PATCH 00/38] Fixes related to incorrect usage of unsigned types

2015-09-22 Thread Andrzej Hajda
On 09/21/2015 03:42 PM, David Howells wrote: > Andrzej Hajda wrote: > >> Semantic patch finds comparisons of types: >> unsigned < 0 >> unsigned >= 0 >> The former is always false, the latter is always true. >> Such comparisons are useless, so theoretically they could be >> safely removed,

Re: [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160

2015-09-22 Thread Johannes Berg
On Tue, 2015-09-22 at 10:44 +0200, Johannes Berg wrote: > On Sat, 2015-09-19 at 12:39 +0200, Hauke Mehrtens wrote: > > modinfo iwlwifi showed the following required firmware: > > firmware: iwlwifi-3160-IWL3160_UCODE_API_OK.ucode > > This is obviously wrong. > > > > > MODULE_FIRMWARE(IWL7260_MOD

Re: [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160

2015-09-22 Thread Johannes Berg
On Sat, 2015-09-19 at 12:39 +0200, Hauke Mehrtens wrote: > modinfo iwlwifi showed the following required firmware: > firmware: iwlwifi-3160-IWL3160_UCODE_API_OK.ucode This is obviously wrong. > > MODULE_FIRMWARE(IWL7260_MODULE_FIRMWARE(IWL7260_UCODE_API_OK)); > -MODULE_FIRMWARE(IWL3160_MODULE_F

RE: [PATCH] mmc: new API for data write using scatter gather DMA

2015-09-22 Thread Amitkumar Karwar
Hi Ulf/Arend, > > > On Wed, Nov 26, 2014 at 11:40 PM, Arend van Spriel > > wrote: > > On 11/26/14 14:43, Ulf Hansson wrote: > > > On 26 November 2014 at 12:07, Avinash PatilĀ  wrote: > > > From: Bing Zhao > > > > This patch adds new API to handle scatter gather aggregation. > > > Why is this ne