> In commit 1277fa2ab2f9 ("rtlwifi: Remove the clear interrupt routine from all
> drivers"), the code that cleared all interrupt enable bits before setting them
> was removed for all PCI drivers. This fixed an issue that caused TX to be
> blocked for 3-5 seconds. On some RTL8821AE units, this chan
On Fri, Oct 02, 2015 at 04:39:11PM +0300, Dan Carpenter wrote:
> On Fri, Oct 02, 2015 at 06:47:35PM +0530, Chandra S Gorentla wrote:
> > During the clean-up of the function, it is need to check if
> > errors occurred, not the memory pointer.
> >
>
> The bug here is that we have a use after free on
From: Jacob Kiefer
This patch fixes the following sparse errors:
CHECK drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
...
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25:
This card comes preinstalled in the new Lenovo Edge 15 at least.
I have recorded some important information (problem detailed
description and dmesg logs) in a post to the archlinux forums [1], and
I wanted to see how could I help to make this device work in linux.
(I am not subscribed to this li
In commit 1277fa2ab2f9, the code that cleared all interrupt enable
bits before setting them was removed for all PCI drivers. This fixed an
issue that caused TX to be blocked for 3-5 seconds. On some RTL8821AE units,
this change causes soft lockups to occur on boot. For that reason, the portion
of t
On Fri, Oct 02, 2015 at 06:47:35PM +0530, Chandra S Gorentla wrote:
> During the clean-up of the function, it is need to check if
> errors occurred, not the memory pointer.
>
The bug here is that we have a use after free on the success path. It
should have been mentioned in the changelog.
Anyway
During the clean-up of the function, it is need to check if
errors occurred, not the memory pointer.
Signed-off-by: Chandra S Gorentla
---
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c
b/driv
There are a couple of return statements before unlock. Lock is moved
to a location just before queue manipulation.
Signed-off-by: Chandra S Gorentla
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc
The value of 'result' is not modified from 0 after initialization.
Hence no need to check it.
Signed-off-by: Chandra S Gorentla
---
drivers/staging/wilc1000/wilc_msgqueue.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c
b/drivers/staging/wilc100
This patch changes NULL comparison style to use ! operator found by
checkpatch.pl
CHECK: Comparison to NULL could be written "!pstrWFIDrv"
drivers/staging/wilc1000/host_interface.c:5324:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertio
This patch changes PRINT_ER by pr_err.
It would be better to use netdev_err, but it cannot use it in this
function, so just use pr_err.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wi
This patch replaces s32Error with result to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interfa
This patch replaces s32Error with result to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interfa
This patch changes return type of host_int_wait_msg_queue_idle from s32
to int. s32Error gets return value from wilc_mq_send that has return
type of int. It should be changed return type of
host_int_wait_msg_queue_idle by int as well as data type of s32Error.
Signed-off-by: Chaehyun Lim
---
driv
This patch replaces hWFIDrv with wfi_drv that is first argument of
host_int_set_mac_chnl_num to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-
This patch removes blank lines before close brace '}'
CHECK: Blank lines aren't necessary before a close brace '}'
drivers/staging/wilc1000/host_interface.c:5366:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
This patch replaces u8ChNum with channel that is second argument of
host_int_set_mac_chnl_num to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
This patch replaces PRINT_ER with pr_err.
It would be better to use netdev_err, but it cannot use it in this
function, so just use pr_err.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/sta
This patch changes return type of host_int_set_mac_chnl_num from s32 to
int. s32Error gets return value from wilc_mq_send function that
has return type of int. It should be changed return type of
host_int_set_mac_chnl_num function by int as well as data type of
s32Error.
Signed-off-by: Chaehyun Li
On Fri, Oct 02, 2015 at 09:45:44AM +0200, Arend van Spriel wrote:
> On 10/01/2015 03:43 PM, Chaehyun Lim wrote:
> >This patch replaces int8_t with s8 that is a preferred type.
> >
> >Signed-off-by: Chaehyun Lim
> >---
> > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
> > 1 file ch
On Fri, Oct 2, 2015 at 5:02 PM, Arend van Spriel wrote:
> On 10/02/2015 09:41 AM, Chaehyun Lim wrote:
>>
>> This patch replaces int8_t with int.
>> The int8_t should be int. It's used as an index into an array
>> or -1 for not found.
>
>
> Please consider using bool instead. See my previous emails
Hi
On Tue, Sep 29, 2015 at 06:38:19PM +0200, Pascal Huerst wrote:
> on rt2x00 devices, firmware gets loaded in:
>
> int rt2x00lib_start(struct rt2x00_dev *rt2x00dev)
>
> which is called, when we start the interface by:
>
> ifconfig wlan0 up
>
> I need to lower tx power of the device and create
> Kalle Valo [mailto:kv...@codeaurora.org] writes:
>
> David Lin writes:
>
> > The Linux driver for WRT1900AC. The work was initially developed as
> > part of openwrt effort and maintained on https://github.com/kaloz/mwlwifi.
> >
> > This is still work in progress, with 8864 chipset more mature a
On 10/02/2015 09:41 AM, Chaehyun Lim wrote:
This patch replaces int8_t with int.
The int8_t should be int. It's used as an index into an array
or -1 for not found.
Please consider using bool instead. See my previous emails.
Regards,
Arend
Suggested-by: Dan Carpenter
Signed-off-by: Chaehyun
On 10/02/2015 09:45 AM, Arend van Spriel wrote:
On 10/01/2015 03:43 PM, Chaehyun Lim wrote:
This patch replaces int8_t with s8 that is a preferred type.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
On 10/01/2015 03:43 PM, Chaehyun Lim wrote:
This patch replaces int8_t with s8 that is a preferred type.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_w
This patch replaces s32Error with result to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi
This patch replaces u8CurrChannel with curr_channel to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging
This patch changes data type of s32Error variable from s32 to int
because return type of this function is int.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This patch removes commented codes that is not used in this driver.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/linux_wlan.c | 3 ---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 -
drivers/staging/wilc1000/wilc_wlan.c
This patch removes unnecessary comment.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/host_interface.c | 6 --
drivers/staging/wilc1000/host_interface.h | 16
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 23 +
This patch removes if defined codes of USE_OLD_SPI_SW.
This macro is deleted because it is commented out.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/wilc_spi.c | 125
1 file changed, 125 deletions(-)
This patch removes unnecessary block braces and fix indentation.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/linux_wlan.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/drivers/stagin
This patch replaces int8_t with int.
The int8_t should be int. It's used as an index into an array
or -1 for not found.
Suggested-by: Dan Carpenter
Signed-off-by: Chaehyun Lim
---
V2: replaces s8 with int suggested by dan.
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file ch
This patch uses ARRAY_SIZE macro found by checkpatch.pl
WARNING: Prefer ARRAY_SIZE(wb)
drivers/staging/wilc1000/wilc_spi.c:400
drivers/staging/wilc1000/wilc_spi.c:402
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/wilc_spi.c | 4 ++--
1 file
This patch removes blank line after open brace '{' found by
checkpatch.pl
CHECK: Blank lines aren't necessary after an open brace '{'
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:664:
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/wilc_
This patch removes #if 1 and #endif, which is encapsulated
some codes.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperation
This patch removes wilc_platform.h file that is not used anywhere.
Signed-off-by: Chaehyun Lim
---
V2: resend because 08/12 patch is changed.
drivers/staging/wilc1000/wilc_platform.h | 28
1 file changed, 28 deletions(-)
delete mode 100644 drivers/staging/wilc1000/
On Fri, Oct 2, 2015 at 3:06 PM, Dan Carpenter wrote:
> On Fri, Oct 02, 2015 at 07:56:28AM +0900, Chaehyun Lim wrote:
>> On Fri, Oct 2, 2015 at 12:40 AM, Dan Carpenter
>> wrote:
>> > On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote:
>> >> This patch replaces int8_t with s8 that is a p
39 matches
Mail list logo
