[PATCH V4] ath10k: Debugfs entry to enable/disable WLAN&Blutooth Coexist feature

2015-10-23 Thread Yanbo Li
As some radio have no connection with BT modules, enable the WLAN/Bluetooth coexist(BTC) feature will has some side effect if the radio's GPIO connect with any other HW modules. Add the control switcher "btc_feature" at debugfs and set the feature as disable by default to avoid such case. The FW s

[PATCH] iw: Fix memory leak if nla_put fails

2015-10-23 Thread Ola Olsson
The NLA_PUT macro will automatically goto nla_put_failure if the underlying nla_put fails. This will in turn leak our malloced memory in both the scan and wowlan commands. Fix that by not using the macro in the cases where we have allocated heap mem. Signed-off-by: Ola Olsson --- scan.c |5

Re: [RFC 16/16] rtl8xxxu: rtl8188eu: Implement parse_efuse()

2015-10-23 Thread Jakub Sitnicki
On Wed, Oct 21, 2015 at 04:15 AM CEST, Jes Sorensen wrote: > Jakub Sitnicki writes: >> As opposed to the vendor driver (rtl8188eu), extract from efuse only >> these TX power values that are going to be of use later on. >> >> Signed-off-by: Jakub Sitnicki >> --- >> drivers/net/wireless/realtek/

Re: [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start

2015-10-23 Thread Larry Finger
On 10/23/2015 03:31 PM, Jes Sorensen wrote: Bruno Randolf writes: On 10/22/2015 02:42 PM, Jes Sorensen wrote: Making things work against random kernel versions of OpenWRT is not particularly "credible". If the driver needs hacks to work with older kernels, then they should be applied for the o

Re: [RFC 13/16] rtl8xxxu: Make set_tx_power a chip-type-dependent operation

2015-10-23 Thread Jakub Sitnicki
On Wed, Oct 21, 2015 at 04:07 AM CEST, Jes Sorensen wrote: > Jakub Sitnicki writes: >> Preparatory step for adding support for RTL8188EU chips. >> >> Signed-off-by: Jakub Sitnicki >> --- >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 6 -- >> drivers/net/wireless/realtek/rtl8xxxu/rt

Re: [RFC 08/16] rtl8xxxu: Extract TX power fields from struct rtl8xxu_priv

2015-10-23 Thread Jakub Sitnicki
On Wed, Oct 21, 2015 at 03:58 AM CEST, Jes Sorensen wrote: > Jakub Sitnicki writes: >> Signed-off-by: Jakub Sitnicki >> --- >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 95 >> >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 30 >> 2 files chang

Re: [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start

2015-10-23 Thread Jes Sorensen
Bruno Randolf writes: > On 10/22/2015 02:42 PM, Jes Sorensen wrote: >> Making things work against random kernel versions of OpenWRT is not >> particularly "credible". If the driver needs hacks to work with older >> kernels, then they should be applied for the older kernels. Linux does >> not have

Re: overlap of devices in rtl8xxxu and rtl8192cu

2015-10-23 Thread Larry Finger
On 10/23/2015 12:53 PM, Jes Sorensen wrote: Kalle Valo writes: Kalle Valo writes: Like I said earlier in rtl8xxxu review, I don't want to have two drivers supporting the same device. So either rtl8xxxu or rtlwifi supports the devices above, not both. And to my knowledge rtl8xxxu is still lac

Re: overlap of devices in rtl8xxxu and rtl8192cu

2015-10-23 Thread Jes Sorensen
Kalle Valo writes: > Kalle Valo writes: > >> Like I said earlier in rtl8xxxu review, I don't want to have two drivers >> supporting the same device. So either rtl8xxxu or rtlwifi supports the >> devices above, not both. And to my knowledge rtl8xxxu is still lacking >> in features, and it's a new

[PATCH v6 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-23 Thread Punit Vara
This warning is reported by coccicheck: Signed-off-by: Punit Vara --- drivers/net/wireless/ath/wcn36xx/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 900e72a..94bcc08 100644 --

[PATCH] rtl8xxxu: move devices supported by rtlwifi under UNTESTED config

2015-10-23 Thread Kalle Valo
There are still four devices which are currently supported both by the new rtl8xxxu driver and rtlwifi. To not break existing setups enable the support for these four devices only when CONFIG_RTL8XXXU_UNTESTED is turned on. Once rtl8xxxu support is found to be good enough the devices can be remove

Re: overlap of devices in rtl8xxxu and rtl8192cu

2015-10-23 Thread Kalle Valo
Kalle Valo writes: > Like I said earlier in rtl8xxxu review, I don't want to have two drivers > supporting the same device. So either rtl8xxxu or rtlwifi supports the > devices above, not both. And to my knowledge rtl8xxxu is still lacking > in features, and it's a new driver, so it's best that r

Re: overlap of devices in rtl8xxxu and rtl8192cu

2015-10-23 Thread Kalle Valo
Jes Sorensen writes: > Kalle Valo writes: >> Jes Sorensen writes: >> >>> Xose Vazquez Perez writes: There is overlap of devices between rtl8xxxu and rtl8192cu: USB_VENDER_ID_REALTEK, 0x8176 USB_VENDER_ID_REALTEK, 0x8178 USB_VENDER_ID_REALTEK, 0x817f 0x7392, 0x7811

Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

2015-10-23 Thread Jes Sorensen
Jes Sorensen writes: > Xose Vazquez Perez writes: >> Jes Sorensen wrote: >> >>> This is an alternate driver for a number of Realtek WiFi USB devices, >>> including RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, and RTL8192CU. >>> It was written from scratch utilizing the Linux mac80211 stack. >>>[..

Re: [PATCH] staging: rtl8723au: core: rtw_wlan_util: fix misleading indentation

2015-10-23 Thread Jes Sorensen
Luis de Bethencourt writes: > For loop is outside of the else branch of the above conditional statement. > Fixing misleading indentation. > > Fix a smatch warning: > drivers/staging/rtl8723au/core/rtw_wlan_util.c:528 > WMMOnAssocRsp23a() warn: curly braces intended? > > Signed-off-by: Luis de Beth

Re: [RFC 05/16] rtl8xxxu: Unbreak a user-visible string

2015-10-23 Thread Jes Sorensen
Jakub Sitnicki writes: > On Wed, Oct 21, 2015 at 03:46 AM CEST, Jes Sorensen > wrote: >> Jakub Sitnicki writes: >>> Signed-off-by: Jakub Sitnicki >>> --- >>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/driv

ar5523: duplicate ID

2015-10-23 Thread Xose Vazquez Perez
Hi, This device is duplicate at ar5523.c: AR5523_DEVICE_UG(0x157e, 0x3006), /* Umedia / AR5523_1 */ AR5523_DEVICE_UG(0x157e, 0x3006), /* Umedia / TEW444UBEU */ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to major

Re: [PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-23 Thread Bjorn Andersson
On Thu, Oct 22, 2015 at 11:57 AM, Punit Vara wrote: Hi Punit, > Remove empty line suggested by Sergei > A commit message is here to, in the future, help us all understand what and why this change was made, so you should not include comments about what you changed since a previous version of thi

Re: overlap of devices in rtl8xxxu and rtl8192cu

2015-10-23 Thread Jes Sorensen
Kalle Valo writes: > Jes Sorensen writes: > >> Xose Vazquez Perez writes: >>> >>> There is overlap of devices between rtl8xxxu and rtl8192cu: >>> USB_VENDER_ID_REALTEK, 0x8176 >>> USB_VENDER_ID_REALTEK, 0x8178 >>> USB_VENDER_ID_REALTEK, 0x817f >>> 0x7392, 0x7811 >> >> Yes > > What, are you sayin

Re: overlap of devices in rtl8xxxu and rtl8192cu

2015-10-23 Thread Kalle Valo
Jes Sorensen writes: > Xose Vazquez Perez writes: >> >> There is overlap of devices between rtl8xxxu and rtl8192cu: >> USB_VENDER_ID_REALTEK, 0x8176 >> USB_VENDER_ID_REALTEK, 0x8178 >> USB_VENDER_ID_REALTEK, 0x817f >> 0x7392, 0x7811 > > Yes What, are you saying that you didn't fix that? I did s

Regression in minstrel_ht vs minstrel?

2015-10-23 Thread Dmitrijs Ivanovs
Hi! While investigating a case of intermittent extreme packet loss, I've found that minstrel_ht algo has one possible regression compared to non-HT version of minstrel. It does not add lowest rate to the last element of rate table array. Minstrel: /* Use lowest rate last */ ratetbl->rate

Re: staging/rtl8723au should be removed

2015-10-23 Thread Jes Sorensen
Larry Finger writes: > On 10/23/2015 05:44 AM, Xose Vazquez Perez wrote: >> Hi, >> >> Support for RTL8723AU devices was added to >> wireless-drivers-next.git recently: >> https://marc.info/?l=linux-wireless&m=144541406318463 >> commit: >> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless

Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

2015-10-23 Thread Jes Sorensen
Xose Vazquez Perez writes: > Jes Sorensen wrote: > >> This is an alternate driver for a number of Realtek WiFi USB devices, >> including RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, and RTL8192CU. >> It was written from scratch utilizing the Linux mac80211 stack. >>[...] >>+{USB_DEVICE_AND_INTERFAC

Re: overlap of devices in rtl8xxxu and rtl8192cu

2015-10-23 Thread Jes Sorensen
Xose Vazquez Perez writes: > Kalle Valo wrote: > >>> From: Jes Sorensen >>> >>> This is an alternate driver for a number of Realtek WiFi USB devices, >>> including RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, and RTL8192CU. >>> It was written from scratch utilizing the Linux mac80211 stack. >>>

Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

2015-10-23 Thread Xose Vazquez Perez
Jes Sorensen wrote: > This is an alternate driver for a number of Realtek WiFi USB devices, > including RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, and RTL8192CU. > It was written from scratch utilizing the Linux mac80211 stack. >[...] >+{USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x317f

[PATCH v2 4/4] ath10k: remove shadow copy of CE descriptors for source ring

2015-10-23 Thread Rajkumar Manoharan
For the messages from host to target, shadow copy of CE descriptors are maintained in source ring. Before writing actual CE descriptor, first shadow copy is filled and then it is copied to CE address space. To optimize in download path and to reduce d-cache pressure, removing shadow copy of CE desc

[PATCH v2 2/4] ath10k: remove send completion validation in diag read/write

2015-10-23 Thread Rajkumar Manoharan
CE diag window access is serialized (it has to be by design) so there's no way to get a different send completion. so there's no need for post completion validation. Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/pci.c | 20 1 file changed, 20 deletion

[PATCH v2 1/4] ath10k: use local memory instead of shadow descriptor in ce_send

2015-10-23 Thread Rajkumar Manoharan
Currently to avoid uncached memory access while filling up copy engine descriptors, shadow descriptors are used. This can be optimized further by removing shadow descriptors. To achieve that first shadow ring dependency in ce_send is removed by creating local copy of the descriptor on stack and mak

[PATCH v2 3/4] ath10k: cleanup copy engine send completion

2015-10-23 Thread Rajkumar Manoharan
The physical address necessary to unmap DMA ('bufferp') is stored in ath10k_skb_cb as 'paddr'. ath10k doesn't rely on the meta/transfer_id when handling send completion (htc ep id is stored in sk_buff control buffer). So the unused output arguments {bufferp, nbytesp and transfer_idp} are removed fr

[PATCH v2 0/4] ath10k: remove shadow copy engine descriptors

2015-10-23 Thread Rajkumar Manoharan
Below series remove shadow copy of CE descriptors for source ring. Removing the shadow copy should reduce d-cache pressure and memory usage of the driver. v2: * Since ce_send is not using shadow, fix send completion as well. Rajkumar Manoharan (4): ath10k: use local memory instead of shadow de

overlap of devices in rtl8xxxu and rtl8192cu

2015-10-23 Thread Xose Vazquez Perez
Kalle Valo wrote: >> From: Jes Sorensen >> >> This is an alternate driver for a number of Realtek WiFi USB devices, >> including RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, and RTL8192CU. >> It was written from scratch utilizing the Linux mac80211 stack. >> >> After spending months cleaning up

Re: staging/rtl8723au should be removed

2015-10-23 Thread Larry Finger
On 10/23/2015 05:44 AM, Xose Vazquez Perez wrote: Hi, Support for RTL8723AU devices was added to wireless-drivers-next.git recently: https://marc.info/?l=linux-wireless&m=144541406318463 commit: https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/drivers/net/wir

staging/rtl8723au should be removed

2015-10-23 Thread Xose Vazquez Perez
Hi, Support for RTL8723AU devices was added to wireless-drivers-next.git recently: https://marc.info/?l=linux-wireless&m=144541406318463 commit: https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h?id=26f1fad29a

[PATCH 0/2] brcm: new firmware files

2015-10-23 Thread Arend van Spriel
One firmware file update and firmware for a new supported device. The patches are for the master branch of the linux-firmware repository and apply on top of commit 66d3d8d7607c ("Add FW binary used by mwlwifi driver."). Arend van Spriel (2): brcm: adding firmware for BCM4350 PCIe device brcm:

Re: [PATCH] ath10k: Add support for pktlog in QCA99X0

2015-10-23 Thread kbuild test robot
Hi Vivek, [auto build test ERROR on next-20151022 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Vivek-Natarajan/ath10k-Add-support-for-pktlog-in-QCA99X0/20151023-140452 config: x86_64-allmodc

[PATCH] cfg80211: Enable update of properties for unassociated station.

2015-10-23 Thread Emmanuel Grumbach
From: Ayala Beker Currently, cfg80211 rejects updates of AID and listen interval parameters for existing entries. This information is known only at association stage, and as a result it's impossible to update entries that were added unassociated. Fix this by allowing updates of these properies fo

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Tony Cho
On 2015년 10월 23일 16:52, Dan Carpenter wrote: On Fri, Oct 23, 2015 at 04:36:07PM +0900, Tony Cho wrote: In addition, the function parameter names will be wilc for the variable of struct wilc. The "wl" is local variable naming as well. So if it is a parameter it is wilc but if it is a local va

Re: [PATCH] ath10k: Add support for pktlog in QCA99X0

2015-10-23 Thread kbuild test robot
Hi Vivek, [auto build test ERROR on next-20151022 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Vivek-Natarajan/ath10k-Add-support-for-pktlog-in-QCA99X0/20151023-140452 config: i386-allmodc

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 04:36:07PM +0900, Tony Cho wrote: > In addition, the function parameter names will be wilc > for the variable of struct wilc. > > The "wl" is local variable naming as well. So if it is a parameter it is wilc but if it is a local variable then it is wl? That seems like an

Re: [PATCH 00/19] staging/wilc1000 cleanups

2015-10-23 Thread Tony Cho
Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In these days, we are sending big changes while testing such patches and also

[PATCH] cfg80211: replace ieee80211_ie_split() with an inline

2015-10-23 Thread Johannes Berg
From: Johannes Berg The function is a very simple wrapper around another one, just adds a few default parameters, so replace it with a static inline instead of using EXPORT_SYMBOL, reducing the module size slightly. Signed-off-by: Johannes Berg --- include/net/cfg80211.h | 7 +-- net/wirel

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Tony Cho
On 2015년 10월 23일 15:57, Dan Carpenter wrote: On Fri, Oct 23, 2015 at 02:28:21PM +0900, Glen Lee wrote: This patch add new argument wilc to wilc_handle_isr and pass wilc to the function. It's not important enough to redo the patch but why are we sometimes using "wl" and sometimes "wilc"? We