Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-12 Thread glen lee
On 2015년 11월 12일 20:39, Arnd Bergmann wrote: On Thursday 12 November 2015 19:05:41 glen lee wrote: Hi arnd, I appreciate the patches. I did test this patch series on h/w which is arm based MCU. From this patch wilc is not working properly. After downloading firmware, the firmware cannot st

Re: [PATCH v2] cfg80211: add VHT support for Mesh

2015-11-12 Thread Johannes Berg
On Thu, 2015-11-12 at 15:05 -0800, Peter Oh wrote: > On 11/12/2015 02:32 PM, Johannes Berg wrote: > > On Thu, 2015-11-12 at 14:28 -0800, Peter Oh wrote: > > >   > > > Exactly the same communication mechanism and purpose are used > > > with > > > NL80211_EXT_FEATURE_VHT_IBSS which is already a part

Re: [PATCH] ath9k: incorrect queue may be stopped/awaken

2015-11-12 Thread Janusz Dziedzic
On 3 November 2015 at 18:37, Borja Salazar wrote: > When channel context is enabled, we could be > stopping/awakening an incorrect queue. > --- > drivers/net/wireless/ath/ath9k/xmit.c | 22 -- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/wir

Re: [PATCH v2 0/9] ath10k: clean up ath10k_skb_cb

2015-11-12 Thread Michal Kazior
On 12 November 2015 at 20:29, Kalle Valo wrote: > Michal Kazior writes: > >> The ath10k_skb_cb structure wasn't really space >> efficient. Some stuff is removed or replaced with >> more compact representation. >> >> This cleanup is necessary for future features. >> >> The size of ath10k_skb_cb: >

Re: Does mac80211 guarantee no data frames are sent to driver until encryption is setup?

2015-11-12 Thread Janusz Dziedzic
On 13 November 2015 at 01:59, Ben Greear wrote: > A certain firmware tries to do EAPOL inspection and only allow data pkts > to be sent after the 4-way M4 has been sent, for instance. > > This was breaking .11r because in that case you don't do the 4-way after > roaming, so the firmware was waitin

Does mac80211 guarantee no data frames are sent to driver until encryption is setup?

2015-11-12 Thread Ben Greear
A certain firmware tries to do EAPOL inspection and only allow data pkts to be sent after the 4-way M4 has been sent, for instance. This was breaking .11r because in that case you don't do the 4-way after roaming, so the firmware was waiting forever for an M4 to be sent and thus all tx data was h

Re: [PATCH] ath10k: Enable VHT for Mesh

2015-11-12 Thread kbuild test robot
Hi Peter, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.3 next-20151112] url: https://github.com/0day-ci/linux/commits/Peter-Oh/ath10k-Enable-VHT-for-Mesh/20151113-061427 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers

Re: [PATCH v2] cfg80211: add VHT support for Mesh

2015-11-12 Thread Peter Oh
On 11/12/2015 02:32 PM, Johannes Berg wrote: On Thu, 2015-11-12 at 14:28 -0800, Peter Oh wrote: Exactly the same communication mechanism and purpose are used with NL80211_EXT_FEATURE_VHT_IBSS which is already a part of NL80211 feature flag. The new feature flag, NL80211_EXT_FEATURE_VHT_MESH,

Re: [PATCH v2] cfg80211: add VHT support for Mesh

2015-11-12 Thread Johannes Berg
On Thu, 2015-11-12 at 14:28 -0800, Peter Oh wrote: >  > Exactly the same communication mechanism and purpose are used with > NL80211_EXT_FEATURE_VHT_IBSS which is already a part of NL80211 > feature > flag. > The new feature flag, NL80211_EXT_FEATURE_VHT_MESH, follows the same > purpose and usag

Re: [PATCH v2] cfg80211: add VHT support for Mesh

2015-11-12 Thread Peter Oh
On 11/12/2015 01:40 PM, Johannes Berg wrote: On Thu, 2015-11-12 at 13:33 -0800, Peter Oh wrote: At this moment Mesh Point is not able to be brought up by userspace such as wap_supplicant at VHT data rates because there is no events/NL80211 defined that userspace can check out if drivers can sup

DFS Master Region

2015-11-12 Thread Larry Finger
I'm trying to understand a problem that some users are having with the 5G band when using rtl8821ae. One of them sees the following output from cfg80211: cfg80211: World regulatory domain updated: cfg80211: DFS Master region: unset cfg80211: (start_freq - end_freq @ bandwidth), (max_antenna_g

[PATCH] ath10k: Enable VHT for Mesh

2015-11-12 Thread Peter Oh
Mesh until now has no framework for VHT support which requires NL80211 and wpa_supplicant updates communicating with wireless drivers for capabilities. I've sent patches of NL80211 and wpa_supplicant separately that can be used for Mesh VHT support. Also enable ath10k Mesh VHT support in this patch

[RFC v5 1/5] kconfig: introduce "count"

2015-11-12 Thread Johannes Berg
From: Johannes Berg "count" works similar to "select"; take, for example, this snippet: config MY_COUNTER int config MY_DRIVER_1 bool "my driver 1" count MY_COUNTER config MY_DRIVER_2 bool "my driver 2" count MY_COUNTER T

[RFC v5 4/5] mac80211: use Kconfig counters to elide unnecessary code

2015-11-12 Thread Johannes Berg
From: Johannes Berg There are many drivers with different behaviour, but in a lot of systems only a single driver will ever be built. In that case we can get rid of code paths that this driver doesn't need and also optimize the ones that it always takes to not have a check. To make that possible

[RFC v5 3/5] mac80211: generate hw flags from include file

2015-11-12 Thread Johannes Berg
From: Johannes Berg Instead of having to list all the hw flags in many places, just list the macro to generate everything in a new include file and include it in the proper places. Unfortunately this breaks docbook processing since that doesn't pre-process the file. It also doesn't generate the

[RFC v5 0/5] mac80211: elide code for static hw flags

2015-11-12 Thread Johannes Berg
In v5, I've radically simplified the whole concept and dropped the support for static keys. Instead, I'm now simply entirely removing the if statements - replacing them by "if (true)" or "if (false)" if that's at all possible. For many (distro) kernels, this will - as before - mean no change, bu

[RFC v5 2/5] kconfig: regenerate the shipped files

2015-11-12 Thread Johannes Berg
From: Johannes Berg Unfortunately, I again used a different version of the tools, so the changes are rather large. Signed-off-by: Johannes Berg --- scripts/kconfig/zconf.hash.c_shipped | 10 +- scripts/kconfig/zconf.lex.c_shipped | 62 +- scripts/kconfig/zconf.tab.c_shipped | 1600 ++

[RFC v5 5/5] iwlwifi: mvm: add Kconfig settings for hw flags

2015-11-12 Thread Johannes Berg
From: Johannes Berg Copy the hardware flags settings into Kconfig for iwlwifi/mvm. Signed-off-by: Johannes Berg --- drivers/net/wireless/iwlwifi/Kconfig | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wi

[RFC v5] mac80211: elide code for static hw flags

2015-11-12 Thread Johannes Berg
In v5, I've radically simplified the whole concept and dropped the support for static keys. Instead, I'm now simply entirely removing the if statements - replacing them by "if (true)" or "if (false)" if that's at all possible. For many (distro) kernels, this will - as before - mean no change, bu

Re: [PATCH v2] cfg80211: add VHT support for Mesh

2015-11-12 Thread Johannes Berg
On Thu, 2015-11-12 at 13:33 -0800, Peter Oh wrote: >  > At this moment Mesh Point is not able to be brought up by userspace > such > as wap_supplicant at VHT data rates because there is no > events/NL80211 > defined that userspace can check out if drivers can support Mesh > Point > (802.11s) at

Re: [PATCH v2] cfg80211: add VHT support for Mesh

2015-11-12 Thread Peter Oh
On 11/12/2015 12:03 PM, Johannes Berg wrote: On Thu, 2015-11-12 at 09:59 -0800, Peter Oh wrote: Add NL80211_EXT_FEATURE_VHT_MESH flag to allow drivers to indicate support for VHT in Mesh mode. This flag will be used by wireless drivers to indicate the capability of VHT Mesh support and wpa_supp

Re: [PATCH] realtek: rtlwifi: rtl8821ae: Fix lockups on boot

2015-11-12 Thread Larry Finger
On 11/12/2015 01:54 PM, Kalle Valo wrote: Larry Finger writes: In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"), an attempt was made to fix a regression introduced in commit 1277fa2ab2f9 ("rtlwifi: Remove the clear interrupt routine from all drivers"). Unfortunately,

Re: [PATCH v2] cfg80211: add VHT support for Mesh

2015-11-12 Thread Johannes Berg
On Thu, 2015-11-12 at 09:59 -0800, Peter Oh wrote: > Add NL80211_EXT_FEATURE_VHT_MESH flag to allow drivers > to indicate support for VHT in Mesh mode. > This flag will be used by wireless drivers to indicate > the capability of VHT Mesh support and wpa_supplicant to inspect > wireless drivers' cap

Re: [PATCH] ath9k: incorrect queue may be stopped/awaken

2015-11-12 Thread Kalle Valo
Borja Salazar writes: > When channel context is enabled, we could be > stopping/awakening an incorrect queue. Signed-off-by line is missing, I can't take this. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.

Re: [PATCH] realtek: rtlwifi: rtl8821ae: Fix lockups on boot

2015-11-12 Thread Kalle Valo
Larry Finger writes: > In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"), > an attempt was made to fix a regression introduced in commit 1277fa2ab2f9 > ("rtlwifi: Remove the clear interrupt routine from all drivers"). > Unfortunately, there were logic errors in that patch

Re: [PATCH 05/12] ath9k: use u32 when calculate tsf

2015-11-12 Thread Kalle Valo
Janusz Dziedzic writes: > Signed-off-by: Janusz Dziedzic Why? And no empty commit logs, please. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH 6/9] brcmfmac: Add RSDB support.

2015-11-12 Thread Kalle Valo
Arend van Spriel writes: > From: Hante Meuleman > > RSDB works almost autonomously in firmware except for AP config. > When device supports RSDB then the interface should not be > brought down when configuring it, otherwise the link (if > configured) on the other interface will be lost. > > Revi

Re: [PATCH v7] Add new mac80211 driver mwlwifi.

2015-11-12 Thread Jes Sorensen
David Lin writes: > This patch provides the mwlwifi driver for Marvell 8863, 8864 and 8897 > chipsets. > This driver was developed as part of the openwrt.org project to support > Linksys WRT1900AC and is maintained on https://github.com/kaloz/mwlwifi. > > The mwlwifi driver differs from existing m

Re: [PATCH v2 0/9] ath10k: clean up ath10k_skb_cb

2015-11-12 Thread Kalle Valo
Michal Kazior writes: > The ath10k_skb_cb structure wasn't really space > efficient. Some stuff is removed or replaced with > more compact representation. > > This cleanup is necessary for future features. > > The size of ath10k_skb_cb: > > before after > x86-32 26 12 > x86-

Re: [PATCH V3 0/3] Fix few WMI/HTT interfaces

2015-11-12 Thread Kalle Valo
Vasanthakumar Thiagarajan writes: > This patch set fixes mismatch in peer_assoc complete wmi command for > version 10.4 and peer_id configuration for HTT version < 3.4. > > V2: > - Add cover letter > - Rename ath10k_mac_need_offchan_tx_work() to > ath10k_mac_tx_frm_has_freq().

Re: [PATCH] MAINTAINERS: wil6210: new maintainer - Maya Erez

2015-11-12 Thread Kalle Valo
Vladimir Kondratiev writes: > Maya Erez will maintain the wil6210 driver > > Signed-off-by: Vladimir Kondratiev Applied to ath-current, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3] ath10k: Override CE5 configuration for QCA6147 device

2015-11-12 Thread Kalle Valo
Ryan Hsu writes: > 'Commit a70587b3389a ("ath10k: configure copy engine 5 for HTT messages")' > Introduces to use the unused CE5 for target to host message. > > For the device like QCA6174, CE5 already assigned for other feature. > So for QCA6174, override the CE5 configuration and use the CE1 in

Re: [PATCH v2 0/4] update ath10k support for QCA9377 chips

2015-11-12 Thread Kalle Valo
Bartosz Markowski writes: > * Clarifying the naming scheme for QCA9377 targets > * Adding the dev_id mathod (RFC) as a HW identification helper > * updating missing hw_params for 1.1 target > > --- > > Notes: > v2: >* rebase >* fix the whitespace mess in patch 4/4 [Kalle] > > Bartosz Ma

[PATCH] ath10k: Fix the wrong RX rate idx report at 11G mode

2015-11-12 Thread Yanbo Li
The RX rate idx is not correctly for 11G mode OFDM packet. Because the bitrate table start with CCK index instead of OFDM. Signed-off-by: Yanbo Li diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index 6060dda4e910..9dcf93d1bd24 100644 --- a/drive

[PATCH v2] cfg80211: add VHT support for Mesh

2015-11-12 Thread Peter Oh
Add NL80211_EXT_FEATURE_VHT_MESH flag to allow drivers to indicate support for VHT in Mesh mode. This flag will be used by wireless drivers to indicate the capability of VHT Mesh support and wpa_supplicant to inspect wireless drivers' capability of VHT Mesh. In addition to this patch, separate patc

[PATCH] ath10k: Enable VHT for Mesh

2015-11-12 Thread Peter Oh
Mesh until now has no framework for VHT support which requires NL80211 and wpa_supplicant updates communicating with wireless drivers for capabilities. I've sent patches of NL80211 and wpa_supplicant separately that can be used for Mesh VHT support. Also enable ath10k Mesh VHT support in this patch

Re: [PATCH] cfg80211: add VHT support for Mesh

2015-11-12 Thread Johannes Berg
On Thu, 2015-11-12 at 09:36 -0800, Peter Oh wrote: > Add NL80211_EXT_FEATURE_VHT_MESH flag to allow drivers > to indicate support for VHT in Mesh mode. > I'm confused. Why would it be needed? You haven't added any API or anything where userspace would do something differently based on whether or n

[PATCH] cfg80211: add VHT support for Mesh

2015-11-12 Thread Peter Oh
Add NL80211_EXT_FEATURE_VHT_MESH flag to allow drivers to indicate support for VHT in Mesh mode. Signed-off-by: Peter Oh --- include/uapi/linux/nl80211.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index 1f0b4cf..4a16ed5 10064

Re: [PATCH v3] ath10k: Override CE5 configuration for QCA6147 device

2015-11-12 Thread Kalle Valo
Julian Calaby writes: >> +static void ath10k_pci_override_ce_config(struct ath10k *ar) >> +{ >> + struct ce_attr *attr; >> + struct ce_pipe_config *config; >> + >> + /* For QCA6174 we're overriding the Copy Engine 5 configuration, >> +* since it is currently used for oth

Re: [PATCH 09/12] ath9k: request NOA update when chanctx active

2015-11-12 Thread kbuild test robot
Hi Janusz, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.3 next-20151112] url: https://github.com/0day-ci/linux/commits/Janusz-Dziedzic/ath9k-add-debug-messages-to-aggr-chanctx-funcs/20151112-212004 base: https://git.kernel.org/pub/scm/linux/kernel

[PATCH 09/12] ath9k: request NOA update when chanctx active

2015-11-12 Thread Janusz Dziedzic
Request NOA update when chanctx active, also in case of STA. Signed-off-by: Janusz Dziedzic --- This depends on: [PATCH] mac80211: add new IEEE80211_VIF_GET_NOA_UPDATE flag drivers/net/wireless/ath/ath9k/channel.c | 2 +- drivers/net/wireless/ath/ath9k/main.c| 5 - 2 files changed, 5 in

[PATCH 03/12] ath9k: queue null frames in case of MCC

2015-11-12 Thread Janusz Dziedzic
While mac80211 using null frames when connection polling, we should queue this frames while NOA could be there, and AP, P2P_GO could be not present. Without this patch, with no traffic we often saw disconnections while we try to send nullfunc when AP/GO wasn't present. Signed-off-by: Janusz Dzied

[PATCH 02/12] ath9k: print real timer value

2015-11-12 Thread Janusz Dziedzic
In case of low HZ before this patch we saw wrong values in debug message. Print real timeout value. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/channel.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/

[PATCH 08/12] ath9k: P2P_CLIENT, get/set NOA correctly

2015-11-12 Thread Janusz Dziedzic
In case we get BSS_CHANGED_P2P_PS early, from mac80211, we didn't set NOA timer correctly, while p2p_ps_vif was NULL. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/channel.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/at

[PATCH 05/12] ath9k: use u32 when calculate tsf

2015-11-12 Thread Janusz Dziedzic
Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c index 5640e88..d86566b 100644 --- a/drivers/net/wireless/ath/ath9k/c

[PATCH 12/12] ath9k: MCC, print time elapsed between events

2015-11-12 Thread Janusz Dziedzic
This is useful for MCC debugging and bug fixing. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/ath9k.h | 1 + drivers/net/wireless/ath/ath9k/channel.c | 19 +-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/a

[PATCH 04/12] ath9k: P2P_CLIENT, send frames after 1ms AP/GO will aprear

2015-11-12 Thread Janusz Dziedzic
AP/GO will aprear after NOA, wait 1ms to be sure AP could receive/answer this frames. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/channel.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/cha

[PATCH 07/12] ath9k: MCC enable Opportunistic Power Save

2015-11-12 Thread Janusz Dziedzic
When adding NOA attr enable Opportunistiv Power Save. Before we calculate ctwindow but didn't enable oppps. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/channel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wi

[PATCH 10/12] ath9k: MCC, add NOA also in case of an AP

2015-11-12 Thread Janusz Dziedzic
In case of MCC and AP interface, add also NOA attr that will inform stations about absence of an AP. There is a chance that some stations will handle this NOA attr correctly and will know exactly when AP is present/absent. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/beacon.

[PATCH 01/12] ath9k: add debug messages to aggr/chanctx funcs

2015-11-12 Thread Janusz Dziedzic
Add/extend debug messages when chanctx used. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/channel.c | 11 --- drivers/net/wireless/ath/ath9k/hw.c | 8 drivers/net/wireless/ath/ath9k/xmit.c| 15 +++ 3 files changed, 27 insertions(+), 7 d

[PATCH 11/12] ath9k: MCC add sta_ap_ratio module param

2015-11-12 Thread Janusz Dziedzic
In case of MCC we can setup STA/AP(GO) ratio. Eg. setting sta_ap_ratio=80 STA will get 80% of time, while AP(GO) 20%. Setup correct ctwindow. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/ath9k.h | 2 + drivers/net/wireless/ath/ath9k/channel.c | 69 +---

[PATCH 06/12] ath9k: setup correct skb priority for nullfunc

2015-11-12 Thread Janusz Dziedzic
After queue nullfunc for MCC case, we hit WARN_ON in xmit.c:2398 while skb priority wasn't set. Signed-off-by: Janusz Dziedzic --- drivers/net/wireless/ath/ath9k/channel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-12 Thread Arnd Bergmann
On Thursday 12 November 2015 19:05:41 glen lee wrote: > Hi arnd, > > I appreciate the patches. > I did test this patch series on h/w which is arm based MCU. > From this patch wilc is not working properly. After downloading firmware, > the firmware cannot start and it fails. > I double check this

Re: [PATCH v3] ath10k: Override CE5 configuration for QCA6147 device

2015-11-12 Thread Julian Calaby
Hi Ryan, On Thu, Nov 12, 2015 at 5:21 AM, Ryan Hsu wrote: > 'Commit a70587b3389a ("ath10k: configure copy engine 5 for HTT messages")' > Introduces to use the unused CE5 for target to host message. > > For the device like QCA6174, CE5 already assigned for other feature. > So for QCA6174, override

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-12 Thread glen lee
Hi arnd, I appreciate the patches. I did test this patch series on h/w which is arm based MCU. From this patch wilc is not working properly. After downloading firmware, the firmware cannot start and it fails. I double check this patch and the previous one(14/20) which works fine. I cannot find t

[RFC v4 5/8] mac80211: generate hw flags from include file

2015-11-12 Thread Johannes Berg
From: Johannes Berg Instead of having to list all the hw flags in many places, just list the macro to generate everything in a new include file and include it in the proper places. Unfortunately this breaks docbook processing since that doesn't pre-process the file. It also doesn't generate the

[RFC v4 6/8] kconfig: introduce "count"

2015-11-12 Thread Johannes Berg
From: Johannes Berg "count" works similar to "select"; take, for example, this snippet: config MY_COUNTER int config MY_DRIVER_1 bool "my driver 1" count MY_COUNTER config MY_DRIVER_2 bool "my driver 2" count MY_COUNTER T

[RFC v4 2/8] mac80211: introduce ieee80211_local_check()

2015-11-12 Thread Johannes Berg
From: Johannes Berg This will later allow introducing different behaviour between driver and hw checks. Make mac80211 use the new check function almost everywhere - one place cannot (rate control) and two of them shouldn't get the behaviour I want to introduce (in hw registration.) Signed-off-by

[RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation

2015-11-12 Thread Johannes Berg
From: Johannes Berg Drivers that would like to have feature flag optimisations are currently required to select _ON and _OFF symbols for each one, indicating whether they'd like to be optimised for being on or off respectively. This handles badly, if a new feature flag is added then all such driv

[RFC v4 0/8] mac80211: jump labels for HW flags

2015-11-12 Thread Johannes Berg
Changes since v3: * fix Kconfig count to count only enabled (!= n) symbols * fix code when CONFIG_JUMP_LABEL is not enabled Changes since v2: * introduce Kconfig count and use it instead of _ON/_OFF in the first few patches and described below (I'll squash that later if I don't abandon th

[RFC v4 4/8] mac80211: test the static key code

2015-11-12 Thread Johannes Berg
From: Johannes Berg Make hwsim select a few on/off symbols and check that the result is as expected: * before 'registering' a device the branches are according to the Kconfig default only * 'registering' a device fixes that up to actually check the hardware flags * 'unregistering' again

[RFC v4 7/8] kconfig: regenerate the shipped files

2015-11-12 Thread Johannes Berg
From: Johannes Berg Unfortunately, I again used a different version of the tools, so the changes are rather large. Signed-off-by: Johannes Berg --- scripts/kconfig/zconf.hash.c_shipped | 10 +- scripts/kconfig/zconf.lex.c_shipped | 62 +- scripts/kconfig/zconf.tab.c_shipped | 1600 ++

[RFC v4 3/8] mac80211: use static keys for hw flags

2015-11-12 Thread Johannes Berg
From: Johannes Berg There are many drivers with different behaviour, but in a lot of systems only a single driver will ever be built. In that case we could practically get rid of the code for the paths that this driver/device doesn't need. Doing that, however, would be rather dangerous. As a dec

[RFC v4 1/8] mac80211: add ieee80211_hw_clear()

2015-11-12 Thread Johannes Berg
From: Johannes Berg There are a few hardware flags that *are* valid to change, at least under certain circumstances. Since drivers are doing that, add an inline to make it easier to do correctly. They still need to take care of locking themselves. While at it, remove the pointless return in ieee

Re: [RFC v3 6/8] kconfig: introduce "count"

2015-11-12 Thread Johannes Berg
On Thu, 2015-11-12 at 08:59 +0100, Johannes Berg wrote: > On Wed, 2015-11-11 at 23:15 +0100, Johannes Berg wrote: > >   > > +static unsigned long long count_or_symbols(struct expr *e) > > +{ > > + switch (e->type) { > > + case E_SYMBOL: > > + return 1; > > Oh, this is obviously bogus

Re: [RFC v3 6/8] kconfig: introduce "count"

2015-11-12 Thread Johannes Berg
On Wed, 2015-11-11 at 23:15 +0100, Johannes Berg wrote: >  > +static unsigned long long count_or_symbols(struct expr *e) > +{ > + switch (e->type) { > + case E_SYMBOL: > + return 1; Oh, this is obviously bogus - I need to count the *enabled* symbols. johannes -- To unsubscribe