Re: [PATCH] staging: wilc1000: remove new line around else and braces

2015-11-13 Thread Panayiotis Tembriotis
On Sat, Nov 14, 2015 at 12:22:29PM +0530, Sudip Mukherjee wrote: > On Fri, Nov 13, 2015 at 11:59:47PM +0200, Panayiotis Tembriotis wrote: > > Remove excess new line characters as suggested by checkpatch.pl: > > ERROR: else should follow close brace '}' > > ERROR: that open brace { should be on the

Re: [PATCH] staging: wilc1000: remove new line around else and braces

2015-11-13 Thread Sudip Mukherjee
On Fri, Nov 13, 2015 at 11:59:47PM +0200, Panayiotis Tembriotis wrote: > Remove excess new line characters as suggested by checkpatch.pl: > ERROR: else should follow close brace '}' > ERROR: that open brace { should be on the previous line > > Signed-off-by: Panayiotis Tembriotis > --- This has

[PATCH v2 2/2] mac80211: passively scan DFS channels if requested

2015-11-13 Thread Antonio Quartulli
if the NL80211_SCAN_FLAG_PASSIVE_RADAR flag was specified upon sw scan start, passively scan any channel marked as DFS. Signed-off-by: Antonio Quartulli --- v2: fix variable names and add scan_req argument to ieee80211_scan_get_channel_time() net/mac80211/scan.c | 18 +- 1

[PATCH v2 1/2] nl80211: add flag to force passive scan on DFS channels

2015-11-13 Thread Antonio Quartulli
In certain circumstances the user might not want to actively scan DFS channels, therefore add a nl80211 scan flag to instruct the underlying layers that DFS channels must be passively scanned. This flag can be specified upon scan trigger command. Signed-off-by: Antonio Quartulli --- v2: no chan

BCM4350 doesn't resume correctly

2015-11-13 Thread Andy Lutomirski
I have a BCM4350: 3a:00.0 Network controller: Broadcom Corporation Device 43a3 (rev 08). It's a Dell M.2 wireless card. This card is supported in wireless-testing but not in 4.3. On resume, my wireless doesn't come up. When I manually turn on the link (by telling NetworkManager to turn it on),

Re: [PATCH v2] cfg80211: add VHT support for Mesh

2015-11-13 Thread Peter Oh
On 11/12/2015 11:37 PM, Johannes Berg wrote: On Thu, 2015-11-12 at 15:05 -0800, Peter Oh wrote: On 11/12/2015 02:32 PM, Johannes Berg wrote: On Thu, 2015-11-12 at 14:28 -0800, Peter Oh wrote: Exactly the same communication mechanism and purpose are used with NL80211_EXT_FEATURE_VHT_IBSS w

[PATCH] staging: wilc1000: remove new line around else and braces

2015-11-13 Thread Panayiotis Tembriotis
Remove excess new line characters as suggested by checkpatch.pl: ERROR: else should follow close brace '}' ERROR: that open brace { should be on the previous line Signed-off-by: Panayiotis Tembriotis --- drivers/staging/wilc1000/wilc_wlan.c | 10 +++--- 1 file changed, 3 insertions(+), 7 del

Re: Does mac80211 guarantee no data frames are sent to driver until encryption is setup?

2015-11-13 Thread Ben Greear
On 11/12/2015 10:14 PM, Janusz Dziedzic wrote: On 13 November 2015 at 01:59, Ben Greear wrote: A certain firmware tries to do EAPOL inspection and only allow data pkts to be sent after the 4-way M4 has been sent, for instance. This was breaking .11r because in that case you don't do the 4-way

Re: [PATCH 2/2] mac80211: passively scan DFS channels if requested

2015-11-13 Thread kbuild test robot
Hi Antonio, [auto build test WARNING on mac80211-next/master] [also build test WARNING on v4.3 next-20151113] url: https://github.com/0day-ci/linux/commits/Antonio-Quartulli/nl80211-add-flag-to-force-passive-scan-on-DFS-channels/20151114-025331 base: https://git.kernel.org/pub/scm/linux

Re: [PATCH 2/2] mac80211: passively scan DFS channels if requested

2015-11-13 Thread kbuild test robot
Hi Antonio, [auto build test ERROR on: mac80211-next/master] [also build test ERROR on: v4.3 next-20151113] url: https://github.com/0day-ci/linux/commits/Antonio-Quartulli/nl80211-add-flag-to-force-passive-scan-on-DFS-channels/20151114-025331 base: https://git.kernel.org/pub/scm/linux

[PATCH 1/2] nl80211: add flag to force passive scan on DFS channels

2015-11-13 Thread Antonio Quartulli
In certain circumstances the user might not want to actively scan DFS channels, therefore add a nl80211 scan flag to instruct the underlying layers that DFS channels must be passively scanned. This flag can be specified upon scan trigger command. Signed-off-by: Antonio Quartulli --- include/uap

[PATCH 2/2] mac80211: passively scan DFS channels if requested

2015-11-13 Thread Antonio Quartulli
if the NL80211_SCAN_FLAG_PASSIVE_RADAR flag was specified upon sw scan start, passively scan any channel marked as DFS. Signed-off-by: Antonio Quartulli --- net/mac80211/scan.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/net/mac80211/scan.c b/net/mac80211/sca

Re: [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation

2015-11-13 Thread Steven Rostedt
On Fri, 13 Nov 2015 17:35:39 +0100 Johannes Berg wrote: > On Fri, 2015-11-13 at 11:29 -0500, Steven Rostedt wrote: > > > > - select MAC80211_HW_HAS_RATE_CONTROL_OFF > > > - select MAC80211_HW_RX_INCLUDES_FCS_OFF > > > > What happened to these two? > > I removed the _OFF ones entirely, and

Re: [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation

2015-11-13 Thread Johannes Berg
On Fri, 2015-11-13 at 11:29 -0500, Steven Rostedt wrote: > > - select MAC80211_HW_HAS_RATE_CONTROL_OFF > > - select MAC80211_HW_RX_INCLUDES_FCS_OFF > > What happened to these two? I removed the _OFF ones entirely, and instead with this patch am now relying on modified logic:  _on  = flags_c

Re: [RFC v4 6/8] kconfig: introduce "count"

2015-11-13 Thread Johannes Berg
On Fri, 2015-11-13 at 11:26 -0500, Steven Rostedt wrote: >  > > config MY_DRIVER_2 > > bool "my driver 2" > > count MY_COUNTER > > > > This will get MY_COUNTER to have a value of 0, 1 or 2, depending > > on whether or not MY_DRIVER_1/MY_DRIVER_2 are not at all, one or >

Re: [RFC v4 5/8] mac80211: generate hw flags from include file

2015-11-13 Thread Johannes Berg
On Fri, 2015-11-13 at 11:25 -0500, Steven Rostedt wrote: > > + __DEFINE_HWFLAG(_flg, > > \ > > + IS_ENABLED(CONFIG_MAC80211_HW_##_flg##_ON) > > , \ > > + IS_ENABLED(CONFIG_MAC80211_HW_##_flg##_OFF > > )) > > +#include

Re: [RFC v4 3/8] mac80211: use static keys for hw flags

2015-11-13 Thread Johannes Berg
On Fri, 2015-11-13 at 11:22 -0500, Steven Rostedt wrote: > This sure could use a comment. > >  on = 0, off = 0,  -1 + (0^0) * (1 + 0) = -1 >  on = 0, off = 1,  -1 + (0^1) * (1 + 0) = 0 >  on = 1, off = 0,  -1 + (1^0) * (1 + 1) = 1 >  on = 1, off = 1,  -1 + (1^1) * (1 + 1) = -1 > > The I would al

Re: [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:53 +0100 Johannes Berg wrote: > From: Johannes Berg > > Drivers that would like to have feature flag optimisations are > currently required to select _ON and _OFF symbols for each one, > indicating whether they'd like to be optimised for being on or > off respectively.

Re: [RFC v4 6/8] kconfig: introduce "count"

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:51 +0100 Johannes Berg wrote: > From: Johannes Berg > > "count" works similar to "select"; take, for example, this snippet: > > config MY_COUNTER > int > > config MY_DRIVER_1 > bool "my driver 1" > count MY_COUNTER > >

Re: [RFC v4 5/8] mac80211: generate hw flags from include file

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:50 +0100 Johannes Berg wrote: > +#define __DEFINE_HWFLAG(_flg, _on, _off) \ > + HWFLAGS_DEFSTATE_##_flg = -1 + ((_on) ^ (_off)) * (1 + _on), > +#define DEFINE_HWFLAG(_flg) \ > + __DEFINE_HWFLAG

Re: [RFC v4 3/8] mac80211: use static keys for hw flags

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:48 +0100 Johannes Berg wrote: > index ..e220c5e04406 > --- /dev/null > +++ b/net/mac80211/hwflags.h > @@ -0,0 +1,89 @@ > +/* > + * Copyright 2015Intel Deutschland GmbH > + * > + * This program is free software; you can redistribute it and/or modify > + *

Re: [PATCH] nfc: s3fwrn5: constify s3fwrn5_phy_ops structures

2015-11-13 Thread Robert Baldyga
On 11/13/2015 01:04 PM, Julia Lawall wrote: > The s3fwrn5_phy_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Robert Baldyga Thanks! Robert Baldyga > > --- > drivers/nfc/s3fwrn5/core.c|2 +- >

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-13 Thread Sudip Mukherjee
On Mon, Nov 09, 2015 at 08:09:36PM +0530, punit vara wrote: > On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee > wrote: > > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: > >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: > >> > > >> > > >> > On 2015년 11월 09일 18:05, punit vara wrote

DFS Master Region

2015-11-13 Thread Xose Vazquez Perez
Larry Finger wrote: > I'm trying to understand a problem that some users are having with the 5G > band > when using rtl8821ae. One of them sees the following output from cfg80211: > [...] > One other possible difference. My openSUSE system uses CRDA 1.1.3. The other > box > runs Fedora 23 with

[PATCH] nfc: s3fwrn5: constify s3fwrn5_phy_ops structures

2015-11-13 Thread Julia Lawall
The s3fwrn5_phy_ops structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/nfc/s3fwrn5/core.c|2 +- drivers/nfc/s3fwrn5/i2c.c |2 +- drivers/nfc/s3fwrn5/s3fwrn5.h |4 ++-- 3 files changed, 4 insertions(

Re: [PATCH v2] ath9k: incorrect queue may be stopped/awaken

2015-11-13 Thread Kalle Valo
Borja Salazar writes: > Let me explain the patch more thoroughly. We are testing MCC and we've > found some issues with the queues handlers, the main problem is that > when we transmit a multicast/broadcast frame, where hw_queue is 8 > (CAB), we check queue status, which is 2(q), and if it is ful

Re: [PATCH v2] ath9k: incorrect queue may be stopped/awaken

2015-11-13 Thread Borja Salazar
arggg, you are right, we have it the right way as a patch for openwrt, I made a mistake generating kernel patch, will send V3 Borja Salazar Firmware team All information in this email is confidential On Fri, Nov 13, 2015 at 12:19 PM, Janusz Dziedzic wrote: > Send again as txt. > > > On 13 Novemb

Re: [PATCH v2] ath9k: incorrect queue may be stopped/awaken

2015-11-13 Thread Janusz Dziedzic
Send again as txt. On 13 November 2015 at 12:17, Janusz Dziedzic wrote: > > > > On 13 November 2015 at 11:45, Borja Salazar wrote: >> >> Hi, >> >> Let me explain the patch more thoroughly. We are testing MCC and we've found >> some issues with the queues handlers, the main problem is that when

[PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

2015-11-13 Thread Saurabh Sengar
added the sysfs entry for nfcsim workqueue delay, as tx_delay Signed-off-by: Saurabh Sengar --- implementing the TODO task drivers/nfc/nfcsim.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/drivers/nfc/nfcsim.c b/drivers/nfc/nfcsim.c

Re: [PATCH v2] ath9k: incorrect queue may be stopped/awaken

2015-11-13 Thread Borja Salazar
Hi, Let me explain the patch more thoroughly. We are testing MCC and we've found some issues with the queues handlers, the main problem is that when we transmit a multicast/broadcast frame, where hw_queue is 8 (CAB), we check queue status, which is 2(q), and if it is full and we have to stop it, w

[PATCH v2] ath9k: incorrect queue may be stopped/awaken

2015-11-13 Thread Borja Salazar
When channel context is enabled, we could be stopping/awakening an incorrect queue. Signed-off-by: Borja Salazar --- drivers/net/wireless/ath/ath9k/xmit.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers

Re: [RFC v5 4/5] mac80211: use Kconfig counters to elide unnecessary code

2015-11-13 Thread Johannes Berg
On Fri, 2015-11-13 at 10:52 +0100, Johannes Berg wrote: >  >    (CONFIG_MAC80211_DRIVER_NO_HWFLAGS > 0),   Of course not, it's a bool. Anyway, thanks! johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to major

Re: [RFC v5 4/5] mac80211: use Kconfig counters to elide unnecessary code

2015-11-13 Thread Johannes Berg
On Fri, 2015-11-13 at 20:48 +1100, Julian Calaby wrote: >  > Am I missing something or are you not actually doing anything with > MAC80211_DRIVER_NO_HWFLAGS? > Crap. I meant to pass it to the macro like this (I think): #define __DEFINE_HWFLAG(_flg, _dyn, _on, _off) \

Re: [RFC v5 4/5] mac80211: use Kconfig counters to elide unnecessary code

2015-11-13 Thread Julian Calaby
Hi Johannes, On Fri, Nov 13, 2015 at 9:00 AM, Johannes Berg wrote: > From: Johannes Berg > > There are many drivers with different behaviour, but in a lot of > systems only a single driver will ever be built. In that case we > can get rid of code paths that this driver doesn't need and also > op

Re: [PATCH 6/9] brcmfmac: Add RSDB support.

2015-11-13 Thread Kalle Valo
Arend van Spriel writes: > On 11/12/2015 08:49 PM, Kalle Valo wrote: >> Arend van Spriel writes: >> >>> From: Hante Meuleman >>> >>> RSDB works almost autonomously in firmware except for AP config. >>> When device supports RSDB then the interface should not be >>> brought down when configuring

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-13 Thread Arnd Bergmann
On Friday 13 November 2015 16:49:22 glen lee wrote: > > Hi arnd, > > I found this. These should be like this. It works fine. > + .hif_block_tx_ext = sdio_write, > + .hif_block_rx_ext = sdio_read, > > also, wilc_hif_spi need to be fixed together like this. > + .hif_block_tx_ext

Re: [PATCH 6/9] brcmfmac: Add RSDB support.

2015-11-13 Thread Arend van Spriel
On 11/12/2015 08:49 PM, Kalle Valo wrote: Arend van Spriel writes: From: Hante Meuleman RSDB works almost autonomously in firmware except for AP config. When device supports RSDB then the interface should not be brought down when configuring it, otherwise the link (if configured) on the othe