Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Krishna Chaitanya
On Wed, Dec 9, 2015 at 12:52 AM, Grumbach, Emmanuel wrote: > > > On 12/08/2015 09:11 PM, Krishna Chaitanya wrote: >> >> >> On Dec 9, 2015 12:37 AM, "Grumbach, Emmanuel" >> mailto:emmanuel.grumb...@intel.com>> wrote: >> > >> > >> > >> > On 12/08/2015 07:49 PM, Krishna Chaitanya wrote: >> > > >> > >

[PATCH] mtd: bcm47xxnflash: really unregister NAND on device removal

2015-12-08 Thread Brian Norris
The field bcma_nflash::mtd is never set to be non-zero anywhere, but we test for it in the removal path. So the MTD is never unregistered. Also, we should use nand_release(), not mtd_device_unregister(). Finally, we don't need to use the 'platdata' for stashing/retrieving our *driver* data -- tha

[PATCH] ath9k: fix inconsistent indenting on return statement

2015-12-08 Thread Colin King
From: Colin Ian King minor change, indenting is one tab out. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath9k/xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c index 3e3dac3.

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 09:11 PM, Krishna Chaitanya wrote: > > > On Dec 9, 2015 12:37 AM, "Grumbach, Emmanuel" > mailto:emmanuel.grumb...@intel.com>> wrote: > > > > > > > > On 12/08/2015 07:49 PM, Krishna Chaitanya wrote: > > > > > > > > > On Dec 8, 2015 10:13 PM, "Grumbach, Emmanuel" > > > mailto:emmanuel

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 07:49 PM, Krishna Chaitanya wrote: > > > On Dec 8, 2015 10:13 PM, "Grumbach, Emmanuel" > mailto:emmanuel.grumb...@intel.com>> wrote: > > > > > > > > On 12/08/2015 06:35 PM, Krishna Chaitanya wrote: > > > > > > > > > On Dec 8, 2015 10:01 PM, "Grumbach, Emmanuel" > > > mailto:emmanuel

Re: pull-request: wireless-drivers-next 2015-12-07

2015-12-08 Thread David Miller
From: Kalle Valo Date: Mon, 07 Dec 2015 19:46:45 +0200 > here's the first "real" pull request after the wireless directory > reorganisation. Nothing really out ordinary, new features and bugfixes > as usual. This time there's a regression in ath10k because of a bugfix > in wireless-drivers.git wh

Re: [PATCH 2/2] mac80211: support hw managing reorder logic

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 07:09 PM, Grumbach, Emmanuel wrote: > From: Sara Sharon > > Enable driver to manage the reordering logic itself. > This is needed for example for the iwlwifi driver that > supports hardware based reordering. > > type=feature Ouch - sorry for that. I guess you'll edit? Or you want

[PATCH 1/2] mac80211: pass block ack session timeout to to driver

2015-12-08 Thread Emmanuel Grumbach
From: Sara Sharon Currently mac80211 does not inform the driver of the session block ack timeout when starting a rx aggregation session. Drivers that manage the reorder buffer need to know this parameter. Seeing that there are now too many arguments for the drv_ampdu_action() function, wrap them

[PATCH 2/2] mac80211: support hw managing reorder logic

2015-12-08 Thread Emmanuel Grumbach
From: Sara Sharon Enable driver to manage the reordering logic itself. This is needed for example for the iwlwifi driver that supports hardware based reordering. type=feature Signed-off-by: Sara Sharon Signed-off-by: Emmanuel Grumbach --- include/net/mac80211.h | 6 ++ net/mac80211/agg

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 06:35 PM, Krishna Chaitanya wrote: > > > On Dec 8, 2015 10:01 PM, "Grumbach, Emmanuel" > mailto:emmanuel.grumb...@intel.com>> wrote: > > > > > > > > On 12/08/2015 06:03 PM, Krishna Chaitanya wrote: > > > On Tue, Dec 8, 2015 at 7:34 PM, Emmanuel Grumbach > > > mailto:emmanuel.grumb..

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 06:03 PM, Krishna Chaitanya wrote: > On Tue, Dec 8, 2015 at 7:34 PM, Emmanuel Grumbach > wrote: >> index 7a76ce6..f4a5287 100644 >> --- a/net/mac80211/ht.c >> +++ b/net/mac80211/ht.c >> @@ -230,6 +230,11 @@ bool ieee80211_ht_cap_ie_to_sta_ht_cap(struct >> ieee80211_sub_if_data *sd

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

2015-12-08 Thread Krishna Chaitanya
On Tue, Dec 8, 2015 at 9:28 PM, Johannes Berg wrote: > On Tue, 2015-12-08 at 21:25 +0530, Krishna Chaitanya wrote: >> On Tue, Dec 8, 2015 at 9:23 PM, Johannes Berg > net> wrote: >> > On Tue, 2015-12-08 at 21:17 +0530, Krishna Chaitanya wrote: >> > > >> > > > If the rate control algorithm doesn't l

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Krishna Chaitanya
On Tue, Dec 8, 2015 at 7:34 PM, Emmanuel Grumbach wrote: > index 7a76ce6..f4a5287 100644 > --- a/net/mac80211/ht.c > +++ b/net/mac80211/ht.c > @@ -230,6 +230,11 @@ bool ieee80211_ht_cap_ie_to_sta_ht_cap(struct > ieee80211_sub_if_data *sdata, > /* set Rx highest rate */ > ht_cap.mc

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

2015-12-08 Thread Johannes Berg
On Tue, 2015-12-08 at 21:25 +0530, Krishna Chaitanya wrote: > On Tue, Dec 8, 2015 at 9:23 PM, Johannes Berg net> wrote: > > On Tue, 2015-12-08 at 21:17 +0530, Krishna Chaitanya wrote: > > > > > > > If the rate control algorithm doesn't look at sta->sta.rx_nss > > > > then > > > > that's their bug

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

2015-12-08 Thread Krishna Chaitanya
On Tue, Dec 8, 2015 at 9:23 PM, Johannes Berg wrote: > On Tue, 2015-12-08 at 21:17 +0530, Krishna Chaitanya wrote: >> >> > If the rate control algorithm doesn't look at sta->sta.rx_nss then >> > that's their bug. >> >> Yes, it looks like it. Only BW is handled, not the NSS change, and >> without t

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

2015-12-08 Thread Johannes Berg
On Tue, 2015-12-08 at 21:17 +0530, Krishna Chaitanya wrote: >  > > If the rate control algorithm doesn't look at sta->sta.rx_nss then > > that's their bug. > > Yes, it looks like it. Only BW is handled, not the NSS change, and > without this patch OP MODE IE in beacon updates neither NSS nor BW. >

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

2015-12-08 Thread Johannes Berg
On Tue, 2015-12-08 at 21:08 +0530, Krishna Chaitanya wrote: >  > >  void ieee80211_vht_handle_opmode(struct ieee80211_sub_if_data > > *sdata, > >  struct sta_info *sta, u8 opmode, > > -enum ieee80211_band band, bool > > nss_only) > > +

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

2015-12-08 Thread Krishna Chaitanya
On Tue, Dec 8, 2015 at 9:12 PM, Johannes Berg wrote: > On Tue, 2015-12-08 at 21:08 +0530, Krishna Chaitanya wrote: >> >> > void ieee80211_vht_handle_opmode(struct ieee80211_sub_if_data >> > *sdata, >> > struct sta_info *sta, u8 opmode, >> > -

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

2015-12-08 Thread Krishna Chaitanya
On Tue, Dec 8, 2015 at 7:34 PM, Emmanuel Grumbach wrote: > > From: Eyal Shapira > > An AP can send an operating channel width change in a beacon > opmode notification IE as long as there's a change in the nss as > well (See 802.11ac-2013 section 10.41). > So don't limit updating to nss only from

ATH10K VLAN firmware issue

2015-12-08 Thread Cedric VONCKEN
I'm testing to transmit frame with 802.1q tag (VLAN). My client is set in STA + WDS and the netdev is bridged with eth0. I have a computer with vlan configuration set connected to the STA eth0. If I try to transmit frames with 802.1q tag, the frames are not sent.

Re: [PATCH v2 01/13] ath9k: add debug messages to aggr/chanctx funcs

2015-12-08 Thread Kalle Valo
Janusz Dziedzic writes: > Add/extend debug messages when chanctx used. > > Signed-off-by: Janusz Dziedzic Manually applied these patches to ath.git: 05a85a6c42b5 ath9k: remove ath9k_mod_tsf64_tu 02edab5b5f82 ath9k: MCC, print time elapsed between events a64d876ef7dc ath9k: MCC, add NOA also in

Re: [PATCH] wil6210: prevent external wmi commands during suspend flow

2015-12-08 Thread Kalle Valo
Maya Erez writes: > In __wmi_send we check if fw is ready at the beginning of the function. > While we wait for the completion of the previous command, system suspend > can be invoked and reset the HW, causing __wmi_send to read from HW > registers while it is not ready. > Taking the wmi_mutex in

Re: [PATCH] ath5k: fix RTS/CTS by using proper rate flags

2015-12-08 Thread Kalle Valo
Bob Copeland writes: > The rates in the tx control rateset do not have the protection > flags applied, so RTS/CTS would never get enabled if requested. > > Fix by using the rate flags in the rates returned by > ieee80211_get_tx_rates(). > > Signed-off-by: Bob Copeland Applied, thanks. -- Kall

Re: [PATCH] ath6kl: Don't print error message when recv is canceled

2015-12-08 Thread Kalle Valo
Steve deRosier writes: > An error message ath6kl_htc_rxmsg_pending_handler isn't appropate for when > the error is ECANCELED. This could be the result of a perfectly appropriate > RX cancel due to shutdown or suspend. This allows the right cleanup to > continue, but without an alarming error mess

Re: [PATCH V2] ath9k: Simplify and fix eeprom endianness swapping

2015-12-08 Thread Kalle Valo
Martin Blumenstingl writes: > The three eeprom implementations had quite some duplicate code when it > came to endianness swapping. > Additionally there was a bug in eeprom_4k and eeprom_9287 which > prevented the endianness swapping from working correctly, because the > swapping code was guarded

Re: [PATCH v2] ath10k: do not use coherent memory for allocated device memory chunks

2015-12-08 Thread Kalle Valo
Felix Fietkau writes: > Coherent memory is more expensive to allocate (and constrained on some > architectures where it has to be pre-allocated). It is also completely > unnecessary, since the host has no reason to even access these allocated > memory spaces > > Signed-off-by: Felix Fietkau App

Re: [PATCH] ath10k: Remove unnecessary amsdu/ampdu assignment in debugfs

2015-12-08 Thread Kalle Valo
Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > The default values of max_num_amsdu / max_num_amdpu is assigned a > default value as part of 'ath10k_core_init_firmware_features' > > Signed-off-by: Mohammed Shafi Shajakhan Applied, thanks. -- Kalle Valo -- To unsubscribe

[PATCH 9/9] mac80211: reprogram in interface order

2015-12-08 Thread Emmanuel Grumbach
From: Johannes Berg During reprogramming, mac80211 currently first adds all the channel contexts, then binds them to the vifs and then goes to reconfigure all the interfaces. Drivers might, perhaps implicitly, rely on the operation order for certain things that typically happen within a single fu

[PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Emmanuel Grumbach
In VHT, the specification allows to limit the number of MSDUs in an A-MSDU in the Extended Capabilities IE. There is also a limitation on the byte size in the VHT IE. In HT, the only limitation is on the byte size. Parse the capabilities from the peer and make them available to the driver. In HT,

[PATCH 4/9] mac80211: pass aggregation window size to lower level

2015-12-08 Thread Emmanuel Grumbach
From: Sara Sharon Currently mac80211 does not inform the driver of the window size when starting a rx aggregation session. Following patches will enable managing the reorder buffer in the driver or hardware, and the window size is needed. Signed-off-by: Sara Sharon Signed-off-by: Emmanuel Grumb

[PATCH 8/9] mac80211: run scan completed work on reconfig failure

2015-12-08 Thread Emmanuel Grumbach
From: Johannes Berg When reconfiguration during resume fails while a scan is pending for completion work, that work will never run, and the scan will be stuck forever. Factor out the code to recover this and call it also in ieee80211_handle_reconfig_failure(). Signed-off-by: Johannes Berg ---

[PATCH 3/9] mac80211: add flag for duplication check

2015-12-08 Thread Emmanuel Grumbach
From: Sara Sharon Add an option for driver to check for packet duplication by itself. This is needed for example by the iwlwifi driver which parallelizes the RX path and does the duplcation check per queue. Signed-off-by: Sara Sharon Signed-off-by: Emmanuel Grumbach --- include/net/mac80211.h

[PATCH 1/9] mac80211: process and save VHT MU-MIMO group frame

2015-12-08 Thread Emmanuel Grumbach
From: Sara Sharon The Group ID Management frame is an Action frame of category VHT. It is transmitted by the AP to assign or change the user position of a STA for one or more group IDs. Process and save the group membership data. Notify underlying driver of changes. Signed-off-by: Sara Sharon S

[PATCH 0/9] various mac80211 / cfg80211 patches

2015-12-08 Thread Emmanuel Grumbach
Hi Johannes, This is a mix of a few random things. A few of things seem to deserved to be merge in mac80211.git, but all this is based on mac80211-next.git. Emmanuel Grumbach (1): mac80211: limit the A-MSDU Tx based on peer's capabilities Eyal Shapira (1): mac80211: handle width changes from

[PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

2015-12-08 Thread Emmanuel Grumbach
From: Eyal Shapira An AP can send an operating channel width change in a beacon opmode notification IE as long as there's a change in the nss as well (See 802.11ac-2013 section 10.41). So don't limit updating to nss only from an opmode notification IE. Signed-off-by: Eyal Shapira Signed-off-by:

[PATCH 7/9] mac80211: suppress unchanged "limiting TX power" messages

2015-12-08 Thread Emmanuel Grumbach
From: Johannes Berg When the AP is advertising limited TX power, the message can be printed over and over again. Suppress it when the power level isn't changing. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=106011 Signed-off-by: Johannes Berg --- net/mac80211/mlme.c | 15 ++-

[PATCH 5/9] mac80211: document status.freq restrictions

2015-12-08 Thread Emmanuel Grumbach
From: Johannes Berg It's not always necessary to set the status.freq field, for example when this would be an expensive calculation. It must be set for all management frames (as they might be reported to userspace), but for data frames it's not really required. Document this. Signed-off-by: Joha

Re: wireless-testing rebased, new HEAD commit f5feec4244464225c03ccc9ddad615cb43a044cc

2015-12-08 Thread Bob Copeland
On Mon, Dec 07, 2015 at 02:39:11PM -0500, John W. Linville wrote: > All, > > An earlier pull got a version of mac80211.git that was later reverted. > Unfortunately, the intervening merges got things so screwed-up I > couldn't reasonably unravel them. So, I have taken the somewhat > unusual step o

Re: Fixing full name in patchwork

2015-12-08 Thread Kalle Valo
Sudip Mukherjee writes: > On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote: >> Sudip Mukherjee writes: >> >> > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: >> >> Hi Sudip, >> >> >> >> Sudip Mukherjee writes: >> >> > >> > >> > I have also noticed the patch. Anyway, I

Re: Fixing full name in patchwork

2015-12-08 Thread Sudip Mukherjee
On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote: > Sudip Mukherjee writes: > > > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: > >> Hi Sudip, > >> > >> Sudip Mukherjee writes: > >> > > > > I have also noticed the patch. Anyway, I have created a profile in > > patchwor