Re: Mediatek wifi

Sorry, 's/usb/pci' On Mon, Dec 21, 2015 at 2:09 PM, Anca Emanuel wrote: > Hi Linus Walleij, and everyone interested. > > http://askubuntu.com/questions/676390/no-wi-fi-on-ubuntu-14-04-lts-asus-notebook-with-mediatek-mt7630e > > Here is the bug report: >

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

Hi Brent, On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: > Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to > be pointing to memory allocated by vmalloc. If the api1 method (via > ath6kl_fetch_fw_api1) is used to allocate memory for ar->fw,

[PATCH 02/45] iwlwifi: mvm: add an option to start rs from HT/VHT rates

From: Gregory Greenman Extend the configurable option of setting initial rate to RSSI based. Make the initial rate to be set to VHT/HT SISO or legacy depending on the AP capabilities. Signed-off-by: Gregory Greenman Signed-off-by:

[PATCH 03/45] iwlwifi: mvm: set default new STA as non-aggregated

From: Liad Kaufman When sending the first ADD_STA HCMD for a STA, the %add_modify field indicates an addition of a STA and not a modification of one. In such a case, all fields of the HCMD are used to initialize the corresponding fields in the FW, regardless of what bits

[PATCH 01/45] iwlwifi: mvm: don't keep an mvm ref when the interface is down

From: Luca Coelho There is no reason to keep a reference when the interface is down, since we are not really doing anything. The reference is only needed when the mac80211 start op (or a hw restart) is running, to prevent going into runtime or system supend in the

[PATCH 28/45] iwlwifi: pcie: build an A-MSDU using TSO core

When the op_mode sends an skb whose payload is bigger than MSS, PCIe will create an A-MSDU out of it. PCIe assumes that the skb that is coming from the op_mode can fit in one A-MSDU. It is the op_mode's responsibility to make sure that this guarantee holds. Additional headers need to be built for

[PATCH 44/45] iwlwifi: fix printf specifier

Smatch warned about a bad specifier being used. Fix that. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 36/45] iwlwifi: mvm: change iwl_mvm_get_key_sta_id() to return the station

From: Johannes Berg The code in iwl_mvm_update_tkip_key() is now pretty much duplicated with the code in iwl_mvm_get_key_sta_id() doing the station ID lookup again after it was already done. Change iwl_mvm_get_key_sta_id() to iwl_mvm_get_key_sta(), returning the mvm_sta

[PATCH 32/45] iwlwifi: mvm: support description for user triggered fw dbg collection

From: Golan Ben-Ami Add to the user triggered fw debug collection support for describing the reason of the trigger. This could be useful for identifying a dump by a unique id, passed as a description. Signed-off-by: Golan Ben-Ami Signed-off-by:

[PATCH 42/45] iwlwifi: update key params on d0i3 entrance/exit

From: Eliad Peller In order to let the fw do offloading properly, we need to provide various key data (e.g. PN). Configure the params on d0i3 entrance, and update them back on d0i3 exit. Since d3 code is now called in d0i3 which requires runtime pm only, make d3.0 depend on

[PATCH 40/45] iwlwifi: Update PCI IDs for 8000 and 9000 series

From: Oren Givon A new PCI IDs update to the 8000 and 9000 series. type=feature Signed-off-by: Oren Givon Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 11 ++- 1 file

[PATCH 33/45] iwlwifi: mvm: small update in the firmware API

Small change in firmware API, no functional change. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api-rx.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH 39/45] iwlwifi: mvm: dump more registers upon error

These registers can help to debug PHY issues. Since this adds a significant amount of work to the debug collection phase, dump the periphery registers only if the firmware is stopped. Signed-off-by: Emmanuel Grumbach ---

[PATCH 41/45] iwlwifi: mvm: Change number of associated stations when station becomes associated

From: Ayala Beker Currently, the number of associated stations gets updated when adding a new station or removing it. This is incorrect as it's possible that a station was inserted before it was associated Fix this by increasing/decreasing ap_assoc_sta_count whenever a

[PATCH 38/45] iwlwifi: mvm: infrastructure for frame-release message

From: Sara Sharon Incoming hardware will send frame release notifications to the reorder buffer in order to update with the BA session status and up to date NSSN. This patch enables the API. Signed-off-by: Johannes Berg Signed-off-by: Sara Sharon

[PATCH 37/45] iwlwifi: mvm: add 9000 series RX processing

From: Johannes Berg Convert the convert the new infrastructure added by previous patches to actually use the new RX descriptor layout. Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach ---

[PATCH 31/45] iwlwifi: mvm: enable L3 filtering

From: Sara Sharon Firmware will support filtering multicast L3 packets. The L3 filtering is configured by the WOWLAN_CONFIG command. All flags should be enabled by default. Older firmware is not affected as it does not look into this field. Signed-off-by: Sara Sharon

[PATCH 43/45] iwlwifi: remove unused parameter from grab_nic_access

All the callers used silent = false. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/dvm/main.c | 4 ++-- drivers/net/wireless/intel/iwlwifi/dvm/tt.c | 2 +- drivers/net/wireless/intel/iwlwifi/iwl-io.c | 14 ++---

[PATCH 45/45] iwlwifi: bail out in case of bad trans state

From: Eliad Peller In case of bad trans state (i.e. fw is not loaded) bail out immediately instead of calling the trans, which might not be fully initialized yet. Also add WARN_ON_ONCE to help debugging where the errorneous call is coming from. Signed-off-by: Eliad Peller

[PATCH 34/45] iwlwifi: mvm: add extended dwell time

From: David Spinadel When doing active scan on crowded channels we are likely to miss probe responses due to collisions. To overcome this issue we use an extended dwell time on channels 1, 6 and 11; this dwell time is set to 100. In case of fragmented scan extended

[PATCH 30/45] iwlwifi: mvm: refactor the way fw_key_table is handled

From: Luca Coelho Instead of keeping the fw_key_table bits set when the keys are removed (i.e. in D3 entry or HW_RESTART flows), clear them and set them again only when the keys have been successfully re-added. This makes the bitmask more closely tied to the actual

[PATCH 35/45] iwlwifi: mvm: Add a station in monitor mode

From: Chaya Rachel Ivgi Currently when creating a new vif in monitor mode the driver doesn't allocate a specific station. This causes that in the situation that tx traffic is injected, the tx queues are not scheduled, with the result of a TFD queue hang. Fix that by

Re: [PATCH RESEND 03/46] staging: wilc1000: rename index to tcp_pending_ack_idx

On Mon, Dec 21, 2015 at 02:18:07PM +0900, Glen Lee wrote: > This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since > this name could be confused index of txq_entry_t. It is index of tcp pending > ack. > > It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da You didn't

Re: pull request: iwlwifi-next-2015-12-21

On 12/21/2015 10:49 PM, Grumbach, Emmanuel wrote: > Hi Kalle, > > here is a pull request for 4.5. I guess there will be one more after that > depending on when Linus will open the merge window I guess. > The diffstat look awful and I have no clue why. It looks as if I had done the > whole code

Re: Panic in rtl8192ee on 4.2 kernel (Ubuntu 15.10)

On 12/19/2015 08:29 PM, Rich wrote: Hi all, (Apologies if this is the wrong place, but [1] said I should send my report here.) I've got a Lenovo ThinkPad T440 running Ubuntu 15.10 here, and under load, the rtl8192ee wireless driver will panic after a few minutes. The kernel is the Ubuntu

Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup()

On Mon, Dec 21, 2015 at 12:46:51AM +0300, Alexey Khoroshilov wrote: > If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(), > it calls release_bus() and continues execution. But it leads to double > release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex. > > Found

Re: [PATCH] enable setting MAC address for r8723au

On Mon, Dec 21, 2015 at 9:53 AM, Larry Finger wrote: > On 12/20/2015 08:28 PM, Dan Lenski wrote: >> >> Signed-off-by: Dan Lenski > > > The commit message should be in this patch rather than in the non-patch > previous mail. If this patch were to be

Re: [RFC/RFT 2/2] ath9k: request aligned skb

On Thu, Dec 17, 2015 at 2:50 PM, Janusz Dziedzic wrote: > > Set NEEDS_ALIGNED4_SKB hw flag. > This allow driver to save CPU and remove two memmove > from tx path. > > Signed-off-by: Janusz Dziedzic > --- >

pull request: iwlwifi-next-2015-12-21

Hi Kalle, here is a pull request for 4.5. I guess there will be one more after that depending on when Linus will open the merge window I guess. The diffstat look awful and I have no clue why. It looks as if I had done the whole code reorganisation... So we have a pretty large pull request here.

[PATCH 04/45] iwlwifi: mvm: configure scheduled scan according to traffic conditions

From: Avraham Stern Change scan configuration (dwell time, suspend time etc.) according to traffic conditions. This is useful for scans that are managed by the FW (e.g. scheduled scan). Signed-off-by: Avraham Stern Signed-off-by: Emmanuel

[PATCH 29/45] iwlwifi: 9000: increase the number of queues

9000 family devices have 31 queues. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/iwl-9000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-9000.c

[PATCH 16/45] iwlwifi: mvm: close the SP if we send fewer frames than expected in SP

When we have holes in the BA window, there might be frames that have been ACKed between the read and the right pointers. This means that these frames won't be scheduled again by the SCD and the firwmare won't see them. This invalidates the number of frames we tell the firmware to send. When we

[PATCH 15/45] iwlwifi: update host command messages to new format

From: Sharon Dvir Host commands now have a group id, express this in printed messages. Signed-off-by: Sharon Dvir Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/dvm/agn.h | 9 -

[PATCH 12/45] iwlwifi: trans: support a callback for ASYNC commands

This allows the op_mode to request from the transport to call a callback when an ASYNC commands is completed by the firmware. The same callback will be called for all the commands. Pass the command whose response triggers the callback as a parameter to the callback itself. Signed-off-by: Emmanuel

[PATCH 27/45] iwlwifi: clear ieee80211_tx_info->driver_data in the op_mode

The transport will need to use the info->driver_data pointers. Since the op_mode has this memory hot in cache, clear it there. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/dvm/tx.c| 1 + drivers/net/wireless/intel/iwlwifi/iwl-trans.h |

[PATCH 14/45] iwlwifi: uninline iwl_trans_send_cmd

This function got too big to be inlined. Uninline it. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/iwl-trans.c | 33 + drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 34 ++ 2 files changed,

[PATCH 10/45] iwlwifi: mvm: check iwl_mvm_wowlan_config_key_params() return value

From: Eliad Peller commit 9a4c830007817e ("iwlwifi: mvm: refactor d3 key update functions") refactored some code into iwl_mvm_wowlan_config_key_params() function, but the return value was never checked, and not all the function flows returned valid values. fix it. Fixes:

[PATCH 23/45] iwlwifi: change the Intel Wireless email address

i...@linux.intel.com is not available anymore. linuxw...@intel.com should be used instead. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/dvm/agn.h | 2 +- drivers/net/wireless/intel/iwlwifi/dvm/debugfs.c | 2 +-

[PATCH 26/45] iwlwifi: pcie: re-organize code towards TSO

The code that handles the TBs that contain the WiFi payload will be changed for TSO. Move the current code into a separate function. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 113 +++ 1 file changed,

[PATCH 09/45] iwlwifi: mvm: cleanup roc te on restart cleanup

From: Eliad Peller iwl_mvm_restart_cleanup() calls ieee80211_remain_on_channel_expired() on cleanup, but it doesn't clean the actual roc time events, resulting in failure of further ROC attempts. Refactor iwl_mvm_stop_roc() a bit, and add a new function to only cleanup the roc

[PATCH 11/45] iwlwifi: pcie: allow the op_mode to block the tx queues

In certain flows (see next patches), the op_mode may need to block the Tx queues for a short period. Provide an API for that. The transport is in charge of counting the number of times the queues are blocked since the op_mode may block the queues several times in a row before unblocking them.

[PATCH 13/45] iwlwifi: block the queues when we send ADD_STA for uAPSD

We send an ADD_STA to instruct the firmware to release frames despite the peer being in PS. Since the ADD_STA command and the Tx frame that comes immediately afterwards can be reordered by the DMA engine, we need to block the Tx queues until the firmware replies with the ADD_STA response.

[PATCH 21/45] iwlwifi: mvm: change protocol offload flows

From: Sara Sharon RFC4862 states that "In all cases, a node MUST NOT respond to a Neighbor Solicitation for a tentative address". Currently the driver configures the NS offload and does not wait for address to become permanent, thus violating the RFC. Just removing the

[PATCH 06/45] iwlwifi: mvm: advertise NETIF_F_SG

From: Johannes Berg If the transport supports it, advertise NETIF_F_SG to mac80211 to be able to use frag SKBs. This will already improve performance by allowing software GSO to be used. Signed-off-by: Johannes Berg Signed-off-by: Emmanuel

[PATCH 24/45] iwlwifi: pcie: allow to pretend to have Tx CSUM for debug

Allow to configure the driver to pretend to have TX CSUM offload support. This will be useful to test the TSO flows that will come in further patches. This configuration is disabled by default. Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach

[PATCH 17/45] iwlwifi: avoid d0i3 commands when no/init ucode is loaded

From: Eliad Peller d0i3 commands are not supported in the init image, so take a reference to ensure we don't enter d0i3 during init image, and additional checks to prevent d0i3 commands when no fw image is loaded. Add a few WARN_ON_ONCE to the d0i3 enter/exit commands to

[PATCH 08/45] iwlwifi: mvm: remove an extra tab

From: Dan Carpenter Smatch prints a static checker warning here: drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c:386 iwl_dump_prph() warn: curly braces intended? Curly braces are NOT intended, the extra tab was added by mistake in commit 1a616dd2f171

[PATCH 18/45] iwlwifi: mvm: remove the vif parameter of iwl_mvm_configure_bcast_filter()

From: Eliad Peller Remove the vif parameter of iwl_mvm_configure_bcast_filter() as it's not being used. Signed-off-by: Eliad Peller Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c |

[PATCH 05/45] iwlwifi: mvm: rs: fix a potential out of bounds access

From: Eyal Shapira Klocwork pointed these out. There is a theoretical possibility that rate->index might be set to IWL_RATE_INVALID (15). This could trigger an out of bounds access on ht_vht_rates or legacy_rates arrays. Fix it by adding some checks. Signed-off-by: Eyal Shapira

[PATCH 19/45] iwlwifi: replace d0i3_mode and wowlan_d0i3 with more generic variables

From: Luca Coelho The d0i3_mode variable is used to distinguish between transports that handle d0i3 entry during suspend by themselves (i.e. the slave transports) and those which rely on the op_mode layer to do it. The reason why the former do it by themselves is that

[PATCH 20/45] iwlwifi: expose fw usniffer mode to more utilities

From: Golan Ben-Ami Today, in order to configure fw in usniffer mode, the ucode must have the corresponding tlv, which is revealed to the driver while parsing the ucode. Expose the mode of the usniffer to other utilities in the driver (other than the ucode parser) by

[PATCH 25/45] iwlwifi: mvm: prepare the code towards TSO implementation

Differentiate between the cases where the skb is a large send and the other cases. Advertise TSO even if, at this stage, skb_gso_segment will be called and it will do all the work. Signed-off-by: Emmanuel Grumbach ---

[PATCH 22/45] iwlwifi: dvm: fix compare_const_fl.cocci warnings

From: Julia Lawall Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci type=cleanup Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall Signed-off-by: Emmanuel

[PATCH 07/45] iwlwifi: dvm: advertise NETIF_F_SG

From: Johannes Berg If the transport supports it, advertise NETIF_F_SG to mac80211 to be able to use frag SKBs. This will already improve performance by allowing software GSO to be used. Signed-off-by: Johannes Berg Signed-off-by: Emmanuel

Re: [PATCH v1 3/7] ima: load policy using path

On Thu, Dec 17, 2015 at 11:33 AM, Luis R. Rodriguez wrote: > Please no, instead of adding yet-another kernel file-loading facility which is > likely error prone we should consolidate *all kernel file-loading facilities* > into a *common generic shared one*. So please work to make

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

occinelle script (relaxed version of > scripts/coccinelle/api/alloc/kzalloc-simple.cocci) > > Patch was compile tested with: x86_64_defconfig + > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) > > Patch is against linux-next (localversion-next is -next-20151221) > > drivers/net/wireles

Re: [linux-nfc] [ PATCH v5 2/3] driver: nfc: Add ST95HF NFC Transceiver support

On Mon, Dec 21, 2015 at 11:45:35PM +0100, Samuel Ortiz wrote: > Hi Shikha, > > On Mon, Dec 21, 2015 at 07:57:23PM +0800, Shikha SINGH wrote: > > Hello Samuel, > > Please see my answer below. > > > > >This looks a lot better than the initial version. > > >I only have one question: > > > >

Re: [[linux-nfc] PATCH v5 2/3] driver: nfc: Add ST95HF NFC Transceiver support

Hi Shikha, On Mon, Dec 21, 2015 at 07:57:23PM +0800, Shikha SINGH wrote: > Hello Samuel, > Please see my answer below. > > >This looks a lot better than the initial version. > >I only have one question: > > > >On Fri, Nov 20, 2015 at 06:40:20AM -0500, Shikha Singh wrote: > >> +/* >

[PATCH 02/13] staging: wilc1000: match argument name of wilc_add_ptk declaration

Some arguments name of wilc_add_pkt declaration is different to those of this function definition. It is changed as same name of this function declaration and definition. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 6 +++--- 1 file

[PATCH 08/13] staging: wilc1000: replace u32 with int

The data type of variable i changes u32 to int. It is used as array index to copy some data with memcpy function so that it is better to use data type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1

[PATCH 10/13] staging: wilc1000: fix return type of wilc_get_mac_address

This patch changes return type of wilc_get_mac_address from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim

[PATCH 09/13] staging: wilc1000: rename pu8PmkidInfoArray in wilc_set_pmkid_info

This patch changes pu8PmkidInfoArray to pmkid to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 01/13] staging: wilc1000: fix return type of wilc_add_pkt declaration

This patch changes return type of wilc_add_pkt declaration from s32 to int. The return type of this function declaration and definition should be same as data type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 2 +- 1 file changed, 1

[PATCH 05/13] staging: wilc1000: remove wilc_add_tx_gtk declaration

This patch deletes wilc_add_tx_gtk declaration. It is not find wilc_add_tx_gtk definition in this driver. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 07/13] staging: wilc1000: fix return type of wilc_set_pmkid_info

This patch changes return type of wilc_set_pmkid_info from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim

[PATCH 03/13] staging: wilc1000: fix return type of wilc_add_rx_gtk declaration

This patch changes return type of wilc_add_rx_gtk declaration from s32 to int. The return type of this function declaration and definition should be same as data type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 2 +- 1 file

[PATCH 06/13] staging: wilc1000: remove wilc_set_start_scan_req declaration

This patch deletes wilc_set_start_scan_req declaration. It is not find wilc_set_start_scan_req definition in this driver. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 04/13] staging: wilc1000: match argument name of wilc_add_rx_gtk declaration

Some argument name of wilc_add_rx_gtk declaration is different to those of this function definition. It is changed as same name of this function declaration and definition. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 8 1 file

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder wrote: > Hi Brent, > > On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: >> Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to >> be pointing to memory allocated by vmalloc.

Re: [RFC/RFT 2/2] ath9k: request aligned skb

Hi, On Tue, Dec 22, 2015 at 5:53 AM, Souptick Joarder wrote: > On Thu, Dec 17, 2015 at 2:50 PM, Janusz Dziedzic > wrote: >> >> Set NEEDS_ALIGNED4_SKB hw flag. >> This allow driver to save CPU and remove two memmove >> from tx path. >> >>

[PATCH] rtlwifi: rtl_pci: Fix kernel panic

In commit 38506ecefab9 (rtlwifi: rtl_pci: Start modification for new drivers), a bug was introduced that causes a NULL pointer dereference. As this bug only affects the infrequently used RTL8192EE and only under low-memory conditions, it has taken a long time for the bug to show up. The bug was

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

Hi Brent and Souptick, On 12/21/15, 2:23 PM, "ath6kl on behalf of Souptick Joarder" wrote: >Hi Brent, > >On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: >> Since commit

[PATCH 12/13] staging: wilc1000: fix return type of wilc_set_mac_address

This patch changes return type of wilc_set_mac_address from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim

[PATCH 11/13] staging: wilc1000: rename pu8MacAddress in wilc_get_mac_address

This patch changes pu8MacAddress to mac_addr to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 13/13] staging: wilc1000: rename pu8MacAddress in wilc_set_mac_address

This patch changes pu8MacAddress to mac_addr to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] enable setting MAC address for r8723au

On 12/20/2015 08:28 PM, Dan Lenski wrote: Signed-off-by: Dan Lenski The commit message should be in this patch rather than in the non-patch previous mail. If this patch were to be accepted, all that explanation would be lost! Rather than issuing a warning when the MAC is

Re: [PATCH RESEND 03/46] staging: wilc1000: rename index to tcp_pending_ack_idx

Hi greg, On 2015년 12월 22일 06:17, Greg KH wrote: On Mon, Dec 21, 2015 at 02:18:07PM +0900, Glen Lee wrote: This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since this name could be confused index of txq_entry_t. It is index of tcp pending ack. It fixes

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

ipt (relaxed version of > scripts/coccinelle/api/alloc/kzalloc-simple.cocci) > > Patch was compile tested with: x86_64_defconfig + > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) > > Patch is against linux-next (localversion-next is -next-20151221) > > drivers/net/wireless/ti/w

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

t; scripts/coccinelle/api/alloc/kzalloc-simple.cocci) >> > >> > Patch was compile tested with: x86_64_defconfig + >> > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) >> > >> > Patch is against linux-next (localversion-next is -next-20151221) >> > >>

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

mplies CONFIG_WLCORE=m) > > > > Patch is against linux-next (localversion-next is -next-20151221) > > > > drivers/net/wireless/ti/wlcore/main.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/net/wireless/ti/wlco

RE: [[linux-nfc] PATCH v5 2/3] driver: nfc: Add ST95HF NFC Transceiver support

Hello Samuel, Please see my answer below. >This looks a lot better than the initial version. >I only have one question: > >On Fri, Nov 20, 2015 at 06:40:20AM -0500, Shikha Singh wrote: >> +/* >> + * st95hf_send_recv_cmd() is for sending commands to ST95HF >> + * that are described

Mediatek wifi

Hi Linus Walleij, and everyone interested. http://askubuntu.com/questions/676390/no-wi-fi-on-ubuntu-14-04-lts-asus-notebook-with-mediatek-mt7630e Here is the bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1220146 https://github.com/neurobin/MT7630E is reported to work for

[PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

config + CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) Patch is against linux-next (localversion-next is -next-20151221) drivers/net/wireless/ti/wlcore/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/